[GitHub] incubator-trafficcontrol issue #705: [TC-402] - ds xml_id is not editable

2017-07-11 Thread dangogh
Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/705
  
isn't this to make xml_id read-only?  title confused me..

and there are conflicts now..



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-trafficcontrol issue #705: [TC-402] - ds xml_id is not editable

2017-07-12 Thread mitchell852
Github user mitchell852 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/705
  
conflicts resolved. this PR is to make ds.xml_id immutable. you're not 
allowed to change the xml_id of a deliveryservice once it has been established. 
bad things happen if you do...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---