[GitHub] incubator-trafficcontrol pull request #347: Add global build script.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/347


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #347: Add global build script.

[limited]

Github user limited commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/347#discussion_r113432531
  
--- Diff: infrastructure/docker/build/clean_build.sh ---
@@ -0,0 +1,8 @@
+#!/usr/bin/env sh
--- End diff --

Needs an AL2 license header


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #347: Add global build script.

[alficles]

GitHub user alficles opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/347

Add global build script.

This splits out the somewhat messy docker build command into its own script 
and adds a global build script.
There’s still work to be done to clean up docker build scripts, but this 
provides a basic way to build top to bottom
In a single, simple command.

This is a step toward addressing TC-180, but falls short of cleaning up 
everything that requires cleaning up.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alficles/incubator-trafficcontrol 
global-build-script

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #347


commit 64e18cb57756ed995adc29ab8018abb1d60e73d6
Author: Chris Lemmons 
Date:   2017-03-10T18:18:57Z

Add global build script.

This splits out the somewhat messy docker build command into its own script 
and adds a global build script.
There’s still work to be done to clean up docker build scripts, but this 
provides a basic way to build top to bottom
In a single, simple command.

This is a step toward addressing TC-180, but falls short of cleaning up 
everything that requires cleaning up.

commit 0eb9eddc1b850a8adb934e6b5cc48511fb7ac672
Author: Chris Lemmons 
Date:   2017-03-10T20:20:51Z

Updated default build instructions to refer to the build script.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---