[jira] [Updated] (TS-994) X-Forwarded-For should follow the squid way
[
https://issues.apache.org/jira/browse/TS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhao Yongming updated TS-994:
-
Description:
TS will append the IP in the format of:
{code}
X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
{code}
while http://en.wikipedia.org/wiki/X-Forwarded-For says:
{code}
X-Forwarded-For: client1, proxy1, proxy2
{code}
there is 2 spaces in TS X-Forwarded-For header.
was:
TS will append the IP in the format of:
X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
while http://en.wikipedia.org/wiki/X-Forwarded-For says:
X-Forwarded-For: client1, proxy1, proxy2
there is 2 spaces
> X-Forwarded-For should follow the squid way
> ---
>
> Key: TS-994
> URL: https://issues.apache.org/jira/browse/TS-994
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
>Affects Versions: 3.1.1
>Reporter: Zhao Yongming
>Assignee: Zhao Yongming
>Priority: Minor
> Fix For: 3.1.1
>
> Attachments: XFF.patch
>
>
> TS will append the IP in the format of:
> {code}
> X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
> {code}
> while http://en.wikipedia.org/wiki/X-Forwarded-For says:
> {code}
> X-Forwarded-For: client1, proxy1, proxy2
> {code}
> there is 2 spaces in TS X-Forwarded-For header.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-994) X-Forwarded-For should follow the squid way
[
https://issues.apache.org/jira/browse/TS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132484#comment-13132484
]
Igor Galić commented on TS-994:
---
Does this cause an actual problem anywhere or are we just talking about
aesthetics?
> X-Forwarded-For should follow the squid way
> ---
>
> Key: TS-994
> URL: https://issues.apache.org/jira/browse/TS-994
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
>Affects Versions: 3.1.1
>Reporter: Zhao Yongming
>Assignee: Zhao Yongming
>Priority: Minor
> Fix For: 3.1.1
>
> Attachments: XFF.patch
>
>
> TS will append the IP in the format of:
> {code}
> X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
> {code}
> while http://en.wikipedia.org/wiki/X-Forwarded-For says:
> {code}
> X-Forwarded-For: client1, proxy1, proxy2
> {code}
> there is 2 spaces in TS X-Forwarded-For header.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-994) X-Forwarded-For should follow the squid way
[
https://issues.apache.org/jira/browse/TS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132497#comment-13132497
]
Conan Wang commented on TS-994:
---
My backend server will log X-Forwarded-For, and the additional leading space
bother me when parsing the log.
> X-Forwarded-For should follow the squid way
> ---
>
> Key: TS-994
> URL: https://issues.apache.org/jira/browse/TS-994
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
>Affects Versions: 3.1.1
>Reporter: Zhao Yongming
>Assignee: Zhao Yongming
>Priority: Minor
> Fix For: 3.1.1
>
> Attachments: XFF.patch
>
>
> TS will append the IP in the format of:
> {code}
> X-Forwarded-For: 127.0.0.1, 10.32.102.41\r\n
> {code}
> while http://en.wikipedia.org/wiki/X-Forwarded-For says:
> {code}
> X-Forwarded-For: client1, proxy1, proxy2
> {code}
> there is 2 spaces in TS X-Forwarded-For header.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-995) Change IPv6 support function names to be clearer and more compliant.
Change IPv6 support function names to be clearer and more compliant. Key: TS-995 URL: https://issues.apache.org/jira/browse/TS-995 Project: Traffic Server Issue Type: Improvement Components: Network Affects Versions: 3.1.0 Reporter: Alan M. Carroll Assignee: Alan M. Carroll Priority: Minor Fix For: 3.1.2 Several changes: 1) Change "ink_inet" to "ats_ip". 2) Except for a few test functions, "ats_is_ip", "ats_is_ip4", "ats_is_ip6". 3) Change the current "cmp" and "eq" functions to "cmp_addr" and "eq_addr" to reduce confusion about whether the port is compared as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-995) Change IPv6 support function names to be clearer and more compliant.
[ https://issues.apache.org/jira/browse/TS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132789#comment-13132789 ] Alan M. Carroll commented on TS-995: After all of this, put back the "eq" and "cmp" to also check port. Update proxy/ICPConfig.cc to use this instead of splitting it out. > Change IPv6 support function names to be clearer and more compliant. > > > Key: TS-995 > URL: https://issues.apache.org/jira/browse/TS-995 > Project: Traffic Server > Issue Type: Improvement > Components: Network >Affects Versions: 3.1.0 >Reporter: Alan M. Carroll >Assignee: Alan M. Carroll >Priority: Minor > Fix For: 3.1.2 > > > Several changes: > 1) Change "ink_inet" to "ats_ip". > 2) Except for a few test functions, "ats_is_ip", "ats_is_ip4", "ats_is_ip6". > 3) Change the current "cmp" and "eq" functions to "cmp_addr" and "eq_addr" to > reduce confusion about whether the port is compared as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-996) HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called
HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called Key: TS-996 URL: https://issues.apache.org/jira/browse/TS-996 Project: Traffic Server Issue Type: Bug Components: HTTP, MIME Affects Versions: 3.1.0 Reporter: B Wyatt class HTTPHdr stores a copy of the string pointer from either the URLimpl or the MIMEHdr for the host name in m_host. In both cases, these strings can be moved to a new heap underneath the HTTPHdr. When this happens, the process will, at best read stale memory and be fine and at worst read unmapped memory and segfault. Currently, HdrHeap::evacuate_from_str_heaps is called to coalesce multiple heaps into a single heap. When this happens it will directly access the low level objects via ::move_strings calls. These objects do not posses the necessary information to inform parent objects about the change, nor does the HdrHeap directly inform interested parties. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-996) HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called
[ https://issues.apache.org/jira/browse/TS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132822#comment-13132822 ] B Wyatt commented on TS-996: I am auditioning a fast/dirty fix for this that cache's a MIMEField pointer instead of the string pointer if the host comes from the MIMEHdr. For Hosts in the URL it uses the m_cached_url's copy instead of a top level copy which should be immune to heap changes. Ideally, I think that code is up for a bit of cleaning but this will hopefully suffice for now. The patch is attached as m_host.patch > HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called > > > Key: TS-996 > URL: https://issues.apache.org/jira/browse/TS-996 > Project: Traffic Server > Issue Type: Bug > Components: HTTP, MIME >Affects Versions: 3.1.0 >Reporter: B Wyatt > Attachments: m_host.patch > > > class HTTPHdr stores a copy of the string pointer from either the URLimpl or > the MIMEHdr for the host name in m_host. In both cases, these strings can be > moved to a new heap underneath the HTTPHdr. When this happens, the process > will, at best read stale memory and be fine and at worst read unmapped memory > and segfault. > Currently, HdrHeap::evacuate_from_str_heaps is called to coalesce multiple > heaps into a single heap. When this happens it will directly access the low > level objects via ::move_strings calls. These objects do not posses the > necessary information to inform parent objects about the change, nor does the > HdrHeap directly inform interested parties. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-996) HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called
[ https://issues.apache.org/jira/browse/TS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] B Wyatt updated TS-996: --- Attachment: m_host.patch > HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called > > > Key: TS-996 > URL: https://issues.apache.org/jira/browse/TS-996 > Project: Traffic Server > Issue Type: Bug > Components: HTTP, MIME >Affects Versions: 3.1.0 >Reporter: B Wyatt > Attachments: m_host.patch > > > class HTTPHdr stores a copy of the string pointer from either the URLimpl or > the MIMEHdr for the host name in m_host. In both cases, these strings can be > moved to a new heap underneath the HTTPHdr. When this happens, the process > will, at best read stale memory and be fine and at worst read unmapped memory > and segfault. > Currently, HdrHeap::evacuate_from_str_heaps is called to coalesce multiple > heaps into a single heap. When this happens it will directly access the low > level objects via ::move_strings calls. These objects do not posses the > necessary information to inform parent objects about the change, nor does the > HdrHeap directly inform interested parties. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-997) ATS crashes on remap plugin initialization failure
ATS crashes on remap plugin initialization failure --- Key: TS-997 URL: https://issues.apache.org/jira/browse/TS-997 Project: Traffic Server Issue Type: Bug Reporter: Manjesh Nilange Attachments: bad-destruction.patch A bad destructor causes the planned exit() to fail. This prevents remap plugins from logging why initialization failed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-997) ATS crashes on remap plugin initialization failure
[ https://issues.apache.org/jira/browse/TS-997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manjesh Nilange updated TS-997: --- Attachment: bad-destruction.patch > ATS crashes on remap plugin initialization failure > --- > > Key: TS-997 > URL: https://issues.apache.org/jira/browse/TS-997 > Project: Traffic Server > Issue Type: Bug >Reporter: Manjesh Nilange > Attachments: bad-destruction.patch > > > A bad destructor causes the planned exit() to fail. This prevents remap > plugins from logging why initialization failed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-997) ATS crashes on remap plugin initialization failure
[ https://issues.apache.org/jira/browse/TS-997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-997: - Fix Version/s: 3.1.1 Thanks Manjesh! > ATS crashes on remap plugin initialization failure > --- > > Key: TS-997 > URL: https://issues.apache.org/jira/browse/TS-997 > Project: Traffic Server > Issue Type: Bug >Reporter: Manjesh Nilange >Assignee: Leif Hedstrom > Fix For: 3.1.1 > > Attachments: bad-destruction.patch > > > A bad destructor causes the planned exit() to fail. This prevents remap > plugins from logging why initialization failed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-997) ATS crashes on remap plugin initialization failure
[ https://issues.apache.org/jira/browse/TS-997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reassigned TS-997: Assignee: Leif Hedstrom > ATS crashes on remap plugin initialization failure > --- > > Key: TS-997 > URL: https://issues.apache.org/jira/browse/TS-997 > Project: Traffic Server > Issue Type: Bug >Reporter: Manjesh Nilange >Assignee: Leif Hedstrom > Fix For: 3.1.1 > > Attachments: bad-destruction.patch > > > A bad destructor causes the planned exit() to fail. This prevents remap > plugins from logging why initialization failed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-988) Upgrade ICP support for IPv6
[ https://issues.apache.org/jira/browse/TS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan M. Carroll resolved TS-988. Resolution: Fixed > Upgrade ICP support for IPv6 > > > Key: TS-988 > URL: https://issues.apache.org/jira/browse/TS-988 > Project: Traffic Server > Issue Type: Improvement > Components: Clustering >Affects Versions: 3.1.0 >Reporter: Alan M. Carroll >Assignee: Alan M. Carroll >Priority: Minor > Labels: icp, ipv6 > Fix For: 3.1.2 > > > Make ICP compatible with IPv6. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
