[jira] [Updated] (TS-996) HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called
[ https://issues.apache.org/jira/browse/TS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] B Wyatt updated TS-996: --- Attachment: m_host.v4.patch Added initialization of host_len in the case that it isn't in the URL or the Mime header. The function returns a NULL string and 0 length in that case. HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called Key: TS-996 URL: https://issues.apache.org/jira/browse/TS-996 Project: Traffic Server Issue Type: Bug Components: HTTP, MIME Affects Versions: 3.1.0 Reporter: B Wyatt Assignee: Leif Hedstrom Fix For: 3.1.2 Attachments: m_host.V2.patch, m_host.patch, m_host.v3.patch, m_host.v4.patch class HTTPHdr stores a copy of the string pointer from either the URLimpl or the MIMEHdr for the host name in m_host. In both cases, these strings can be moved to a new heap underneath the HTTPHdr. When this happens, the process will, at best read stale memory and be fine and at worst read unmapped memory and segfault. Currently, HdrHeap::evacuate_from_str_heaps is called to coalesce multiple heaps into a single heap. When this happens it will directly access the low level objects via ::move_strings calls. These objects do not posses the necessary information to inform parent objects about the change, nor does the HdrHeap directly inform interested parties. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-996) HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called
[ https://issues.apache.org/jira/browse/TS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom resolved TS-996. -- Resolution: Fixed HTTPHdr::m_host goes stale if HdrHeap::evacuate_from_str_heaps is called Key: TS-996 URL: https://issues.apache.org/jira/browse/TS-996 Project: Traffic Server Issue Type: Bug Components: HTTP, MIME Affects Versions: 3.1.0 Reporter: B Wyatt Assignee: Leif Hedstrom Fix For: 3.1.2 Attachments: m_host.V2.patch, m_host.patch, m_host.v3.patch, m_host.v4.patch class HTTPHdr stores a copy of the string pointer from either the URLimpl or the MIMEHdr for the host name in m_host. In both cases, these strings can be moved to a new heap underneath the HTTPHdr. When this happens, the process will, at best read stale memory and be fine and at worst read unmapped memory and segfault. Currently, HdrHeap::evacuate_from_str_heaps is called to coalesce multiple heaps into a single heap. When this happens it will directly access the low level objects via ::move_strings calls. These objects do not posses the necessary information to inform parent objects about the change, nor does the HdrHeap directly inform interested parties. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with inbound transparency
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-961: - Fix Version/s: (was: 3.1.2) 3.1.3 Moving this out to 3.1.3, please move as necessary. Extend TS API to support TSNetAccept with inbound transparency -- Key: TS-961 URL: https://issues.apache.org/jira/browse/TS-961 Project: Traffic Server Issue Type: Improvement Components: TS API Reporter: Yossi Gottlieb Assignee: Alan M. Carroll Priority: Minor Fix For: 3.1.3 Attachments: api_transparency.diff This is required for protocol plugins to use this capability. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1073) no_dns_just_forward_to_parent configuration parameter is ignored/not used.
[
https://issues.apache.org/jira/browse/TS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-1073:
--
Fix Version/s: (was: 3.1.2)
3.1.3
Moving out to v3.1.3, please move back if you think it will be done in the very
near future.
no_dns_just_forward_to_parent configuration parameter is ignored/not used.
--
Key: TS-1073
URL: https://issues.apache.org/jira/browse/TS-1073
Project: Traffic Server
Issue Type: Bug
Components: DNS
Affects Versions: 3.0.2
Environment: Ubuntu 10.0, Fedora 14
Reporter: Kevin Giles
Assignee: Leif Hedstrom
Fix For: 3.1.3
Attachments: TS-1073.patch
I have two instances of trafficserver configured, one instance is configured
to use the second instance as a parent proxy using the following parameters
from the records.config:
CONFIG proxy.config.http.no_dns_just_forward_to_parent INT 1
CONFIG proxy.config.http.parent_proxy_routing_enable INT 1
The parent config looks like this:
dest_domain=. parent=parent:8080 round_robin=false
The no_dns_just_forward_to_parent is not used in the code and as a result dns
lookups are being performed in the child instance.
The following code changes seem to fix this:
proxy/http/HttpSM.cc
@@ -6406,11 +6405,20 @@
t_state.dns_info.lookup_success = true;
call_transact_and_set_next_state(NULL);
break;
} else if (t_state.parent_result.r == PARENT_UNDEFINED
t_state.dns_info.lookup_success) {
// Already set, and we don't have a parent proxy to lookup
ink_assert(t_state.host_db_info.ip());
Debug(dns, [HttpTransact::HandleRequest] Skipping DNS lookup,
provided by plugin);
call_transact_and_set_next_state(NULL);
break;
+ } else if (t_state.dns_info.looking_up == HttpTransact::ORIGIN_SERVER
+ t_state.http_config_param-no_dns_forward_to_parent){
+
+if(t_state.cop_test_page) {
+t_state.host_db_info.ip()
=t_state.state_machine-ua_session-get_netvc()-get_local_ip();
+}
+
+t_state.dns_info.lookup_success = true;
+call_transact_and_set_next_state(NULL);
+break;
}
HTTP_SM_SET_DEFAULT_HANDLER(HttpSM::state_hostdb_lookup);
to avoid reverse ns lookups
/proxy/http/HttpTransact.cc
@@ -1650,7 +1651,8 @@
} else if (s-dns_info.lookup_name[0] = '9'
s-dns_info.lookup_name[0] = '0'
//(s-state_machine-authAdapter.needs_rev_dns() ||
- ( host_rule_in_CacheControlTable() ||
s-parent_params-ParentTable-hostMatch)) {
+ ( host_rule_in_CacheControlTable() ||
s-parent_params-ParentTable-hostMatch)
+ !s-http_config_param-no_dns_forward_to_parent) {
// note, broken logic: ACC fudges the OR stmt to always be true,
// 'AuthHttpAdapter' should do the rev-dns if needed, not here .
TRANSACT_RETURN(REVERSE_DNS_LOOKUP, HttpTransact::StartAccessControl);
I would like to have these changes applied to the repository if they look ok.
I also created an empty resolv.conf and pointed ats to the empty file:
CONFIG proxy.config.dns.resolv_conf STRING
/usr/local/etc/trafficserver/resolv.conf
When these changes are applied the child instance no longer attempts to
perform dns lookups for the
http requests that it receives. If they are not applied and the dns lookup it
slow or unreliable on the
child then the http requests are blocked by the dns lookup within the child
trafficserver instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1082) configure always clobbers optimiser flags
configure always clobbers optimiser flags - Key: TS-1082 URL: https://issues.apache.org/jira/browse/TS-1082 Project: Traffic Server Issue Type: Bug Components: Build Reporter: James Peach Assignee: James Peach Priority: Minor If the builder specifies optimizer flags, don't flip the default to -O3. Current behaviour is to always use -O3, since the check to disable this doesn't work. I believe the intention if for the builder to be able to do CXXFLAGS=-O1 ./configure and have the build use -O1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1082) configure always clobbers optimiser flags
[ https://issues.apache.org/jira/browse/TS-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach updated TS-1082: Attachment: 0001-TS-1082-Fix-optimizer-flags-detection.patch Attach patch. configure always clobbers optimiser flags - Key: TS-1082 URL: https://issues.apache.org/jira/browse/TS-1082 Project: Traffic Server Issue Type: Bug Components: Build Reporter: James Peach Assignee: James Peach Priority: Minor Attachments: 0001-TS-1082-Fix-optimizer-flags-detection.patch If the builder specifies optimizer flags, don't flip the default to -O3. Current behaviour is to always use -O3, since the check to disable this doesn't work. I believe the intention if for the builder to be able to do CXXFLAGS=-O1 ./configure and have the build use -O1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1082) configure always clobbers optimiser flags
[ https://issues.apache.org/jira/browse/TS-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach reassigned TS-1082: --- Assignee: Igor Galić (was: James Peach) Igor, can you please review and commit if appropriate. Thanks. configure always clobbers optimiser flags - Key: TS-1082 URL: https://issues.apache.org/jira/browse/TS-1082 Project: Traffic Server Issue Type: Bug Components: Build Reporter: James Peach Assignee: Igor Galić Priority: Minor Attachments: 0001-TS-1082-Fix-optimizer-flags-detection.patch If the builder specifies optimizer flags, don't flip the default to -O3. Current behaviour is to always use -O3, since the check to disable this doesn't work. I believe the intention if for the builder to be able to do CXXFLAGS=-O1 ./configure and have the build use -O1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1083) initial SSL next protocol negotiation support
initial SSL next protocol negotiation support - Key: TS-1083 URL: https://issues.apache.org/jira/browse/TS-1083 Project: Traffic Server Issue Type: Improvement Components: SSL Reporter: James Peach Assignee: James Peach Priority: Minor Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1083) initial SSL next protocol negotiation support
[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach updated TS-1083: Attachment: 0002-Initial-NPN-plumbing.patch 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch Attached 1 patches. First just adds the autoconf checks. Second adds make the calls and advertises the HTTP protocol. Careful, if you build on OS X with MacPorts /opt/local/bin will be linked before /usr/local/ssl and NPN support won't be detected. This is difficult to avoid. initial SSL next protocol negotiation support - Key: TS-1083 URL: https://issues.apache.org/jira/browse/TS-1083 Project: Traffic Server Issue Type: Improvement Components: SSL Reporter: James Peach Assignee: James Peach Priority: Minor Attachments: 0001-Compile-time-detection-of-NextProtocolNegotiation-su.patch, 0002-Initial-NPN-plumbing.patch Initial autoconf support for detecting OpenSSL Next Protocol Negotiation APIs. Advertise that we support HTTP/1.0 and HTTP/1.1. Because we do. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1084) enable compile-time format string checking
enable compile-time format string checking -- Key: TS-1084 URL: https://issues.apache.org/jira/browse/TS-1084 Project: Traffic Server Issue Type: Improvement Components: Cleanup Reporter: James Peach Priority: Minor Add format string checking. Add format string checking to internal and external APIs that take a printf(3) format string. No functional changes. Fix all the resulting warnings - time_t is formatted as long long for portability - size_t became %zu - pointers all became %p -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1084) enable compile-time format string checking
[ https://issues.apache.org/jira/browse/TS-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach reassigned TS-1084: --- Assignee: Leif Hedstrom Leif, can you review and apply if appropriate. Thanks. enable compile-time format string checking -- Key: TS-1084 URL: https://issues.apache.org/jira/browse/TS-1084 Project: Traffic Server Issue Type: Improvement Components: Cleanup Reporter: James Peach Assignee: Leif Hedstrom Priority: Minor Attachments: 0001-Add-format-string-checking.patch Add format string checking. Add format string checking to internal and external APIs that take a printf(3) format string. No functional changes. Fix all the resulting warnings - time_t is formatted as long long for portability - size_t became %zu - pointers all became %p -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1084) enable compile-time format string checking
[ https://issues.apache.org/jira/browse/TS-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach updated TS-1084: Attachment: 0001-Add-format-string-checking.patch Tested on OS X; there's a reasonable probability of build breakage on other platforms. This will need a couple of passes through the build farm to shake it out. enable compile-time format string checking -- Key: TS-1084 URL: https://issues.apache.org/jira/browse/TS-1084 Project: Traffic Server Issue Type: Improvement Components: Cleanup Reporter: James Peach Priority: Minor Attachments: 0001-Add-format-string-checking.patch Add format string checking. Add format string checking to internal and external APIs that take a printf(3) format string. No functional changes. Fix all the resulting warnings - time_t is formatted as long long for portability - size_t became %zu - pointers all became %p -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
