[jira] [Updated] (TS-1116) Fix build issues with clang (particularly on OSX)

[Leif Hedstrom (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-1116:
--

Attachment: TS-1116.diff

This fixes the build problems with clang. Alan, is this the right solution?

> Fix build issues with clang (particularly on OSX)
> -
>
> Key: TS-1116
> URL: https://issues.apache.org/jira/browse/TS-1116
> Project: Traffic Server
>  Issue Type: Improvement
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 3.1.3
>
> Attachments: TS-1116.diff
>
>
> We should get it to compile with clang again, specially since on OSX, clang 
> is the 'future'.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-1102) Cleanup obsolete debugging code

[Uri Shachar (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211407#comment-13211407
 ] 

Uri Shachar commented on TS-1102:
-

Took me ages to set up a solaris dev env, and then I saw your latest commit :-) 
-- it looks a lot better then the bunch of ifdefs I had going.
I'll add another patch soon to remove the redundant DebugOn command, and then 
(finally) go back to the txn specific debugging functionality.

> Cleanup obsolete debugging code
> ---
>
> Key: TS-1102
> URL: https://issues.apache.org/jira/browse/TS-1102
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Logging, Performance
>Affects Versions: 3.0.2
> Environment: Any
>Reporter: Uri Shachar
>Assignee: Leif Hedstrom
>Priority: Minor
> Fix For: 3.1.3
>
> Attachments: diags_cleanup.patch, remove_prefix_arg.patch, 
> remove_prefix_arg_v2.patch, remove_prefix_arg_v3.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1 
> for all compilation environments, and it includes variadic argument macro 
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are 
> provided.
> Removing the added layer should also improve performance when high volume 
> debugging is turned on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira