[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636438#comment-13636438 ] Leif Hedstrom commented on TS-1453: --- If I understand you correctly, even without TS-1405, disabling InactivityCop is an improvement on performance / scalability? If so, great and +1. remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636444#comment-13636444 ] Leif Hedstrom commented on TS-1453: --- I'd probably also do what James suggested, eliminate the old code, and get rid of the INACTIVITY_TIMEOUT option. One thing I could *possible* see is to have a way to have both activated at any time, such that you run inactivity cop once every 60s or some such, to clean out potentially lost connection. I don't know if that can ever happen (but it did in the past). That's optional though, and can be a different bug / RFE. But if people think having such a feature is useful, then leave the old code, but change it to an #ifdef INACTIVITY_COP or some such (i.e. inverse the logic on the ifdef's). remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1819) make check throwing a core-dump for a hwloc call
[
https://issues.apache.org/jira/browse/TS-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636493#comment-13636493
]
ASF subversion and git services commented on TS-1819:
-
Commit 878f1954fc0358e9f8abdc06014038981e5db387 in branch refs/heads/master
from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=878f195 ]
TS-1819: guarantee hwloc initialization
The global hwloc handle was initialized as a side-effect. Use the
proper accessor API everywhere to guarantee that it is always
initialized correctly.
make check throwing a core-dump for a hwloc call
-
Key: TS-1819
URL: https://issues.apache.org/jira/browse/TS-1819
Project: Traffic Server
Issue Type: Bug
Reporter: Igor Galić
Assignee: Leif Hedstrom
Fix For: 3.3.3
{noformat}
make check-TESTS
make[3]: Entering directory
`/tmp/ts/trafficserver-3.3.2-dev/iocore/eventsystem'
ERROR: unable to access() TS_ROOT '/opt/ats-3.3': 2, No such file or directory
/bin/bash: line 5: 21004 Segmentation fault (core dumped) ${dir}$tst
FAIL: test_Buffer
ERROR: unable to access() TS_ROOT '/opt/ats-3.3': 2, No such file or directory
/bin/bash: line 5: 21023 Segmentation fault (core dumped) ${dir}$tst
FAIL: test_Event
=
2 of 2 tests failed
Please report to d...@trafficserver.apache.org
=
make[3]: *** [check-TESTS] Error 1
{noformat}
The back-trace from the core:
{noformat}
Core was generated by
`/tmp/ts/trafficserver-3.3.2-dev/iocore/eventsystem/.libs/lt-test_Buffer'.
Program terminated with signal 11, Segmentation fault.
#0 0x2b44c6721f21 in hwloc_get_type_depth () from
/usr/lib/x86_64-linux-gnu/libhwloc.so.5
(gdb) bt
#0 0x2b44c6721f21 in hwloc_get_type_depth () from
/usr/lib/x86_64-linux-gnu/libhwloc.so.5
#1 0x2b44c6037f21 in hwloc_get_nbobjs_by_type (type=HWLOC_OBJ_SOCKET,
topology=0x0) at /usr/include/hwloc.h:1114
#2 EventProcessor::start (this=0x2b44c625a520 eventProcessor,
n_event_threads=2) at UnixEventProcessor.cc:171
#3 0x2b44c6033413 in main (argc=optimized out, argv=optimized out)
at test_Buffer.cc:134
(gdb)
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1819) make check throwing a core-dump for a hwloc call
[
https://issues.apache.org/jira/browse/TS-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Peach reassigned TS-1819:
---
Assignee: James Peach (was: Leif Hedstrom)
make check throwing a core-dump for a hwloc call
-
Key: TS-1819
URL: https://issues.apache.org/jira/browse/TS-1819
Project: Traffic Server
Issue Type: Bug
Reporter: Igor Galić
Assignee: James Peach
Fix For: 3.3.3
{noformat}
make check-TESTS
make[3]: Entering directory
`/tmp/ts/trafficserver-3.3.2-dev/iocore/eventsystem'
ERROR: unable to access() TS_ROOT '/opt/ats-3.3': 2, No such file or directory
/bin/bash: line 5: 21004 Segmentation fault (core dumped) ${dir}$tst
FAIL: test_Buffer
ERROR: unable to access() TS_ROOT '/opt/ats-3.3': 2, No such file or directory
/bin/bash: line 5: 21023 Segmentation fault (core dumped) ${dir}$tst
FAIL: test_Event
=
2 of 2 tests failed
Please report to d...@trafficserver.apache.org
=
make[3]: *** [check-TESTS] Error 1
{noformat}
The back-trace from the core:
{noformat}
Core was generated by
`/tmp/ts/trafficserver-3.3.2-dev/iocore/eventsystem/.libs/lt-test_Buffer'.
Program terminated with signal 11, Segmentation fault.
#0 0x2b44c6721f21 in hwloc_get_type_depth () from
/usr/lib/x86_64-linux-gnu/libhwloc.so.5
(gdb) bt
#0 0x2b44c6721f21 in hwloc_get_type_depth () from
/usr/lib/x86_64-linux-gnu/libhwloc.so.5
#1 0x2b44c6037f21 in hwloc_get_nbobjs_by_type (type=HWLOC_OBJ_SOCKET,
topology=0x0) at /usr/include/hwloc.h:1114
#2 EventProcessor::start (this=0x2b44c625a520 eventProcessor,
n_event_threads=2) at UnixEventProcessor.cc:171
#3 0x2b44c6033413 in main (argc=optimized out, argv=optimized out)
at test_Buffer.cc:134
(gdb)
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1819) make check throwing a core-dump for a hwloc call
[
https://issues.apache.org/jira/browse/TS-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Peach resolved TS-1819.
-
Resolution: Fixed
make check throwing a core-dump for a hwloc call
-
Key: TS-1819
URL: https://issues.apache.org/jira/browse/TS-1819
Project: Traffic Server
Issue Type: Bug
Reporter: Igor Galić
Assignee: James Peach
Fix For: 3.3.3
{noformat}
make check-TESTS
make[3]: Entering directory
`/tmp/ts/trafficserver-3.3.2-dev/iocore/eventsystem'
ERROR: unable to access() TS_ROOT '/opt/ats-3.3': 2, No such file or directory
/bin/bash: line 5: 21004 Segmentation fault (core dumped) ${dir}$tst
FAIL: test_Buffer
ERROR: unable to access() TS_ROOT '/opt/ats-3.3': 2, No such file or directory
/bin/bash: line 5: 21023 Segmentation fault (core dumped) ${dir}$tst
FAIL: test_Event
=
2 of 2 tests failed
Please report to d...@trafficserver.apache.org
=
make[3]: *** [check-TESTS] Error 1
{noformat}
The back-trace from the core:
{noformat}
Core was generated by
`/tmp/ts/trafficserver-3.3.2-dev/iocore/eventsystem/.libs/lt-test_Buffer'.
Program terminated with signal 11, Segmentation fault.
#0 0x2b44c6721f21 in hwloc_get_type_depth () from
/usr/lib/x86_64-linux-gnu/libhwloc.so.5
(gdb) bt
#0 0x2b44c6721f21 in hwloc_get_type_depth () from
/usr/lib/x86_64-linux-gnu/libhwloc.so.5
#1 0x2b44c6037f21 in hwloc_get_nbobjs_by_type (type=HWLOC_OBJ_SOCKET,
topology=0x0) at /usr/include/hwloc.h:1114
#2 EventProcessor::start (this=0x2b44c625a520 eventProcessor,
n_event_threads=2) at UnixEventProcessor.cc:171
#3 0x2b44c6033413 in main (argc=optimized out, argv=optimized out)
at test_Buffer.cc:134
(gdb)
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1819) make check throwing a core-dump for a hwloc call
[
https://issues.apache.org/jira/browse/TS-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636523#comment-13636523
]
ASF subversion and git services commented on TS-1819:
-
Commit 760a2c49dec3e4627942e67e2012de8fbe45bd46 in branch refs/heads/master
from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=760a2c4 ]
TS-1819 Also make the new tests build on all platforms
make check throwing a core-dump for a hwloc call
-
Key: TS-1819
URL: https://issues.apache.org/jira/browse/TS-1819
Project: Traffic Server
Issue Type: Bug
Reporter: Igor Galić
Assignee: James Peach
Fix For: 3.3.3
{noformat}
make check-TESTS
make[3]: Entering directory
`/tmp/ts/trafficserver-3.3.2-dev/iocore/eventsystem'
ERROR: unable to access() TS_ROOT '/opt/ats-3.3': 2, No such file or directory
/bin/bash: line 5: 21004 Segmentation fault (core dumped) ${dir}$tst
FAIL: test_Buffer
ERROR: unable to access() TS_ROOT '/opt/ats-3.3': 2, No such file or directory
/bin/bash: line 5: 21023 Segmentation fault (core dumped) ${dir}$tst
FAIL: test_Event
=
2 of 2 tests failed
Please report to d...@trafficserver.apache.org
=
make[3]: *** [check-TESTS] Error 1
{noformat}
The back-trace from the core:
{noformat}
Core was generated by
`/tmp/ts/trafficserver-3.3.2-dev/iocore/eventsystem/.libs/lt-test_Buffer'.
Program terminated with signal 11, Segmentation fault.
#0 0x2b44c6721f21 in hwloc_get_type_depth () from
/usr/lib/x86_64-linux-gnu/libhwloc.so.5
(gdb) bt
#0 0x2b44c6721f21 in hwloc_get_type_depth () from
/usr/lib/x86_64-linux-gnu/libhwloc.so.5
#1 0x2b44c6037f21 in hwloc_get_nbobjs_by_type (type=HWLOC_OBJ_SOCKET,
topology=0x0) at /usr/include/hwloc.h:1114
#2 EventProcessor::start (this=0x2b44c625a520 eventProcessor,
n_event_threads=2) at UnixEventProcessor.cc:171
#3 0x2b44c6033413 in main (argc=optimized out, argv=optimized out)
at test_Buffer.cc:134
(gdb)
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1834) make test fails on logstats tests
Leif Hedstrom created TS-1834: - Summary: make test fails on logstats tests Key: TS-1834 URL: https://issues.apache.org/jira/browse/TS-1834 Project: Traffic Server Issue Type: Bug Components: Build Reporter: Leif Hedstrom Files /tmp/logstats.jvWidH and ../../../proxy/tests/logstats.json differ FAIL: tests/test_logstats_json FAIL: tests/test_logstats_summary Diff failures are in http://paste.fedoraproject.org/8018/88145136 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1834) make test fails on logstats tests
[ https://issues.apache.org/jira/browse/TS-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach updated TS-1834: Assignee: James Peach Looks like TS-1805 fixed stats, yay! make test fails on logstats tests - Key: TS-1834 URL: https://issues.apache.org/jira/browse/TS-1834 Project: Traffic Server Issue Type: Bug Components: Build Reporter: Leif Hedstrom Assignee: James Peach Files /tmp/logstats.jvWidH and ../../../proxy/tests/logstats.json differ FAIL: tests/test_logstats_json FAIL: tests/test_logstats_summary Diff failures are in http://paste.fedoraproject.org/8018/88145136 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1834) make test fails on logstats tests
[ https://issues.apache.org/jira/browse/TS-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636585#comment-13636585 ] James Peach commented on TS-1834: - Actually, it looks like something is broken on that build platform. We used to get fields of 0.0 and now we get -nan. That's not good. This is passing on my build systems; what are you using? make test fails on logstats tests - Key: TS-1834 URL: https://issues.apache.org/jira/browse/TS-1834 Project: Traffic Server Issue Type: Bug Components: Build Reporter: Leif Hedstrom Assignee: James Peach Files /tmp/logstats.jvWidH and ../../../proxy/tests/logstats.json differ FAIL: tests/test_logstats_json FAIL: tests/test_logstats_summary Diff failures are in http://paste.fedoraproject.org/8018/88145136 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1792) Cleanup debug around vary headers
[ https://issues.apache.org/jira/browse/TS-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636593#comment-13636593 ] ASF subversion and git services commented on TS-1792: - Commit 552cd0c4cb242e4c86be8c7c9d33df5e8318e512 in branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=552cd0c ] TS-1792 Cleanup debug around vary headers Cleanup debug around vary headers - Key: TS-1792 URL: https://issues.apache.org/jira/browse/TS-1792 Project: Traffic Server Issue Type: Improvement Components: HTTP Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 3.3.3 We have an excessive printf() in debug builds, which really ought to be triggered by a tracer tag. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636624#comment-13636624 ] John Plevyak commented on TS-1453: -- Couple things: 1) the lock is always held over accesses to disabled so it doesn't need to be volatile 2) I would just change the callback_event to a new EVENT_DISABLED and handle it in NetVConnction::mainEvent. The reason is that this will isolate the changes to the net processor, and I think the interaction of the disabled flag with the timeouts is problematic: you are going to end up rescheduling the event as an immediate eventually which will cause a lot of busy processing. remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1053) get combo_handler compiled
[
https://issues.apache.org/jira/browse/TS-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636641#comment-13636641
]
ASF subversion and git services commented on TS-1053:
-
Commit 7f7eddf57065996df936a372681341ce7c637dd8 in branch refs/heads/master
from [~conanmind]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=7f7eddf ]
TS-1053 Make combo_handler compiler.
get combo_handler compiled
--
Key: TS-1053
URL: https://issues.apache.org/jira/browse/TS-1053
Project: Traffic Server
Issue Type: Task
Components: Plugins
Reporter: Conan Wang
Assignee: Leif Hedstrom
Fix For: 3.3.3
Attachments: combo_handler.diff, fetcher.diff, Makefile
combo_handler require ESI's code. Before make ESI work as a lib, you can try
it this way:
make esi/lib and esi/fetcher the subdir of combo_handler and use the
makefile.
{noformat}
combo_handler
|combo_handler.cc
|fetcher
|lib
|LICENSE
|Makefile
|README
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1053) get combo_handler compiled
[
https://issues.apache.org/jira/browse/TS-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636638#comment-13636638
]
ASF subversion and git services commented on TS-1053:
-
Commit 0012eee3b43f736737062e10267f423a156c35d5 in branch refs/heads/master
from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0012eee ]
TS-1053 Cleaning this up, since I was mucking around in it.
get combo_handler compiled
--
Key: TS-1053
URL: https://issues.apache.org/jira/browse/TS-1053
Project: Traffic Server
Issue Type: Task
Components: Plugins
Reporter: Conan Wang
Assignee: Leif Hedstrom
Fix For: 3.3.3
Attachments: combo_handler.diff, fetcher.diff, Makefile
combo_handler require ESI's code. Before make ESI work as a lib, you can try
it this way:
make esi/lib and esi/fetcher the subdir of combo_handler and use the
makefile.
{noformat}
combo_handler
|combo_handler.cc
|fetcher
|lib
|LICENSE
|Makefile
|README
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1053) get combo_handler compiled
[
https://issues.apache.org/jira/browse/TS-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636640#comment-13636640
]
ASF subversion and git services commented on TS-1053:
-
Commit ee04a10dc592065abf534d408b2685e4c588a19a in branch refs/heads/master
from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ee04a10 ]
TS-1053 Move combo_handler to ESI, also change plugin.cc to esi.cc
get combo_handler compiled
--
Key: TS-1053
URL: https://issues.apache.org/jira/browse/TS-1053
Project: Traffic Server
Issue Type: Task
Components: Plugins
Reporter: Conan Wang
Assignee: Leif Hedstrom
Fix For: 3.3.3
Attachments: combo_handler.diff, fetcher.diff, Makefile
combo_handler require ESI's code. Before make ESI work as a lib, you can try
it this way:
make esi/lib and esi/fetcher the subdir of combo_handler and use the
makefile.
{noformat}
combo_handler
|combo_handler.cc
|fetcher
|lib
|LICENSE
|Makefile
|README
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1053) get combo_handler compiled
[
https://issues.apache.org/jira/browse/TS-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636637#comment-13636637
]
ASF subversion and git services commented on TS-1053:
-
Commit 21515f600a33fd4b4e1e28bd88b0b69854180c5b in branch refs/heads/master
from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=21515f6 ]
TS-1053 Move the README for combo handler
get combo_handler compiled
--
Key: TS-1053
URL: https://issues.apache.org/jira/browse/TS-1053
Project: Traffic Server
Issue Type: Task
Components: Plugins
Reporter: Conan Wang
Assignee: Leif Hedstrom
Fix For: 3.3.3
Attachments: combo_handler.diff, fetcher.diff, Makefile
combo_handler require ESI's code. Before make ESI work as a lib, you can try
it this way:
make esi/lib and esi/fetcher the subdir of combo_handler and use the
makefile.
{noformat}
combo_handler
|combo_handler.cc
|fetcher
|lib
|LICENSE
|Makefile
|README
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1053) get combo_handler compiled
[
https://issues.apache.org/jira/browse/TS-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636639#comment-13636639
]
ASF subversion and git services commented on TS-1053:
-
Commit 27fb7b7a1d720b86a418c820a216c0ffe31411ae in branch refs/heads/master
from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=27fb7b7 ]
Added TS-1053.
get combo_handler compiled
--
Key: TS-1053
URL: https://issues.apache.org/jira/browse/TS-1053
Project: Traffic Server
Issue Type: Task
Components: Plugins
Reporter: Conan Wang
Assignee: Leif Hedstrom
Fix For: 3.3.3
Attachments: combo_handler.diff, fetcher.diff, Makefile
combo_handler require ESI's code. Before make ESI work as a lib, you can try
it this way:
make esi/lib and esi/fetcher the subdir of combo_handler and use the
makefile.
{noformat}
combo_handler
|combo_handler.cc
|fetcher
|lib
|LICENSE
|Makefile
|README
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1586) spdy plugin doesn't build under clang (from trunk)
[
https://issues.apache.org/jira/browse/TS-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636726#comment-13636726
]
Igor Galić commented on TS-1586:
First off, the patch that I submitted makes __restrict conform to more or less
documented way it's supposed to be used:
http://gcc.gnu.org/onlinedocs/gcc/Restricted-Pointers.html -- also note, this
is a G++ specific extension. restrict does not exist in C++.
Second, the error message,
{noformat}/usr/lib/gcc/x86_64-linux-gnu/4.7/../../../../include/c++/4.7/bits/stl_iterator_base_funcs.h:174:49:
error: no type named 'difference_type' in
'std::iterator_traitsconst unsigned char *restrict'
typename iterator_traits_InputIterator::difference_type __d =
__n;{noformat}
suggests to me that we simply need a template for this, perhaps [~amc] can
chip in here with his mad C++ skillz.
spdy plugin doesn't build under clang (from trunk)
--
Key: TS-1586
URL: https://issues.apache.org/jira/browse/TS-1586
Project: Traffic Server
Issue Type: Bug
Components: Build, Plugins
Affects Versions: 3.3.1
Environment: Linux with llvm/clang from trunk + libstc++
(I don't have libc++ on Linux)
Reporter: Igor Galić
Assignee: Igor Galić
Fix For: 3.3.3
Attachments: restrict.patch, swap_restrict.patch
{noformat}
Making all in spdy
gmake[3]: Entering directory
`/home/igalic/src/asf/trafficserver/CLANG/plugins/experimental/spdy'
/bin/sh ../../../libtool --tag=CXX --mode=compile clang++ -DHAVE_CONFIG_H
-I. -I../../../../plugins/experimental/spdy -I../../../lib/ts
-I../../../../plugins/experimental/spdy/lib -I../../../proxy/api
-D__STDC_FORMAT_MACROS=1 -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1
-D_GNU_SOURCE -D_REENTRANT -Dlinux -DDEBUG -D_DEBUG -std=c++11 -ggdb3
-Werror -Qunused-arguments -Wno-invalid-offsetof -MT message.lo -MD -MP -MF
.deps/message.Tpo -c -o message.lo `test -f 'lib/spdy/message.cc' || echo
'../../../../plugins/experimental/spdy/'`lib/spdy/message.cc
libtool: compile: clang++ -DHAVE_CONFIG_H -I.
-I../../../../plugins/experimental/spdy -I../../../lib/ts
-I../../../../plugins/experimental/spdy/lib -I../../../proxy/api
-D__STDC_FORMAT_MACROS=1 -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1
-D_GNU_SOURCE -D_REENTRANT -Dlinux -DDEBUG -D_DEBUG -std=c++11 -ggdb3 -Werror
-Qunused-arguments -Wno-invalid-offsetof -MT message.lo -MD -MP -MF
.deps/message.Tpo -c
../../../../plugins/experimental/spdy/lib/spdy/message.cc -fPIC -DPIC -o
.libs/message.o
../../../../plugins/experimental/spdy/lib/spdy/message.cc:72:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
extract(const uint8_t __restrict * ptr) {
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:80:32: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
extractuint8_t(const uint8_t __restrict * ptr) {
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:85:30: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
insert(const T val, uint8_t __restrict * ptr) {
^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:91:33: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
extract_stream_id(const uint8_t __restrict * ptr)
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:97:46: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
insert_stream_id(uint32_t stream_id, uint8_t __restrict * ptr)
^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:104:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
const uint8_t __restrict * ptr, size_t len)
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:133:44: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
const message_header msg, uint8_t __restrict * ptr, size_t len)
^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:153:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
const uint8_t __restrict * ptr, size_t len)
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:170:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned
[jira] [Work started] (TS-1811) Reduce HostDB entry sizes based on SRV being enabled or not
[ https://issues.apache.org/jira/browse/TS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on TS-1811 started by Leif Hedstrom. Reduce HostDB entry sizes based on SRV being enabled or not --- Key: TS-1811 URL: https://issues.apache.org/jira/browse/TS-1811 Project: Traffic Server Issue Type: Improvement Components: DNS Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 3.3.4 It seems that reserving the large (~3x or so) amount of space for SRV records in HostDB entries is a bit wasteful. Since SRV records aren't enabled by default, and I'd venture a guess that most people never will use it, we ought to adjust this such that the HostDB is set to a size appropriate for if SRV records are supported or not. This also implies that the HostDB needs to know if it's initialized for SRV records or not. And if we change the config, to reinitialize the HostDB. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1811) Reduce HostDB entry sizes based on SRV being enabled or not
[ https://issues.apache.org/jira/browse/TS-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636779#comment-13636779 ] Leif Hedstrom commented on TS-1811: --- I have a patch for this, will commit as soon as approved. Reduce HostDB entry sizes based on SRV being enabled or not --- Key: TS-1811 URL: https://issues.apache.org/jira/browse/TS-1811 Project: Traffic Server Issue Type: Improvement Components: DNS Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 3.3.4 It seems that reserving the large (~3x or so) amount of space for SRV records in HostDB entries is a bit wasteful. Since SRV records aren't enabled by default, and I'd venture a guess that most people never will use it, we ought to adjust this such that the HostDB is set to a size appropriate for if SRV records are supported or not. This also implies that the HostDB needs to know if it's initialized for SRV records or not. And if we change the config, to reinitialize the HostDB. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1820) Cleanup UNUSED / INK_UNUSED / RELEASE_UNUSED
[ https://issues.apache.org/jira/browse/TS-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637003#comment-13637003 ] ASF subversion and git services commented on TS-1820: - Commit c88d6153e0850a5c5f633ae8afd7947773b65d99 in branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c88d615 ] TS-1820 Cleanup the comments some, and eliminate a few unused parameters where it was obvious Cleanup UNUSED / INK_UNUSED / RELEASE_UNUSED Key: TS-1820 URL: https://issues.apache.org/jira/browse/TS-1820 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 3.3.3 We have to many of these defines, and should clean this up and unify it. There are also plugins and core code defining their own versions of this, lets eliminate that as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1820) Cleanup UNUSED / INK_UNUSED / RELEASE_UNUSED
[ https://issues.apache.org/jira/browse/TS-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637004#comment-13637004 ] ASF subversion and git services commented on TS-1820: - Commit c6dd66ec5361df70bb5e2610463ecabb1fee2c88 in branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c6dd66e ] TS-1820 Fix read_manager_string(), and make sure it uses the buffer size to ink_strlcpy(). Cleanup UNUSED / INK_UNUSED / RELEASE_UNUSED Key: TS-1820 URL: https://issues.apache.org/jira/browse/TS-1820 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 3.3.3 We have to many of these defines, and should clean this up and unify it. There are also plugins and core code defining their own versions of this, lets eliminate that as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1820) Cleanup UNUSED / INK_UNUSED / RELEASE_UNUSED
[ https://issues.apache.org/jira/browse/TS-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637006#comment-13637006 ] ASF subversion and git services commented on TS-1820: - Commit 3840df1827bb9af3fad92f36a726c485cd932445 in branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=3840df1 ] TS-1820 Unify the use of UNUSED, and eliminate trash Cleanup UNUSED / INK_UNUSED / RELEASE_UNUSED Key: TS-1820 URL: https://issues.apache.org/jira/browse/TS-1820 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 3.3.3 We have to many of these defines, and should clean this up and unify it. There are also plugins and core code defining their own versions of this, lets eliminate that as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1835) Eliminate ink_resource.{cc,h}
[
https://issues.apache.org/jira/browse/TS-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-1835:
--
Component/s: Core
Fix Version/s: 3.3.3
Assignee: Leif Hedstrom
Eliminate ink_resource.{cc,h}
-
Key: TS-1835
URL: https://issues.apache.org/jira/browse/TS-1835
Project: Traffic Server
Issue Type: Bug
Components: Core
Reporter: Leif Hedstrom
Assignee: Leif Hedstrom
Fix For: 3.3.3
I think we should eliminate the ink_resource memory tracking code. We already
have support for this when linking in with tcmalloc or jemalloc, rolling our
own seems pointless with these tools being available.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1586) spdy plugin doesn't build under clang (from trunk)
[
https://issues.apache.org/jira/browse/TS-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637107#comment-13637107
]
ASF subversion and git services commented on TS-1586:
-
Commit 270edbe704bc3d69b56026d8d54e0f16891cb649 in branch refs/heads/master
from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=270edbe ]
TS-1586: Fix the SPDY plugin build under clang on Linux.
spdy plugin doesn't build under clang (from trunk)
--
Key: TS-1586
URL: https://issues.apache.org/jira/browse/TS-1586
Project: Traffic Server
Issue Type: Bug
Components: Build, Plugins
Affects Versions: 3.3.1
Environment: Linux with llvm/clang from trunk + libstc++
(I don't have libc++ on Linux)
Reporter: Igor Galić
Assignee: Igor Galić
Fix For: 3.3.3
Attachments: restrict.patch, swap_restrict.patch
{noformat}
Making all in spdy
gmake[3]: Entering directory
`/home/igalic/src/asf/trafficserver/CLANG/plugins/experimental/spdy'
/bin/sh ../../../libtool --tag=CXX --mode=compile clang++ -DHAVE_CONFIG_H
-I. -I../../../../plugins/experimental/spdy -I../../../lib/ts
-I../../../../plugins/experimental/spdy/lib -I../../../proxy/api
-D__STDC_FORMAT_MACROS=1 -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1
-D_GNU_SOURCE -D_REENTRANT -Dlinux -DDEBUG -D_DEBUG -std=c++11 -ggdb3
-Werror -Qunused-arguments -Wno-invalid-offsetof -MT message.lo -MD -MP -MF
.deps/message.Tpo -c -o message.lo `test -f 'lib/spdy/message.cc' || echo
'../../../../plugins/experimental/spdy/'`lib/spdy/message.cc
libtool: compile: clang++ -DHAVE_CONFIG_H -I.
-I../../../../plugins/experimental/spdy -I../../../lib/ts
-I../../../../plugins/experimental/spdy/lib -I../../../proxy/api
-D__STDC_FORMAT_MACROS=1 -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1
-D_GNU_SOURCE -D_REENTRANT -Dlinux -DDEBUG -D_DEBUG -std=c++11 -ggdb3 -Werror
-Qunused-arguments -Wno-invalid-offsetof -MT message.lo -MD -MP -MF
.deps/message.Tpo -c
../../../../plugins/experimental/spdy/lib/spdy/message.cc -fPIC -DPIC -o
.libs/message.o
../../../../plugins/experimental/spdy/lib/spdy/message.cc:72:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
extract(const uint8_t __restrict * ptr) {
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:80:32: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
extractuint8_t(const uint8_t __restrict * ptr) {
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:85:30: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
insert(const T val, uint8_t __restrict * ptr) {
^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:91:33: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
extract_stream_id(const uint8_t __restrict * ptr)
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:97:46: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
insert_stream_id(uint32_t stream_id, uint8_t __restrict * ptr)
^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:104:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
const uint8_t __restrict * ptr, size_t len)
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:133:44: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
const message_header msg, uint8_t __restrict * ptr, size_t len)
^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:153:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
const uint8_t __restrict * ptr, size_t len)
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:170:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
const uint8_t __restrict * ptr, size_t len)
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:185:23: error:
restrict requires a pointer or reference ('uint8_t' (aka 'unsigned char') is
invalid)
const uint8_t __restrict * ptr, size_t len)
~~^~
../../../../plugins/experimental/spdy/lib/spdy/message.cc:200:48:
