[jira] [Commented] (TS-1800) coalesce FNV hash implementations
[ https://issues.apache.org/jira/browse/TS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643508#comment-13643508 ] James Peach commented on TS-1800: - Phil, in the medium term I'd like to create a standard set of hash APIs in libts. Just something to keep in mind when your deciding how to do this ;) > coalesce FNV hash implementations > - > > Key: TS-1800 > URL: https://issues.apache.org/jira/browse/TS-1800 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: James Peach >Assignee: Phil Sorber > Fix For: 3.5.0 > > > We have 4 copies of the FNV hash function: > example/query-remap/query-remap.c > iocore/hostdb/I_HostDBProcessor.h > proxy/hdrs/HdrToken.cc > proxy/logstats.cc > We should unify these into a single place in libts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1839) make check fails without prior make install
[
https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643474#comment-13643474
]
ASF subversion and git services commented on TS-1839:
-
Commit dba01ebb6fcb060491330efb9c051d17963cc683 in branch refs/heads/master
from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=dba01eb ]
TS-1839 Change Layout initialization, such that if the install
directory doesn't exist, we just give a warning. This fixes
the problem where e.g. make test fails.
> make check fails without prior make install
> ---
>
> Key: TS-1839
> URL: https://issues.apache.org/jira/browse/TS-1839
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Igor Galić
>Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> ./tests/test_logstats_summary: line 23: 9060 Segmentation fault (core
> dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary
> > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =
> 2 of 2 tests failed
> Please report to d...@trafficserver.apache.org
> =
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> 259 if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> #1 0x0041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1839) make check fails without prior make install
[
https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom resolved TS-1839.
---
Resolution: Fixed
> make check fails without prior make install
> ---
>
> Key: TS-1839
> URL: https://issues.apache.org/jira/browse/TS-1839
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Igor Galić
>Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> ./tests/test_logstats_summary: line 23: 9060 Segmentation fault (core
> dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary
> > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =
> 2 of 2 tests failed
> Please report to d...@trafficserver.apache.org
> =
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> 259 if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> #1 0x0041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1839) make check fails without prior make install
[
https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643469#comment-13643469
]
Leif Hedstrom commented on TS-1839:
---
well, what happens is that we leave the Layout in an undefined state, since
that test is done in the middle of initialization. So anything that wants a
Layout is at risk of failing due to pointers possibly being totally in the dark.
> make check fails without prior make install
> ---
>
> Key: TS-1839
> URL: https://issues.apache.org/jira/browse/TS-1839
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Igor Galić
>Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> ./tests/test_logstats_summary: line 23: 9060 Segmentation fault (core
> dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary
> > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =
> 2 of 2 tests failed
> Please report to d...@trafficserver.apache.org
> =
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> 259 if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> #1 0x0041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1839) make check fails without prior make install
[
https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643456#comment-13643456
]
James Peach commented on TS-1839:
-
I though that I fixed this traffic_logstats crash in
d9275d7feb8c1807afd85459b387ef62e01ed6d5.
> make check fails without prior make install
> ---
>
> Key: TS-1839
> URL: https://issues.apache.org/jira/browse/TS-1839
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Igor Galić
>Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> ./tests/test_logstats_summary: line 23: 9060 Segmentation fault (core
> dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary
> > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =
> 2 of 2 tests failed
> Please report to d...@trafficserver.apache.org
> =
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> 259 if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> #1 0x0041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1839) make check fails without prior make install
[
https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643448#comment-13643448
]
Leif Hedstrom commented on TS-1839:
---
This is becuase of this in Layout:
{code}
if (access(path, R_OK) == -1) {
ink_error("unable to access() TS_ROOT '%s': %d, %s\n", path, errno,
strerror(errno));
return;
}
{code}
I'm not sure how to best resolve this, honestly it might make most sense to let
this continue with an ink_warning(), and then let application(s) (like
traffic_server) who really need the install root to fail later.
E.g.
{code}
if (access(path, R_OK) == -1) {
- ink_error("unable to access() TS_ROOT '%s': %d, %s\n", path, errno,
strerror(errno));
- return;
+ ink_warning("unable to access() TS_ROOT '%s': %d, %s\n", path, errno,
strerror(errno));
}
{code}
> make check fails without prior make install
> ---
>
> Key: TS-1839
> URL: https://issues.apache.org/jira/browse/TS-1839
> Project: Traffic Server
> Issue Type: Bug
>Reporter: Igor Galić
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> ./tests/test_logstats_summary: line 23: 9060 Segmentation fault (core
> dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary
> > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =
> 2 of 2 tests failed
> Please report to d...@trafficserver.apache.org
> =
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> 259 if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> #1 0x0041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1839) make check fails without prior make install
[
https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-1839:
--
Fix Version/s: 3.3.3
> make check fails without prior make install
> ---
>
> Key: TS-1839
> URL: https://issues.apache.org/jira/browse/TS-1839
> Project: Traffic Server
> Issue Type: Bug
>Reporter: Igor Galić
> Fix For: 3.3.3
>
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> ./tests/test_logstats_summary: line 23: 9060 Segmentation fault (core
> dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary
> > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =
> 2 of 2 tests failed
> Please report to d...@trafficserver.apache.org
> =
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> 259 if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> #1 0x0041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1839) make check fails without prior make install
[
https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-1839:
--
Component/s: Build
> make check fails without prior make install
> ---
>
> Key: TS-1839
> URL: https://issues.apache.org/jira/browse/TS-1839
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Igor Galić
> Fix For: 3.3.3
>
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> ./tests/test_logstats_summary: line 23: 9060 Segmentation fault (core
> dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary
> > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =
> 2 of 2 tests failed
> Please report to d...@trafficserver.apache.org
> =
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> 259 if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> #1 0x0041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1839) make check fails without prior make install
[
https://issues.apache.org/jira/browse/TS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom reassigned TS-1839:
-
Assignee: Leif Hedstrom
> make check fails without prior make install
> ---
>
> Key: TS-1839
> URL: https://issues.apache.org/jira/browse/TS-1839
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Igor Galić
>Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
>
> make[2]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> make check-TESTS
> make[3]: Entering directory `/home/igalic/src/asf/trafficserver/proxy'
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> FAIL: tests/test_logstats_json
> ERROR: unable to access() TS_ROOT '/opt/ats-trunk': 2, No such file or
> directory
> ./tests/test_logstats_summary: line 23: 9060 Segmentation fault (core
> dumped) ./traffic_logstats --log_file "$srcdir/tests/logstats.blog" --summary
> > "$tmpfile"
> FAIL: tests/test_logstats_summary
> =
> 2 of 2 tests failed
> Please report to d...@trafficserver.apache.org
> =
> Backtrace: {noformat}Program terminated with signal 11, Segmentation fault.
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> 259 if ((*d++ = *s++) == '\0')
> (gdb) bt
> #0 ink_strlcpy (dst=, src=0x0, siz=) at
> ink_string.cc:259
> #1 0x0041de58 in main (argv=0x7fff92e8bf58) at logstats.cc:2269
> (gdb)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1854) centos 5.9 configure: error: conditional "AMDEP" was never defined.
[
https://issues.apache.org/jira/browse/TS-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643353#comment-13643353
]
James Peach commented on TS-1854:
-
http://stackoverflow.com/questions/10629071/error-message-amdep-was-never-defined
> centos 5.9 configure: error: conditional "AMDEP" was never defined.
> ---
>
> Key: TS-1854
> URL: https://issues.apache.org/jira/browse/TS-1854
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: helaku
>Assignee: James Peach
> Fix For: 3.3.3
>
>
> {code}
> checking for struct tcp_info... yes
> configure: Build using CC=gcc
> configure: Build using CXX=g++
> configure: Build using CPP=gcc -E
> configure: Build using CFLAGS=-g -pipe -Wall -Werror -Wunused-parameter -O3
> -feliminate-unused-debug-symbols -fno-strict-aliasing
> configure: Build using SHARED_CFLAGS=-fPIC
> configure: Build using CXXFLAGS=-g -pipe -Wall -Werror -Wunused-parameter -O3
> -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof
> configure: Build using SHARED_CXXFLAGS=-fPIC
> configure: Build using SHARED_CXXLINKFLAGS=
> configure: Build using CPPFLAGS=-D_LARGEFILE64_SOURCE=1
> -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Dlinux
> configure: Build using LDFLAGS=
> configure: Build using SHARED_LDFLAGS=-shared
> configure: Build using EXTRA_CC_LDFLAGS=
> configure: Build using EXTRA_CXX_LDFLAGS=-rdynamic
> configure: Build using LIBTOOL_LINK_FLAGS=
> configure: Build using MGMT_DEFS= -DMGMT_USE_SYSLOG
> configure: Build using API_DEFS=
> configure: error: conditional "AMDEP" was never defined.
> Usually this means the macro was only invoked conditionally.
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1800) coalesce FNV hash implementations
[ https://issues.apache.org/jira/browse/TS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Sorber reassigned TS-1800: --- Assignee: Phil Sorber > coalesce FNV hash implementations > - > > Key: TS-1800 > URL: https://issues.apache.org/jira/browse/TS-1800 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: James Peach >Assignee: Phil Sorber > Fix For: 3.5.0 > > > We have 4 copies of the FNV hash function: > example/query-remap/query-remap.c > iocore/hostdb/I_HostDBProcessor.h > proxy/hdrs/HdrToken.cc > proxy/logstats.cc > We should unify these into a single place in libts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1856) rename SIZE() macro for better clarity
[ https://issues.apache.org/jira/browse/TS-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643242#comment-13643242 ] ASF subversion and git services commented on TS-1856: - Commit 1250c7cf8018a3e7695c5790f3bb23ca094ec2c2 in branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=1250c7c ] TS-1856 Remove the countof() template from SPDY plugin, and make it compile properly with ink_defs.h included. > rename SIZE() macro for better clarity > -- > > Key: TS-1856 > URL: https://issues.apache.org/jira/browse/TS-1856 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: James Peach >Assignee: James Peach >Priority: Trivial > Fix For: 3.3.3 > > > SIZE() is quite ambiguous. COUNT() is a better name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1856) rename SIZE() macro for better clarity
[ https://issues.apache.org/jira/browse/TS-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach resolved TS-1856. - Resolution: Fixed commit 1617f7620e652623779c28e29685f0f264190da5 Author: James Peach Date: Fri Apr 26 10:49:20 2013 -0700 Replace SIZE() with COUNTOF() and countof() > rename SIZE() macro for better clarity > -- > > Key: TS-1856 > URL: https://issues.apache.org/jira/browse/TS-1856 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: James Peach >Assignee: James Peach >Priority: Trivial > Fix For: 3.3.3 > > > SIZE() is quite ambiguous. COUNT() is a better name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1856) rename SIZE() macro for better clarity
[ https://issues.apache.org/jira/browse/TS-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643095#comment-13643095 ] ASF subversion and git services commented on TS-1856: - Commit cec4cf1d2dd70f5e834811b3159c67c7761f9afe in branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=cec4cf1 ] TS-1856: fix unsigned comparison warnings > rename SIZE() macro for better clarity > -- > > Key: TS-1856 > URL: https://issues.apache.org/jira/browse/TS-1856 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: James Peach >Assignee: James Peach >Priority: Trivial > Fix For: 3.3.3 > > > SIZE() is quite ambiguous. COUNT() is a better name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1856) rename SIZE() macro for better clarity
[ https://issues.apache.org/jira/browse/TS-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach updated TS-1856: Priority: Trivial (was: Major) Fix Version/s: 3.3.3 Assignee: James Peach > rename SIZE() macro for better clarity > -- > > Key: TS-1856 > URL: https://issues.apache.org/jira/browse/TS-1856 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: James Peach >Assignee: James Peach >Priority: Trivial > Fix For: 3.3.3 > > > SIZE() is quite ambiguous. COUNT() is a better name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1856) rename SIZE() macro for better clarity
James Peach created TS-1856: --- Summary: rename SIZE() macro for better clarity Key: TS-1856 URL: https://issues.apache.org/jira/browse/TS-1856 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: James Peach SIZE() is quite ambiguous. COUNT() is a better name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1853) make test on logstats can fail due to math rounding difference
[
https://issues.apache.org/jira/browse/TS-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom resolved TS-1853.
---
Resolution: Fixed
Changed by unifying all numbers to 2-digit precision. There was only one place
where it was 3, for no apparent reason.
> make test on logstats can fail due to math rounding difference
> --
>
> Key: TS-1853
> URL: https://issues.apache.org/jira/browse/TS-1853
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
>
> When doing "make test" for logstats, it can differ slightly on some of the
> floating point calculations. E.g.
> {code}
> 159c159
> < Cache miss total 881,059 423.758
> 199.432
> ---
> > Cache miss total 881,059 423.758
> > 199.431
> {code}
> One suggestion would be to allow for a few lines of differences, another is
> to round the produced text file (munge them) such that the likelihood of
> rounding discrepancies is small.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1855) autoconf warning on older versions
[
https://issues.apache.org/jira/browse/TS-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642985#comment-13642985
]
Leif Hedstrom commented on TS-1855:
---
CentOS 5.9.
{code}
centos-5-x64 (16:11) 259/0 $ rpm -q automake autoconf libtool
automake-1.9.6-2.3.el5
autoconf-2.59-12
libtool-1.5.22-7.el5_4
{code}
> autoconf warning on older versions
> --
>
> Key: TS-1855
> URL: https://issues.apache.org/jira/browse/TS-1855
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Leif Hedstrom
>Assignee: James Peach
> Fix For: 3.3.3
>
>
> {code}
> checking dlfcn.h presence... yes
> configure: WARNING: dlfcn.h: present but cannot be compiled
> configure: WARNING: dlfcn.h: check for missing prerequisite headers?
> configure: WARNING: dlfcn.h: see the Autoconf documentation
> configure: WARNING: dlfcn.h: section "Present But Cannot Be Compiled"
> configure: WARNING: dlfcn.h: proceeding with the preprocessor's result
> configure: WARNING: dlfcn.h: in the future, the compiler will take precedence
> configure: WARNING: ## --- ##
> configure: WARNING: ## Report this to d...@trafficserver.apache.org ##
> configure: WARNING: ## --- ##
> checking for dlfcn.h... yes
> checking how to run the C++ preprocessor... g++ -E
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1855) autoconf warning on older versions
[
https://issues.apache.org/jira/browse/TS-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642977#comment-13642977
]
James Peach commented on TS-1855:
-
Which platform? Which version of autoconf/automake/etc?
> autoconf warning on older versions
> --
>
> Key: TS-1855
> URL: https://issues.apache.org/jira/browse/TS-1855
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Leif Hedstrom
>Assignee: James Peach
> Fix For: 3.3.3
>
>
> {code}
> checking dlfcn.h presence... yes
> configure: WARNING: dlfcn.h: present but cannot be compiled
> configure: WARNING: dlfcn.h: check for missing prerequisite headers?
> configure: WARNING: dlfcn.h: see the Autoconf documentation
> configure: WARNING: dlfcn.h: section "Present But Cannot Be Compiled"
> configure: WARNING: dlfcn.h: proceeding with the preprocessor's result
> configure: WARNING: dlfcn.h: in the future, the compiler will take precedence
> configure: WARNING: ## --- ##
> configure: WARNING: ## Report this to d...@trafficserver.apache.org ##
> configure: WARNING: ## --- ##
> checking for dlfcn.h... yes
> checking how to run the C++ preprocessor... g++ -E
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1855) autoconf warning on older versions
[
https://issues.apache.org/jira/browse/TS-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-1855:
--
Fix Version/s: 3.3.3
> autoconf warning on older versions
> --
>
> Key: TS-1855
> URL: https://issues.apache.org/jira/browse/TS-1855
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Leif Hedstrom
>Assignee: James Peach
> Fix For: 3.3.3
>
>
> {code}
> checking dlfcn.h presence... yes
> configure: WARNING: dlfcn.h: present but cannot be compiled
> configure: WARNING: dlfcn.h: check for missing prerequisite headers?
> configure: WARNING: dlfcn.h: see the Autoconf documentation
> configure: WARNING: dlfcn.h: section "Present But Cannot Be Compiled"
> configure: WARNING: dlfcn.h: proceeding with the preprocessor's result
> configure: WARNING: dlfcn.h: in the future, the compiler will take precedence
> configure: WARNING: ## --- ##
> configure: WARNING: ## Report this to d...@trafficserver.apache.org ##
> configure: WARNING: ## --- ##
> checking for dlfcn.h... yes
> checking how to run the C++ preprocessor... g++ -E
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1855) autoconf warning on older versions
Leif Hedstrom created TS-1855:
-
Summary: autoconf warning on older versions
Key: TS-1855
URL: https://issues.apache.org/jira/browse/TS-1855
Project: Traffic Server
Issue Type: Bug
Components: Build
Reporter: Leif Hedstrom
{code}
checking dlfcn.h presence... yes
configure: WARNING: dlfcn.h: present but cannot be compiled
configure: WARNING: dlfcn.h: check for missing prerequisite headers?
configure: WARNING: dlfcn.h: see the Autoconf documentation
configure: WARNING: dlfcn.h: section "Present But Cannot Be Compiled"
configure: WARNING: dlfcn.h: proceeding with the preprocessor's result
configure: WARNING: dlfcn.h: in the future, the compiler will take precedence
configure: WARNING: ## --- ##
configure: WARNING: ## Report this to d...@trafficserver.apache.org ##
configure: WARNING: ## --- ##
checking for dlfcn.h... yes
checking how to run the C++ preprocessor... g++ -E
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1855) autoconf warning on older versions
[
https://issues.apache.org/jira/browse/TS-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom reassigned TS-1855:
-
Assignee: James Peach
> autoconf warning on older versions
> --
>
> Key: TS-1855
> URL: https://issues.apache.org/jira/browse/TS-1855
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Leif Hedstrom
>Assignee: James Peach
>
> {code}
> checking dlfcn.h presence... yes
> configure: WARNING: dlfcn.h: present but cannot be compiled
> configure: WARNING: dlfcn.h: check for missing prerequisite headers?
> configure: WARNING: dlfcn.h: see the Autoconf documentation
> configure: WARNING: dlfcn.h: section "Present But Cannot Be Compiled"
> configure: WARNING: dlfcn.h: proceeding with the preprocessor's result
> configure: WARNING: dlfcn.h: in the future, the compiler will take precedence
> configure: WARNING: ## --- ##
> configure: WARNING: ## Report this to d...@trafficserver.apache.org ##
> configure: WARNING: ## --- ##
> checking for dlfcn.h... yes
> checking how to run the C++ preprocessor... g++ -E
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1853) make test on logstats can fail due to math rounding difference
[
https://issues.apache.org/jira/browse/TS-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642967#comment-13642967
]
ASF subversion and git services commented on TS-1853:
-
Commit a8981a71ab369bbe603923a52161c8eff7249c3a in branch refs/heads/master
from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a8981a7 ]
TS-1853 Fix formatting in logstats to be consistenly 2 decimals
> make test on logstats can fail due to math rounding difference
> --
>
> Key: TS-1853
> URL: https://issues.apache.org/jira/browse/TS-1853
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
>
> When doing "make test" for logstats, it can differ slightly on some of the
> floating point calculations. E.g.
> {code}
> 159c159
> < Cache miss total 881,059 423.758
> 199.432
> ---
> > Cache miss total 881,059 423.758
> > 199.431
> {code}
> One suggestion would be to allow for a few lines of differences, another is
> to round the produced text file (munge them) such that the likelihood of
> rounding discrepancies is small.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1854) centos 5.9 configure: error: conditional "AMDEP" was never defined.
[
https://issues.apache.org/jira/browse/TS-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642837#comment-13642837
]
Leif Hedstrom commented on TS-1854:
---
I saw this yesterday too, but fwiw, it was not fatal to me (meaning, it still
built fine).
> centos 5.9 configure: error: conditional "AMDEP" was never defined.
> ---
>
> Key: TS-1854
> URL: https://issues.apache.org/jira/browse/TS-1854
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: helaku
>Assignee: James Peach
> Fix For: 3.3.3
>
>
> {code}
> checking for struct tcp_info... yes
> configure: Build using CC=gcc
> configure: Build using CXX=g++
> configure: Build using CPP=gcc -E
> configure: Build using CFLAGS=-g -pipe -Wall -Werror -Wunused-parameter -O3
> -feliminate-unused-debug-symbols -fno-strict-aliasing
> configure: Build using SHARED_CFLAGS=-fPIC
> configure: Build using CXXFLAGS=-g -pipe -Wall -Werror -Wunused-parameter -O3
> -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof
> configure: Build using SHARED_CXXFLAGS=-fPIC
> configure: Build using SHARED_CXXLINKFLAGS=
> configure: Build using CPPFLAGS=-D_LARGEFILE64_SOURCE=1
> -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Dlinux
> configure: Build using LDFLAGS=
> configure: Build using SHARED_LDFLAGS=-shared
> configure: Build using EXTRA_CC_LDFLAGS=
> configure: Build using EXTRA_CXX_LDFLAGS=-rdynamic
> configure: Build using LIBTOOL_LINK_FLAGS=
> configure: Build using MGMT_DEFS= -DMGMT_USE_SYSLOG
> configure: Build using API_DEFS=
> configure: error: conditional "AMDEP" was never defined.
> Usually this means the macro was only invoked conditionally.
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1854) centos 5.9 configure: error: conditional "AMDEP" was never defined.
[
https://issues.apache.org/jira/browse/TS-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-1854:
--
Component/s: Build
Fix Version/s: 3.3.3
Assignee: James Peach
> centos 5.9 configure: error: conditional "AMDEP" was never defined.
> ---
>
> Key: TS-1854
> URL: https://issues.apache.org/jira/browse/TS-1854
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: helaku
>Assignee: James Peach
> Fix For: 3.3.3
>
>
> {code}
> checking for struct tcp_info... yes
> configure: Build using CC=gcc
> configure: Build using CXX=g++
> configure: Build using CPP=gcc -E
> configure: Build using CFLAGS=-g -pipe -Wall -Werror -Wunused-parameter -O3
> -feliminate-unused-debug-symbols -fno-strict-aliasing
> configure: Build using SHARED_CFLAGS=-fPIC
> configure: Build using CXXFLAGS=-g -pipe -Wall -Werror -Wunused-parameter -O3
> -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof
> configure: Build using SHARED_CXXFLAGS=-fPIC
> configure: Build using SHARED_CXXLINKFLAGS=
> configure: Build using CPPFLAGS=-D_LARGEFILE64_SOURCE=1
> -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Dlinux
> configure: Build using LDFLAGS=
> configure: Build using SHARED_LDFLAGS=-shared
> configure: Build using EXTRA_CC_LDFLAGS=
> configure: Build using EXTRA_CXX_LDFLAGS=-rdynamic
> configure: Build using LIBTOOL_LINK_FLAGS=
> configure: Build using MGMT_DEFS= -DMGMT_USE_SYSLOG
> configure: Build using API_DEFS=
> configure: error: conditional "AMDEP" was never defined.
> Usually this means the macro was only invoked conditionally.
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1853) make test on logstats can fail due to math rounding difference
[
https://issues.apache.org/jira/browse/TS-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-1853:
--
Fix Version/s: 3.3.3
Assignee: Leif Hedstrom
> make test on logstats can fail due to math rounding difference
> --
>
> Key: TS-1853
> URL: https://issues.apache.org/jira/browse/TS-1853
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
>
> When doing "make test" for logstats, it can differ slightly on some of the
> floating point calculations. E.g.
> {code}
> 159c159
> < Cache miss total 881,059 423.758
> 199.432
> ---
> > Cache miss total 881,059 423.758
> > 199.431
> {code}
> One suggestion would be to allow for a few lines of differences, another is
> to round the produced text file (munge them) such that the likelihood of
> rounding discrepancies is small.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1852) centos5.9 autoreconf -i failed
[
https://issues.apache.org/jira/browse/TS-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642649#comment-13642649
]
helaku commented on TS-1852:
thank's
> centos5.9 autoreconf -i failed
>
>
> Key: TS-1852
> URL: https://issues.apache.org/jira/browse/TS-1852
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
>Reporter: helaku
>Assignee: James Peach
> Fix For: 3.3.3
>
>
> {code}
> [root@admin trafficserver]# autoreconf -i
> configure.ac:987: warning: AC_PROG_SED is m4_require'd but is not m4_defun'd
> configure.ac:987: AC_PROG_SED is required by...
> build/ax_path_generic.m4:164: AX_PATH_GENERIC is expanded from...
> build/ax_lib_curl.m4:38: AX_LIB_CURL is expanded from...
> configure.ac:987: the top level
> configure.ac:987: warning: AC_PROG_SED is m4_require'd but is not m4_defun'd
> configure.ac:987: AC_PROG_SED is required by...
> build/ax_path_generic.m4:164: AX_PATH_GENERIC is expanded from...
> build/ax_lib_curl.m4:38: AX_LIB_CURL is expanded from...
> configure.ac:987: the top level
> Putting files in AC_CONFIG_AUX_DIR, `build/aux'.
> configure.ac:987: warning: AC_PROG_SED is m4_require'd but is not m4_defun'd
> configure.ac:987: AC_PROG_SED is required by...
> build/ax_path_generic.m4:164: AX_PATH_GENERIC is expanded from...
> build/ax_lib_curl.m4:38: AX_LIB_CURL is expanded from...
> configure.ac:987: the top level
> configure.ac:987: warning: AC_PROG_SED is m4_require'd but is not m4_defun'd
> configure.ac:987: AC_PROG_SED is required by...
> build/ax_path_generic.m4:164: AX_PATH_GENERIC is expanded from...
> build/ax_lib_curl.m4:38: AX_LIB_CURL is expanded from...
> configure.ac:987: the top level
> configure.ac:580: error: possibly undefined macro: AC_PROG_SED
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> autoreconf: /usr/bin/autoconf failed with exit status: 1
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1854) centos 5.9 configure: error: conditional "AMDEP" was never defined.
helaku created TS-1854:
--
Summary: centos 5.9 configure: error: conditional "AMDEP" was
never defined.
Key: TS-1854
URL: https://issues.apache.org/jira/browse/TS-1854
Project: Traffic Server
Issue Type: Bug
Reporter: helaku
{code}
checking for struct tcp_info... yes
configure: Build using CC=gcc
configure: Build using CXX=g++
configure: Build using CPP=gcc -E
configure: Build using CFLAGS=-g -pipe -Wall -Werror -Wunused-parameter -O3
-feliminate-unused-debug-symbols -fno-strict-aliasing
configure: Build using SHARED_CFLAGS=-fPIC
configure: Build using CXXFLAGS=-g -pipe -Wall -Werror -Wunused-parameter -O3
-feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof
configure: Build using SHARED_CXXFLAGS=-fPIC
configure: Build using SHARED_CXXLINKFLAGS=
configure: Build using CPPFLAGS=-D_LARGEFILE64_SOURCE=1
-D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Dlinux
configure: Build using LDFLAGS=
configure: Build using SHARED_LDFLAGS=-shared
configure: Build using EXTRA_CC_LDFLAGS=
configure: Build using EXTRA_CXX_LDFLAGS=-rdynamic
configure: Build using LIBTOOL_LINK_FLAGS=
configure: Build using MGMT_DEFS= -DMGMT_USE_SYSLOG
configure: Build using API_DEFS=
configure: error: conditional "AMDEP" was never defined.
Usually this means the macro was only invoked conditionally.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
