[jira] [Commented] (TS-1953) remove check_ts_version() from (example) plugins or make it an API
[
https://issues.apache.org/jira/browse/TS-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727462#comment-13727462
]
Igor Galić commented on TS-1953:
uses the version string:
{code}
// plugins/stats_over_http/stats_over_http.c Line 150
static void
json_out_stats(stats_state * my_state)
{
const char *version;
APPEND({ \global\: {\n);
TSRecordDump(TS_RECORDTYPE_PROCESS, json_out_stat, my_state);
version = TSTrafficServerVersionGet();
APPEND(\server\: \);
APPEND(version);
APPEND(\\n);
APPEND( }\n}\n);
}
{code}
uses the Version Number in a way that actually makes sense:
{code}
// plugins/stats_over_http/stats_over_http.c Line 241
cleanup:
#if (TS_VERSION_NUMBER 2001005)
if(path) TSHandleStringRelease(reqp, url_loc, path);
#endif
if(url_loc) TSHandleMLocRelease(reqp, hdr_loc, url_loc);
if(hdr_loc) TSHandleMLocRelease(reqp, TS_NULL_MLOC, hdr_loc);
{code}
so I'd like to boil this down to an example/doc about how to handle versioning.
remove check_ts_version() from (example) plugins or make it an API
--
Key: TS-1953
URL: https://issues.apache.org/jira/browse/TS-1953
Project: Traffic Server
Issue Type: Improvement
Components: Plugins
Reporter: Igor Galić
Fix For: sometime
almost every single of our (example) plugins has a function
{{chec_ts_version()}}. If this boiler-code is so crucial to a plugin's
functionality, we should offer an API for it, instead of making developers
write (copy) that code every time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1953) remove check_ts_version() from (example) plugins or make it an API
[
https://issues.apache.org/jira/browse/TS-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727475#comment-13727475
]
Leif Hedstrom commented on TS-1953:
---
+1.
remove check_ts_version() from (example) plugins or make it an API
--
Key: TS-1953
URL: https://issues.apache.org/jira/browse/TS-1953
Project: Traffic Server
Issue Type: Improvement
Components: Plugins
Reporter: Igor Galić
Fix For: sometime
almost every single of our (example) plugins has a function
{{chec_ts_version()}}. If this boiler-code is so crucial to a plugin's
functionality, we should offer an API for it, instead of making developers
write (copy) that code every time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TS-2088) Change TSRecordType enum values to powers of two
[ https://issues.apache.org/jira/browse/TS-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727676#comment-13727676 ] Phil Sorber edited comment on TS-2088 at 8/2/13 1:32 PM: - [~jpe...@apache.org], That's an interesting point. I think when I get to this ticket I'll look into what I think makes sense and solicit your input. I'm OK with tossing this ticket as a possible outcome of that. Do you think the existing NULL type makes sense? [~zwoop], Do you see their behavior as different? Or you just like the explicitness of that name? was (Author: psudaemon): [~jpeach], That's an interesting point. I think when I get to this ticket I'll look into what I think makes sense and solicit your input. I'm OK with tossing this ticket as a possible outcome of that. Do you think the existing NULL type makes sense? [~zwoop], Do you see their behavior as different? Or you just like the explicitness of that name? Change TSRecordType enum values to powers of two Key: TS-2088 URL: https://issues.apache.org/jira/browse/TS-2088 Project: Traffic Server Issue Type: Improvement Reporter: Phil Sorber Assignee: Phil Sorber Priority: Minor Labels: C Fix For: 3.5.1 This way we can OR them together and do multiple types at once. Also add an ALL value. This should not effect the API compatibility with old usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2088) Change TSRecordType enum values to powers of two
[ https://issues.apache.org/jira/browse/TS-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727676#comment-13727676 ] Phil Sorber commented on TS-2088: - [~jpeach], That's an interesting point. I think when I get to this ticket I'll look into what I think makes sense and solicit your input. I'm OK with tossing this ticket as a possible outcome of that. Do you think the existing NULL type makes sense? [~zwoop], Do you see their behavior as different? Or you just like the explicitness of that name? Change TSRecordType enum values to powers of two Key: TS-2088 URL: https://issues.apache.org/jira/browse/TS-2088 Project: Traffic Server Issue Type: Improvement Reporter: Phil Sorber Assignee: Phil Sorber Priority: Minor Labels: C Fix For: 3.5.1 This way we can OR them together and do multiple types at once. Also add an ALL value. This should not effect the API compatibility with old usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-2089) one log collation thread is not enough for busy system
Zhao Yongming created TS-2089:
-
Summary: one log collation thread is not enough for busy system
Key: TS-2089
URL: https://issues.apache.org/jira/browse/TS-2089
Project: Traffic Server
Issue Type: Improvement
Components: Logging
Reporter: Zhao Yongming
we should make log collation more thread cpu nice.
{code}
top - 22:34:22 up 3:37, 1 user, load average: 1.20, 1.71, 1.66
Tasks: 979 total, 2 running, 977 sleeping, 0 stopped, 0 zombie
Cpu(s): 3.5%us, 0.6%sy, 0.0%ni, 95.6%id, 0.0%wa, 0.0%hi, 0.3%si, 0.0%st
Mem: 65943744k total, 62536348k used, 3407396k free,90544k buffers
Swap: 2097144k total,0k used, 2097144k free, 54189788k cached
PID USER PR NI VIRT RES SHR S %CPU %MEMTIME+ COMMAND
4651 ats 20 0 12.9g 5.3g 4928 R 100.1 8.5 197:51.78 [LOGGING]
4460 ats 20 0 12.9g 5.3g 4928 S 7.9 8.5 18:12.57 [ET_NET 44]
4457 ats 20 0 12.9g 5.3g 4928 S 5.3 8.5 7:32.34 [ET_NET 41]
4461 ats 20 0 12.9g 5.3g 4928 S 4.3 8.5 6:41.79 [ET_NET 45]
4453 ats 20 0 12.9g 5.3g 4928 S 3.0 8.5 6:44.52 [ET_NET 37]
4463 ats 20 0 12.9g 5.3g 4928 S 3.0 8.5 7:54.01 [ET_NET 47]
3652 root 39 19 000 S 1.0 0.0 2:14.15 kipmi0
4425 ats 20 0 12.9g 5.3g 4928 S 0.7 8.5 0:19.21 [ET_NET 9]
4426 ats 20 0 12.9g 5.3g 4928 S 0.7 8.5 0:19.42 [ET_NET 10]
4430 ats 20 0 12.9g 5.3g 4928 S 0.7 8.5 0:19.55 [ET_NET 14]
132 root 20 0 000 S 0.3 0.0 0:00.82 events/1
4417 ats 20 0 12.9g 5.3g 4928 S 0.3 8.5 0:19.82 [ET_NET 1]
4418 ats 20 0 12.9g 5.3g 4928 S 0.3 8.5 0:20.02 [ET_NET 2]
4420 ats 20 0 12.9g 5.3g 4928 S 0.3 8.5 0:19.64 [ET_NET 4]
4422 ats 20 0 12.9g 5.3g 4928 S 0.3 8.5 0:19.84 [ET_NET 6]
4427 ats 20 0 12.9g 5.3g 4928 S 0.3 8.5 0:19.94 [ET_NET 11]
4435 ats 20 0 12.9g 5.3g 4928 S 0.3 8.5 0:19.88 [ET_NET 19]
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1006) memory management, cut down memory waste ?
[
https://issues.apache.org/jira/browse/TS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727759#comment-13727759
]
ASF subversion and git services commented on TS-1006:
-
Commit cdbfe1d6d6c43241d773a32e3bbdd0ca1d9b in branch refs/heads/master
from [~yunkai]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=cdbfe1d ]
TS-1006: adjust some reclaimable-freelist's default configuration
1) Adjust enable_reclaim to 1 as default in
records.config.default.in file.
2) Adjust max_overage to 3 in code, so that it keeps the same value
with records.config.default.in. And most important, this value seems
work well in our product environment.
Signed-off-by: Yunkai Zhang qiushu@taobao.com
memory management, cut down memory waste ?
--
Key: TS-1006
URL: https://issues.apache.org/jira/browse/TS-1006
Project: Traffic Server
Issue Type: Improvement
Components: Core
Affects Versions: 3.1.1
Reporter: Zhao Yongming
Assignee: Yunkai Zhang
Fix For: 3.3.4
Attachments:
0001-TS-1006-Add-an-enable-reclaimable-freelist-option.patch,
0002-TS-1006-Add-a-new-wrapper-ink_atomic_decrement.patch,
0003-TS-1006-Introduce-a-reclaimable-InkFreeList.patch,
0004-TS-1006-Make-InkFreeList-memory-pool-configurable.patch,
Memory-Usage-After-Introduced-New-Allocator.png, memusage.ods, memusage.ods
when we review the memory usage in the production, there is something
abnormal, ie, looks like TS take much memory than index data + common system
waste, and here is some memory dump result by set
proxy.config.dump_mem_info_frequency
1, the one on a not so busy forwarding system:
physics memory: 32G
RAM cache: 22G
DISK: 6140 GB
average_object_size 64000
{code}
allocated |in-use | type size | free list name
|||--
671088640 | 37748736 |2097152 |
memory/ioBufAllocator[14]
2248146944 | 2135949312 |1048576 |
memory/ioBufAllocator[13]
1711276032 | 1705508864 | 524288 |
memory/ioBufAllocator[12]
1669332992 | 1667760128 | 262144 |
memory/ioBufAllocator[11]
2214592512 | 221184 | 131072 |
memory/ioBufAllocator[10]
2325741568 | 2323775488 | 65536 |
memory/ioBufAllocator[9]
2091909120 | 2089123840 | 32768 |
memory/ioBufAllocator[8]
1956642816 | 1956478976 | 16384 |
memory/ioBufAllocator[7]
2094530560 | 2094071808 | 8192 |
memory/ioBufAllocator[6]
356515840 | 355540992 | 4096 |
memory/ioBufAllocator[5]
1048576 | 14336 | 2048 |
memory/ioBufAllocator[4]
131072 | 0 | 1024 |
memory/ioBufAllocator[3]
65536 | 0 |512 |
memory/ioBufAllocator[2]
32768 | 0 |256 |
memory/ioBufAllocator[1]
16384 | 0 |128 |
memory/ioBufAllocator[0]
0 | 0 |576 |
memory/ICPRequestCont_allocator
0 | 0 |112 |
memory/ICPPeerReadContAllocator
0 | 0 |432 |
memory/PeerReadDataAllocator
0 | 0 | 32 |
memory/MIMEFieldSDKHandle
0 | 0 |240 |
memory/INKVConnAllocator
0 | 0 | 96 |
memory/INKContAllocator
4096 | 0 | 32 |
memory/apiHookAllocator
0 | 0 |288 |
memory/FetchSMAllocator
0 | 0 | 80 |
memory/prefetchLockHandlerAllocator
0 | 0 |176 |
memory/PrefetchBlasterAllocator
0 | 0 | 80 |
memory/prefetchUrlBlaster
0 | 0 | 96 | memory/blasterUrlList
0 | 0 | 96 |
memory/prefetchUrlEntryAllocator
0 | 0 |128 |
memory/socksProxyAllocator
0 | 0 |144 |
memory/ObjectReloadCont
3258368 | 576016 |592 |
memory/httpClientSessionAllocator
825344 | 139568 |208 |
memory/httpServerSessionAllocator
22597632 |1284848 | 9808 | memory/httpSMAllocator
0
[jira] [Created] (TS-2090) Make proxy.config.allocator.enable_reclaim default based on build instructions
Leif Hedstrom created TS-2090: - Summary: Make proxy.config.allocator.enable_reclaim default based on build instructions Key: TS-2090 URL: https://issues.apache.org/jira/browse/TS-2090 Project: Traffic Server Issue Type: Bug Components: Build Reporter: Leif Hedstrom -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2090) Make proxy.config.allocator.enable_reclaim default based on build instructions
[ https://issues.apache.org/jira/browse/TS-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727810#comment-13727810 ] ASF subversion and git services commented on TS-2090: - Commit b91279d9992bd9fd7a8fd76db78bff584bfdf385 in branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=b91279d ] TS-2090 Make proxy.config.allocator.enable_reclaim default based on build instructions Make proxy.config.allocator.enable_reclaim default based on build instructions -- Key: TS-2090 URL: https://issues.apache.org/jira/browse/TS-2090 Project: Traffic Server Issue Type: Improvement Components: Build Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 3.3.5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-2090) Make proxy.config.allocator.enable_reclaim default based on build instructions
[ https://issues.apache.org/jira/browse/TS-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-2090: -- Fix Version/s: 3.3.5 Assignee: Leif Hedstrom Issue Type: Improvement (was: Bug) Make proxy.config.allocator.enable_reclaim default based on build instructions -- Key: TS-2090 URL: https://issues.apache.org/jira/browse/TS-2090 Project: Traffic Server Issue Type: Improvement Components: Build Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 3.3.5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2088) Change TSRecordType enum values to powers of two
[ https://issues.apache.org/jira/browse/TS-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727815#comment-13727815 ] Leif Hedstrom commented on TS-2088: --- Different behavior (but, I haven't looked at the code). ALL to me implies all Records types, which includes not only metrics, but also configurations. If you want both, they sure, it should be ALL, but it seems reasonable to think that you might only want ALL metrics. Perhaps you also need an ALL configurations. -- leif Change TSRecordType enum values to powers of two Key: TS-2088 URL: https://issues.apache.org/jira/browse/TS-2088 Project: Traffic Server Issue Type: Improvement Reporter: Phil Sorber Assignee: Phil Sorber Priority: Minor Labels: C Fix For: 3.5.1 This way we can OR them together and do multiple types at once. Also add an ALL value. This should not effect the API compatibility with old usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2088) Change TSRecordType enum values to powers of two
[ https://issues.apache.org/jira/browse/TS-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727816#comment-13727816 ] Leif Hedstrom commented on TS-2088: --- To clarify, librecords contain both metrics and configurations. Change TSRecordType enum values to powers of two Key: TS-2088 URL: https://issues.apache.org/jira/browse/TS-2088 Project: Traffic Server Issue Type: Improvement Reporter: Phil Sorber Assignee: Phil Sorber Priority: Minor Labels: C Fix For: 3.5.1 This way we can OR them together and do multiple types at once. Also add an ALL value. This should not effect the API compatibility with old usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-2091) Persistent stats not working
[ https://issues.apache.org/jira/browse/TS-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Sorber updated TS-2091: Fix Version/s: 3.5.1 Persistent stats not working Key: TS-2091 URL: https://issues.apache.org/jira/browse/TS-2091 Project: Traffic Server Issue Type: Bug Affects Versions: 3.3.4 Reporter: Phil Sorber Labels: C Fix For: 3.5.1 When creating TS_STAT_PERSISTENT stats in plugins in 3.3dev I don't see them as reloading properly. I can create them fine, and they get stored. Upon restarting TS I can see them in stats, but when doing TSStatFindName() I always get 0 back with a TS_SUCCESS. So it sees that they are there but does not have the correct ID for them to return. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-2091) Persistent stats not working
[ https://issues.apache.org/jira/browse/TS-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Sorber updated TS-2091: Labels: C (was: ) Persistent stats not working Key: TS-2091 URL: https://issues.apache.org/jira/browse/TS-2091 Project: Traffic Server Issue Type: Bug Affects Versions: 3.3.4 Reporter: Phil Sorber Labels: C When creating TS_STAT_PERSISTENT stats in plugins in 3.3dev I don't see them as reloading properly. I can create them fine, and they get stored. Upon restarting TS I can see them in stats, but when doing TSStatFindName() I always get 0 back with a TS_SUCCESS. So it sees that they are there but does not have the correct ID for them to return. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-2091) Persistent stats not working
Phil Sorber created TS-2091: --- Summary: Persistent stats not working Key: TS-2091 URL: https://issues.apache.org/jira/browse/TS-2091 Project: Traffic Server Issue Type: Bug Reporter: Phil Sorber When creating TS_STAT_PERSISTENT stats in plugins in 3.3dev I don't see them as reloading properly. I can create them fine, and they get stored. Upon restarting TS I can see them in stats, but when doing TSStatFindName() I always get 0 back with a TS_SUCCESS. So it sees that they are there but does not have the correct ID for them to return. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-2091) Persistent stats not working
[ https://issues.apache.org/jira/browse/TS-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Sorber updated TS-2091: Affects Version/s: 3.3.4 Persistent stats not working Key: TS-2091 URL: https://issues.apache.org/jira/browse/TS-2091 Project: Traffic Server Issue Type: Bug Affects Versions: 3.3.4 Reporter: Phil Sorber When creating TS_STAT_PERSISTENT stats in plugins in 3.3dev I don't see them as reloading properly. I can create them fine, and they get stored. Upon restarting TS I can see them in stats, but when doing TSStatFindName() I always get 0 back with a TS_SUCCESS. So it sees that they are there but does not have the correct ID for them to return. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-2091) Persistent stats not working
[ https://issues.apache.org/jira/browse/TS-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Sorber updated TS-2091: Fix Version/s: (was: 3.5.1) 3.3.6 Persistent stats not working Key: TS-2091 URL: https://issues.apache.org/jira/browse/TS-2091 Project: Traffic Server Issue Type: Bug Affects Versions: 3.3.4 Reporter: Phil Sorber Labels: C Fix For: 3.3.6 When creating TS_STAT_PERSISTENT stats in plugins in 3.3dev I don't see them as reloading properly. I can create them fine, and they get stored. Upon restarting TS I can see them in stats, but when doing TSStatFindName() I always get 0 back with a TS_SUCCESS. So it sees that they are there but does not have the correct ID for them to return. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-454) Dynamic resizing API stats
[ https://issues.apache.org/jira/browse/TS-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Sorber reassigned TS-454: -- Assignee: Phil Sorber Dynamic resizing API stats -- Key: TS-454 URL: https://issues.apache.org/jira/browse/TS-454 Project: Traffic Server Issue Type: Bug Components: Stats Reporter: Leif Hedstrom Assignee: Phil Sorber Fix For: sometime This is a new bug, as introduced with TS-390. We do not properly allow to resize the librecords container, not allowing API (plugins) to create the requested number of stats slots. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-2052) ET_SSL thread spinning
[ https://issues.apache.org/jira/browse/TS-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Geffon resolved TS-2052. -- Resolution: Fixed Fixed in 94e9830c21f046aafe0247fb9c95198fc0902144 ET_SSL thread spinning -- Key: TS-2052 URL: https://issues.apache.org/jira/browse/TS-2052 Project: Traffic Server Issue Type: Bug Components: SSL Reporter: Thomas Jackson Assignee: Brian Geffon Priority: Blocker Fix For: 3.3.5 I'm running ATS 3.2.4 and as I was benchmarking ATS for SSL usage I noticed that the CPU usage would go up dramatically even after I had stopped the test. After running a benchmark I am able to get an ET_SSL thread stuck spinning (100% cpu in top). I am also able to reproduce this off master from git. To reproduce: - setup trafficserver with ssl port - siege -b -c 1000 -n 100 https://hostname/path let it sit for 1-5minutes and one of the ET_SSL threads will be stuck spinning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2052) ET_SSL thread spinning
[ https://issues.apache.org/jira/browse/TS-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728328#comment-13728328 ] ASF subversion and git services commented on TS-2052: - Commit 94e9830c21f046aafe0247fb9c95198fc0902144 in branch refs/heads/master from [~briang] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=94e9830 ] [TS-2052] ET_SSL thread spinning ET_SSL thread spinning -- Key: TS-2052 URL: https://issues.apache.org/jira/browse/TS-2052 Project: Traffic Server Issue Type: Bug Components: SSL Reporter: Thomas Jackson Assignee: Brian Geffon Priority: Blocker Fix For: 3.3.5 I'm running ATS 3.2.4 and as I was benchmarking ATS for SSL usage I noticed that the CPU usage would go up dramatically even after I had stopped the test. After running a benchmark I am able to get an ET_SSL thread stuck spinning (100% cpu in top). I am also able to reproduce this off master from git. To reproduce: - setup trafficserver with ssl port - siege -b -c 1000 -n 100 https://hostname/path let it sit for 1-5minutes and one of the ET_SSL threads will be stuck spinning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-2088) Change TSRecordType enum values to powers of two
[ https://issues.apache.org/jira/browse/TS-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728387#comment-13728387 ] Phil Sorber commented on TS-2088: - [~zwoop] Ah, that makes sense then. So maybe three options. ALL, ALL_METRICS, and ALL_CONFIG or something like that. Change TSRecordType enum values to powers of two Key: TS-2088 URL: https://issues.apache.org/jira/browse/TS-2088 Project: Traffic Server Issue Type: Improvement Reporter: Phil Sorber Assignee: Phil Sorber Priority: Minor Labels: C Fix For: 3.5.1 This way we can OR them together and do multiple types at once. Also add an ALL value. This should not effect the API compatibility with old usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-2008) Cache control with multiple suffixes
[
https://issues.apache.org/jira/browse/TS-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bettydramit updated TS-2008:
Attachment: ts-2008-v3.patch
third version
Cache control with multiple suffixes
Key: TS-2008
URL: https://issues.apache.org/jira/browse/TS-2008
Project: Traffic Server
Issue Type: New Feature
Components: Cache, HTTP
Affects Versions: 3.3.4
Reporter: bettydramit
Assignee: James Peach
Fix For: 3.5.0
Attachments: ControlMatcher.patch, ts-2008.patch, ts-2008-v3.patch
if you want to control on ver many suffix in cache.config: jpeg js ... you
need to specify:
dest_domain=www.test.com suffix=jpeg ttl-in-cache=1m
dest_domain=www.test.com suffix=js ttl-in-cache=1m
...
and we can change to :
dest_domain=www.test.com suffix=jpeg,js,css,html ttl-in-cache=1m
by this patch：
{code}
diff -Nur ts-3.3.1/proxy/ControlMatcher.cc
ts-3.3.1-new/proxy/ControlMatcher.cc
--- ts-3.3.1/proxy/ControlMatcher.cc2013-03-10 03:44:28.0 +0800
+++ ts-3.3.1-new/proxy/ControlMatcher.cc2013-07-08 22:42:31.568980245
+0800
@@ -44,7 +44,7 @@
#include P_Cache.h
#include P_SplitDNS.h
#include congest/Congestion.h
-
+#include string
/
* Place all template instantiations at the bottom of the file
/
@@ -815,6 +815,63 @@
if (file_buf == NULL) {
return 1;
}
+ /* add by reggie */
+ if(strcmp([CacheControl],matcher_name) == 0){
+ Debug(reggie-suffix,file_string is begin );
+ char *strbuffern = NULL;
+ char *strfile_buf = file_buf, *tmpvalue = NULL;
+ char *cp_line[64];
+ int in = 0;
+ char buffer1[128] = {0};
+ char *outer_ptr=NULL;
+ std::string file_string;
+ while((strbuffern = strtok_r(strfile_buf,\n,outer_ptr)) != NULL){
+ Debug(reggie-suffix,strbuffern is %s,strbuffern);
+ if(*strbuffern == '#'){
+ Debug(reggie-suffix,# is %s ,strbuffern);
+ strfile_buf = NULL;
+ continue;
+ }
+ if((strchr(strbuffern,',')) != NULL){
+ in = 0;
+ while((cp_line[in]=strtok(strbuffern, ))!=NULL) {
+ strbuffern = NULL;
+ in++;
+ }
+ if((strchr(cp_line[1],'=') != NULL)
(strstr(cp_line[1],suffix))){
+ if((cp_line[in] = strtok(cp_line[1],=)) !=
NULL)
+ tmpvalue = strtok(NULL,=);
+ while((cp_line[in] = strtok(tmpvalue,,)) !=
NULL){
+ in++;
+ tmpvalue = NULL;
+ }
+ }
+ for(int nk = 3; nk in ;nk++){
+ //nbuf_len = strlen(cp_line[0]) +
strlen(cp_line[2]) +strlen(cp_line[nk]) + 9;
+ //snprintf(buffer1,nbuf_len,%s suffix=%s
%s\n,cp_line[0],cp_line[nk],cp_line[2]);
+ sprintf(buffer1,%s suffix=%s
%s\n,cp_line[0],cp_line[nk],cp_line[2]);
+ file_string.append(buffer1);
+ }
+ }
+ else{
+ file_string.append(strbuffern);
+ file_string += \n;
+ }
+ strfile_buf = NULL;
+ }
+ //file_string.erase(file_string.end()-1);
+ Debug(reggie_suffix,file_string is %s ,file_string.c_str());
+ ats_free(file_buf);
+ file_buf = (char*) ats_malloc(file_string.size()+1);
+ if(strcpy(file_buf,file_string.c_str()) == NULL){
+ ats_free(file_buf);
+ return 2;
+ }
+ ret = BuildTableFromString(file_buf);
+ ats_free(file_buf);
+ return ret;
+ }
+ /*end by reggie */
ret = BuildTableFromString(file_buf);
ats_free(file_buf);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
