[jira] [Commented] (TS-2891) remap_stats plugin is not recording stats correctly
[ https://issues.apache.org/jira/browse/TS-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036514#comment-14036514 ] ASF subversion and git services commented on TS-2891: - Commit d3879b03fdb5ff27685a004413b28f744e587a8a in trafficserver's branch refs/heads/master from [~jlaue] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=d3879b0 ] TS-2891: Optimiize if block for status code remap_stats plugin is not recording stats correctly --- Key: TS-2891 URL: https://issues.apache.org/jira/browse/TS-2891 Project: Traffic Server Issue Type: Bug Components: Plugins Reporter: Phil Sorber Assignee: Phil Sorber Fix For: 5.1.0 remap_stats plugin only records stats some of the time. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2891) remap_stats plugin is not recording stats correctly
[ https://issues.apache.org/jira/browse/TS-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036515#comment-14036515 ] ASF subversion and git services commented on TS-2891: - Commit eab97f12055a00c544ba0c1f3c17f48847e33a90 in trafficserver's branch refs/heads/master from [~psudaemon] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=eab97f1 ] TS-2891: Change status code usage to int to avoid clang warning remap_stats plugin is not recording stats correctly --- Key: TS-2891 URL: https://issues.apache.org/jira/browse/TS-2891 Project: Traffic Server Issue Type: Bug Components: Plugins Reporter: Phil Sorber Assignee: Phil Sorber Fix For: 5.1.0 remap_stats plugin only records stats some of the time. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2879) Remap errors and redirects should honor keep-alive
[ https://issues.apache.org/jira/browse/TS-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036675#comment-14036675 ] ASF subversion and git services commented on TS-2879: - Commit 940489d7aa4017de7fbd40cb23b59731a2bd800f in trafficserver's branch refs/heads/4.2.x from [~briang] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=940489d ] TS-2879: Remap errors and redirects should honor keep-alive Remap errors and redirects should honor keep-alive -- Key: TS-2879 URL: https://issues.apache.org/jira/browse/TS-2879 Project: Traffic Server Issue Type: Bug Components: Core, Remap API Reporter: Brian Geffon Assignee: Brian Geffon Fix For: 5.1.0 It appears that when you redirect via regex_remap (or any remap plugin), or if you have a remap error (such as mapping not found) it will close the connection. This seems wrongs, you should probably honor the clients Keep-Alive settings. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2253) PluginVC::process_close Segmentation fault
[ https://issues.apache.org/jira/browse/TS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036674#comment-14036674 ] ASF subversion and git services commented on TS-2253: - Commit 29f945ee926650b60e517f960a8e7ae48e885c0a in trafficserver's branch refs/heads/4.2.x from [~bettydreamit] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=29f945e ] TS-2253: PluginVC::process_close Segmentation fault PluginVC::process_close Segmentation fault --- Key: TS-2253 URL: https://issues.apache.org/jira/browse/TS-2253 Project: Traffic Server Issue Type: Bug Components: Core Affects Versions: 4.0.1 Reporter: bettydramit Assignee: Bryan Call Labels: crash, review Fix For: 5.0.0 Attachments: 4.0.1.patch, TS-2253.wj.diff Env: centos 6 x86_64 ats 4.0.1 [E. Mgmt] log == [TrafficManager] using root directory '/usr' [TrafficServer] using root directory '/usr' NOTE: Traffic Server received Sig 11: Segmentation fault /usr/bin/traffic_server - STACK TRACE: /lib64/libpthread.so.0(+0xf500)[0x2b7b3a8a3500] [0x2b7b3e825ac0] gdb info Reading symbols from /lib64/libnss_dns-2.12.so...Reading symbols from /usr/lib/debug/lib64/libnss_dns-2.12.so.debug...done. done. Loaded symbols for /lib64/libnss_dns-2.12.so Core was generated by `/usr/bin/traffic_server -M --httpport 80:fd=7'. Program terminated with signal 11, Segmentation fault. #0 0x2ac40034ed80 in ?? () Missing separate debuginfos, use: debuginfo-install ts-4.0.1-9.el6.x86_64 (gdb) where #0 0x2ac40034ed80 in ?? () #1 0x004d1ef2 in PluginVC::process_close() () #2 0x004d2938 in PluginVC::main_handler(int, void*) () #3 0x006a372f in EThread::process_event(Event*, int) () #4 0x006a42ab in EThread::execute() () #5 0x004c59b4 in main () -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2497) Failed post results in tunnel buffers being returned to freelist prematurely
[ https://issues.apache.org/jira/browse/TS-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036672#comment-14036672 ] ASF subversion and git services commented on TS-2497: - Commit 3590612398a1e458a056541a5ca5d0dc44405183 in trafficserver's branch refs/heads/4.2.x from [~briang] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=3590612 ] TS-2497: Memory leak with failed posts Failed post results in tunnel buffers being returned to freelist prematurely Key: TS-2497 URL: https://issues.apache.org/jira/browse/TS-2497 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Brian Geffon Assignee: Brian Geffon Fix For: 4.2.0 Attachments: TS-2497.patch, repro.js When a post fails to an origin server either the server died or the server returned a response without reading all of the post data, in either case, TS will destroy buffers too early. This normally does not result in a crash because the MIOBuffers are returned to the freelist and only with sufficient load will the race happen causing a crash. Additionally, even if a crash doesn't happen you might have data corruption across post requests from the buffers being used after being returned to the freelist. Thanks to Thomas Jackson for help reproducing and resolving this bug. An example stack trace, while we've seen other crashes in write_avail too. #0 0x004eff14 in IOBufferBlock::read_avail (this=0x0) at ../iocore/eventsystem/I_IOBuffer.h:362 #1 0x0050d151 in MIOBuffer::append_block_internal (this=0x2aab38001130, b=0x2aab0c037200) at ../iocore/eventsystem/P_IOBuffer.h:946 #2 0x0050d39b in MIOBuffer::append_block (this=0x2aab38001130, asize_index=15) at ../iocore/eventsystem/P_IOBuffer.h:986 #3 0x0050d49b in MIOBuffer::add_block (this=0x2aab38001130) at ../iocore/eventsystem/P_IOBuffer.h:994 #4 0x0055cee2 in MIOBuffer::check_add_block (this=0x2aab38001130) at ../iocore/eventsystem/P_IOBuffer.h:1002 #5 0x0055d115 in MIOBuffer::write_avail (this=0x2aab38001130) at ../iocore/eventsystem/P_IOBuffer.h:1048 #6 0x006c18f3 in read_from_net (nh=0x2aaafca0d208, vc=0x2aab1c009140, thread=0x2aaafca0a010) at UnixNetVConnection.cc:234 #7 0x006c37bf in UnixNetVConnection::net_read_io (this=0x2aab1c009140, nh=0x2aaafca0d208, lthread=0x2aaafca0a010) at UnixNetVConnection.cc:816 #8 0x006be392 in NetHandler::mainNetEvent (this=0x2aaafca0d208, event=5, e=0x271d8e0) at UnixNet.cc:380 #9 0x004f05c4 in Continuation::handleEvent (this=0x2aaafca0d208, event=5, data=0x271d8e0) at ../iocore/eventsystem/I_Continuation.h:146 #10 0x006e361e in EThread::process_event (this=0x2aaafca0a010, e=0x271d8e0, calling_code=5) at UnixEThread.cc:142 #11 0x006e3b13 in EThread::execute (this=0x2aaafca0a010) at UnixEThread.cc:264 #12 0x006e290b in spawn_thread_internal (a=0x2716400) at Thread.cc:88 #13 0x003372c077e1 in start_thread () from /lib64/libpthread.so.0 #14 0x0033728e68ed in clone () from /lib64/libc.so.6 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-1981) Url remap method filtering is broken with invalid method
[ https://issues.apache.org/jira/browse/TS-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036673#comment-14036673 ] ASF subversion and git services commented on TS-1981: - Commit ee8a4b18ea78e9bb9c2da3d1d7f92860dc7c8b28 in trafficserver's branch refs/heads/4.2.x from [~briang] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ee8a4b1 ] [TS-1981] Adding arbitrary methods to url remap, and fix the same problem in IpAllow (not cherrypicked, applied via patch built for 4.2.x) Url remap method filtering is broken with invalid method Key: TS-1981 URL: https://issues.apache.org/jira/browse/TS-1981 Project: Traffic Server Issue Type: Bug Components: Configuration, Security Reporter: Thach Tran Assignee: Brian Geffon Labels: review Fix For: 5.0.0 Attachments: 0001-TS-1981-Fix-method-filtering-to-deny-invalid-methods.patch, updated-TS-1981.patch ACL filtering based on HTTP's method is ignored if method received from client is invalid. To reproduce, with the default 8080 {{server_ports}} configure the {{remap.conf}} as follows. {noformat} map http://localhost:8080/ http://www.google.com/ @method=GET {noformat} Then run the following curl command. {noformat} $ curl -v -X AA http://localhost:8080/ {noformat} Notice that a 200 OK response is received by the client with some (empty) HTML from google.com. If the following curl command is issued instead {noformat} $ curl -v -X PUT http://localhost:8080/ {noformat} One will see that TS sends back a 403 Access Denied as expected. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2889) Crash in FetchSM related to spdy FetchSM changes in 5.0.x
[ https://issues.apache.org/jira/browse/TS-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036679#comment-14036679 ] ASF subversion and git services commented on TS-2889: - Commit aae3067e226db1d5f41bce35eff2cf46fc40 in trafficserver's branch refs/heads/master from [~briang] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=aae3067 ] TS-2889 updating changes Crash in FetchSM related to spdy FetchSM changes in 5.0.x - Key: TS-2889 URL: https://issues.apache.org/jira/browse/TS-2889 Project: Traffic Server Issue Type: Bug Components: Core, SPDY Affects Versions: 5.0.0 Reporter: Brian Geffon Assignee: Brian Geffon Fix For: 5.1.0 Attachments: ts2889.diff I'm seeing a crash in the FetchSM on 5.0.x, this is surely because of the changes that were made to the FetchSM as a result of SPDY. Sample bt: #0 0x00377c632925 in raise () from /lib64/libc.so.6 #1 0x00377c634105 in abort () from /lib64/libc.so.6 #2 0x2b09b0693ef0 in ink_die_die_die (retval=1) at ink_error.cc:43 #3 0x2b09b0693fbd in ink_fatal_va(int, const char *, typedef __va_list_tag __va_list_tag *) (return_code=1, message_format=0x2b09b06a1358 %s:%d: failed assert `%s`, ap=0x2b09b8806710) at ink_error.cc:65 #4 0x2b09b0694086 in ink_fatal (return_code=1, message_format=0x2b09b06a1358 %s:%d: failed assert `%s`) at ink_error.cc:73 #5 0x2b09b0692d40 in _ink_assert (expression=0x761f2f header_done, file=0x761ede FetchSM.cc, line=160) at ink_assert.cc:37 #6 0x004fa5c0 in FetchSM::check_chunked (this=0x2b09f8012240) at FetchSM.cc:160 #7 0x004fac82 in FetchSM::get_info_from_buffer (this=0x2b09f8012240, the_reader=0x2b09f4004818) at FetchSM.cc:313 #8 0x004fb18b in FetchSM::process_fetch_read (this=0x2b09f8012240, event=104) at FetchSM.cc:402 #9 0x004fb42d in FetchSM::fetch_handler (this=0x2b09f8012240, event=104, edata=0x2b09f8002768) at FetchSM.cc:449 #10 0x004fc43e in Continuation::handleEvent (this=0x2b09f8012240, event=104, data=0x2b09f8002768) at ../iocore/eventsystem/I_Continuation.h:146 ---Type return to continue, or q return to quit--- #11 0x00537f2e in PluginVC::process_read_side (this=0x2b09f8002670, other_side_call=false) at PluginVC.cc:637 #12 0x00536856 in PluginVC::main_handler (this=0x2b09f8002670, event=1, data=0x2b0a340293e0) at PluginVC.cc:208 #13 0x004fc43e in Continuation::handleEvent (this=0x2b09f8002670, event=1, data=0x2b0a340293e0) at ../iocore/eventsystem/I_Continuation.h:146 #14 0x0075d2e6 in EThread::process_event (this=0x2b09b23cc010, e=0x2b0a340293e0, calling_code=1) at UnixEThread.cc:145 #15 0x0075d4b4 in EThread::execute (this=0x2b09b23cc010) at UnixEThread.cc:196 #16 0x0075c844 in spawn_thread_internal (a=0x1428b10) at Thread.cc:88 #17 0x00377ce079d1 in start_thread () from /lib64/libpthread.so.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2892) Keep-alive post out is not enabled by default
[ https://issues.apache.org/jira/browse/TS-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036798#comment-14036798 ] ASF subversion and git services commented on TS-2892: - Commit 9e93c0a8d436c1df65e4890a8bbd2427673f62c5 in trafficserver's branch refs/heads/master from [~briang] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=9e93c0a ] TS-2892: Keep-alive post out enabled by default Keep-alive post out is not enabled by default - Key: TS-2892 URL: https://issues.apache.org/jira/browse/TS-2892 Project: Traffic Server Issue Type: Bug Components: Core Affects Versions: 5.0.0 Reporter: Brian Geffon Assignee: Brian Geffon Fix For: 5.1.0 Even though documentation claims keep-alive post out is enabled by default the code doesn't agree. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (TS-2892) Keep-alive post out is not enabled by default
[ https://issues.apache.org/jira/browse/TS-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Geffon reassigned TS-2892: Assignee: Brian Geffon Keep-alive post out is not enabled by default - Key: TS-2892 URL: https://issues.apache.org/jira/browse/TS-2892 Project: Traffic Server Issue Type: Bug Components: Core Affects Versions: 5.0.0 Reporter: Brian Geffon Assignee: Brian Geffon Fix For: 5.1.0 Even though documentation claims keep-alive post out is enabled by default the code doesn't agree. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TS-2892) Keep-alive post out is not enabled by default
[ https://issues.apache.org/jira/browse/TS-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Geffon updated TS-2892: - Affects Version/s: 5.0.0 Keep-alive post out is not enabled by default - Key: TS-2892 URL: https://issues.apache.org/jira/browse/TS-2892 Project: Traffic Server Issue Type: Bug Components: Core Affects Versions: 5.0.0 Reporter: Brian Geffon Fix For: 5.1.0 Even though documentation claims keep-alive post out is enabled by default the code doesn't agree. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TS-2892) Keep-alive post out is not enabled by default
[ https://issues.apache.org/jira/browse/TS-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Geffon resolved TS-2892. -- Resolution: Fixed Keep-alive post out is not enabled by default - Key: TS-2892 URL: https://issues.apache.org/jira/browse/TS-2892 Project: Traffic Server Issue Type: Bug Components: Core Affects Versions: 5.0.0 Reporter: Brian Geffon Assignee: Brian Geffon Fix For: 5.1.0 Even though documentation claims keep-alive post out is enabled by default the code doesn't agree. -- This message was sent by Atlassian JIRA (v6.2#6252)