[jira] [Created] (TS-3181) manager ports should only do local network interaction
Zhao Yongming created TS-3181: - Summary: manager ports should only do local network interaction Key: TS-3181 URL: https://issues.apache.org/jira/browse/TS-3181 Project: Traffic Server Issue Type: Improvement Components: Manager Reporter: Zhao Yongming the manager ports, such as 8088 8089 etc shoud only accept local network connections, and by ignore all the connections from outer network, we can make the interactions more stable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3181) manager ports should only do local network interaction
[
https://issues.apache.org/jira/browse/TS-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203965#comment-14203965
]
Zhao Yongming commented on TS-3181:
---
for example, we should try to filter out these issues with cluster enabled:
{code}
[Nov 7 15:28:21.428] Manager {0x7f277bfff700} NOTE:
[ClusterCom::drainIncomingChannel] Unexpected message on cluster port.
Possibly an attack
[Nov 7 15:28:57.501] Manager {0x7f277bfff700} NOTE:
[ClusterCom::drainIncomingChannel] Unexpected message on cluster port.
Possibly an attack
[Nov 7 15:34:09.624] Manager {0x7f277bfff700} NOTE:
[ClusterCom::drainIncomingChannel] Unexpected message on cluster port.
Possibly an attack
[Nov 7 15:38:36.235] Manager {0x7f277bfff700} NOTE:
[ClusterCom::drainIncomingChannel] Unexpected message on cluster port.
Possibly an attack
[Nov 7 15:39:45.596] Manager {0x7f277bfff700} NOTE:
[ClusterCom::drainIncomingChannel] Unexpected message on cluster port.
Possibly an attack
{code}
manager ports should only do local network interaction
--
Key: TS-3181
URL: https://issues.apache.org/jira/browse/TS-3181
Project: Traffic Server
Issue Type: Improvement
Components: Manager
Reporter: Zhao Yongming
the manager ports, such as 8088 8089 etc shoud only accept local network
connections, and by ignore all the connections from outer network, we can
make the interactions more stable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-3181) manager ports should only do local network interaction
[ https://issues.apache.org/jira/browse/TS-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao Yongming updated TS-3181: -- Fix Version/s: sometime manager ports should only do local network interaction -- Key: TS-3181 URL: https://issues.apache.org/jira/browse/TS-3181 Project: Traffic Server Issue Type: Improvement Components: Manager Reporter: Zhao Yongming Fix For: sometime the manager ports, such as 8088 8089 etc shoud only accept local network connections, and by ignore all the connections from outer network, we can make the interactions more stable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[
https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14204240#comment-14204240
]
Ryo Okubo commented on TS-3156:
---
Hi Powell,
As you said, this issue may be caused by an uninitialized lock.
I tried to print strerror() by writing that code:
{noformat}
static inline int
ink_mutex_acquire(ink_mutex * m)
{
int err = pthread_mutex_lock(m);
if (err != 0) {
fprintf(stderr, Failed to acquire mutex lock: %s, strerror(err));
abort();
}
return 0;
}
{noformat}
then I got
Mutex[Try]Lock bool() operator change and unused API removal
Key: TS-3156
URL: https://issues.apache.org/jira/browse/TS-3156
Project: Traffic Server
Issue Type: Improvement
Components: Core
Reporter: Powell Molleti
Assignee: James Peach
Priority: Minor
Labels: review
Fix For: 5.2.0
Attachments: MutexLock-ats.patch, MutexLock-ats.patch
Removed unused constructor in MutexLock along with set_and_take() method, had
to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.
default bool and ! operator from both MutexLock and MutexTryLock with
is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code
base.
Ran make test will be performing more system testing. Posted before for early
comments / feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[
https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14204241#comment-14204241
]
Ryo Okubo commented on TS-3156:
---
Hi Powell,
As you said, this issue may be caused by an uninitialized lock.
I tried to print strerror() by writing that code:
{noformat}
static inline int
ink_mutex_acquire(ink_mutex * m)
{
int err = pthread_mutex_lock(m);
if (err != 0) {
fprintf(stderr, Failed to acquire mutex lock: %s, strerror(err));
abort();
}
return 0;
}
{noformat}
then I got
Mutex[Try]Lock bool() operator change and unused API removal
Key: TS-3156
URL: https://issues.apache.org/jira/browse/TS-3156
Project: Traffic Server
Issue Type: Improvement
Components: Core
Reporter: Powell Molleti
Assignee: James Peach
Priority: Minor
Labels: review
Fix For: 5.2.0
Attachments: MutexLock-ats.patch, MutexLock-ats.patch
Removed unused constructor in MutexLock along with set_and_take() method, had
to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.
default bool and ! operator from both MutexLock and MutexTryLock with
is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code
base.
Ran make test will be performing more system testing. Posted before for early
comments / feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Issue Comment Deleted] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[
https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryo Okubo updated TS-3156:
--
Comment: was deleted
(was: Hi Powell,
As you said, this issue may be caused by an uninitialized lock.
I tried to print strerror() by writing that code:
{noformat}
static inline int
ink_mutex_acquire(ink_mutex * m)
{
int err = pthread_mutex_lock(m);
if (err != 0) {
fprintf(stderr, Failed to acquire mutex lock: %s, strerror(err));
abort();
}
return 0;
}
{noformat}
then I got )
Mutex[Try]Lock bool() operator change and unused API removal
Key: TS-3156
URL: https://issues.apache.org/jira/browse/TS-3156
Project: Traffic Server
Issue Type: Improvement
Components: Core
Reporter: Powell Molleti
Assignee: James Peach
Priority: Minor
Labels: review
Fix For: 5.2.0
Attachments: MutexLock-ats.patch, MutexLock-ats.patch
Removed unused constructor in MutexLock along with set_and_take() method, had
to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.
default bool and ! operator from both MutexLock and MutexTryLock with
is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code
base.
Ran make test will be performing more system testing. Posted before for early
comments / feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal
[
https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14204240#comment-14204240
]
Ryo Okubo edited comment on TS-3156 at 11/10/14 2:13 AM:
-
Hi Powell,
As you said, this issue may be caused by an uninitialized lock.
I tried to print strerror() by writing that code:
{noformat}
static inline int
ink_mutex_acquire(ink_mutex * m)
{
int err = pthread_mutex_lock(m);
if (err != 0) {
fprintf(stderr, Failed to acquire mutex lock: %s, strerror(err));
abort();
}
return 0;
}
{noformat}
then I got EINVAL.
{noformat}
Failed to acquire mutex lock: Invalid argument
{noformat}
was (Author: rokubo):
Hi Powell,
As you said, this issue may be caused by an uninitialized lock.
I tried to print strerror() by writing that code:
{noformat}
static inline int
ink_mutex_acquire(ink_mutex * m)
{
int err = pthread_mutex_lock(m);
if (err != 0) {
fprintf(stderr, Failed to acquire mutex lock: %s, strerror(err));
abort();
}
return 0;
}
{noformat}
then I got
Mutex[Try]Lock bool() operator change and unused API removal
Key: TS-3156
URL: https://issues.apache.org/jira/browse/TS-3156
Project: Traffic Server
Issue Type: Improvement
Components: Core
Reporter: Powell Molleti
Assignee: James Peach
Priority: Minor
Labels: review
Fix For: 5.2.0
Attachments: MutexLock-ats.patch, MutexLock-ats.patch
Removed unused constructor in MutexLock along with set_and_take() method, had
to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.
default bool and ! operator from both MutexLock and MutexTryLock with
is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code
base.
Ran make test will be performing more system testing. Posted before for early
comments / feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
