[jira] [Assigned] (TS-3475) Add configuration knobs for HTTP/2

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom reassigned TS-3475:
-

Assignee: Leif Hedstrom

> Add configuration knobs for HTTP/2
> --
>
> Key: TS-3475
> URL: https://issues.apache.org/jira/browse/TS-3475
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: HTTP/2
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 6.0.0
>
>
> We currently have the following SPDY configs, we should have at least the 
> same ones for HTTP/2:
> {code}
>   {RECT_CONFIG, "proxy.config.spdy.max_concurrent_streams_in", RECD_INT, 
> "100", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.no_activity_timeout_in", RECD_INT, "115", 
> RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.initial_window_size_in", RECD_INT, 
> "1048576", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.accept_no_activity_timeout", RECD_INT, 
> "120", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3475) Add configuration knobs for HTTP/2

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391919#comment-14391919
 ] 

Leif Hedstrom commented on TS-3475:
---

I agree. I have a patch for this, it's not quite ready yet, but hope to have 
something by tomorrow. It basically replaces all that static defines with 
records.config's.

> Add configuration knobs for HTTP/2
> --
>
> Key: TS-3475
> URL: https://issues.apache.org/jira/browse/TS-3475
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: HTTP/2
>Reporter: Leif Hedstrom
> Fix For: 6.0.0
>
>
> We currently have the following SPDY configs, we should have at least the 
> same ones for HTTP/2:
> {code}
>   {RECT_CONFIG, "proxy.config.spdy.max_concurrent_streams_in", RECD_INT, 
> "100", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.no_activity_timeout_in", RECD_INT, "115", 
> RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.initial_window_size_in", RECD_INT, 
> "1048576", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.accept_no_activity_timeout", RECD_INT, 
> "120", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3475) Add configuration knobs for HTTP/2

[Ryo Okubo (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391913#comment-14391913
 ] 

Ryo Okubo commented on TS-3475:
---

I think we should add the rest of [SETTINGS 
Parameters|https://tools.ietf.org/html/draft-ietf-httpbis-http2-17#section-6.5.2],
 like HEADER_TABLE_SIZE and ENABLE_PUSH. And configuration relating to behivior 
of HPACK encoder (around huffman coding and indexing) may be required.

> Add configuration knobs for HTTP/2
> --
>
> Key: TS-3475
> URL: https://issues.apache.org/jira/browse/TS-3475
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: HTTP/2
>Reporter: Leif Hedstrom
> Fix For: 6.0.0
>
>
> We currently have the following SPDY configs, we should have at least the 
> same ones for HTTP/2:
> {code}
>   {RECT_CONFIG, "proxy.config.spdy.max_concurrent_streams_in", RECD_INT, 
> "100", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.no_activity_timeout_in", RECD_INT, "115", 
> RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.initial_window_size_in", RECD_INT, 
> "1048576", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   {RECT_CONFIG, "proxy.config.spdy.accept_no_activity_timeout", RECD_INT, 
> "120", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: tsqa-master #267

[jenkins]

See 

Changes:

[Leif Hedstrom] TS-3479 Remove verbose Warning() from HTTP/2 connections

--
[...truncated 13210 lines...]
  10  653  3268.300   47705991/4770599  2088 2088 2087   78376699   
12.90
  10  669  3350.500   48864514/4886451  2141 2141 2141   81157931   
13.90
  10  675  3380.600   49246112/4924611  2145 2145 2145   80920265   
14.90
  10  681  3408.700   51779021/5177902  2165 2165 2165   84837183   
15.90
  10  678  3393.500   53023437/5302343  2158 2158 2158   86352852   
16.90
  10  679  3399.600   52436410/5243641  2161 2161 2160   85164806   
17.90
  10  681  3409.100   53031580/5303158  2175 2175 2175   86895643   
18.90
  10  686  3434.300   53144371/5314437  2194 2194 2194   86784326   
19.90
 con  new ops   1B  lat  bytes/per svrs  new  ops  total   time 
 err
  10  690  3456.000   53701479/5370147  2206 2206 2206   87939941   
20.90
  10  697  3487.200   52662661/5266266  2225 2225 2225   86371507   
21.90
  10  695  3481.200   52163474/5216347  2219 2219 2219   85426435   
22.90
  10  695  3476.900   52618321/5261832  2213 2213 2213   86399110   
23.90
  10  693  3465.800   52089192/5208919  2210 2210 2210   85665483   
24.90
  10  694  3472.800   52227798/5222779  2216 2216 2216   85909225   
25.90
  10  699  3499.600   52160136/5216013  2238 2238 2239   86077924   
26.90
  10  695  3479.900   52769095/5276909  2217 2217 2217   86752412   
27.90
  10  692  3465.100   52881761/5288176  2209 2209 2209   86671893   
28.90
MSG: reloading logging configuration
  10  698  3495.900   53677814/5367781  2226 2226 2226   88204645   
29.90
  10  699  3499.700   53913162/5391316  2234 2234 2234   89068164   
30.90
  10  692  3463.800   53478390/5347839  2233 2233 2233   89230749   
31.90
  10  690  3453.000   53102131/5310213  2226 2226 2226   88231020   
32.90
  10  686  3435.800   52471243/5247124  2213 2213 2213   87371928   
33.90
  10  687  3437.900   52808329/5280832  2214 2214 2214   88568636   
34.90
  10  686  3432.900   52851601/5285160  2214 2214 2214   88473997   
35.90
  10  687  3436.100   51607808/5160780  2206 2206 2206   86648748   
36.90
  10  695  3480.700   51899312/5189931  2225 2225 2225   86808317   
37.90
  10  698  3493.500   52280027/5228002  2240 2240 2240   87208715   
38.90
  10  694  3473.400   53666732/5366673  2226 2226 2226   89857917   
39.90
 con  new ops   1B  lat  bytes/per svrs  new  ops  total   time 
 err
  10  696  3486.800   53718909/5371890  2231 2231 2231   89736796   
40.90
  10  703  3518.600   53674778/5367477  2253 2253 2253   89229308   
41.90
  10  704  3521.300   53884639/5388463  2254 2254 2254   89251373   
42.90
  10  703  3519.200   53334827/5333482  2254 2254 2254   87627344   
43.90
  10  706  3533.200   53605902/5360590  2266 2266 2266   88248019   
44.90
  10  709  3550.900   52758314/5275831  2284 2284 2284   87316933   
45.90
  10  708  3542.600   53855111/5385511  2274 2274 2274   89513587   
46.90
  10  709  3549.000   54611862/5461186  2283 2283 2283   90676422   
47.90
  10  711  3558.800   53194480/5319448  2289 2289 2289   87887355   
48.90
  10  712  3563.100   53207437/5320743  2289 2289 2289   87685239   
49.90
  10  708  3544.500   53314779/5331477  2282 2282 2282   87815639   
50.90
  10  698  3492.200   53984799/5398479  2262 2262 2262   88666407   
51.90
  10  702  3514.300   53266764/5326676  2272 2272 2272   87781428   
52.90
  10  703  3519.100   53564764/5356476  2271 2271 2271   88241039   
53.90
  10  701  3508.700   53020413/5302041  2264 2264 2264   87535047   
54.90
  10  699  3499.900   52598188/5259818  2262 2262 2262   86561479   
55.90
  10  683  3421.100   51165736/5116573  2209 2209 2209   83880402   
56.90
  10  677  3387.700   51255415/5125541  2178 2178 2178   84052829   
57.90
  10  676  3385.000   51880156/5188015  2179 2179 2179   85063763   
58.90
MSG: reloading logging configuration
  10  680  3405.200   51926353/5192635  2186 2186 2187   84915320   
59.90
 con  new ops   1B  lat  bytes/per svrs  new  ops  total   time 
 err
  10  679  3400.500   51116838/5111683  2179 2179 2178   83700161   
60.90
  10  543  2720.400   40893470/4089347  1743 1743 1743   66960128   
60.90
MSG: checking for crashes ...
./functions: line 177:  4311 Terminated  ( tsex

[jira] [Resolved] (TS-3479) Remove a very verbose Warning() from HTTP2 code

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-3479.
---
Resolution: Fixed

Albeit a trivial fix, I made a Jira for this, so we can consider back porting 
this to 5.3.0.

> Remove a very verbose Warning() from HTTP2 code
> ---
>
> Key: TS-3479
> URL: https://issues.apache.org/jira/browse/TS-3479
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 6.0.0
>
>
> We have
> {code}
> Warning("skipping access control checks for HTTP/2 connection");
> {code}
> this produces a lot of warnings in digs.log, which is not rotated. I say we 
> just remove this for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3479) Remove a very verbose Warning() from HTTP2 code

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391664#comment-14391664
 ] 

ASF subversion and git services commented on TS-3479:
-

Commit 26f438d486eaa04267db953d8d5f1249a63af2c3 in trafficserver's branch 
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=26f438d ]

TS-3479 Remove verbose Warning() from HTTP/2 connections


> Remove a very verbose Warning() from HTTP2 code
> ---
>
> Key: TS-3479
> URL: https://issues.apache.org/jira/browse/TS-3479
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 6.0.0
>
>
> We have
> {code}
> Warning("skipping access control checks for HTTP/2 connection");
> {code}
> this produces a lot of warnings in digs.log, which is not rotated. I say we 
> just remove this for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3479) Remove a very verbose Warning() from HTTP2 code

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-3479:
--
Backport to Version: 5.3.0

> Remove a very verbose Warning() from HTTP2 code
> ---
>
> Key: TS-3479
> URL: https://issues.apache.org/jira/browse/TS-3479
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 6.0.0
>
>
> We have
> {code}
> Warning("skipping access control checks for HTTP/2 connection");
> {code}
> this produces a lot of warnings in digs.log, which is not rotated. I say we 
> just remove this for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (TS-3479) Remove a very verbose Warning() from HTTP2 code

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom reassigned TS-3479:
-

Assignee: Leif Hedstrom

> Remove a very verbose Warning() from HTTP2 code
> ---
>
> Key: TS-3479
> URL: https://issues.apache.org/jira/browse/TS-3479
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 6.0.0
>
>
> We have
> {code}
> Warning("skipping access control checks for HTTP/2 connection");
> {code}
> this produces a lot of warnings in digs.log, which is not rotated. I say we 
> just remove this for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3479) Remove a very verbose Warning() from HTTP2 code

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-3479:
--
Fix Version/s: 6.0.0

> Remove a very verbose Warning() from HTTP2 code
> ---
>
> Key: TS-3479
> URL: https://issues.apache.org/jira/browse/TS-3479
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 6.0.0
>
>
> We have
> {code}
> Warning("skipping access control checks for HTTP/2 connection");
> {code}
> this produces a lot of warnings in digs.log, which is not rotated. I say we 
> just remove this for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-3479) Remove a very verbose Warning() from HTTP2 code

[Leif Hedstrom (JIRA)]

Leif Hedstrom created TS-3479:
-

 Summary: Remove a very verbose Warning() from HTTP2 code
 Key: TS-3479
 URL: https://issues.apache.org/jira/browse/TS-3479
 Project: Traffic Server
  Issue Type: Bug
  Components: HTTP/2
Reporter: Leif Hedstrom


We have

{code}
Warning("skipping access control checks for HTTP/2 connection");
{code}

this produces a lot of warnings in digs.log, which is not rotated. I say we 
just remove this for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3474) HTTP/2 Server Push support in ATS

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390811#comment-14390811
 ] 

Leif Hedstrom commented on TS-3474:
---

Ilya also pointed me to this thread: 
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/Abrd-tbDyuQ/nHr_6AfW_sYJ

> HTTP/2 Server Push support in ATS
> -
>
> Key: TS-3474
> URL: https://issues.apache.org/jira/browse/TS-3474
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: HTTP/2
>Reporter: Sudheer Vinukonda
>Assignee: Sudheer Vinukonda
> Fix For: sometime
>
>
> I've done some preliminary analysis/prototype of SPDY server push support in 
> ATS, but, ran into a problem with browser (chrome) support for HTTPS cross 
> origin resource push (which is sort of critical in the way, our CDN works). 
> Wanted to open this Jira to share this info with the community and ask for 
> suggestions/opinions.
> Basically, there are 3 approaches in supporting Server push at the proxy 
> layer:
>  - Origin Driven
>  - Client Driven
>  - Proxy Driven
> Origin Driven approach relies on the origin passing pushable resources as 
> special headers in the response to a base page, for instance. We are 
> exploring making use of the HTTP LINK header for this purpose. The proxy 
> would basically initiate PUSH streams to the client for the resources 
> identified by the LINK headers in the base page response and at the same 
> time, fetch those resources by initiating internal SPDY requests. There are a 
> few things to consider such as whether the pushable resources should be 
> limited to only cacheable resources? Whether non-https resources can be 
> pushed on a https connection, vice-versa etc.
> Client Driven approach relies on the Referrer header sent by the client and 
> ATS building dynamically a set of associated resources for a given base page 
> request url. Once such a list is built, the rest of the mechanism is similar 
> to the Origin driven approach.
> Proxy Driven approach is mainly for proto-typing purpose and relies on the 
> proxy extracting/unzipping/parsing the response body and identifying pushable 
> resources and initiating the push resources similar to the other approaches 
> above.  This is performance intensive and will need some optimizations in not 
> having to parse every response, but doing it based on some sort of 
> count/frequency of the access. 
> I did some prototyping and was able to push resources, but, realized there 
> are some stumbling blocks. For example, Chrome doesn't permit cross origin 
> HTTPS resources to be pushed (even if certs were presented for both the 
> original and push domain). See below email from Chrome indicating that they 
> won't fix this behavior.
> https://code.google.com/p/chromium/issues/detail?id=408317
> Here's the summary of the response from Chrome:
> {code}
> "It's very much by design that cross-origin HTTPS push streams are being 
> rejected. The central reason is that the session isn't authenticated for the 
> pushed origin.
> The specific requirement is also that a push stream match the origin of it's 
> declared associated stream. This is true even of a SPDY session which 
> presented certs & authenticated for both the associated & push origins: you 
> still need to arrange for an associated stream on the origin for which you'd 
> like to push. The --trusted-spdy-proxy flag relaxes this somewhat, in that it 
> allows cross-origin HTTP push streams (but not HTTPS).
> The implementation block you point to is indeed where this logic lives.
> There aren't any immediate plans to enable cross-origin HTTPS push, though 
> there are continuing conversations about how it might be done. It'd need to 
> be done very carefully.
> "
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3478) Support some header representations on HPACK encoder

[Ryo Okubo (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390392#comment-14390392
 ] 

Ryo Okubo commented on TS-3478:
---

I'm working for it now.

> Support some header representations on HPACK encoder
> 
>
> Key: TS-3478
> URL: https://issues.apache.org/jira/browse/TS-3478
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: HTTP/2
>Reporter: Ryo Okubo
>
> Support other header field representations on HPACK encoder.
> http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6
> Currently the encoder supports only [Literal Header Field never 
> Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-3478) Support some header representations on HPACK encoder

[Ryo Okubo (JIRA)]

Ryo Okubo created TS-3478:
-

 Summary: Support some header representations on HPACK encoder
 Key: TS-3478
 URL: https://issues.apache.org/jira/browse/TS-3478
 Project: Traffic Server
  Issue Type: Improvement
  Components: HTTP/2
Reporter: Ryo Okubo


Support other header field representations on HPACK encoder.
http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6

Currently the encoder supports only [Literal Header Field never 
Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-1611) async http request in lua remap plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390191#comment-14390191
 ] 

ASF subversion and git services commented on TS-1611:
-

Commit 0b3fac4a3f291a2b88dc2b7934a61d3e834c53eb in trafficserver's branch 
refs/heads/master from [~kichan]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0b3fac4 ]

TS-1611: fix coverity scan defects and use TSError instead of fprintf to stderr


> async http request in lua remap plugin
> --
>
> Key: TS-1611
> URL: https://issues.apache.org/jira/browse/TS-1611
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Lua, Plugins
>Reporter: Luca Rea
>Assignee: Kit Chan
> Fix For: sometime
>
> Attachments: 
> 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, 
> 0002-TS-1611-add-ts_lua_constant.c.patch, 
> 0003-TS-1611-refine-doc-for-ts_lua.patch
>
>
> Hi,
> can you add support for async http requests in lua remap plugin please?
> Thank you



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)