[jira] [Commented] (TS-306) enable log rotation for diags.log

2015-08-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680384#comment-14680384
 ] 

ASF GitHub Bot commented on TS-306:
---

Github user bellofreedom commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/274#discussion_r36656961
  
--- Diff: proxy/shared/Makefile.am ---
@@ -26,6 +26,8 @@ noinst_LIBRARIES = \
 AM_CPPFLAGS = \
   $(iocore_include_dirs) \
   -I$(top_srcdir)/lib/records \
+   -I$(top_srcdir)/lib/ts \
--- End diff --

indent


 enable log rotation for diags.log
 -

 Key: TS-306
 URL: https://issues.apache.org/jira/browse/TS-306
 Project: Traffic Server
  Issue Type: Improvement
  Components: Logging
Reporter: Miles Libbey
Assignee: Daniel Xu
  Labels: newbie
 Fix For: 6.1.0


 (from yahoo bug 913896)
 Original description
 by Leif Hedstrom 3 years ago at 2006-12-04 12:42
 There might be reasons why this file might get filled up, e.g. libraries used 
 by plugins producing output on STDOUT/STDERR. A few suggestions have been
 made, to somehow rotate traffic.out. One possible solution (suggested by 
 Ryan) is to use cronolog (http://cronolog.org/), which seems like a fine idea.
   
  
 Comment 1
  by Joseph Rothrock  2 years ago at 2007-10-17 09:13:24
 Maybe consider rolling diags.log as well. -Feature enhancement.
   
 Comment 2
  by Kevin Dalley 13 months ago at 2009-03-04 15:32:18
 When traffic.out gets filled up, error.log stops filing up, even though 
 rotation is turned on. This is
 counter-intuitive.  Rotation does not control traffic.out, but a large 
 traffic.out will stop error.log from being
 written.
   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-3831) Overridable error response type

2015-08-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680674#comment-14680674
 ] 

ASF GitHub Bot commented on TS-3831:


Github user asfgit closed the pull request at:

https://github.com/apache/trafficserver/pull/273


 Overridable error response type
 ---

 Key: TS-3831
 URL: https://issues.apache.org/jira/browse/TS-3831
 Project: Traffic Server
  Issue Type: New Feature
  Components: Configuration
Reporter: Syeda Persia Aziz

 ATS has a set of error pages in the folder body_factory, namely 
 access#denied, access#proxy_auth_required,connect#dns_failed... etc. All 
 these error pages are loaded in a RawHashTable. When there is an error for 
 e.g. access denied,  ATS builds a error response of type access#denied. We 
 can have an overridable config that will decide which custom error page to 
 send to the client. This config will be set per remap rule. We can have the 
 custom error pages in the body_factory folder and these pages will follow a 
 specific naming convention for e.g. $var_access#denied, 
 $var_access#proxy_auth_required, ….. Here $var is the overridable config 
 (proxy.config.error.response.type). 
 Example: 
 in Remap.config
 map www.abcxyz.com www.efgijk.com @plugin=config.so 
 @pparam=proxy.config.error.response.type=yahoo
 Now, if there is for e.g. a 'access denied' error, the build_error_response 
 will build a customized error response of type yahoo_access#denied . If it 
 can not find the type yahoo_access#denied, then it will simply build the 
 default access#denied error response. 
 Note: I already have a patch for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-3831) Overridable error response type

2015-08-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680672#comment-14680672
 ] 

ASF subversion and git services commented on TS-3831:
-

Commit e985569ae95fa6345f6302d1340d4e9b4e64b804 in trafficserver's branch 
refs/heads/master from [~persiaAziz]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e985569 ]

TS-3831: overridable error response type
This closes #273.


 Overridable error response type
 ---

 Key: TS-3831
 URL: https://issues.apache.org/jira/browse/TS-3831
 Project: Traffic Server
  Issue Type: New Feature
  Components: Configuration
Reporter: Syeda Persia Aziz

 ATS has a set of error pages in the folder body_factory, namely 
 access#denied, access#proxy_auth_required,connect#dns_failed... etc. All 
 these error pages are loaded in a RawHashTable. When there is an error for 
 e.g. access denied,  ATS builds a error response of type access#denied. We 
 can have an overridable config that will decide which custom error page to 
 send to the client. This config will be set per remap rule. We can have the 
 custom error pages in the body_factory folder and these pages will follow a 
 specific naming convention for e.g. $var_access#denied, 
 $var_access#proxy_auth_required, ….. Here $var is the overridable config 
 (proxy.config.error.response.type). 
 Example: 
 in Remap.config
 map www.abcxyz.com www.efgijk.com @plugin=config.so 
 @pparam=proxy.config.error.response.type=yahoo
 Now, if there is for e.g. a 'access denied' error, the build_error_response 
 will build a customized error response of type yahoo_access#denied . If it 
 can not find the type yahoo_access#denied, then it will simply build the 
 default access#denied error response. 
 Note: I already have a patch for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: tsqa-master #775

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-master/775/changes

Changes:

[shinrich] TS-3648 Desire support for client TLS cipher in custom log format. 
This closes #252.

--
Started by upstream project out_of_tree-master build number 1077
originally caused by:
 Started by an SCM change
Started by upstream project in_tree-master build number 1296
originally caused by:
 Started by an SCM change
Building remotely on QA3 (qa) in workspace 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/
  /usr/bin/git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
  /usr/bin/git config remote.origin.url 
  https://git-wip-us.apache.org/repos/asf/trafficserver.git # timeout=10
Cleaning workspace
  /usr/bin/git rev-parse --verify HEAD # timeout=10
Resetting working tree
  /usr/bin/git reset --hard # timeout=10
  /usr/bin/git clean -fdx # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/trafficserver.git
  /usr/bin/git --version # timeout=10
  /usr/bin/git -c core.askpass=true fetch --tags --progress 
  https://git-wip-us.apache.org/repos/asf/trafficserver.git 
  +refs/heads/*:refs/remotes/origin/*
  /usr/bin/git rev-parse refs/remotes/origin/master^{commit} # timeout=10
  /usr/bin/git rev-parse refs/remotes/origin/origin/master^{commit} # 
  timeout=10
Checking out Revision b597f9cfa8148df6eb787b8f872a8bd20d0f9492 
(refs/remotes/origin/master)
  /usr/bin/git config core.sparsecheckout # timeout=10
  /usr/bin/git checkout -f b597f9cfa8148df6eb787b8f872a8bd20d0f9492
  /usr/bin/git rev-list e985569ae95fa6345f6302d1340d4e9b4e64b804 # timeout=10
[tsqa-master] $ /bin/bash -xe /tmp/hudson3953777146649690704.sh
+ source /home/jenkins/bin/environment.sh
++ export ATS_SRC_HOME=/home/jenkins/src
++ ATS_SRC_HOME=/home/jenkins/src
++ test tsqa-master '!=' tsqa-master
++ ATS_MAKE=make
++ test tsqa-master '!=' tsqa-master
++ export ATS_MAKE
+++ /bin/date +%m%d%Y
++ export TODAY=08102015
++ TODAY=08102015
++ ATS_BRANCH=master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ export ATS_BRANCH
++ test tsqa-master '!=' tsqa-master
+ source /home/jenkins/bin/tsqa.sh
++ TSQA_LAYOUT_DIR=https://ci.trafficserver.apache.org/job/tsqa-master/ws/775
++ cd https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa
++ make test
New python executable in virtualenv/bin/python
Installing 
Setuptools..done.
Installing 
Pip.done.
make update
make[1]: Entering directory 
`https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa'
Exception:
Traceback (most recent call last):
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/basecommand.py;,
 line 134, in main
status = self.run(options, args)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/commands/install.py;,
 line 220, in run
for req in parse_requirements(filename, finder=finder, options=options):
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 1477, in parse_requirements
req = InstallRequirement.from_line(line, comes_from, 
prereleases=getattr(options, pre, None))
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 129, in from_line
return cls(req, comes_from, url=url, prereleases=prereleases)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 44, in __init__
req = pkg_resources.Requirement.parse(req)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pkg_resources.py;,
 line 2914, in parse
reqs = list(parse_requirements(s))
  File 

Jenkins build is still unstable: tsqa-lint #426

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-lint/changes



Build failed in Jenkins: tsqa-master #774

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-master/774/changes

Changes:

[solidwallofcode] TS-3831: overridable error response type

--
Started by upstream project out_of_tree-master build number 1076
originally caused by:
 Started by an SCM change
Started by upstream project in_tree-master build number 1295
originally caused by:
 Started by an SCM change
Building remotely on QA3 (qa) in workspace 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/
  /usr/bin/git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
  /usr/bin/git config remote.origin.url 
  https://git-wip-us.apache.org/repos/asf/trafficserver.git # timeout=10
Cleaning workspace
  /usr/bin/git rev-parse --verify HEAD # timeout=10
Resetting working tree
  /usr/bin/git reset --hard # timeout=10
  /usr/bin/git clean -fdx # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/trafficserver.git
  /usr/bin/git --version # timeout=10
  /usr/bin/git -c core.askpass=true fetch --tags --progress 
  https://git-wip-us.apache.org/repos/asf/trafficserver.git 
  +refs/heads/*:refs/remotes/origin/*
  /usr/bin/git rev-parse refs/remotes/origin/master^{commit} # timeout=10
  /usr/bin/git rev-parse refs/remotes/origin/origin/master^{commit} # 
  timeout=10
Checking out Revision e985569ae95fa6345f6302d1340d4e9b4e64b804 
(refs/remotes/origin/master)
  /usr/bin/git config core.sparsecheckout # timeout=10
  /usr/bin/git checkout -f e985569ae95fa6345f6302d1340d4e9b4e64b804
  /usr/bin/git rev-list d903a38d169e8b43c51fce001afab5da81e4b754 # timeout=10
[tsqa-master] $ /bin/bash -xe /tmp/hudson6946143505726065340.sh
+ source /home/jenkins/bin/environment.sh
++ export ATS_SRC_HOME=/home/jenkins/src
++ ATS_SRC_HOME=/home/jenkins/src
++ test tsqa-master '!=' tsqa-master
++ ATS_MAKE=make
++ test tsqa-master '!=' tsqa-master
++ export ATS_MAKE
+++ /bin/date +%m%d%Y
++ export TODAY=08102015
++ TODAY=08102015
++ ATS_BRANCH=master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ export ATS_BRANCH
++ test tsqa-master '!=' tsqa-master
+ source /home/jenkins/bin/tsqa.sh
++ TSQA_LAYOUT_DIR=https://ci.trafficserver.apache.org/job/tsqa-master/ws/774
++ cd https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa
++ make test
New python executable in virtualenv/bin/python
Installing 
Setuptools..done.
Installing 
Pip.done.
make update
make[1]: Entering directory 
`https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa'
Exception:
Traceback (most recent call last):
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/basecommand.py;,
 line 134, in main
status = self.run(options, args)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/commands/install.py;,
 line 220, in run
for req in parse_requirements(filename, finder=finder, options=options):
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 1477, in parse_requirements
req = InstallRequirement.from_line(line, comes_from, 
prereleases=getattr(options, pre, None))
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 129, in from_line
return cls(req, comes_from, url=url, prereleases=prereleases)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 44, in __init__
req = pkg_resources.Requirement.parse(req)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pkg_resources.py;,
 line 2914, in parse
reqs = list(parse_requirements(s))
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pkg_resources.py;,
 line 2839, in 

Jenkins build is still unstable: tsqa-lint #425

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-lint/changes



[jira] [Commented] (TS-3648) Desire support for client TLS cipher in custom log format

2015-08-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680746#comment-14680746
 ] 

ASF GitHub Bot commented on TS-3648:


Github user asfgit closed the pull request at:

https://github.com/apache/trafficserver/pull/252


 Desire support for client TLS cipher in custom log format
 -

 Key: TS-3648
 URL: https://issues.apache.org/jira/browse/TS-3648
 Project: Traffic Server
  Issue Type: New Feature
  Components: Logging
Reporter: Eric Sproul
Assignee: Eric Schwartz
 Fix For: 6.1.0


 While the TLS cipher stats from TS-2169 are awesome for seeing what ciphers 
 are in active use, I would also like to be able to create a custom log to 
 track cipher by client request.  That would enable me, for example, to 
 determine who among my users might be affected by a cipher list change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Jenkins build is still unstable: tsqa-lint #427

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-lint/changes



[jira] [Commented] (TS-3426) Consolidate the multiple API for disabling cache

2015-08-10 Thread Alan M. Carroll (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680751#comment-14680751
 ] 

Alan M. Carroll commented on TS-3426:
-

What is desired is a single point where the plugin can set one of three values:

1) Default - do the default thing as if the plugin had done nothing.
2) Do not cache - do not cache the transaction.
3) Do cache - cache the transaction if possible.

There are few complications. The primary one is checking to see if the 
transaction is cacheable via {{TSHttpTxnIsCacheable}} which should ignore this 
value. That is, it should return a value as if the setting was default 
otherwise you get in to circularity problems.

It should also be noted that is possible covers the cache being entirely 
disabled. In that case nothing will be cached regardless of setting this 
override.

This would replace (at a minimum)

* {{TSHttpTxnServerRespNoStore}}
* {{proxy.config.http.cache.http}} as overridable (this configuration would 
become restart only)
* {{TSHttpTxnUntransformedRespCache}}
* {{TSHttpTxnTransformedRespCache}}


 Consolidate the multiple API for disabling cache
 

 Key: TS-3426
 URL: https://issues.apache.org/jira/browse/TS-3426
 Project: Traffic Server
  Issue Type: Improvement
  Components: TS API
Reporter: Sudheer Vinukonda
Assignee: Alan M. Carroll
  Labels: A
 Fix For: 6.1.0


 There are currently multiple API (see below) that can be used by a plugin to 
 disable cache for a given transaction. 
 {{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}}, 
 {{TSHttpTxnRespCacheableSet}}
 Opening this jira to analyze whether these are redundant and consolidate if 
 necessary. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-3426) Consolidate the multiple API for disabling cache

2015-08-10 Thread William Bardwell (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680896#comment-14680896
 ] 

William Bardwell commented on TS-3426:
--

Aren't the Transformed vs Untransformed thing allowing you to choose where the 
Cache is attached to the tunnel, which is nothing that the new 3 values would 
not allow, it sounds like it needs more values or a bit-mask or to keep some 
variation of those APIs.

 Consolidate the multiple API for disabling cache
 

 Key: TS-3426
 URL: https://issues.apache.org/jira/browse/TS-3426
 Project: Traffic Server
  Issue Type: Improvement
  Components: TS API
Reporter: Sudheer Vinukonda
Assignee: Alan M. Carroll
  Labels: A
 Fix For: 6.1.0


 There are currently multiple API (see below) that can be used by a plugin to 
 disable cache for a given transaction. 
 {{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}}, 
 {{TSHttpTxnRespCacheableSet}}
 Opening this jira to analyze whether these are redundant and consolidate if 
 necessary. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-3426) Consolidate the multiple API for disabling cache

2015-08-10 Thread Leif Hedstrom (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680922#comment-14680922
 ] 

Leif Hedstrom commented on TS-3426:
---

I agree with William, and I replied a while back on the mailing list as well. 
In an ideal world, we replace all the APIs, including the ones mentioned in the 
original post here. In addition, as I pointed out in email, I think there are 
APIs that are very specific, such as allow caching this even though the method 
used is not allowed for caching. So I think a bit-mask (under the hood) could 
be necessary?

I'm also not sure that changing the overidable config is a requirement, since 
it can not be done in a compatible way. Rather, we'd mark it as deprecated for 
7.0.0 and removed for 8.0.0, replace with either a new config or some other 
more generic method (e.g. Options in cache.config, storage.config or Lua 
scriptlets).


 Consolidate the multiple API for disabling cache
 

 Key: TS-3426
 URL: https://issues.apache.org/jira/browse/TS-3426
 Project: Traffic Server
  Issue Type: Improvement
  Components: TS API
Reporter: Sudheer Vinukonda
Assignee: Alan M. Carroll
  Labels: A
 Fix For: 6.1.0


 There are currently multiple API (see below) that can be used by a plugin to 
 disable cache for a given transaction. 
 {{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}}, 
 {{TSHttpTxnRespCacheableSet}}
 Opening this jira to analyze whether these are redundant and consolidate if 
 necessary. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-3426) Consolidate the multiple API for disabling cache

2015-08-10 Thread Sudheer Vinukonda (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680928#comment-14680928
 ] 

Sudheer Vinukonda commented on TS-3426:
---

+1 on *not* trying to change the semantics of existing config to somehow 
satisfy overridability and/or reload-ability, since it most likely will cause 
confusion and/or break compatibility one way or the other. I also agree that a 
cleaner way is to not modify the meaning of existing settings and use new 
settings/methods while deprecating the existing ones.

 Consolidate the multiple API for disabling cache
 

 Key: TS-3426
 URL: https://issues.apache.org/jira/browse/TS-3426
 Project: Traffic Server
  Issue Type: Improvement
  Components: TS API
Reporter: Sudheer Vinukonda
Assignee: Alan M. Carroll
  Labels: A
 Fix For: 6.1.0


 There are currently multiple API (see below) that can be used by a plugin to 
 disable cache for a given transaction. 
 {{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}}, 
 {{TSHttpTxnRespCacheableSet}}
 Opening this jira to analyze whether these are redundant and consolidate if 
 necessary. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Jenkins build is still unstable: tsqa-lint #424

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-lint/changes



[jira] [Commented] (TS-3648) Desire support for client TLS cipher in custom log format

2015-08-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680603#comment-14680603
 ] 

ASF GitHub Bot commented on TS-3648:


Github user shinrich commented on the pull request:

https://github.com/apache/trafficserver/pull/252#issuecomment-129571297
  
Looks good to me.   A straightforward reworking of acacio's original PR in 
the face of the other SSL logging changes that have been made.


 Desire support for client TLS cipher in custom log format
 -

 Key: TS-3648
 URL: https://issues.apache.org/jira/browse/TS-3648
 Project: Traffic Server
  Issue Type: New Feature
  Components: Logging
Reporter: Eric Sproul
Assignee: Eric Schwartz
 Fix For: 6.1.0


 While the TLS cipher stats from TS-2169 are awesome for seeing what ciphers 
 are in active use, I would also like to be able to create a custom log to 
 track cipher by client request.  That would enable me, for example, to 
 determine who among my users might be affected by a cipher list change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-3792) Pointing proxy.config.dns.resolv_conf at an empty (or nonexistant) file causes segmentation faults on first DNS query

2015-08-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681133#comment-14681133
 ] 

ASF subversion and git services commented on TS-3792:
-

Commit 576c2de9d2e17f6930e718ec34f8fb3baba692d1 in trafficserver's branch 
refs/heads/master from [~zhangzizhong]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=576c2de ]

TS-3792: Pointing proxy.config.dns.resolv_conf at an empty (or nonexistant) 
file causes crashes.


 Pointing proxy.config.dns.resolv_conf at an empty (or nonexistant) file 
 causes segmentation faults on first DNS query
 -

 Key: TS-3792
 URL: https://issues.apache.org/jira/browse/TS-3792
 Project: Traffic Server
  Issue Type: Bug
Reporter: Thomas Jackson
Assignee: Brian Geffon
 Fix For: 6.1.0


 {code}
 [connect] ERROR (main_socket_fd 9): Connection refused
 [Jul 22 17:04:34.553] {0x2b293f16b960} ERROR: wrote crash log to 
 /var/log/trafficserver/crash-2015-07-22-170434.log
 traffic_server: Floating point exception (Integer divide by zero 
 [0x6d8e5a])traffic_server - STACK TRACE: 
 traffic_server(_Z19crash_logger_invokeiP7siginfoPv+0xc3)[0x50994e]
 /lib64/libpthread.so.0[0x340d40f710]
 traffic_server[0x6d8e5a]
 traffic_server(_ZN8DNSEntry9mainEventEiP5Event+0x3d3)[0x6d9a95]
 traffic_server(_ZN12Continuation11handleEventEiPv+0x6c)[0x50c838]
 traffic_server(_ZN12DNSProcessor5getbyEPKciiP12ContinuationRKNS_7OptionsE+0x1c1)[0x6d9e45]
 traffic_server(_ZN12DNSProcessor13gethostbynameEP12ContinuationPKcRKNS_7OptionsE+0x44)[0x6ccb30]
 traffic_server(_ZN18HostDBContinuation6do_dnsEv+0x290)[0x6cadbc]
 traffic_server(_ZN18HostDBContinuation10probeEventEiP5Event+0x2bc)[0x6ca8a6]
 traffic_server(_ZN12Continuation11handleEventEiPv+0x6c)[0x50c838]
 traffic_server(_ZN7EThread13process_eventEP5Eventi+0xc6)[0x786d56]
 traffic_server(_ZN7EThread7executeEv+0xa0)[0x786f24]
 traffic_server(main+0x1246)[0x53da75]
 /lib64/libc.so.6(__libc_start_main+0xfd)[0x340cc1ed5d]
 traffic_server[0x4f47a9]
 Floating point exception (core dumped)
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-3792) Pointing proxy.config.dns.resolv_conf at an empty (or nonexistant) file causes segmentation faults on first DNS query

2015-08-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681134#comment-14681134
 ] 

ASF subversion and git services commented on TS-3792:
-

Commit cc6233173338d6304b89b959d35a6eda01f98e7c in trafficserver's branch 
refs/heads/master from [~zhangzizhong]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=cc62331 ]

TS-3792: Pointing proxy.config.dns.resolv_conf at an empty (or nonexistant) 
file causes crashes. Prevent ATS from crashing.


 Pointing proxy.config.dns.resolv_conf at an empty (or nonexistant) file 
 causes segmentation faults on first DNS query
 -

 Key: TS-3792
 URL: https://issues.apache.org/jira/browse/TS-3792
 Project: Traffic Server
  Issue Type: Bug
Reporter: Thomas Jackson
Assignee: Brian Geffon
 Fix For: 6.1.0


 {code}
 [connect] ERROR (main_socket_fd 9): Connection refused
 [Jul 22 17:04:34.553] {0x2b293f16b960} ERROR: wrote crash log to 
 /var/log/trafficserver/crash-2015-07-22-170434.log
 traffic_server: Floating point exception (Integer divide by zero 
 [0x6d8e5a])traffic_server - STACK TRACE: 
 traffic_server(_Z19crash_logger_invokeiP7siginfoPv+0xc3)[0x50994e]
 /lib64/libpthread.so.0[0x340d40f710]
 traffic_server[0x6d8e5a]
 traffic_server(_ZN8DNSEntry9mainEventEiP5Event+0x3d3)[0x6d9a95]
 traffic_server(_ZN12Continuation11handleEventEiPv+0x6c)[0x50c838]
 traffic_server(_ZN12DNSProcessor5getbyEPKciiP12ContinuationRKNS_7OptionsE+0x1c1)[0x6d9e45]
 traffic_server(_ZN12DNSProcessor13gethostbynameEP12ContinuationPKcRKNS_7OptionsE+0x44)[0x6ccb30]
 traffic_server(_ZN18HostDBContinuation6do_dnsEv+0x290)[0x6cadbc]
 traffic_server(_ZN18HostDBContinuation10probeEventEiP5Event+0x2bc)[0x6ca8a6]
 traffic_server(_ZN12Continuation11handleEventEiPv+0x6c)[0x50c838]
 traffic_server(_ZN7EThread13process_eventEP5Eventi+0xc6)[0x786d56]
 traffic_server(_ZN7EThread7executeEv+0xa0)[0x786f24]
 traffic_server(main+0x1246)[0x53da75]
 /lib64/libc.so.6(__libc_start_main+0xfd)[0x340cc1ed5d]
 traffic_server[0x4f47a9]
 Floating point exception (core dumped)
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: tsqa-master #776

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-master/776/changes

Changes:

[briang] TS-3792: Pointing proxy.config.dns.resolv_conf at an empty (or 
nonexistant) file causes crashes.

[briang] TS-3792: Pointing proxy.config.dns.resolv_conf at an empty (or 
nonexistant) file causes crashes. Prevent ATS from crashing.

--
Started by upstream project out_of_tree-master build number 1078
originally caused by:
 Started by an SCM change
Started by upstream project in_tree-master build number 1297
originally caused by:
 Started by an SCM change
Building remotely on QA3 (qa) in workspace 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/
  /usr/bin/git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
  /usr/bin/git config remote.origin.url 
  https://git-wip-us.apache.org/repos/asf/trafficserver.git # timeout=10
Cleaning workspace
  /usr/bin/git rev-parse --verify HEAD # timeout=10
Resetting working tree
  /usr/bin/git reset --hard # timeout=10
  /usr/bin/git clean -fdx # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/trafficserver.git
  /usr/bin/git --version # timeout=10
  /usr/bin/git -c core.askpass=true fetch --tags --progress 
  https://git-wip-us.apache.org/repos/asf/trafficserver.git 
  +refs/heads/*:refs/remotes/origin/*
  /usr/bin/git rev-parse refs/remotes/origin/master^{commit} # timeout=10
  /usr/bin/git rev-parse refs/remotes/origin/origin/master^{commit} # 
  timeout=10
Checking out Revision cc6233173338d6304b89b959d35a6eda01f98e7c 
(refs/remotes/origin/master)
  /usr/bin/git config core.sparsecheckout # timeout=10
  /usr/bin/git checkout -f cc6233173338d6304b89b959d35a6eda01f98e7c
  /usr/bin/git rev-list b597f9cfa8148df6eb787b8f872a8bd20d0f9492 # timeout=10
[tsqa-master] $ /bin/bash -xe /tmp/hudson7535294820343359032.sh
+ source /home/jenkins/bin/environment.sh
++ export ATS_SRC_HOME=/home/jenkins/src
++ ATS_SRC_HOME=/home/jenkins/src
++ test tsqa-master '!=' tsqa-master
++ ATS_MAKE=make
++ test tsqa-master '!=' tsqa-master
++ export ATS_MAKE
+++ /bin/date +%m%d%Y
++ export TODAY=08112015
++ TODAY=08112015
++ ATS_BRANCH=master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ test tsqa-master '!=' tsqa-master
++ export ATS_BRANCH
++ test tsqa-master '!=' tsqa-master
+ source /home/jenkins/bin/tsqa.sh
++ TSQA_LAYOUT_DIR=https://ci.trafficserver.apache.org/job/tsqa-master/ws/776
++ cd https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa
++ make test
New python executable in virtualenv/bin/python
Installing 
Setuptools..done.
Installing 
Pip.done.
make update
make[1]: Entering directory 
`https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa'
Exception:
Traceback (most recent call last):
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/basecommand.py;,
 line 134, in main
status = self.run(options, args)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/commands/install.py;,
 line 220, in run
for req in parse_requirements(filename, finder=finder, options=options):
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 1477, in parse_requirements
req = InstallRequirement.from_line(line, comes_from, 
prereleases=getattr(options, pre, None))
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 129, in from_line
return cls(req, comes_from, url=url, prereleases=prereleases)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pip/req.py;,
 line 44, in __init__
req = pkg_resources.Requirement.parse(req)
  File 
https://ci.trafficserver.apache.org/job/tsqa-master/ws/src/ci/tsqa/virtualenv/lib/python2.7/site-packages/pkg_resources.py;,
 line 2914, in parse
reqs 

Jenkins build is still unstable: tsqa-lint #428

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-lint/changes



Jenkins build is still unstable: tsqa-lint #429

2015-08-10 Thread jenkins
See https://ci.trafficserver.apache.org/job/tsqa-lint/changes



[jira] [Updated] (TS-3831) Overridable error response type

2015-08-10 Thread Syeda Persia Aziz (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Syeda Persia Aziz updated TS-3831:
--
Description: 
ATS has a set of error pages in the folder body_factory, namely access#denied, 
access#proxy_auth_required,connect#dns_failed... etc. All these error pages are 
loaded in a RawHashTable. When there is an error for e.g. access denied,  ATS 
builds a error response of type access#denied. We can have an overridable 
config that will decide which custom error page to send to the client. This 
config will be set per remap rule. We can have the custom error pages in the 
body_factory folder and these pages will follow a specific naming convention 
for e.g. $var_access#denied, $var_access#proxy_auth_required, ….. Here $var is 
the overridable config (proxy.config.error.response.type). 

Example: 
in Remap.config

map www.abcxyz.com www.efgijk.com @plugin=config.so 
@pparam=proxy.config.error.response.type=yahoo

Now, if there is for e.g. a 'access denied' error, the build_error_response 
will build a customized error response of type yahoo_access#denied . If it can 
not find the type yahoo_access#denied, then it will simply build the default 
access#denied error response. 

Note: I already have a patch for this.

  was:
ATS has a set of error pages in the folder body_factory, namely access#denied, 
access#proxy_auth_required,connect#dns_failed... etc. All these error pages are 
loaded in a RawHashTable. When there is an error for e.g. access denied,  ATS 
builds a error response of type access#denied. We can have an overridable 
config that will decide which custom error page to send to the client. This 
config will be set per remap rule. We can have the custom error pages in the 
body_factory folder and these pages will follow a specific naming convention 
for e.g. $var_access#denied, $var_proxy_auth_required, ….. Here $var is the 
overridable config (proxy.config.error.response.type). 

Example: 
in Remap.config

map www.abcxyz.com www.efgijk.com @plugin=config.so 
@pparam=proxy.config.error.response.type=yahoo

Now, if there is for e.g. a 'access denied' error, the build_error_response 
will build a customized error response of type yahoo_access#denied . If it can 
not find the type yahoo_access#denied, then it will simply build the default 
access#denied error response. 

Note: I already have a patch for this.


 Overridable error response type
 ---

 Key: TS-3831
 URL: https://issues.apache.org/jira/browse/TS-3831
 Project: Traffic Server
  Issue Type: New Feature
  Components: Configuration
Reporter: Syeda Persia Aziz

 ATS has a set of error pages in the folder body_factory, namely 
 access#denied, access#proxy_auth_required,connect#dns_failed... etc. All 
 these error pages are loaded in a RawHashTable. When there is an error for 
 e.g. access denied,  ATS builds a error response of type access#denied. We 
 can have an overridable config that will decide which custom error page to 
 send to the client. This config will be set per remap rule. We can have the 
 custom error pages in the body_factory folder and these pages will follow a 
 specific naming convention for e.g. $var_access#denied, 
 $var_access#proxy_auth_required, ….. Here $var is the overridable config 
 (proxy.config.error.response.type). 
 Example: 
 in Remap.config
 map www.abcxyz.com www.efgijk.com @plugin=config.so 
 @pparam=proxy.config.error.response.type=yahoo
 Now, if there is for e.g. a 'access denied' error, the build_error_response 
 will build a customized error response of type yahoo_access#denied . If it 
 can not find the type yahoo_access#denied, then it will simply build the 
 default access#denied error response. 
 Note: I already have a patch for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)