[jira] [Commented] (TS-3912) 200 OK returned on successful conditional request if Last-Modified header not present in stored response

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803121#comment-14803121
 ] 

ASF subversion and git services commented on TS-3912:
-

Commit c3e2b466b90e2568cf3a338a278cedfe731d766e in trafficserver's branch 
refs/heads/master from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c3e2b46 ]

TS-3912: Fix Coverity CID 1324531


> 200 OK returned on successful conditional request if Last-Modified header not 
> present in stored response
> 
>
> Key: TS-3912
> URL: https://issues.apache.org/jira/browse/TS-3912
> Project: Traffic Server
>  Issue Type: Bug
>Affects Versions: 5.3.2, 6.0.0
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 6.1.0
>
>
> The [spec|https://tools.ietf.org/html/rfc7234#section-4.3.2] says:
> {noformat}
>A cache recipient SHOULD
>generate a 304 (Not Modified) response (using the metadata of the
>selected stored response) if one of the following cases is true: 1)
>the selected stored response has a Last-Modified field-value that is
>earlier than or equal to the conditional timestamp; 2) no
>Last-Modified field is present in the selected stored response, but
>it has a Date field-value that is earlier than or equal to the
>conditional timestamp; or, 3) neither Last-Modified nor Date is
>present in the selected stored response, but the cache recorded it as
>having been received at a time earlier than or equal to the
>conditional timestamp.
> {noformat}
> but our 
> [code|https://github.com/apache/trafficserver/blob/master/proxy/http/HttpTransactCache.cc#L1297-L1313]
>  does:
> {noformat}
>   // If-Modified-Since //
>   if (request->presence(MIME_PRESENCE_IF_MODIFIED_SINCE)) {
> // lm_value is zero if Last-modified not exists
> ink_time_t lm_value = response->get_last_modified();
> // we won't return NOT_MODIFIED if Last-modified not exists
> if ((lm_value == 0) || (request->get_if_modified_since() < lm_value)) {
>   return response->status_get();
> } else {
>   // we cannot return NOT_MODIFIED yet, need to check If-none-match
>   response_code = HTTP_STATUS_NOT_MODIFIED;
>   if (!request->presence(MIME_PRESENCE_IF_NONE_MATCH)) {
> return response_code;
>   }
> }
>   }
> {noformat}
> So we are ignoring Date header and response received time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: clang-analyzer #1400

[jenkins]

See 

Changes:

[Phil Sorber] TS-3912: Fix Coverity CID 1324531

--
[...truncated 2419 lines...]
= 
Value Effect
= 
0 Decouple inbound connections and cache initialization. Connections will 
be accepted as soon as
  possible and Traffic Server will run regardless of the results of cache 
initialization.

1 Do not accept inbound connections until cache initialization has 
finished. Traffic server will run
  regardless of the results of cache initialization.

2 Do not accept inbound connections until cache initialization has finished 
and been sufficiently
  successful that cache is enabled. This means at least one cache span is 
usable. If there are no
  spans in :configfile:`storage.config` or none of the spans can be 
successfully parsed and
  initialized then Traffic Server will shut down.

3 Do not accept inbound connections until cache initialization has finished 
and been completely
  successful. This requires at least one cache span in 
:configfile:`storage.config` and that every
  span specified is valid and successfully initialized. Any error will 
cause Traffic Server to shut
  down.
= 
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:222:
 ERROR: Unexpected indentation.
:63:
 WARNING: toctree contains reference to nonexisting document 
u'reference/plugins/Cache Promotion: provides additional control over when an 
object should be'
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... TSAPI.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_VC_CLOSE_ABORT
None:None: WARNING: c:data reference target not found: TS_URL_SCHEME_FILE
None:None: WARNING: c:data reference target not found: TS_MIME_FIELD_ACCEPT
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/plugin.config
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/records.config
TSActionCancel.3ts { } TSActionDone.3ts { } TSCacheRead.3ts { } None:None: 
WARNING: c:data reference target not found: TS_EVENT_CACHE_OPEN_READ
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_READ_FAILED
TSCacheRemove.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE_FAILED
None:None: WARNING: c:data reference target not found: TS_EVENT_CACHE_REMOVE
TSCacheWrite.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE_FAILED
TSConfigDataGet.3ts { } TSConfigGet.3ts { } TSConfigRelease.3ts { } 
TSConfigSet.3ts { } TSContCall.3ts { } TSContCreate.3ts { } TSContDataGet.3ts { 
} TSContDataSet.3ts { } TSContDestroy.3ts { } TSContMutexGet.3ts { } 
TSContSchedule.3ts { } TSDebug.3ts { } None:None: WARNING: c:type reference 
target not found: expression
None:None: WARNING: c:type reference target not found: expression
None:None: WARNING: c:func reference target not found: printf
TSHostLookup.3ts { } TSHostLookupResultAddrGet.3ts { } TSHttpConnect.3ts { } 
TSHttpConnectWithPluginId.3ts { } None:None: WARNING: c:type reference target 
not found: TSCVonn
TSHttpHdrClone.3ts { } TSHttpHdrCopy.3ts { } TSHttpHdrCreate.3ts { }

Build failed in Jenkins: clang-analyzer #1401

[jenkins]

See 

--
[...truncated 2419 lines...]
= 
Value Effect
= 
0 Decouple inbound connections and cache initialization. Connections will 
be accepted as soon as
  possible and Traffic Server will run regardless of the results of cache 
initialization.

1 Do not accept inbound connections until cache initialization has 
finished. Traffic server will run
  regardless of the results of cache initialization.

2 Do not accept inbound connections until cache initialization has finished 
and been sufficiently
  successful that cache is enabled. This means at least one cache span is 
usable. If there are no
  spans in :configfile:`storage.config` or none of the spans can be 
successfully parsed and
  initialized then Traffic Server will shut down.

3 Do not accept inbound connections until cache initialization has finished 
and been completely
  successful. This requires at least one cache span in 
:configfile:`storage.config` and that every
  span specified is valid and successfully initialized. Any error will 
cause Traffic Server to shut
  down.
= 
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:222:
 ERROR: Unexpected indentation.
:63:
 WARNING: toctree contains reference to nonexisting document 
u'reference/plugins/Cache Promotion: provides additional control over when an 
object should be'
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... TSAPI.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_VC_CLOSE_ABORT
None:None: WARNING: c:data reference target not found: TS_URL_SCHEME_FILE
None:None: WARNING: c:data reference target not found: TS_MIME_FIELD_ACCEPT
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/plugin.config
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/records.config
TSActionCancel.3ts { } TSActionDone.3ts { } TSCacheRead.3ts { } None:None: 
WARNING: c:data reference target not found: TS_EVENT_CACHE_OPEN_READ
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_READ_FAILED
TSCacheRemove.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE_FAILED
None:None: WARNING: c:data reference target not found: TS_EVENT_CACHE_REMOVE
TSCacheWrite.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE_FAILED
TSConfigDataGet.3ts { } TSConfigGet.3ts { } TSConfigRelease.3ts { } 
TSConfigSet.3ts { } TSContCall.3ts { } TSContCreate.3ts { } TSContDataGet.3ts { 
} TSContDataSet.3ts { } TSContDestroy.3ts { } TSContMutexGet.3ts { } 
TSContSchedule.3ts { } TSDebug.3ts { } None:None: WARNING: c:type reference 
target not found: expression
None:None: WARNING: c:type reference target not found: expression
None:None: WARNING: c:func reference target not found: printf
TSHostLookup.3ts { } TSHostLookupResultAddrGet.3ts { } TSHttpConnect.3ts { } 
TSHttpConnectWithPluginId.3ts { } None:None: WARNING: c:type reference target 
not found: TSCVonn
TSHttpHdrClone.3ts { } TSHttpHdrCopy.3ts { } TSHttpHdrCreate.3ts { } 
TSHttpHdrDestroy.3ts { } TSHttpHdrHostGet.3ts { } None:None: WAR

[jira] [Created] (TS-3921) HTT/2 send protocol error on invalid data frame

[Bryan Call (JIRA)]

Bryan Call created TS-3921:
--

 Summary: HTT/2 send protocol error on invalid data frame
 Key: TS-3921
 URL: https://issues.apache.org/jira/browse/TS-3921
 Project: Traffic Server
  Issue Type: Bug
  Components: HTTP/2
Reporter: Bryan Call


Data frames should have a none zero streamid.

{code}
(gdb) up
#2  0x0063fe61 in Http2ClientSession::main_event_handler 
(this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
Http2ClientSession.cc:222
222 in Http2ClientSession.cc
(gdb) p current_hdr
$7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3921) HTT/2 send protocol error on invalid data frame

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-3921:
---
Backport to Version: 6.0.1

> HTT/2 send protocol error on invalid data frame
> ---
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3921) HTT/2 send protocol error on invalid data frame

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-3921:
---
Fix Version/s: 6.1.0

> HTT/2 send protocol error on invalid data frame
> ---
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (TS-3921) HTT/2 send protocol error on invalid data frame

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call reassigned TS-3921:
--

Assignee: Bryan Call

> HTT/2 send protocol error on invalid data frame
> ---
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3921) HTTP/2 send protocol error on invalid data frame

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-3921:
---
Summary: HTTP/2 send protocol error on invalid data frame  (was: HTT/2 send 
protocol error on invalid data frame)

> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3918) runtime option to disable freelists

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-3918:
--
Fix Version/s: sometime

> runtime option to disable freelists
> ---
>
> Key: TS-3918
> URL: https://issues.apache.org/jira/browse/TS-3918
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Configuration, Core
>Reporter: James Peach
> Fix For: sometime
>
>
> Disabling the free list is helpful for debugging and could also be useful for 
> memory-constrained deployments. Make this a run-time option (will require a 
> {{traffic_server}} restart).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3911) New log tag for proxy connection being over SSL, pqssl

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-3911:
--
Fix Version/s: 6.1.0

> New log tag for proxy connection being over SSL, pqssl
> --
>
> Key: TS-3911
> URL: https://issues.apache.org/jira/browse/TS-3911
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Logging
>Reporter: Eric Schwartz
>Assignee: Eric Schwartz
> Fix For: 6.1.0
>
>
> Want to add a log tag identifying whether the connection between the proxy 
> and origin is over SSL.  We have a similar tag for the client connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3915) Regression fails when compilied with asan, heap-use-after-free

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-3915:
--
Fix Version/s: 6.1.0

> Regression fails when compilied with asan, heap-use-after-free
> --
>
> Key: TS-3915
> URL: https://issues.apache.org/jira/browse/TS-3915
> Project: Traffic Server
>  Issue Type: Bug
>  Components: TS API
>Reporter: Bryan Call
> Fix For: 6.1.0
>
>
> Running regression with asan enable on Fedora 22:
> {code}
> CXXFLAGS="-Werror -fno-omit-frame-pointer -fsanitize=address" 
> CFLAGS="-Werror" SPDYLAY_CFLAGS="-I /usr/local/include/" 
> SPDYLAY_LIBS="-L/usr/local/lib -lspdylay"  ./configure --enable-ccache 
> --enable-spdy --disable-freelist
> REGRESSION TEST SDK_API_HttpTxnTransform started
> Regression test(SDK_API_HttpTxnTransform) still in progress
> [SDK_API_HttpTxnTransform] TSTransformCreate : [TestCase1] <> { ok }
> [SDK_API_HttpTxnTransform] TSHttpTxnTransformRespGet : [TestCase] <> { 
> ok }
> [SDK_API_HttpTxnTransform] TSHttpTxnTransformRespGet : [TestCase] <> { 
> ok }
> [SDK_API_HttpTxnTransform] TSHttpTxnTransformRespGet : [TestCase] <> { 
> ok }
> [SDK_API_HttpTxnTransform] TSHttpTxnUntransformedResponseCache : [TestCase1] 
> <> { ok }
> [SDK_API_HttpTxnTransform] TSHttpTxnTransformedResponseCache : [TestCase1] 
> <> { ok }
> =
> ==14340==ERROR: AddressSanitizer: heap-use-after-free on address 
> 0x60800d59276b at pc 0x005cb466 bp 0x7f4f46b88b40 sp 0x7f4f46b88b30
> READ of size 1 at 0x60800d59276b thread T9 ([ET_NET 8])
> #0 0x5cb465 in transformtest_transform 
> /home/bcall/dev/apache/trafficserver/proxy/InkAPITest.cc:6318
> #1 0xc33609 in Continuation::handleEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/I_Continuation.h:146
> #2 0xc33609 in EThread::process_event(Event*, int) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:128
> #3 0xc35605 in EThread::execute() 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:207
> #4 0xc32438 in spawn_thread_internal 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/Thread.cc:86
> #5 0x7f4f4da8c554 in start_thread (/lib64/libpthread.so.0+0x7554)
> #6 0x7f4f4c9bcb9c in __clone (/lib64/libc.so.6+0x102b9c)
> 0x60800d59276b is located 75 bytes inside of 96-byte region 
> [0x60800d592720,0x60800d592780)
> freed by thread T4 ([ET_NET 3]) here:
> #0 0x7f4f4fb2470a in __interceptor_free (/lib64/libasan.so.2+0x9870a)
> #1 0x5de815 in transform_hook_handler 
> /home/bcall/dev/apache/trafficserver/proxy/InkAPITest.cc:6637
> #2 0xc33609 in Continuation::handleEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/I_Continuation.h:146
> #3 0xc33609 in EThread::process_event(Event*, int) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:128
> #4 0xc35605 in EThread::execute() 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:207
> #5 0xc32438 in spawn_thread_internal 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/Thread.cc:86
> #6 0x7f4f4da8c554 in start_thread (/lib64/libpthread.so.0+0x7554)
> previously allocated by thread T0 ([ET_NET 0]) here:
> #0 0x7f4f4fb24a0a in malloc (/lib64/libasan.so.2+0x98a0a)
> #1 0x7f4f4f859ae5 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:54
> #2 0x5d3d2a in RegressionTest_SDK_API_HttpTxnTransform(RegressionTest*, 
> int, int*) /home/bcall/dev/apache/trafficserver/proxy/InkAPITest.cc:6663
> #3 0x7f4f4f844f69 in start_test 
> /home/bcall/dev/apache/trafficserver/lib/ts/Regression.cc:78
> #4 0x7f4f4f844f69 in RegressionTest::run_some() 
> /home/bcall/dev/apache/trafficserver/lib/ts/Regression.cc:126
> #5 0x7f4f4f845366 in RegressionTest::check_status() 
> /home/bcall/dev/apache/trafficserver/lib/ts/Regression.cc:141
> #6 0x563773 in RegressionCont::mainEvent(int, Event*) 
> /home/bcall/dev/apache/trafficserver/proxy/Main.cc:1210
> #7 0xc33609 in Continuation::handleEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/I_Continuation.h:146
> #8 0xc33609 in EThread::process_event(Event*, int) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:128
> #9 0xc35605 in EThread::execute() 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:207
> #10 0x497d2c in main 
> /home/bcall/dev/apache/trafficserver/proxy/Main.cc:1812
> #11 0x7f4f4c8da6ff in __libc_start_main (/lib64/libc.so.6+0x206ff)
> Thread T9 ([ET_NET 8]) created by T0 ([ET_NET 0]) here:
> #0 0x7f4f4fac2703 in pthread_create (/lib64/libasan.so.2+0x36703)
> #1 0xc32eda in ink_thread_create ../../lib

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804465#comment-14804465
 ] 

ASF subversion and git services commented on TS-3921:
-

Commit 48fadc42402ddd213f1b30b6639f2334d3d3cf07 in trafficserver's branch 
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=48fadc4 ]

TS-3921: HTTP/2 send protocol error on invalid data frame


> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3921) HTTP/2 send protocol error on invalid data frame

[Phil Sorber (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phil Sorber updated TS-3921:

Backport to Version: 6.0.1, 5.3.3  (was: 6.0.1)

> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: clang-analyzer #1402

[jenkins]

See 

Changes:

[Bryan Call] TS-3921: HTTP/2 send protocol error on invalid data frame

--
[...truncated 2425 lines...]
= 
Value Effect
= 
0 Decouple inbound connections and cache initialization. Connections will 
be accepted as soon as
  possible and Traffic Server will run regardless of the results of cache 
initialization.

1 Do not accept inbound connections until cache initialization has 
finished. Traffic server will run
  regardless of the results of cache initialization.

2 Do not accept inbound connections until cache initialization has finished 
and been sufficiently
  successful that cache is enabled. This means at least one cache span is 
usable. If there are no
  spans in :configfile:`storage.config` or none of the spans can be 
successfully parsed and
  initialized then Traffic Server will shut down.

3 Do not accept inbound connections until cache initialization has finished 
and been completely
  successful. This requires at least one cache span in 
:configfile:`storage.config` and that every
  span specified is valid and successfully initialized. Any error will 
cause Traffic Server to shut
  down.
= 
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:222:
 ERROR: Unexpected indentation.
:63:
 WARNING: toctree contains reference to nonexisting document 
u'reference/plugins/Cache Promotion: provides additional control over when an 
object should be'
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... TSAPI.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_VC_CLOSE_ABORT
None:None: WARNING: c:data reference target not found: TS_URL_SCHEME_FILE
None:None: WARNING: c:data reference target not found: TS_MIME_FIELD_ACCEPT
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/plugin.config
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/records.config
TSActionCancel.3ts { } TSActionDone.3ts { } TSCacheRead.3ts { } None:None: 
WARNING: c:data reference target not found: TS_EVENT_CACHE_OPEN_READ
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_READ_FAILED
TSCacheRemove.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE_FAILED
None:None: WARNING: c:data reference target not found: TS_EVENT_CACHE_REMOVE
TSCacheWrite.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE_FAILED
TSConfigDataGet.3ts { } TSConfigGet.3ts { } TSConfigRelease.3ts { } 
TSConfigSet.3ts { } TSContCall.3ts { } TSContCreate.3ts { } TSContDataGet.3ts { 
} TSContDataSet.3ts { } TSContDestroy.3ts { } TSContMutexGet.3ts { } 
TSContSchedule.3ts { } TSDebug.3ts { } None:None: WARNING: c:type reference 
target not found: expression
None:None: WARNING: c:type reference target not found: expression
None:None: WARNING: c:func reference target not found: printf
TSHostLookup.3ts { } TSHostLookupResultAddrGet.3ts { } TSHttpConnect.3ts { } 
TSHttpConnectWithPluginId.3ts { } None:None: WARNING: c:type reference target 
not found: TSCVonn
TSHttpHdrClone.3ts { } TSHttpHdrCopy.3ts { } 

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804531#comment-14804531
 ] 

ASF subversion and git services commented on TS-3921:
-

Commit f55fdf1c639f83208d5cca6f4f2595e4588f2c9d in trafficserver's branch 
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=f55fdf1 ]

TS-3921: HTTP/2 send protocol error on invalid data frame
Need to return 0 after sending goaway


> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[Masakazu Kitajo (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804538#comment-14804538
 ] 

Masakazu Kitajo commented on TS-3921:
-

The reason why the validation of flags isn't working seems that the mask, the 
sum of the flags, is wrong.
https://github.com/apache/trafficserver/blob/6.0.x/proxy/http2/HTTP2.h#L143

> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[Masakazu Kitajo (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804549#comment-14804549
 ] 

Masakazu Kitajo commented on TS-3921:
-

The mask for HEADERS frame is wrong too.
https://github.com/apache/trafficserver/blob/6.0.x/proxy/http2/HTTP2.h#L153

> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: clang-analyzer #1403

[jenkins]

See 

Changes:

[Bryan Call] TS-3921: HTTP/2 send protocol error on invalid data frame

--
[...truncated 2422 lines...]
= 
Value Effect
= 
0 Decouple inbound connections and cache initialization. Connections will 
be accepted as soon as
  possible and Traffic Server will run regardless of the results of cache 
initialization.

1 Do not accept inbound connections until cache initialization has 
finished. Traffic server will run
  regardless of the results of cache initialization.

2 Do not accept inbound connections until cache initialization has finished 
and been sufficiently
  successful that cache is enabled. This means at least one cache span is 
usable. If there are no
  spans in :configfile:`storage.config` or none of the spans can be 
successfully parsed and
  initialized then Traffic Server will shut down.

3 Do not accept inbound connections until cache initialization has finished 
and been completely
  successful. This requires at least one cache span in 
:configfile:`storage.config` and that every
  span specified is valid and successfully initialized. Any error will 
cause Traffic Server to shut
  down.
= 
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:222:
 ERROR: Unexpected indentation.
:63:
 WARNING: toctree contains reference to nonexisting document 
u'reference/plugins/Cache Promotion: provides additional control over when an 
object should be'
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... TSAPI.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_VC_CLOSE_ABORT
None:None: WARNING: c:data reference target not found: TS_URL_SCHEME_FILE
None:None: WARNING: c:data reference target not found: TS_MIME_FIELD_ACCEPT
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/plugin.config
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/records.config
TSActionCancel.3ts { } TSActionDone.3ts { } TSCacheRead.3ts { } None:None: 
WARNING: c:data reference target not found: TS_EVENT_CACHE_OPEN_READ
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_READ_FAILED
TSCacheRemove.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE_FAILED
None:None: WARNING: c:data reference target not found: TS_EVENT_CACHE_REMOVE
TSCacheWrite.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE_FAILED
TSConfigDataGet.3ts { } TSConfigGet.3ts { } TSConfigRelease.3ts { } 
TSConfigSet.3ts { } TSContCall.3ts { } TSContCreate.3ts { } TSContDataGet.3ts { 
} TSContDataSet.3ts { } TSContDestroy.3ts { } TSContMutexGet.3ts { } 
TSContSchedule.3ts { } TSDebug.3ts { } None:None: WARNING: c:type reference 
target not found: expression
None:None: WARNING: c:type reference target not found: expression
None:None: WARNING: c:func reference target not found: printf
TSHostLookup.3ts { } TSHostLookupResultAddrGet.3ts { } TSHttpConnect.3ts { } 
TSHttpConnectWithPluginId.3ts { } None:None: WARNING: c:type reference target 
not found: TSCVonn
TSHttpHdrClone.3ts { } TSHttpHdrCopy.3ts { } 

[jira] [Resolved] (TS-3921) HTTP/2 send protocol error on invalid data frame

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call resolved TS-3921.

Resolution: Fixed

> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-3922) Add independent WebSocket timeouts

[Brian Geffon (JIRA)]

Brian Geffon created TS-3922:


 Summary: Add independent WebSocket timeouts
 Key: TS-3922
 URL: https://issues.apache.org/jira/browse/TS-3922
 Project: Traffic Server
  Issue Type: Improvement
  Components: Core
Reporter: Brian Geffon


Right now WebSockets fall under the active/inactive transaction timeouts. 
Obviously the inactivate timeout isn't a problem but the active timeout is. We 
need at minimum a new timeout for active WS connections, I'll likely add a new 
timeout for inactive state too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (TS-3922) Add independent WebSocket timeouts

[Brian Geffon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Geffon reassigned TS-3922:


Assignee: Brian Geffon

> Add independent WebSocket timeouts
> --
>
> Key: TS-3922
> URL: https://issues.apache.org/jira/browse/TS-3922
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Brian Geffon
>Assignee: Brian Geffon
>
> Right now WebSockets fall under the active/inactive transaction timeouts. 
> Obviously the inactivate timeout isn't a problem but the active timeout is. 
> We need at minimum a new timeout for active WS connections, I'll likely add a 
> new timeout for inactive state too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3922) Add independent WebSocket timeouts

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-3922:
--
Fix Version/s: 6.1.0

> Add independent WebSocket timeouts
> --
>
> Key: TS-3922
> URL: https://issues.apache.org/jira/browse/TS-3922
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Brian Geffon
>Assignee: Brian Geffon
> Fix For: 6.1.0
>
>
> Right now WebSockets fall under the active/inactive transaction timeouts. 
> Obviously the inactivate timeout isn't a problem but the active timeout is. 
> We need at minimum a new timeout for active WS connections, I'll likely add a 
> new timeout for inactive state too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804903#comment-14804903
 ] 

ASF GitHub Bot commented on TS-3921:


GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/295

TS-3921: Fix MASKs of Frames

- [TS-3921](https://issues.apache.org/jira/browse/TS-3921)
- [TS-3827](https://issues.apache.org/jira/browse/TS-3827)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver ts-3921

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #295


commit 0a6cd5f1b037026ac0d10c69a3c489b79236ddfc
Author: Masaori Koshiba 
Date:   2015-09-18T01:35:57Z

TS-3827: Cleanup Flags of Frames

commit ff5c424bc2c14c25750747d0b74b12fd2868b701
Author: Masaori Koshiba 
Date:   2015-09-18T01:37:05Z

TS-3921: Fix MASKs of Frames




> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804905#comment-14804905
 ] 

ASF GitHub Bot commented on TS-3921:


Github user masaori335 commented on the pull request:

https://github.com/apache/trafficserver/pull/295#issuecomment-141332599
  
@maskit Could you take a look?


> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804909#comment-14804909
 ] 

ASF GitHub Bot commented on TS-3921:


Github user jpeach commented on the pull request:

https://github.com/apache/trafficserver/pull/295#issuecomment-141333600
  
This looks reasonable. Could you add a unit test for 
```http2_are_frame_flags_valid()```, which should be straightforward now the 
masks are correct.

I see that ```http2_frame_header_is_valid()``` does't raise an error on 
invalid flags. Should we restore the check?


> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804913#comment-14804913
 ] 

ASF GitHub Bot commented on TS-3921:


Github user masaori335 commented on the pull request:

https://github.com/apache/trafficserver/pull/295#issuecomment-141334561
  
@jpeach OK, I'll add unit tests. 
IMO, we should restore the check.


> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-2520) Add TCP fastopen support for incoming TCP connections

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804919#comment-14804919
 ] 

ASF subversion and git services commented on TS-2520:
-

Commit 5a2de11482443788dfdbd82c435d7caf3a0d3784 in trafficserver's branch 
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5a2de11 ]

TS-2520: fix OS X build


> Add TCP fastopen support for incoming TCP connections
> -
>
> Key: TS-2520
> URL: https://issues.apache.org/jira/browse/TS-2520
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Network
>Reporter: Alex Sandro Garzão
>Assignee: Bryan Call
>Priority: Minor
>  Labels: yahoo
> Fix For: 6.1.0
>
>
> TFO (TCP Fast Open) can be enabled on all listen sockets in the kernel. 
> Nevertheless, I would like that only ATS try using TFO.
> One possibility is a configuration variable that informs ATS to set 
> TCP_FASTOPEN.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3921) HTTP/2 send protocol error on invalid data frame

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804920#comment-14804920
 ] 

ASF GitHub Bot commented on TS-3921:


Github user maskit commented on the pull request:

https://github.com/apache/trafficserver/pull/295#issuecomment-141335350
  
@masaori335 LGTM.

We should restore the check only about flags. Other part in the commit 
looks reasonable.


> HTTP/2 send protocol error on invalid data frame
> 
>
> Key: TS-3921
> URL: https://issues.apache.org/jira/browse/TS-3921
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.1.0
>
>
> Data frames should have a none zero streamid.
> {code}
> (gdb) up
> #2  0x0063fe61 in Http2ClientSession::main_event_handler 
> (this=0x2af8c0b28a00, event=100, edata=0x2af864f80848) at 
> Http2ClientSession.cc:222
> 222   in Http2ClientSession.cc
> (gdb) p current_hdr
> $7 = {length = 0, type = 0 '\000', flags = 0 '\000', streamid = 0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: clang-analyzer #1404

[jenkins]

See 

Changes:

[James Peach] TS-2520: fix OS X build

[James Peach] Make memcpy_and_advance() static.

--
[...truncated 2419 lines...]
= 
Value Effect
= 
0 Decouple inbound connections and cache initialization. Connections will 
be accepted as soon as
  possible and Traffic Server will run regardless of the results of cache 
initialization.

1 Do not accept inbound connections until cache initialization has 
finished. Traffic server will run
  regardless of the results of cache initialization.

2 Do not accept inbound connections until cache initialization has finished 
and been sufficiently
  successful that cache is enabled. This means at least one cache span is 
usable. If there are no
  spans in :configfile:`storage.config` or none of the spans can be 
successfully parsed and
  initialized then Traffic Server will shut down.

3 Do not accept inbound connections until cache initialization has finished 
and been completely
  successful. This requires at least one cache span in 
:configfile:`storage.config` and that every
  span specified is valid and successfully initialized. Any error will 
cause Traffic Server to shut
  down.
= 
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:222:
 ERROR: Unexpected indentation.
:63:
 WARNING: toctree contains reference to nonexisting document 
u'reference/plugins/Cache Promotion: provides additional control over when an 
object should be'
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... TSAPI.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_VC_CLOSE_ABORT
None:None: WARNING: c:data reference target not found: TS_URL_SCHEME_FILE
None:None: WARNING: c:data reference target not found: TS_MIME_FIELD_ACCEPT
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/plugin.config
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/records.config
TSActionCancel.3ts { } TSActionDone.3ts { } TSCacheRead.3ts { } None:None: 
WARNING: c:data reference target not found: TS_EVENT_CACHE_OPEN_READ
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_READ_FAILED
TSCacheRemove.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE_FAILED
None:None: WARNING: c:data reference target not found: TS_EVENT_CACHE_REMOVE
TSCacheWrite.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE_FAILED
TSConfigDataGet.3ts { } TSConfigGet.3ts { } TSConfigRelease.3ts { } 
TSConfigSet.3ts { } TSContCall.3ts { } TSContCreate.3ts { } TSContDataGet.3ts { 
} TSContDataSet.3ts { } TSContDestroy.3ts { } TSContMutexGet.3ts { } 
TSContSchedule.3ts { } TSDebug.3ts { } None:None: WARNING: c:type reference 
target not found: expression
None:None: WARNING: c:type reference target not found: expression
None:None: WARNING: c:func reference target not found: printf
TSHostLookup.3ts { } TSHostLookupResultAddrGet.3ts { } TSHttpConnect.3ts { } 
TSHttpConnectWithPluginId.3ts { } None:None: WARNING: c:type reference target 
not found: TSCVonn
TSHttpHdrClone.3ts { } TSHttp

Build failed in Jenkins: clang-analyzer #1405

[jenkins]

See 

--
[...truncated 2419 lines...]
= 
Value Effect
= 
0 Decouple inbound connections and cache initialization. Connections will 
be accepted as soon as
  possible and Traffic Server will run regardless of the results of cache 
initialization.

1 Do not accept inbound connections until cache initialization has 
finished. Traffic server will run
  regardless of the results of cache initialization.

2 Do not accept inbound connections until cache initialization has finished 
and been sufficiently
  successful that cache is enabled. This means at least one cache span is 
usable. If there are no
  spans in :configfile:`storage.config` or none of the spans can be 
successfully parsed and
  initialized then Traffic Server will shut down.

3 Do not accept inbound connections until cache initialization has finished 
and been completely
  successful. This requires at least one cache span in 
:configfile:`storage.config` and that every
  span specified is valid and successfully initialized. Any error will 
cause Traffic Server to shut
  down.
= 
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:154:
 WARNING: Title underline too short.

CLIENT-URL, URL, URL-FROM, and URL-TO
-
:222:
 ERROR: Unexpected indentation.
:63:
 WARNING: toctree contains reference to nonexisting document 
u'reference/plugins/Cache Promotion: provides additional control over when an 
object should be'
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:784:
 WARNING: Title underline too short.

ts.http.get_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
:809:
 WARNING: Title underline too short.

ts.http.set_cache_lookup_url
-
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... TSAPI.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_EVENT_NONE
None:None: WARNING: c:data reference target not found: TS_VC_CLOSE_ABORT
None:None: WARNING: c:data reference target not found: TS_URL_SCHEME_FILE
None:None: WARNING: c:data reference target not found: TS_MIME_FIELD_ACCEPT
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/plugin.config
None:None: WARNING: u'file' reference target not found: 
{CONFIG_DIR}/records.config
TSActionCancel.3ts { } TSActionDone.3ts { } TSCacheRead.3ts { } None:None: 
WARNING: c:data reference target not found: TS_EVENT_CACHE_OPEN_READ
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_READ_FAILED
TSCacheRemove.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_REMOVE_FAILED
None:None: WARNING: c:data reference target not found: TS_EVENT_CACHE_REMOVE
TSCacheWrite.3ts { } None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE
None:None: WARNING: c:data reference target not found: 
TS_EVENT_CACHE_OPEN_WRITE_FAILED
TSConfigDataGet.3ts { } TSConfigGet.3ts { } TSConfigRelease.3ts { } 
TSConfigSet.3ts { } TSContCall.3ts { } TSContCreate.3ts { } TSContDataGet.3ts { 
} TSContDataSet.3ts { } TSContDestroy.3ts { } TSContMutexGet.3ts { } 
TSContSchedule.3ts { } TSDebug.3ts { } None:None: WARNING: c:type reference 
target not found: expression
None:None: WARNING: c:type reference target not found: expression
None:None: WARNING: c:func reference target not found: printf
TSHostLookup.3ts { } TSHostLookupResultAddrGet.3ts { } TSHttpConnect.3ts { } 
TSHttpConnectWithPluginId.3ts { } None:None: WARNING: c:type reference target 
not found: TSCVonn
TSHttpHdrClone.3ts { } TSHttpHdrCopy.3ts { } TSHttpHdrCreate.3ts { } 
TSHttpHdrDestroy.3ts { } TSHttpHdrHostGet.3ts { } None:None: WAR