[jira] [Commented] (TS-3967) Set stream state to close after a RST_STEAM has been sent
[ https://issues.apache.org/jira/browse/TS-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090589#comment-15090589 ] ASF GitHub Bot commented on TS-3967: Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/389#issuecomment-170236549 rebased to follow the changes in master > Set stream state to close after a RST_STEAM has been sent > - > > Key: TS-3967 > URL: https://issues.apache.org/jira/browse/TS-3967 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Bryan Call >Assignee: Bryan Call > Fix For: 6.2.0 > > Attachments: ts-3967-2.diff, ts-3967.diff > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (TS-4118) CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
[
https://issues.apache.org/jira/browse/TS-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masaori Koshiba reassigned TS-4118:
---
Assignee: Masaori Koshiba
> CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
> -
>
> Key: TS-4118
> URL: https://issues.apache.org/jira/browse/TS-4118
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 6.2.0
>
>
> {code}
> *** CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
> /proxy/http2/RegressionHPACK.cc: 428 in
> RegressionTest_HPACK_Encode(RegressionTest *, int, int *)()
> 422 uint64_t buf_len = BUFSIZE_FOR_REGRESSION_TEST;
> 423 int64_t len = http2_write_psuedo_headers(headers, buf, buf_len,
> indexing_table);
> 424 buf_len -= len;
> 425
> 426 MIMEFieldIter field_iter;
> 427 bool cont = false;
>CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
>Using variable "len" as an index to array "buf".
> 428 len += http2_write_header_fragment(headers, field_iter, buf +
> len, buf_len, indexing_table, cont);
> 429
> 430 box.check(len ==
> encoded_field_response_test_case[i].encoded_field_len, "encoded length was %"
> PRId64 ", expecting %d", len,
> 431 encoded_field_response_test_case[i].encoded_field_len);
> 432 box.check(len > 0 && memcmp(buf,
> encoded_field_response_test_case[i].encoded_field, len) == 0, "encoded value
> was invalid");
> 433
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-4118) CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
[
https://issues.apache.org/jira/browse/TS-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masaori Koshiba updated TS-4118:
Fix Version/s: 6.2.0
> CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
> -
>
> Key: TS-4118
> URL: https://issues.apache.org/jira/browse/TS-4118
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 6.2.0
>
>
> {code}
> *** CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
> /proxy/http2/RegressionHPACK.cc: 428 in
> RegressionTest_HPACK_Encode(RegressionTest *, int, int *)()
> 422 uint64_t buf_len = BUFSIZE_FOR_REGRESSION_TEST;
> 423 int64_t len = http2_write_psuedo_headers(headers, buf, buf_len,
> indexing_table);
> 424 buf_len -= len;
> 425
> 426 MIMEFieldIter field_iter;
> 427 bool cont = false;
>CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
>Using variable "len" as an index to array "buf".
> 428 len += http2_write_header_fragment(headers, field_iter, buf +
> len, buf_len, indexing_table, cont);
> 429
> 430 box.check(len ==
> encoded_field_response_test_case[i].encoded_field_len, "encoded length was %"
> PRId64 ", expecting %d", len,
> 431 encoded_field_response_test_case[i].encoded_field_len);
> 432 box.check(len > 0 && memcmp(buf,
> encoded_field_response_test_case[i].encoded_field, len) == 0, "encoded value
> was invalid");
> 433
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TS-4118) CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
Masaori Koshiba created TS-4118:
---
Summary: CID 1347871: Memory - illegal accesses in
RegressionHPACK.cc
Key: TS-4118
URL: https://issues.apache.org/jira/browse/TS-4118
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Masaori Koshiba
{code}
*** CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
/proxy/http2/RegressionHPACK.cc: 428 in
RegressionTest_HPACK_Encode(RegressionTest *, int, int *)()
422 uint64_t buf_len = BUFSIZE_FOR_REGRESSION_TEST;
423 int64_t len = http2_write_psuedo_headers(headers, buf, buf_len,
indexing_table);
424 buf_len -= len;
425
426 MIMEFieldIter field_iter;
427 bool cont = false;
CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
Using variable "len" as an index to array "buf".
428 len += http2_write_header_fragment(headers, field_iter, buf + len,
buf_len, indexing_table, cont);
429
430 box.check(len ==
encoded_field_response_test_case[i].encoded_field_len, "encoded length was %"
PRId64 ", expecting %d", len,
431 encoded_field_response_test_case[i].encoded_field_len);
432 box.check(len > 0 && memcmp(buf,
encoded_field_response_test_case[i].encoded_field, len) == 0, "encoded value
was invalid");
433
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-4097) HPACK encoder doesn't handle empty value
[ https://issues.apache.org/jira/browse/TS-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masakazu Kitajo updated TS-4097: Backport to Version: 6.1.0 Fix Version/s: (was: 6.1.0) 6.2.0 > HPACK encoder doesn't handle empty value > > > Key: TS-4097 > URL: https://issues.apache.org/jira/browse/TS-4097 > Project: Traffic Server > Issue Type: Bug > Components: HTTP/2 >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 6.2.0 > > > HPACK string encoder doesn't handle empty string properly after supporting > Huffman code. > It fails and returns error code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4118) CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
[
https://issues.apache.org/jira/browse/TS-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090817#comment-15090817
]
Leif Hedstrom commented on TS-4118:
---
This problem is not an n 6.1.0 right?
> CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
> -
>
> Key: TS-4118
> URL: https://issues.apache.org/jira/browse/TS-4118
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 6.2.0
>
>
> {code}
> *** CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
> /proxy/http2/RegressionHPACK.cc: 428 in
> RegressionTest_HPACK_Encode(RegressionTest *, int, int *)()
> 422 uint64_t buf_len = BUFSIZE_FOR_REGRESSION_TEST;
> 423 int64_t len = http2_write_psuedo_headers(headers, buf, buf_len,
> indexing_table);
> 424 buf_len -= len;
> 425
> 426 MIMEFieldIter field_iter;
> 427 bool cont = false;
>CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
>Using variable "len" as an index to array "buf".
> 428 len += http2_write_header_fragment(headers, field_iter, buf +
> len, buf_len, indexing_table, cont);
> 429
> 430 box.check(len ==
> encoded_field_response_test_case[i].encoded_field_len, "encoded length was %"
> PRId64 ", expecting %d", len,
> 431 encoded_field_response_test_case[i].encoded_field_len);
> 432 box.check(len > 0 && memcmp(buf,
> encoded_field_response_test_case[i].encoded_field, len) == 0, "encoded value
> was invalid");
> 433
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (TS-4118) CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
[
https://issues.apache.org/jira/browse/TS-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090817#comment-15090817
]
Leif Hedstrom edited comment on TS-4118 at 1/9/16 10:46 PM:
This problem is not in 6.1.0 right?
was (Author: zwoop):
This problem is not an n 6.1.0 right?
> CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
> -
>
> Key: TS-4118
> URL: https://issues.apache.org/jira/browse/TS-4118
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 6.2.0
>
>
> {code}
> *** CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
> /proxy/http2/RegressionHPACK.cc: 428 in
> RegressionTest_HPACK_Encode(RegressionTest *, int, int *)()
> 422 uint64_t buf_len = BUFSIZE_FOR_REGRESSION_TEST;
> 423 int64_t len = http2_write_psuedo_headers(headers, buf, buf_len,
> indexing_table);
> 424 buf_len -= len;
> 425
> 426 MIMEFieldIter field_iter;
> 427 bool cont = false;
>CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
>Using variable "len" as an index to array "buf".
> 428 len += http2_write_header_fragment(headers, field_iter, buf +
> len, buf_len, indexing_table, cont);
> 429
> 430 box.check(len ==
> encoded_field_response_test_case[i].encoded_field_len, "encoded length was %"
> PRId64 ", expecting %d", len,
> 431 encoded_field_response_test_case[i].encoded_field_len);
> 432 box.check(len > 0 && memcmp(buf,
> encoded_field_response_test_case[i].encoded_field, len) == 0, "encoded value
> was invalid");
> 433
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4118) CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
[
https://issues.apache.org/jira/browse/TS-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090887#comment-15090887
]
Masaori Koshiba commented on TS-4118:
-
Yes. This is only in master.
> CID 1347871: Memory - illegal accesses in RegressionHPACK.cc
> -
>
> Key: TS-4118
> URL: https://issues.apache.org/jira/browse/TS-4118
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 6.2.0
>
>
> {code}
> *** CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
> /proxy/http2/RegressionHPACK.cc: 428 in
> RegressionTest_HPACK_Encode(RegressionTest *, int, int *)()
> 422 uint64_t buf_len = BUFSIZE_FOR_REGRESSION_TEST;
> 423 int64_t len = http2_write_psuedo_headers(headers, buf, buf_len,
> indexing_table);
> 424 buf_len -= len;
> 425
> 426 MIMEFieldIter field_iter;
> 427 bool cont = false;
>CID 1347871: Memory - illegal accesses (NEGATIVE_RETURNS)
>Using variable "len" as an index to array "buf".
> 428 len += http2_write_header_fragment(headers, field_iter, buf +
> len, buf_len, indexing_table, cont);
> 429
> 430 box.check(len ==
> encoded_field_response_test_case[i].encoded_field_len, "encoded length was %"
> PRId64 ", expecting %d", len,
> 431 encoded_field_response_test_case[i].encoded_field_len);
> 432 box.check(len > 0 && memcmp(buf,
> encoded_field_response_test_case[i].encoded_field, len) == 0, "encoded value
> was invalid");
> 433
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-3967) Set stream state to close after a RST_STEAM has been sent
[ https://issues.apache.org/jira/browse/TS-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masaori Koshiba updated TS-3967: Backport to Version: 6.1.0 > Set stream state to close after a RST_STEAM has been sent > - > > Key: TS-3967 > URL: https://issues.apache.org/jira/browse/TS-3967 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Bryan Call >Assignee: Bryan Call > Fix For: 6.2.0 > > Attachments: ts-3967-2.diff, ts-3967.diff > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masaori Koshiba updated TS-3478: Fix Version/s: (was: 6.1.0) 6.2.0 > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090504#comment-15090504 ] ASF GitHub Bot commented on TS-3478: Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-170210554 Oops, I mean TS-4092. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (TS-4092) Decouple HPACK from HTTP/2
[ https://issues.apache.org/jira/browse/TS-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masakazu Kitajo reassigned TS-4092: --- Assignee: Masakazu Kitajo > Decouple HPACK from HTTP/2 > -- > > Key: TS-4092 > URL: https://issues.apache.org/jira/browse/TS-4092 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Masakazu Kitajo >Assignee: Masakazu Kitajo > Fix For: 6.2.0 > > > Our HTTP/2 implementation and HPACK implementation are coupled tightly. This > is bad. It makes things complicated. > I tried to write a test runner which uses [hpack-test-case > |https://github.com/http2jp/hpack-test-case], however, I had to call > functions in HTTP2.cc. Because HPACK.cc has only primitive encoder and > decoder, and doesn't handle header blocks. HTTP2.cc covers not only RFC7540 > but also some part of RFC7541. > On the other hand, HPACK.h exports pseudo header names as constants. They > should be in HTTP2.h or MIME.h as WKS. We don't need them in HPACK > implementation. > Also, HPACK is used with QUIC (at least in current draft). We should decouple > HPACK from HTTP/2 so that we can use the module with QUIC in the future. > Once we have done this, we can write tests for these improvements more easily. > TS-4002, TS-4061, TS-4014 and TS-3478 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090503#comment-15090503 ] ASF GitHub Bot commented on TS-3478: Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-170210430 The fixes look ok to me. @masaori335 You mean TS-4092? I'm going to refine the names and interfaces. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090514#comment-15090514 ] ASF subversion and git services commented on TS-3478: - Commit 82ce75676f2ad614be20793b4a217308e6981e84 in trafficserver's branch refs/heads/master from [~rokubo] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=82ce756 ] TS-3478: Indexing header representations on HPACK encoder This closes #391 > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090516#comment-15090516 ] ASF GitHub Bot commented on TS-3478: Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/391 > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090515#comment-15090515 ] ASF subversion and git services commented on TS-3478: - Commit 770e7878c0f4dde9516f6f93490eb8b2f66a8dd2 in trafficserver's branch refs/heads/master from [~masaori] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=770e787 ] TS-3478: clang-format > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3967) Set stream state to close after a RST_STEAM has been sent
[ https://issues.apache.org/jira/browse/TS-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masaori Koshiba updated TS-3967: Fix Version/s: (was: 6.1.0) 6.2.0 > Set stream state to close after a RST_STEAM has been sent > - > > Key: TS-3967 > URL: https://issues.apache.org/jira/browse/TS-3967 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Bryan Call >Assignee: Bryan Call > Fix For: 6.2.0 > > Attachments: ts-3967-2.diff, ts-3967.diff > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
