[jira] [Commented] (TS-4521) compile error on build proxy/http2/test_HPACK

2016-06-12 Thread Oknet Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326884#comment-15326884
 ] 

Oknet Xu commented on TS-4521:
--

Thanks! It's worked.

> compile error on build proxy/http2/test_HPACK
> -
>
> Key: TS-4521
> URL: https://issues.apache.org/jira/browse/TS-4521
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Oknet Xu
>Assignee: Masakazu Kitajo
> Fix For: 7.0.0
>
>
> OS: Debian 7 (wheezy)
> ATS Branch: master
> GCC: 4.7.2(Debian 4.7.2-5)
> {code}
> /usr/bin/ld: ../../proxy/hdrs/libhdrs.a(HttpCompat.o): undefined reference to 
> symbol 'Tcl_NextHashEntry'
> /usr/bin/ld: note: 'Tcl_NextHashEntry' is defined in DSO 
> /usr/lib/libtcl8.5.so.0 so try adding it to the linker command line
> /usr/lib/libtcl8.5.so.0: could not read symbols: Invalid operation
> collect2: error: ld returned 1 exit status
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4517) Build tests in the same build phase all over components

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326788#comment-15326788
 ] 

ASF GitHub Bot commented on TS-4517:


Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/702
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/122/ for details.
 



> Build tests in the same build phase all over components
> ---
>
> Key: TS-4517
> URL: https://issues.apache.org/jira/browse/TS-4517
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Masakazu Kitajo
>Assignee: Masakazu Kitajo
> Fix For: 7.0.0
>
>
> Currently, tests for H2 are built during normal build phase but others are 
> not built until you run "make check".
> There may be reasons on both cases, but it should be consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4517) Build tests in the same build phase all over components

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326786#comment-15326786
 ] 

ASF GitHub Bot commented on TS-4517:


Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/702
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/225/ for details.
 



> Build tests in the same build phase all over components
> ---
>
> Key: TS-4517
> URL: https://issues.apache.org/jira/browse/TS-4517
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Masakazu Kitajo
>Assignee: Masakazu Kitajo
> Fix For: 7.0.0
>
>
> Currently, tests for H2 are built during normal build phase but others are 
> not built until you run "make check".
> There may be reasons on both cases, but it should be consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4517) Build tests in the same build phase all over components

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326783#comment-15326783
 ] 

ASF GitHub Bot commented on TS-4517:


GitHub user maskit opened a pull request:

https://github.com/apache/trafficserver/pull/702

TS-4517: Build tests during "make check" phase

https://issues.apache.org/jira/browse/TS-4517 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maskit/trafficserver ts4517

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/702.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #702


commit 075c0959974f60fca632611373a73871b8247a11
Author: Masakazu Kitajo 
Date:   2016-06-11T03:46:26Z

TS-4517: Build tests during "make check" phase




> Build tests in the same build phase all over components
> ---
>
> Key: TS-4517
> URL: https://issues.apache.org/jira/browse/TS-4517
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Masakazu Kitajo
>Assignee: Masakazu Kitajo
> Fix For: 7.0.0
>
>
> Currently, tests for H2 are built during normal build phase but others are 
> not built until you run "make check".
> There may be reasons on both cases, but it should be consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4521) compile error on build proxy/http2/test_HPACK

2016-06-12 Thread Masakazu Kitajo (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326782#comment-15326782
 ] 

Masakazu Kitajo commented on TS-4521:
-

The change makes sense. Could you try @LIBTCL@ instead of @TCL_LIB_SPEC@ ? It 
should work too, and it is what we use in other "Makefile.am"s. 

> compile error on build proxy/http2/test_HPACK
> -
>
> Key: TS-4521
> URL: https://issues.apache.org/jira/browse/TS-4521
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Oknet Xu
>Assignee: Masakazu Kitajo
> Fix For: 7.0.0
>
>
> OS: Debian 7 (wheezy)
> ATS Branch: master
> GCC: 4.7.2(Debian 4.7.2-5)
> {code}
> /usr/bin/ld: ../../proxy/hdrs/libhdrs.a(HttpCompat.o): undefined reference to 
> symbol 'Tcl_NextHashEntry'
> /usr/bin/ld: note: 'Tcl_NextHashEntry' is defined in DSO 
> /usr/lib/libtcl8.5.so.0 so try adding it to the linker command line
> /usr/lib/libtcl8.5.so.0: could not read symbols: Invalid operation
> collect2: error: ld returned 1 exit status
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (TS-4521) compile error on build proxy/http2/test_HPACK

2016-06-12 Thread Masakazu Kitajo (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masakazu Kitajo reassigned TS-4521:
---

Assignee: Masakazu Kitajo

> compile error on build proxy/http2/test_HPACK
> -
>
> Key: TS-4521
> URL: https://issues.apache.org/jira/browse/TS-4521
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Oknet Xu
>Assignee: Masakazu Kitajo
> Fix For: 7.0.0
>
>
> OS: Debian 7 (wheezy)
> ATS Branch: master
> GCC: 4.7.2(Debian 4.7.2-5)
> {code}
> /usr/bin/ld: ../../proxy/hdrs/libhdrs.a(HttpCompat.o): undefined reference to 
> symbol 'Tcl_NextHashEntry'
> /usr/bin/ld: note: 'Tcl_NextHashEntry' is defined in DSO 
> /usr/lib/libtcl8.5.so.0 so try adding it to the linker command line
> /usr/lib/libtcl8.5.so.0: could not read symbols: Invalid operation
> collect2: error: ld returned 1 exit status
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326775#comment-15326775
 ] 

ASF GitHub Bot commented on TS-4522:


Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
@jpeach ECONNRESET is only found in man 2 send/sendto/sendmsg. obviously 
EPIPE for write() the same as ECONNRESET for send()/sendto()/sendmsg(). And 
write() is called in load_buffer_and_write().


> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326755#comment-15326755
 ] 

ASF GitHub Bot commented on TS-4522:


Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
@jpeach VC_EVENT_EOS indicates socket fd is closed. VC_EVENT_ERROR means 
meet a error and can not going on. Looking around the comment on 
I_VConnection.h about do_io_read and do_io_write. VC_EVENT_EOS is not 
introduced in do_io_write, only VC_EVENT_ERROR.

Is VC_EVENT_EOS callbacked only do_io_read first ?
Write to a closed fd then get -EPIPE and VC_EVENT_ERROR callbacked, is it 
right ?


> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326663#comment-15326663
 ] 

ASF GitHub Bot commented on TS-4522:


Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
This begs the question of why ``-ECONNRESET`` is treated as 
``VC_EVENT_EOS`` rather than ``VC_EVENT_ERROR``.


> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326472#comment-15326472
 ] 

ASF GitHub Bot commented on TS-4522:


Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/121/ for details.
 



> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326470#comment-15326470
 ] 

ASF GitHub Bot commented on TS-4522:


Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/224/ for details.
 



> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread Leif Hedstrom (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4522:
--
Assignee: Oknet Xu

> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread Leif Hedstrom (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4522:
--
Fix Version/s: 7.0.0

> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
> Fix For: 7.0.0
>
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TS-4521) compile error on build proxy/http2/test_HPACK

2016-06-12 Thread Leif Hedstrom (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4521:
--
Fix Version/s: 7.0.0

> compile error on build proxy/http2/test_HPACK
> -
>
> Key: TS-4521
> URL: https://issues.apache.org/jira/browse/TS-4521
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Oknet Xu
> Fix For: 7.0.0
>
>
> OS: Debian 7 (wheezy)
> ATS Branch: master
> GCC: 4.7.2(Debian 4.7.2-5)
> {code}
> /usr/bin/ld: ../../proxy/hdrs/libhdrs.a(HttpCompat.o): undefined reference to 
> symbol 'Tcl_NextHashEntry'
> /usr/bin/ld: note: 'Tcl_NextHashEntry' is defined in DSO 
> /usr/lib/libtcl8.5.so.0 so try adding it to the linker command line
> /usr/lib/libtcl8.5.so.0: could not read symbols: Invalid operation
> collect2: error: ld returned 1 exit status
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326465#comment-15326465
 ] 

ASF GitHub Bot commented on TS-4522:


Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
Jenkins workspaces in disarray due to previous failures (sigh), trying 
again. [approve ci].


> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326453#comment-15326453
 ] 

ASF GitHub Bot commented on TS-4522:


Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/120/ for details.
 



> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326451#comment-15326451
 ] 

ASF GitHub Bot commented on TS-4522:


Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/223/ for details.
 



> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326450#comment-15326450
 ] 

ASF GitHub Bot commented on TS-4522:


Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/701
  
[approve ci]


> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326431#comment-15326431
 ] 

ASF GitHub Bot commented on TS-4522:


GitHub user oknet opened a pull request:

https://github.com/apache/trafficserver/pull/701

TS-4522: check EPIPE instead r==0

man 2 write, Return value, On Success, the number of bytes written is 
returned (zero indicates nothing was written). On error, -1 is returned, and 
errno is set appropriately.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oknet/trafficserver patch-14

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/701.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #701


commit d381a2d4ea5511696484f278b9aa80e4bdea545f
Author: Oknet 
Date:   2016-06-12T13:08:47Z

TS-4522: check EPIPE instead r==0

man 2 write, Return value, On Success, the number of bytes written is 
returned (zero indicates nothing was written). On error, -1 is returned, and 
errno is set appropriately.




> did not check EPIPE on write_to_net_io
> --
>
> Key: TS-4522
> URL: https://issues.apache.org/jira/browse/TS-4522
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Network
>Reporter: Oknet Xu
>
> On a closed socket fd:
> read(socketfd) return 0
> write(socketfd) return EPIPE
> In the write_to_net_io, we check the return value of write() with the same 
> way to read().
> {code}
> if (!r || r == -ECONNRESET) {
> {code}
> The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
> VC_EVENT_ERROR instead. 
> full code here:
> {code}
>   int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);
>   if (total_written > 0) {
> NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
> s->vio.ndone += total_written;
>   }
>   // check for errors
>   if (r <= 0) { // if the socket was not ready,add to WaitList
> if (r == -EAGAIN || r == -ENOTCONN) {
>   NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
>   if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> vc->write.triggered = 0;
> nh->write_ready_list.remove(vc);
> write_reschedule(nh, vc);
>   }
>   if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> vc->read.triggered = 0;
> nh->read_ready_list.remove(vc);
> read_reschedule(nh, vc);
>   }
>   return;
> }
> if (!r || r == -ECONNRESET) {
>   vc->write.triggered = 0;
>   write_signal_done(VC_EVENT_EOS, nh, vc);
>   return;
> }
> vc->write.triggered = 0;
> write_signal_error(nh, vc, (int)-total_written);
> return;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (TS-4522) did not check EPIPE on write_to_net_io

2016-06-12 Thread Oknet Xu (JIRA)
Oknet Xu created TS-4522:


 Summary: did not check EPIPE on write_to_net_io
 Key: TS-4522
 URL: https://issues.apache.org/jira/browse/TS-4522
 Project: Traffic Server
  Issue Type: Bug
  Components: Core, Network
Reporter: Oknet Xu


On a closed socket fd:
read(socketfd) return 0
write(socketfd) return EPIPE

In the write_to_net_io, we check the return value of write() with the same way 
to read().

{code}
if (!r || r == -ECONNRESET) {
{code}

The bug makes no VC_EVENT_EOS callbacked while write_to_net_io, but 
VC_EVENT_ERROR instead. 

full code here:
{code}
  int64_t r = vc->load_buffer_and_write(towrite, buf, total_written, needs);

  if (total_written > 0) {
NET_SUM_DYN_STAT(net_write_bytes_stat, total_written);
s->vio.ndone += total_written;
  }

  // check for errors
  if (r <= 0) { // if the socket was not ready,add to WaitList
if (r == -EAGAIN || r == -ENOTCONN) {
  NET_INCREMENT_DYN_STAT(net_calls_to_write_nodata_stat);
  if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
vc->write.triggered = 0;
nh->write_ready_list.remove(vc);
write_reschedule(nh, vc);
  }
  if ((needs & EVENTIO_READ) == EVENTIO_READ) {
vc->read.triggered = 0;
nh->read_ready_list.remove(vc);
read_reschedule(nh, vc);
  }
  return;
}
if (!r || r == -ECONNRESET) {
  vc->write.triggered = 0;
  write_signal_done(VC_EVENT_EOS, nh, vc);
  return;
}
vc->write.triggered = 0;
write_signal_error(nh, vc, (int)-total_written);
return;
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (TS-4488) Segmentation fault at HttpSM::tunnel_handler_ua

2016-06-12 Thread Oknet Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326419#comment-15326419
 ] 

Oknet Xu edited comment on TS-4488 at 6/12/16 12:34 PM:


meet the similar crash, only has stack trace:
{code}
traffic_server: Segmentation fault (Address not mapped to object [(nil)])
traffic_server - STACK TRACE: 
/usr/bin/traffic_server(crash_logger_invoke(int, siginfo*, 
void*)+0xa2)[0x2ad121596e32]
/lib/x86_64-linux-gnu/libc.so.6(+0x321a0)[0x2ad1252711a0]
/usr/bin/traffic_server(HttpTunnel::consumer_handler(int, 
HttpTunnelConsumer*)+0xca)[0x2ad1216ab19a]
/usr/bin/traffic_server(HttpTunnel::main_handler(int, 
void*)+0x5e)[0x2ad1216ab58e]
/usr/bin/traffic_server(HttpSM::state_send_server_request_header(int, 
void*)+0xfd)[0x2ad12166ea9d]
/usr/bin/traffic_server(HttpSM::main_handler(int, void*)+0x80)[0x2ad12166cb10]
/usr/bin/traffic_server(UnixNetVConnection::mainEvent(int, 
Event*)+0x4e7)[0x2ad121808687]
/usr/bin/traffic_server(InactivityCop::check_inactivity(int, 
Event*)+0x287)[0x2ad1217fe8d7]
/usr/bin/traffic_server(EThread::process_event(Event*, 
int)+0x90)[0x2ad12182a020]
/usr/bin/traffic_server(EThread::execute()+0x69e)[0x2ad12182ac4e]
/usr/bin/traffic_server(+0x39938a)[0x2ad12182938a]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x6b50)[0x2ad1255d3b50]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x2ad12531d30d]{code}

{code}
traffic_server: Segmentation fault (Address not mapped to object [0x3d])
traffic_server - STACK TRACE: 
/usr/bin/traffic_server(crash_logger_invoke(int, siginfo*, 
void*)+0xa2)[0x2afd2459fe32]
/lib/x86_64-linux-gnu/libc.so.6(+0x321a0)[0x2afd2827a1a0]
/usr/bin/traffic_server(HttpSM::tunnel_handler_transform_write(int, 
HttpTunnelConsumer*)+0x1a4)[0x2afd24663f94]
/usr/bin/traffic_server(HttpTunnel::consumer_handler(int, 
HttpTunnelConsumer*)+0xaf)[0x2afd246b417f]
/usr/bin/traffic_server(HttpTunnel::main_handler(int, 
void*)+0x5e)[0x2afd246b458e]
/usr/lib/trafficserver/modules/skg-spe.so(+0xc179)[0x2afd7b2a1179]
/usr/bin/traffic_server(EThread::process_event(Event*, 
int)+0x90)[0x2afd24833020]
/usr/bin/traffic_server(EThread::execute()+0x67f)[0x2afd24833c2f]
/usr/bin/traffic_server(+0x39938a)[0x2afd2483238a]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x6b50)[0x2afd285dcb50]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x2afd2832630d]
traffic_server: using root directory '/usr'
{code}


was (Author: oknet):
meet the similar crash, only has stack trace:
{code}
traffic_server: Segmentation fault (Address not mapped to object [(nil)])
traffic_server - STACK TRACE: 
/usr/bin/traffic_server(_Z19crash_logger_invokeiP7siginfoPv+0xa2)[0x2ad121596e32]
/lib/x86_64-linux-gnu/libc.so.6(+0x321a0)[0x2ad1252711a0]
/usr/bin/traffic_server(_ZN10HttpTunnel16consumer_handlerEiP18HttpTunnelConsumer+0xca)[0x2ad1216ab19a]
/usr/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0x5e)[0x2ad1216ab58e]
/usr/bin/traffic_server(_ZN6HttpSM32state_send_server_request_headerEiPv+0xfd)[0x2ad12166ea9d]
/usr/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x80)[0x2ad12166cb10]
/usr/bin/traffic_server(_ZN18UnixNetVConnection9mainEventEiP5Event+0x4e7)[0x2ad121808687]
/usr/bin/traffic_server(_ZN13InactivityCop16check_inactivityEiP5Event+0x287)[0x2ad1217fe8d7]
/usr/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x90)[0x2ad12182a020]
/usr/bin/traffic_server(_ZN7EThread7executeEv+0x69e)[0x2ad12182ac4e]
/usr/bin/traffic_server(+0x39938a)[0x2ad12182938a]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x6b50)[0x2ad1255d3b50]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x2ad12531d30d]
{code}

{code}
traffic_server: Segmentation fault (Address not mapped to object [0x3d])
traffic_server - STACK TRACE: 
/usr/bin/traffic_server(_Z19crash_logger_invokeiP7siginfoPv+0xa2)[0x2afd2459fe32]
/lib/x86_64-linux-gnu/libc.so.6(+0x321a0)[0x2afd2827a1a0]
/usr/bin/traffic_server(_ZN6HttpSM30tunnel_handler_transform_writeEiP18HttpTunnelConsumer+0x1a4)[0x2afd24663f94]
/usr/bin/traffic_server(_ZN10HttpTunnel16consumer_handlerEiP18HttpTunnelConsumer+0xaf)[0x2afd246b417f]
/usr/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0x5e)[0x2afd246b458e]
/usr/lib/trafficserver/modules/skg-spe.so(+0xc179)[0x2afd7b2a1179]
/usr/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x90)[0x2afd24833020]
/usr/bin/traffic_server(_ZN7EThread7executeEv+0x67f)[0x2afd24833c2f]
/usr/bin/traffic_server(+0x39938a)[0x2afd2483238a]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x6b50)[0x2afd285dcb50]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x2afd2832630d]
traffic_server: using root directory '/usr'
{code}

> Segmentation fault at HttpSM::tunnel_handler_ua
> ---
>
> Key: TS-4488
> URL: https://issues.apache.org/jira/browse/TS-4488
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Pavlo Yatsukhnenko
>Assignee: Pavlo Yatsukhnenko

[jira] [Commented] (TS-4488) Segmentation fault at HttpSM::tunnel_handler_ua

2016-06-12 Thread Oknet Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326419#comment-15326419
 ] 

Oknet Xu commented on TS-4488:
--

meet the similar crash, only has stack trace:
{code}
traffic_server: Segmentation fault (Address not mapped to object [(nil)])
traffic_server - STACK TRACE: 
/usr/bin/traffic_server(_Z19crash_logger_invokeiP7siginfoPv+0xa2)[0x2ad121596e32]
/lib/x86_64-linux-gnu/libc.so.6(+0x321a0)[0x2ad1252711a0]
/usr/bin/traffic_server(_ZN10HttpTunnel16consumer_handlerEiP18HttpTunnelConsumer+0xca)[0x2ad1216ab19a]
/usr/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0x5e)[0x2ad1216ab58e]
/usr/bin/traffic_server(_ZN6HttpSM32state_send_server_request_headerEiPv+0xfd)[0x2ad12166ea9d]
/usr/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x80)[0x2ad12166cb10]
/usr/bin/traffic_server(_ZN18UnixNetVConnection9mainEventEiP5Event+0x4e7)[0x2ad121808687]
/usr/bin/traffic_server(_ZN13InactivityCop16check_inactivityEiP5Event+0x287)[0x2ad1217fe8d7]
/usr/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x90)[0x2ad12182a020]
/usr/bin/traffic_server(_ZN7EThread7executeEv+0x69e)[0x2ad12182ac4e]
/usr/bin/traffic_server(+0x39938a)[0x2ad12182938a]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x6b50)[0x2ad1255d3b50]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x2ad12531d30d]
{code}

{code}
traffic_server: Segmentation fault (Address not mapped to object [0x3d])
traffic_server - STACK TRACE: 
/usr/bin/traffic_server(_Z19crash_logger_invokeiP7siginfoPv+0xa2)[0x2afd2459fe32]
/lib/x86_64-linux-gnu/libc.so.6(+0x321a0)[0x2afd2827a1a0]
/usr/bin/traffic_server(_ZN6HttpSM30tunnel_handler_transform_writeEiP18HttpTunnelConsumer+0x1a4)[0x2afd24663f94]
/usr/bin/traffic_server(_ZN10HttpTunnel16consumer_handlerEiP18HttpTunnelConsumer+0xaf)[0x2afd246b417f]
/usr/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0x5e)[0x2afd246b458e]
/usr/lib/trafficserver/modules/skg-spe.so(+0xc179)[0x2afd7b2a1179]
/usr/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x90)[0x2afd24833020]
/usr/bin/traffic_server(_ZN7EThread7executeEv+0x67f)[0x2afd24833c2f]
/usr/bin/traffic_server(+0x39938a)[0x2afd2483238a]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x6b50)[0x2afd285dcb50]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x2afd2832630d]
traffic_server: using root directory '/usr'
{code}

> Segmentation fault at HttpSM::tunnel_handler_ua
> ---
>
> Key: TS-4488
> URL: https://issues.apache.org/jira/browse/TS-4488
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Pavlo Yatsukhnenko
>Assignee: Pavlo Yatsukhnenko
>  Labels: Crash
> Fix For: 7.0.0
>
>
> From Github PR #674



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4488) Segmentation fault at HttpSM::tunnel_handler_ua

2016-06-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326402#comment-15326402
 ] 

ASF GitHub Bot commented on TS-4488:


Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/700
  
maybe should add EPIPE check?
```
if (!r || r == -ECONNRESET || r == -EPIPE) {   // SIGPIPE when write on 
a closed fd.
  vc->write.triggered = 0;
  write_signal_done(VC_EVENT_EOS, nh, vc);
  return;
}
vc->write.triggered = 0;
write_signal_error(nh, vc, (int)-total_written);
return;
```

make the iocore callback with EOS



> Segmentation fault at HttpSM::tunnel_handler_ua
> ---
>
> Key: TS-4488
> URL: https://issues.apache.org/jira/browse/TS-4488
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Pavlo Yatsukhnenko
>Assignee: Pavlo Yatsukhnenko
>  Labels: Crash
> Fix For: 7.0.0
>
>
> From Github PR #674



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)