[jira] [Created] (TS-4659) log format errors on startup

[James Peach (JIRA)]

James Peach created TS-4659:
---

 Summary: log format errors on startup
 Key: TS-4659
 URL: https://issues.apache.org/jira/browse/TS-4659
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Reporter: James Peach


Seeing these errors at startup:

{noformat}
[Jul 13 22:47:14.896] Server {0x77fde840} NOTE:  'Interval' attribute missing for LogFormat object 
squid_seconds_only_timestamp that contains aggregate operators: % % 
% %/% % % % % %/% %
[Jul 13 22:47:14.896] Server {0x77fde840} NOTE:  'Interval' attribute missing for LogFormat object squid 
that contains aggregate operators: % % % %/% 
% % % % %/% %
[Jul 13 22:47:14.896] Server {0x77fde840} NOTE:  'Interval' attribute missing for LogFormat object common 
that contains aggregate operators: % - % [%] "%" % 
%
[Jul 13 22:47:14.896] Server {0x77fde840} NOTE:  'Interval' attribute missing for LogFormat object 
extended that contains aggregate operators: % - % [%] 
"%" % % % % % % % % 
% % %
[Jul 13 22:47:14.896] Server {0x77fde840} NOTE:  'Interval' attribute missing for LogFormat object 
extended2 that contains aggregate operators: % - % [%] 
"%" % % % % % % % % 
% % % % % % %
[Jul 13 22:47:14.896] Server {0x77fde840} WARNING:  Format squid not in the global format list; cannot 
create LogObject
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4658) Why is TSSslVConnOp API?

[James Peach (JIRA)]

James Peach created TS-4658:
---

 Summary: Why is TSSslVConnOp API?
 Key: TS-4658
 URL: https://issues.apache.org/jira/browse/TS-4658
 Project: Traffic Server
  Issue Type: Bug
  Components: SSL, TS API
Reporter: James Peach


{{TSSslVConnOp}} is not used in any APIs; it is basically an internal flag to 
determine whether the core should terminate a TLS session or not. Let's remove 
it from API and make it internal to {{SSLNetVConnection}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4657) SNI hook sends hook ID for events

[James Peach (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376282#comment-15376282
 ] 

James Peach commented on TS-4657:
-

Ping [~shinrich]

> SNI hook sends hook ID for events
> -
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: TS API
>Reporter: James Peach
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}} 
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the 
> same value. One of these ought to be redundant.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4657) SNI hook sends hook ID for events

[James Peach (JIRA)]

James Peach created TS-4657:
---

 Summary: SNI hook sends hook ID for events
 Key: TS-4657
 URL: https://issues.apache.org/jira/browse/TS-4657
 Project: Traffic Server
  Issue Type: Improvement
  Components: TS API
Reporter: James Peach


If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}} 
values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.

It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the 
same value. One of these ought to be redundant.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Issue Comment Deleted] (TS-4656) document additional hook events

[Kit Chan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kit Chan updated TS-4656:
-
Comment: was deleted

(was: We did the documentation before for TS_HTTP_RESPONSE_CLIENT_HOOK in 
TS-3715)

> document additional hook events
> ---
>
> Key: TS-4656
> URL: https://issues.apache.org/jira/browse/TS-4656
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: James Peach
>
> The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
> missing documentation for which events and event data is provided some 
> events. I can see at definitions for at least the following are missing:
> * TS_HTTP_POST_REMAP_HOOK
> * TS_VCONN_PRE_ACCEPT_HOOK
> * TS_SSL_SNI_HOOK
> * TS_SSL_CERT_HOOK
> * TS_HTTP_RESPONSE_CLIENT_HOOK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4656) document additional hook events

[Kit Chan (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376261#comment-15376261
 ] 

Kit Chan commented on TS-4656:
--

We did the documentation before for TS_HTTP_RESPONSE_CLIENT_HOOK in TS-3715

> document additional hook events
> ---
>
> Key: TS-4656
> URL: https://issues.apache.org/jira/browse/TS-4656
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: James Peach
>
> The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
> missing documentation for which events and event data is provided some 
> events. I can see at definitions for at least the following are missing:
> * TS_HTTP_POST_REMAP_HOOK
> * TS_VCONN_PRE_ACCEPT_HOOK
> * TS_SSL_SNI_HOOK
> * TS_SSL_CERT_HOOK
> * TS_HTTP_RESPONSE_CLIENT_HOOK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4656) document additional hook events

[Kit Chan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kit Chan updated TS-4656:
-
Description: 
The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
missing documentation for which events and event data is provided some events. 
I can see at definitions for at least the following are missing:

* TS_HTTP_POST_REMAP_HOOK
* TS_VCONN_PRE_ACCEPT_HOOK
* TS_SSL_SNI_HOOK
* TS_SSL_CERT_HOOK
* TS_HTTP_RESPONSE_CLIENT_HOOK

  was:
The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
missing documentation for which events and event data is provided some events. 
I can see at definitions for at least the following are missing:

* TS_HTTP_POST_REMAP_HOOK
* TS_VCONN_PRE_ACCEPT_HOOK
* TS_SSL_SNI_HOOK
* TS_SSL_CERT_HOOK
*TS_HTTP_RESPONSE_CLIENT_HOOK


> document additional hook events
> ---
>
> Key: TS-4656
> URL: https://issues.apache.org/jira/browse/TS-4656
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: James Peach
>
> The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
> missing documentation for which events and event data is provided some 
> events. I can see at definitions for at least the following are missing:
> * TS_HTTP_POST_REMAP_HOOK
> * TS_VCONN_PRE_ACCEPT_HOOK
> * TS_SSL_SNI_HOOK
> * TS_SSL_CERT_HOOK
> * TS_HTTP_RESPONSE_CLIENT_HOOK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4656) document additional hook events

[James Peach (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Peach updated TS-4656:

Description: 
The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
missing documentation for which events and event data is provided some events. 
I can see at definitions for at least the following are missing:

* TS_HTTP_POST_REMAP_HOOK
* TS_VCONN_PRE_ACCEPT_HOOK
* TS_SSL_SNI_HOOK
* TS_SSL_CERT_HOOK
*TS_HTTP_RESPONSE_CLIENT_HOOK

  was:
The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
missing documentation for which events and event data is provided some events. 
I can see at definitions for at least the following are missing:

* TS_HTTP_POST_REMAP_HOOK
* TS_VCONN_PRE_ACCEPT_HOOK
* TS_SSL_SNI_HOOK
* TS_SSL_CERT_HOOK


> document additional hook events
> ---
>
> Key: TS-4656
> URL: https://issues.apache.org/jira/browse/TS-4656
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: James Peach
>
> The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
> missing documentation for which events and event data is provided some 
> events. I can see at definitions for at least the following are missing:
> * TS_HTTP_POST_REMAP_HOOK
> * TS_VCONN_PRE_ACCEPT_HOOK
> * TS_SSL_SNI_HOOK
> * TS_SSL_CERT_HOOK
> *TS_HTTP_RESPONSE_CLIENT_HOOK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (TS-4656) document additional hook events

[James Peach (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376220#comment-15376220
 ] 

James Peach edited comment on TS-4656 at 7/14/16 2:52 AM:
--

Ping [~shinrich] [~jsime] [~amc]


was (Author: jamespeach):
Ping [~shinrich] [~jsime]

> document additional hook events
> ---
>
> Key: TS-4656
> URL: https://issues.apache.org/jira/browse/TS-4656
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: James Peach
>
> The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
> missing documentation for which events and event data is provided some 
> events. I can see at definitions for at least the following are missing:
> * TS_HTTP_POST_REMAP_HOOK
> * TS_VCONN_PRE_ACCEPT_HOOK
> * TS_SSL_SNI_HOOK
> * TS_SSL_CERT_HOOK
> *TS_HTTP_RESPONSE_CLIENT_HOOK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4656) document additional hook events

[James Peach (JIRA)]

James Peach created TS-4656:
---

 Summary: document additional hook events
 Key: TS-4656
 URL: https://issues.apache.org/jira/browse/TS-4656
 Project: Traffic Server
  Issue Type: Improvement
  Components: Documentation
Reporter: James Peach


The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
missing documentation for which events and event data is provided some events. 
I can see at definitions for at least the following are missing:

* TS_HTTP_POST_REMAP_HOOK
* TS_VCONN_PRE_ACCEPT_HOOK
* TS_SSL_SNI_HOOK
* TS_SSL_CERT_HOOK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4656) document additional hook events

[James Peach (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376220#comment-15376220
 ] 

James Peach commented on TS-4656:
-

Ping [~shinrich] [~jsime]

> document additional hook events
> ---
>
> Key: TS-4656
> URL: https://issues.apache.org/jira/browse/TS-4656
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: James Peach
>
> The table in {{plugins/continuations/writing-handler-functions.en.rst}} is 
> missing documentation for which events and event data is provided some 
> events. I can see at definitions for at least the following are missing:
> * TS_HTTP_POST_REMAP_HOOK
> * TS_VCONN_PRE_ACCEPT_HOOK
> * TS_SSL_SNI_HOOK
> * TS_SSL_CERT_HOOK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4655) Remove SessionAccept pointer from SSLNetVConnection

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4655?focusedWorklogId=25467=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25467
 ]

ASF GitHub Bot logged work on TS-4655:
--

Author: ASF GitHub Bot
Created on: 14/Jul/16 02:07
Start Date: 14/Jul/16 02:07
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
:+1:


Issue Time Tracking
---

Worklog Id: (was: 25467)
Time Spent: 1h  (was: 50m)

> Remove SessionAccept pointer from SSLNetVConnection
> ---
>
> Key: TS-4655
> URL: https://issues.apache.org/jira/browse/TS-4655
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: SSL
>Reporter: James Peach
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> The {{SSLNetVConnection}} {{sessionAcceptPtr}} is never used. Remove the 
> accessors and the variable itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #795: TS-4655: Remove SessionAccept pointer from SSLNetV...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
:+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4655) Remove SessionAccept pointer from SSLNetVConnection

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4655?focusedWorklogId=25466=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25466
 ]

ASF GitHub Bot logged work on TS-4655:
--

Author: ASF GitHub Bot
Created on: 14/Jul/16 01:28
Start Date: 14/Jul/16 01:28
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/319/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25466)
Time Spent: 50m  (was: 40m)

> Remove SessionAccept pointer from SSLNetVConnection
> ---
>
> Key: TS-4655
> URL: https://issues.apache.org/jira/browse/TS-4655
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: SSL
>Reporter: James Peach
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The {{SSLNetVConnection}} {{sessionAcceptPtr}} is never used. Remove the 
> accessors and the variable itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #795: TS-4655: Remove SessionAccept pointer from SSLNetV...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/319/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4655) Remove SessionAccept pointer from SSLNetVConnection

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4655?focusedWorklogId=25465=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25465
 ]

ASF GitHub Bot logged work on TS-4655:
--

Author: ASF GitHub Bot
Created on: 14/Jul/16 01:25
Start Date: 14/Jul/16 01:25
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/425/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25465)
Time Spent: 40m  (was: 0.5h)

> Remove SessionAccept pointer from SSLNetVConnection
> ---
>
> Key: TS-4655
> URL: https://issues.apache.org/jira/browse/TS-4655
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: SSL
>Reporter: James Peach
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The {{SSLNetVConnection}} {{sessionAcceptPtr}} is never used. Remove the 
> accessors and the variable itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #795: TS-4655: Remove SessionAccept pointer from SSLNetV...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/425/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4655) Remove SessionAccept pointer from SSLNetVConnection

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4655?focusedWorklogId=25464=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25464
 ]

ASF GitHub Bot logged work on TS-4655:
--

Author: ASF GitHub Bot
Created on: 14/Jul/16 01:08
Start Date: 14/Jul/16 01:08
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/318/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25464)
Time Spent: 0.5h  (was: 20m)

> Remove SessionAccept pointer from SSLNetVConnection
> ---
>
> Key: TS-4655
> URL: https://issues.apache.org/jira/browse/TS-4655
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: SSL
>Reporter: James Peach
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The {{SSLNetVConnection}} {{sessionAcceptPtr}} is never used. Remove the 
> accessors and the variable itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #795: TS-4655: Remove SessionAccept pointer from SSLNetV...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/318/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4655) Remove SessionAccept pointer from SSLNetVConnection

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4655?focusedWorklogId=25463=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25463
 ]

ASF GitHub Bot logged work on TS-4655:
--

Author: ASF GitHub Bot
Created on: 14/Jul/16 01:02
Start Date: 14/Jul/16 01:02
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/424/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25463)
Time Spent: 20m  (was: 10m)

> Remove SessionAccept pointer from SSLNetVConnection
> ---
>
> Key: TS-4655
> URL: https://issues.apache.org/jira/browse/TS-4655
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: SSL
>Reporter: James Peach
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The {{SSLNetVConnection}} {{sessionAcceptPtr}} is never used. Remove the 
> accessors and the variable itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4652) ASAN issue in logging with gcc 6.1.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4652?focusedWorklogId=25462=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25462
 ]

ASF GitHub Bot logged work on TS-4652:
--

Author: ASF GitHub Bot
Created on: 14/Jul/16 01:01
Start Date: 14/Jul/16 01:01
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/794
  
This looks alright to me. The one part I'm a little concerned about is the 
changes to the dirent allocation, but I don't think there will be any problems 
with too-long filenames in practice.


Issue Time Tracking
---

Worklog Id: (was: 25462)
Time Spent: 1h 20m  (was: 1h 10m)

> ASAN issue in logging with gcc 6.1.1
> 
>
> Key: TS-4652
> URL: https://issues.apache.org/jira/browse/TS-4652
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Doesn't happen all the time, but enough to make it difficult to do 
> development:
> {code}
> [bcall@homer trafficserver]$ sudo /usr/local/bin/traffic_server
> traffic_server: using root directory '/usr/local'
> =
> ==13717==ERROR: AddressSanitizer: heap-buffer-overflow on address 
> 0x6164fa98 at pc 0x7fe847e44a41 bp 0x7ffdb0ec75b0 sp 0x7ffdb0ec6d28
> READ of size 518 at 0x6164fa98 thread T0
> #0 0x7fe847e44a40  (/lib64/libasan.so.3+0x8ea40)
> #1 0x7fe847e46cad in __interceptor_vsnprintf (/lib64/libasan.so.3+0x90cad)
> #2 0x7fe847e47030 in __interceptor_snprintf (/lib64/libasan.so.3+0x91030)
> #3 0x8cfc63 in LogConfig::update_space_used() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:786
> #4 0x8da373 in LogConfig::init(LogConfig*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:392
> #5 0x499024 in main 
> /home/bcall/dev/apache/trafficserver/proxy/Main.cc:1833
> #6 0x7fe844d8e730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> #7 0x4a9898 in _start (/usr/local/bin/traffic_server+0x4a9898)
> 0x6164fa98 is located 0 bytes to the right of 536-byte region 
> [0x6164f880,0x6164fa98)
> allocated by thread T14 ([LOG_FLUSH]) here:
> #0 0x7fe847e7ce20 in malloc (/lib64/libasan.so.3+0xc6e20)
> #1 0x7fe847b850d5 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x8d0dec in LogConfig::update_space_used() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:774
> #3 0x8b2bd4 in Log::periodic_tasks(long) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:239
> #4 0x8b4fd2 in Log::flush_thread_main(void*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:1308
> #5 0x8bdbcc in LoggingFlushContinuation::mainEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:292
> #6 0xd078a9 in Continuation::handleEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/I_Continuation.h:153
> #7 0xd078a9 in EThread::execute() 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:298
> #8 0xd04f69 in spawn_thread_internal 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/Thread.cc:84
> #9 0x7fe845f4d5c9 in start_thread (/lib64/libpthread.so.0+0x75c9)
> Thread T14 ([LOG_FLUSH]) created by T0 here:
> #0 0x7fe847de7458 in pthread_create (/lib64/libasan.so.3+0x31458)
> #1 0xd05b7c in ink_thread_create ../../lib/ts/ink_thread.h:147
> #2 0xd05b7c in Thread::start(char const*, unsigned long, void* 
> (*)(void*), void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/Thread.cc:99
> #3 0xd0e705 in EventProcessor::spawn_thread(Continuation*, char const*, 
> unsigned long) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEventProcessor.cc:184
> #4 0x8b69bd in Log::create_threads() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:999
> #5 0x8bbd2e in Log::init_when_enabled() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:957
> #6 0x8bca83 in Log::init(int) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:925
> #7 0x499024 in main 
> /home/bcall/dev/apache/trafficserver/proxy/Main.cc:1833
> #8 0x7fe844d8e730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.3+0x8ea40)
> Shadow bytes around the buggy address:
>   0x0c2c80001f00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c2c80001f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c2c80001f20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   

[GitHub] trafficserver issue #794: TS-4652: ASAN issue in logging with gcc 6.1.1

[jpeach]

Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/794
  
This looks alright to me. The one part I'm a little concerned about is the 
changes to the dirent allocation, but I don't think there will be any problems 
with too-long filenames in practice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #795: TS-4655: Remove SessionAccept pointer from SSLNetV...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/795
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/424/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4655) Remove SessionAccept pointer from SSLNetVConnection

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4655?focusedWorklogId=25461=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25461
 ]

ASF GitHub Bot logged work on TS-4655:
--

Author: ASF GitHub Bot
Created on: 14/Jul/16 00:56
Start Date: 14/Jul/16 00:56
Worklog Time Spent: 10m 
  Work Description: GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/795

TS-4655: Remove SessionAccept pointer from SSLNetVConnection.

SSLNetVConnection never uses the SessionAccept pointer, so remove
it and the associated setter and getter. Tidy up the SSLNetVConnection
formatting a little.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver fix/4655

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #795


commit 1e65a1de80e81cdb6cb59919506c4a71f4cc6af3
Author: James Peach 
Date:   2016-07-14T00:53:28Z

TS-4655: Remove SessionAccept pointer from SSLNetVConnection.

SSLNetVConnection never uses the SessionAccept pointer, so remove
it and the associated setter and getter. Tidy up the SSLNetVConnection
formatting a little.




Issue Time Tracking
---

Worklog Id: (was: 25461)
Time Spent: 10m
Remaining Estimate: 0h

> Remove SessionAccept pointer from SSLNetVConnection
> ---
>
> Key: TS-4655
> URL: https://issues.apache.org/jira/browse/TS-4655
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: SSL
>Reporter: James Peach
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{SSLNetVConnection}} {{sessionAcceptPtr}} is never used. Remove the 
> accessors and the variable itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #795: TS-4655: Remove SessionAccept pointer from ...

[jpeach]

GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/795

TS-4655: Remove SessionAccept pointer from SSLNetVConnection.

SSLNetVConnection never uses the SessionAccept pointer, so remove
it and the associated setter and getter. Tidy up the SSLNetVConnection
formatting a little.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver fix/4655

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #795


commit 1e65a1de80e81cdb6cb59919506c4a71f4cc6af3
Author: James Peach 
Date:   2016-07-14T00:53:28Z

TS-4655: Remove SessionAccept pointer from SSLNetVConnection.

SSLNetVConnection never uses the SessionAccept pointer, so remove
it and the associated setter and getter. Tidy up the SSLNetVConnection
formatting a little.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TS-4655) Remove SessionAccept pointer from SSLNetVConnection

[James Peach (JIRA)]

James Peach created TS-4655:
---

 Summary: Remove SessionAccept pointer from SSLNetVConnection
 Key: TS-4655
 URL: https://issues.apache.org/jira/browse/TS-4655
 Project: Traffic Server
  Issue Type: Improvement
  Components: SSL
Reporter: James Peach


The {{SSLNetVConnection}} {{sessionAcceptPtr}} is never used. Remove the 
accessors and the variable itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4654) Incorporate proxy/Test tests

[James Peach (JIRA)]

James Peach created TS-4654:
---

 Summary: Incorporate proxy/Test tests
 Key: TS-4654
 URL: https://issues.apache.org/jira/browse/TS-4654
 Project: Traffic Server
  Issue Type: Improvement
  Components: Tests
Reporter: James Peach


There are some additional tests in the proxy directory. We should examine these 
to see which ones we should integrate into the regression tests. Anything we 
don't integrate we should delete.

{noformat}
trafficserver.git jpeach$ ls proxy/Test*
proxy/TestClock.cc  proxy/TestPreProc.cc
proxy/TestRegex.cc
proxy/TestClusterHash.ccproxy/TestPreProc.h 
proxy/TestSimpleProxy.cc
proxy/TestDNS.ccproxy/TestProxy.cc
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

[Kit Chan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on TS-4653 started by Kit Chan.

> ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally
> 
>
> Key: TS-4653
> URL: https://issues.apache.org/jira/browse/TS-4653
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Kit Chan
>Assignee: Kit Chan
> Fix For: 7.0.0
>
>
> In the ESI spec, we can print out cookie information with $HTTP_COOKIE. This 
> can be problematic and unintentionally print out sensitive info on a web page.
> We should have mechanism to disable this by default and allow us to fine tune 
> it so we can choose to expose this functionality for only the cookie that we 
> allow 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4617) separate documentation language/version selections into central config

[Jon Sime (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jon Sime updated TS-4617:
-
Backport to Version: 5.3.2, 6.2.4

> separate documentation language/version selections into central config
> --
>
> Key: TS-4617
> URL: https://issues.apache.org/jira/browse/TS-4617
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Jon Sime
>Assignee: Jon Sime
> Fix For: Docs
>
>
> Adding a new release, or a language, to the documentation should not require 
> backporting thatsphinx template change to all prior releases (as it currently 
> does). Storing the list of valid languages and versions in a central config 
> that can be magicked in by a little bit of javascript (common to all 
> releases' documentation templates) would let us avoid perpetual backporting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4617) separate documentation language/version selections into central config

[Jon Sime (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375620#comment-15375620
 ] 

Jon Sime commented on TS-4617:
--

Merged 
https://github.com/apache/trafficserver/commit/bffb3dd4b68a0a6568f956944f01b68e6efb926a
 which supports release-branch neutral configurations of available 
languages/versions for documentation. Falls back to a local docbuild compatible 
path so that the switcher will work seamlessly for both our official public 
docs site and any local working copies for people editing the docs.

The commit above will need to be backported to our previous release branches 
(at least the ones we do docbuilds for), but then we shouldn't have to touch 
those branches again when we add new releases, or even new languages.

> separate documentation language/version selections into central config
> --
>
> Key: TS-4617
> URL: https://issues.apache.org/jira/browse/TS-4617
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Jon Sime
>Assignee: Jon Sime
> Fix For: Docs
>
>
> Adding a new release, or a language, to the documentation should not require 
> backporting thatsphinx template change to all prior releases (as it currently 
> does). Storing the list of valid languages and versions in a central config 
> that can be magicked in by a little bit of javascript (common to all 
> releases' documentation templates) would let us avoid perpetual backporting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (TS-4617) separate documentation language/version selections into central config

[Jon Sime (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on TS-4617 started by Jon Sime.

> separate documentation language/version selections into central config
> --
>
> Key: TS-4617
> URL: https://issues.apache.org/jira/browse/TS-4617
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Jon Sime
>Assignee: Jon Sime
> Fix For: Docs
>
>
> Adding a new release, or a language, to the documentation should not require 
> backporting thatsphinx template change to all prior releases (as it currently 
> does). Storing the list of valid languages and versions in a central config 
> that can be magicked in by a little bit of javascript (common to all 
> releases' documentation templates) would let us avoid perpetual backporting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-4617) separate documentation language/version selections into central config

[Jon Sime (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jon Sime resolved TS-4617.
--
Resolution: Fixed

> separate documentation language/version selections into central config
> --
>
> Key: TS-4617
> URL: https://issues.apache.org/jira/browse/TS-4617
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Jon Sime
>Assignee: Jon Sime
> Fix For: Docs
>
>
> Adding a new release, or a language, to the documentation should not require 
> backporting thatsphinx template change to all prior releases (as it currently 
> does). Storing the list of valid languages and versions in a central config 
> that can be magicked in by a little bit of javascript (common to all 
> releases' documentation templates) would let us avoid perpetual backporting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

[Kit Chan (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375600#comment-15375600
 ] 

Kit Chan commented on TS-4653:
--

will put a patch out soon.

> ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally
> 
>
> Key: TS-4653
> URL: https://issues.apache.org/jira/browse/TS-4653
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Kit Chan
>Assignee: Kit Chan
> Fix For: 7.0.0
>
>
> In the ESI spec, we can print out cookie information with $HTTP_COOKIE. This 
> can be problematic and unintentionally print out sensitive info on a web page.
> We should have mechanism to disable this by default and allow us to fine tune 
> it so we can choose to expose this functionality for only the cookie that we 
> allow 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

[Kit Chan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kit Chan reassigned TS-4653:


Assignee: Kit Chan

> ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally
> 
>
> Key: TS-4653
> URL: https://issues.apache.org/jira/browse/TS-4653
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Kit Chan
>Assignee: Kit Chan
> Fix For: 7.0.0
>
>
> In the ESI spec, we can print out cookie information with $HTTP_COOKIE. This 
> can be problematic and unintentionally print out sensitive info on a web page.
> We should have mechanism to disable this by default and allow us to fine tune 
> it so we can choose to expose this functionality for only the cookie that we 
> allow 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

[Kit Chan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kit Chan updated TS-4653:
-
Fix Version/s: 7.0.0

> ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally
> 
>
> Key: TS-4653
> URL: https://issues.apache.org/jira/browse/TS-4653
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Kit Chan
>Assignee: Kit Chan
> Fix For: 7.0.0
>
>
> In the ESI spec, we can print out cookie information with $HTTP_COOKIE. This 
> can be problematic and unintentionally print out sensitive info on a web page.
> We should have mechanism to disable this by default and allow us to fine tune 
> it so we can choose to expose this functionality for only the cookie that we 
> allow 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

[Kit Chan (JIRA)]

Kit Chan created TS-4653:


 Summary: ESI plugin - $HTTP_COOKIE can leak important cookie info 
unintentionally
 Key: TS-4653
 URL: https://issues.apache.org/jira/browse/TS-4653
 Project: Traffic Server
  Issue Type: Bug
  Components: Plugins
Reporter: Kit Chan


In the ESI spec, we can print out cookie information with $HTTP_COOKIE. This 
can be problematic and unintentionally print out sensitive info on a web page.

We should have mechanism to disable this by default and allow us to fine tune 
it so we can choose to expose this functionality for only the cookie that we 
allow 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4652) ASAN issue in logging with gcc 6.1.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4652?focusedWorklogId=25460=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25460
 ]

ASF GitHub Bot logged work on TS-4652:
--

Author: ASF GitHub Bot
Created on: 13/Jul/16 19:08
Start Date: 13/Jul/16 19:08
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/794
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/317/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25460)
Time Spent: 1h 10m  (was: 1h)

> ASAN issue in logging with gcc 6.1.1
> 
>
> Key: TS-4652
> URL: https://issues.apache.org/jira/browse/TS-4652
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Doesn't happen all the time, but enough to make it difficult to do 
> development:
> {code}
> [bcall@homer trafficserver]$ sudo /usr/local/bin/traffic_server
> traffic_server: using root directory '/usr/local'
> =
> ==13717==ERROR: AddressSanitizer: heap-buffer-overflow on address 
> 0x6164fa98 at pc 0x7fe847e44a41 bp 0x7ffdb0ec75b0 sp 0x7ffdb0ec6d28
> READ of size 518 at 0x6164fa98 thread T0
> #0 0x7fe847e44a40  (/lib64/libasan.so.3+0x8ea40)
> #1 0x7fe847e46cad in __interceptor_vsnprintf (/lib64/libasan.so.3+0x90cad)
> #2 0x7fe847e47030 in __interceptor_snprintf (/lib64/libasan.so.3+0x91030)
> #3 0x8cfc63 in LogConfig::update_space_used() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:786
> #4 0x8da373 in LogConfig::init(LogConfig*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:392
> #5 0x499024 in main 
> /home/bcall/dev/apache/trafficserver/proxy/Main.cc:1833
> #6 0x7fe844d8e730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> #7 0x4a9898 in _start (/usr/local/bin/traffic_server+0x4a9898)
> 0x6164fa98 is located 0 bytes to the right of 536-byte region 
> [0x6164f880,0x6164fa98)
> allocated by thread T14 ([LOG_FLUSH]) here:
> #0 0x7fe847e7ce20 in malloc (/lib64/libasan.so.3+0xc6e20)
> #1 0x7fe847b850d5 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x8d0dec in LogConfig::update_space_used() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:774
> #3 0x8b2bd4 in Log::periodic_tasks(long) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:239
> #4 0x8b4fd2 in Log::flush_thread_main(void*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:1308
> #5 0x8bdbcc in LoggingFlushContinuation::mainEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:292
> #6 0xd078a9 in Continuation::handleEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/I_Continuation.h:153
> #7 0xd078a9 in EThread::execute() 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:298
> #8 0xd04f69 in spawn_thread_internal 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/Thread.cc:84
> #9 0x7fe845f4d5c9 in start_thread (/lib64/libpthread.so.0+0x75c9)
> Thread T14 ([LOG_FLUSH]) created by T0 here:
> #0 0x7fe847de7458 in pthread_create (/lib64/libasan.so.3+0x31458)
> #1 0xd05b7c in ink_thread_create ../../lib/ts/ink_thread.h:147
> #2 0xd05b7c in Thread::start(char const*, unsigned long, void* 
> (*)(void*), void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/Thread.cc:99
> #3 0xd0e705 in EventProcessor::spawn_thread(Continuation*, char const*, 
> unsigned long) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEventProcessor.cc:184
> #4 0x8b69bd in Log::create_threads() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:999
> #5 0x8bbd2e in Log::init_when_enabled() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:957
> #6 0x8bca83 in Log::init(int) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:925
> #7 0x499024 in main 
> /home/bcall/dev/apache/trafficserver/proxy/Main.cc:1833
> #8 0x7fe844d8e730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.3+0x8ea40)
> Shadow bytes around the buggy address:
>   0x0c2c80001f00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c2c80001f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c2c80001f20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c2c80001f30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c2c80001f40: 00 00 00 

[GitHub] trafficserver issue #794: TS-4652: ASAN issue in logging with gcc 6.1.1

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/794
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/317/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4652) ASAN issue in logging with gcc 6.1.1

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4652?focusedWorklogId=25459=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25459
 ]

ASF GitHub Bot logged work on TS-4652:
--

Author: ASF GitHub Bot
Created on: 13/Jul/16 19:08
Start Date: 13/Jul/16 19:08
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/794
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/423/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 25459)
Time Spent: 1h  (was: 50m)

> ASAN issue in logging with gcc 6.1.1
> 
>
> Key: TS-4652
> URL: https://issues.apache.org/jira/browse/TS-4652
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Doesn't happen all the time, but enough to make it difficult to do 
> development:
> {code}
> [bcall@homer trafficserver]$ sudo /usr/local/bin/traffic_server
> traffic_server: using root directory '/usr/local'
> =
> ==13717==ERROR: AddressSanitizer: heap-buffer-overflow on address 
> 0x6164fa98 at pc 0x7fe847e44a41 bp 0x7ffdb0ec75b0 sp 0x7ffdb0ec6d28
> READ of size 518 at 0x6164fa98 thread T0
> #0 0x7fe847e44a40  (/lib64/libasan.so.3+0x8ea40)
> #1 0x7fe847e46cad in __interceptor_vsnprintf (/lib64/libasan.so.3+0x90cad)
> #2 0x7fe847e47030 in __interceptor_snprintf (/lib64/libasan.so.3+0x91030)
> #3 0x8cfc63 in LogConfig::update_space_used() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:786
> #4 0x8da373 in LogConfig::init(LogConfig*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:392
> #5 0x499024 in main 
> /home/bcall/dev/apache/trafficserver/proxy/Main.cc:1833
> #6 0x7fe844d8e730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> #7 0x4a9898 in _start (/usr/local/bin/traffic_server+0x4a9898)
> 0x6164fa98 is located 0 bytes to the right of 536-byte region 
> [0x6164f880,0x6164fa98)
> allocated by thread T14 ([LOG_FLUSH]) here:
> #0 0x7fe847e7ce20 in malloc (/lib64/libasan.so.3+0xc6e20)
> #1 0x7fe847b850d5 in ats_malloc 
> /home/bcall/dev/apache/trafficserver/lib/ts/ink_memory.cc:59
> #2 0x8d0dec in LogConfig::update_space_used() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/LogConfig.cc:774
> #3 0x8b2bd4 in Log::periodic_tasks(long) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:239
> #4 0x8b4fd2 in Log::flush_thread_main(void*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:1308
> #5 0x8bdbcc in LoggingFlushContinuation::mainEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:292
> #6 0xd078a9 in Continuation::handleEvent(int, void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/I_Continuation.h:153
> #7 0xd078a9 in EThread::execute() 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEThread.cc:298
> #8 0xd04f69 in spawn_thread_internal 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/Thread.cc:84
> #9 0x7fe845f4d5c9 in start_thread (/lib64/libpthread.so.0+0x75c9)
> Thread T14 ([LOG_FLUSH]) created by T0 here:
> #0 0x7fe847de7458 in pthread_create (/lib64/libasan.so.3+0x31458)
> #1 0xd05b7c in ink_thread_create ../../lib/ts/ink_thread.h:147
> #2 0xd05b7c in Thread::start(char const*, unsigned long, void* 
> (*)(void*), void*) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/Thread.cc:99
> #3 0xd0e705 in EventProcessor::spawn_thread(Continuation*, char const*, 
> unsigned long) 
> /home/bcall/dev/apache/trafficserver/iocore/eventsystem/UnixEventProcessor.cc:184
> #4 0x8b69bd in Log::create_threads() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:999
> #5 0x8bbd2e in Log::init_when_enabled() 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:957
> #6 0x8bca83 in Log::init(int) 
> /home/bcall/dev/apache/trafficserver/proxy/logging/Log.cc:925
> #7 0x499024 in main 
> /home/bcall/dev/apache/trafficserver/proxy/Main.cc:1833
> #8 0x7fe844d8e730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.3+0x8ea40)
> Shadow bytes around the buggy address:
>   0x0c2c80001f00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
>   0x0c2c80001f10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c2c80001f20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c2c80001f30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   0x0c2c80001f40: 00 00 00 00 

[GitHub] trafficserver issue #794: TS-4652: ASAN issue in logging with gcc 6.1.1

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/794
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/423/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (TS-4147) Allow gzip plugin to be a remap plugin

[Miles Libbey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miles Libbey closed TS-4147.


now can do:

map http://example.com http://origin.example.com \
  @plugin=gzip.so @pparam=gzip.conf

with gzip.conf:
compressible-content-type text/*

> Allow gzip plugin to be a remap plugin
> --
>
> Key: TS-4147
> URL: https://issues.apache.org/jira/browse/TS-4147
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Miles Libbey
>Assignee: Meera Mosale Nataraja
> Fix For: 6.2.0, 7.0.0
>
>
> We'd like the gzip plugin to be allowed to be a remap plugin.  While the 
> current plugin has a config file that allows configuration by host, it does 
> not appear that the host patterns are as flexible as a remap rule.  For 
> instance:
> - regex_map. The config does not allow for regex matching.
> - regex_remap plugin. The config does allow for some path based wildcarding, 
> but only disallow (blacklist), no whitelist; and only simple wildcarding.
> If a minority of hosts have the gzip plugin enabled, there is unnecessary 
> overhead for the majority of requests.  Seems like it would be nice to only 
> do the evaluation when desired.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (TS-4625) 6.2 RC2 crashes immediately with Epic plugin installed

[Miles Libbey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miles Libbey closed TS-4625.


Tests with patch no longer show this issue.

> 6.2 RC2 crashes immediately with Epic plugin installed
> --
>
> Key: TS-4625
> URL: https://issues.apache.org/jira/browse/TS-4625
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Miles Libbey
>Assignee: Leif Hedstrom
> Fix For: 6.2.0, 7.0.0
>
>
> We think its an incompatibility with 
> https://github.com/apache/trafficserver/pull/603/files



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)