[jira] [Work logged] (TS-4796) ATS not closing origin connections on first RST from client

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4796?focusedWorklogId=28050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28050
 ]

ASF GitHub Bot logged work on TS-4796:
--

Author: ASF GitHub Bot
Created on: 03/Sep/16 06:34
Start Date: 03/Sep/16 06:34
Worklog Time Spent: 10m 
  Work Description: Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/947
  
comments for codes:
```
  if (get_ev_events(pd, x) & (EVENTIO_READ | EVENTIO_ERROR)) {
// ** set read.triggered if a epoll event of net has EVENTIO_READ 
or EVENTIO_ERROR bit set.
vc->read.triggered = 1;
// ** and put vc in read_ready_list
if (!read_ready_list.in(vc)) {
  read_ready_list.enqueue(vc);
} else if (get_ev_events(pd, x) & EVENTIO_ERROR) {
  // ** output an error message if a netvc already in ready_list 
got EVENTIO_ERROR.
  // check for unhandled epoll events that should be handled
  Debug("iocore_net_main", "Unhandled epoll event on read: 0x%04x 
read.enabled=%d closed=%d read.netready_queue=%d",
get_ev_events(pd, x), vc->read.enabled, vc->closed, 
read_ready_list.in(vc));
}
  }
```
The netvc always put in read_ready_list if it has EVENTIO_READ or 
EVENTIO_ERROR.

```
#if defined(USE_EDGE_TRIGGER)
  // UnixNetVConnection *
  // ** for each netvc in read_ready_list
  while ((vc = read_ready_list.dequeue())) {
if (vc->closed) // ** if the netvc mark closed
  close_UnixNetVConnection(vc, trigger_event->ethread);
else if (vc->read.enabled && vc->read.triggered) //** if the netvc is 
enabled and triggered
  vc->net_read_io(this, trigger_event->ethread);
else if (!vc->read.enabled) { //** if the netvc is not enabled
  read_ready_list.remove(vc);
#if defined(solaris)
  if (vc->read.triggered && vc->write.enabled) {
vc->ep.modify(-EVENTIO_READ);
vc->ep.refresh(EVENTIO_WRITE);
vc->writeReschedule(this);
  }   
#endif
}   
  }
```

for your case, read.enabled is 0
```
else if (!vc->read.enabled) { // if the netvc is not enabled
  read_ready_list.remove(vc);
```
The vc is removed from read_ready_list.

The below is my suggest:
```
  if (get_ev_events(pd, x) & (EVENTIO_READ | EVENTIO_ERROR)) {
vc->read.triggered = 1;
+  if (get_ev_events(pd, x) & EVENTIO_ERROR) {
+vc->read.error = 1;
+  }
if (!read_ready_list.in(vc)) {
  read_ready_list.enqueue(vc);
} else if (get_ev_events(pd, x) & EVENTIO_ERROR) {
```
and
```
else if (vc->read.enabled && vc->read.triggered) //** if the netvc is 
enabled and triggered
  vc->net_read_io(this, trigger_event->ethread);
+  else if (vc->read.error) {
+int err = 0, errlen = sizeof(int);
+if (getsockopt(fd, SOL_SOCKET, SO_ERROR, &err, &errlen) == -1) {
+  err = errno;
+}
+if (err != EAGAIN && err != EINTR)
+  vc->readSignalError(this, err);
+  }
else if (!vc->read.enabled) { //** if the netvc is not enabled
  read_ready_list.remove(vc);
#if defined(solaris)
  if (vc->read.triggered && vc->write.enabled) {
vc->ep.modify(-EVENTIO_READ);
vc->ep.refresh(EVENTIO_WRITE);
```




Issue Time Tracking
---

Worklog Id: (was: 28050)
Time Spent: 3.5h  (was: 3h 20m)

> ATS not closing origin connections on first RST from client
> ---
>
> Key: TS-4796
> URL: https://issues.apache.org/jira/browse/TS-4796
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP
>Reporter: Thomas Jackson
>Assignee: Thomas Jackson
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> *TLDR; similar to TS-4720 -- slower to close than it should, instead of never 
> closing*
> As a continuation of TS-4720, while testing that the session is closed when 
> we expect-- I found that it isn't.
> Although we are now closing the sessions, we aren't doing it as quickly as we 
> should. In this client abort case we expect the client to abort, and ATS 
> should initially continue to send bytes to the client-- as we are in the 
> half-open state. After the first set of bytes are sent to the client-- the 
> client will send an RST-- which should signal ATS to stop sending the request 
> (and tear down the origin connection etc.).
> I'm able to reproduce this locally, and the debug output (with some 
> additional comments) looks like below:
> {code}
> < FIN FRO

[GitHub] trafficserver issue #947: TS-4796 Change UnixNetHandler to always bubble up ...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/947
  
comments for codes:
```
  if (get_ev_events(pd, x) & (EVENTIO_READ | EVENTIO_ERROR)) {
// ** set read.triggered if a epoll event of net has EVENTIO_READ 
or EVENTIO_ERROR bit set.
vc->read.triggered = 1;
// ** and put vc in read_ready_list
if (!read_ready_list.in(vc)) {
  read_ready_list.enqueue(vc);
} else if (get_ev_events(pd, x) & EVENTIO_ERROR) {
  // ** output an error message if a netvc already in ready_list 
got EVENTIO_ERROR.
  // check for unhandled epoll events that should be handled
  Debug("iocore_net_main", "Unhandled epoll event on read: 0x%04x 
read.enabled=%d closed=%d read.netready_queue=%d",
get_ev_events(pd, x), vc->read.enabled, vc->closed, 
read_ready_list.in(vc));
}
  }
```
The netvc always put in read_ready_list if it has EVENTIO_READ or 
EVENTIO_ERROR.

```
#if defined(USE_EDGE_TRIGGER)
  // UnixNetVConnection *
  // ** for each netvc in read_ready_list
  while ((vc = read_ready_list.dequeue())) {
if (vc->closed) // ** if the netvc mark closed
  close_UnixNetVConnection(vc, trigger_event->ethread);
else if (vc->read.enabled && vc->read.triggered) //** if the netvc is 
enabled and triggered
  vc->net_read_io(this, trigger_event->ethread);
else if (!vc->read.enabled) { //** if the netvc is not enabled
  read_ready_list.remove(vc);
#if defined(solaris)
  if (vc->read.triggered && vc->write.enabled) {
vc->ep.modify(-EVENTIO_READ);
vc->ep.refresh(EVENTIO_WRITE);
vc->writeReschedule(this);
  }   
#endif
}   
  }
```

for your case, read.enabled is 0
```
else if (!vc->read.enabled) { // if the netvc is not enabled
  read_ready_list.remove(vc);
```
The vc is removed from read_ready_list.

The below is my suggest:
```
  if (get_ev_events(pd, x) & (EVENTIO_READ | EVENTIO_ERROR)) {
vc->read.triggered = 1;
+  if (get_ev_events(pd, x) & EVENTIO_ERROR) {
+vc->read.error = 1;
+  }
if (!read_ready_list.in(vc)) {
  read_ready_list.enqueue(vc);
} else if (get_ev_events(pd, x) & EVENTIO_ERROR) {
```
and
```
else if (vc->read.enabled && vc->read.triggered) //** if the netvc is 
enabled and triggered
  vc->net_read_io(this, trigger_event->ethread);
+  else if (vc->read.error) {
+int err = 0, errlen = sizeof(int);
+if (getsockopt(fd, SOL_SOCKET, SO_ERROR, &err, &errlen) == -1) {
+  err = errno;
+}
+if (err != EAGAIN && err != EINTR)
+  vc->readSignalError(this, err);
+  }
else if (!vc->read.enabled) { //** if the netvc is not enabled
  read_ready_list.remove(vc);
#if defined(solaris)
  if (vc->read.triggered && vc->write.enabled) {
vc->ep.modify(-EVENTIO_READ);
vc->ep.refresh(EVENTIO_WRITE);
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4776) O_DIRECTORY is not available on OmniOS

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4776?focusedWorklogId=28049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28049
 ]

ASF GitHub Bot logged work on TS-4776:
--

Author: ASF GitHub Bot
Created on: 03/Sep/16 05:43
Start Date: 03/Sep/16 05:43
Worklog Time Spent: 10m 
  Work Description: Github user maskit closed the pull request at:

https://github.com/apache/trafficserver/pull/921


Issue Time Tracking
---

Worklog Id: (was: 28049)
Time Spent: 1h 20m  (was: 1h 10m)

> O_DIRECTORY is not available on OmniOS
> --
>
> Key: TS-4776
> URL: https://issues.apache.org/jira/browse/TS-4776
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Masakazu Kitajo
>Assignee: Masakazu Kitajo
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> {noformat}
> CXX  HostDB.o
> In file included from 
> /home/leif/apache/trafficserver.git/iocore/hostdb/HostDB.cc:27:0:
> /home/leif/apache/trafficserver.git/iocore/hostdb/P_RefCountCacheSerializer.h:
>  In member function ‘int RefCountCacheSerializer::finalize_sync()’:
> /home/leif/apache/trafficserver.git/iocore/hostdb/P_RefCountCacheSerializer.h:258:53:
>  error: ‘O_DIRECTORY’ was not declared in this scope
>dirfd = socketManager.open(this->dirname.c_str(), O_DIRECTORY);
>  ^
> Makefile:969: recipe for target 'HostDB.o' failed
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #921: TS-4776: Emulate the effect of O_DIRECTORY ...

[maskit]

Github user maskit closed the pull request at:

https://github.com/apache/trafficserver/pull/921


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/877
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/690/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4755) Create a plugin that would count the frequency of headers

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4755?focusedWorklogId=28047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28047
 ]

ASF GitHub Bot logged work on TS-4755:
--

Author: ASF GitHub Bot
Created on: 03/Sep/16 02:41
Start Date: 03/Sep/16 02:41
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/877
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/690/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28047)
Time Spent: 2h 50m  (was: 2h 40m)

> Create a plugin that would count the frequency of headers
> -
>
> Key: TS-4755
> URL: https://issues.apache.org/jira/browse/TS-4755
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Bryan Call
>Assignee: Petar Penkov
> Fix For: 7.2.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Create a plugin that would count the frequency of headers.  Have separate 
> frequency counters for origin and client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/877
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/586/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4755) Create a plugin that would count the frequency of headers

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4755?focusedWorklogId=28046&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28046
 ]

ASF GitHub Bot logged work on TS-4755:
--

Author: ASF GitHub Bot
Created on: 03/Sep/16 02:34
Start Date: 03/Sep/16 02:34
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/877
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/586/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28046)
Time Spent: 2h 40m  (was: 2.5h)

> Create a plugin that would count the frequency of headers
> -
>
> Key: TS-4755
> URL: https://issues.apache.org/jira/browse/TS-4755
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Bryan Call
>Assignee: Petar Penkov
> Fix For: 7.2.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Create a plugin that would count the frequency of headers.  Have separate 
> frequency counters for origin and client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4794) fix the memory leaks

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4794?focusedWorklogId=28045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28045
 ]

ASF GitHub Bot logged work on TS-4794:
--

Author: ASF GitHub Bot
Created on: 03/Sep/16 02:25
Start Date: 03/Sep/16 02:25
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/855
  
@bryongloden please address James' concern, and we can land this (after we 
run it on the CI again).


Issue Time Tracking
---

Worklog Id: (was: 28045)
Time Spent: 40m  (was: 0.5h)

> fix the memory leaks
> 
>
> Key: TS-4794
> URL: https://issues.apache.org/jira/browse/TS-4794
> Project: Traffic Server
>  Issue Type: Bug
>  Components: DNS, Network
>Reporter: Bryon Gloden, CISSP®
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> With reference to (WRT) https://github.com/apache/trafficserver/pull/855, on 
> line no. 74 of 'test_P_DNS.cc' there is a memory leak and on line no. 72 of 
> 'test_P_Net.cc' there is memory leak -- both memory leaks are errors.
> Ping [~zwoop]
> Found by https://github.com/bryongloden/cppcheck



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #855: TS-4794 fix the memory leaks

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/855
  
@bryongloden please address James' concern, and we can land this (after we 
run it on the CI again).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4755) Create a plugin that would count the frequency of headers

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4755?focusedWorklogId=28044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28044
 ]

ASF GitHub Bot logged work on TS-4755:
--

Author: ASF GitHub Bot
Created on: 03/Sep/16 02:21
Start Date: 03/Sep/16 02:21
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/877
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 28044)
Time Spent: 2.5h  (was: 2h 20m)

> Create a plugin that would count the frequency of headers
> -
>
> Key: TS-4755
> URL: https://issues.apache.org/jira/browse/TS-4755
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Bryan Call
>Assignee: Petar Penkov
> Fix For: 7.2.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Create a plugin that would count the frequency of headers.  Have separate 
> frequency counters for origin and client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/877
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (TS-4803) Remove proxy.config.dns.url_expansions

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-4803.
---
Resolution: Fixed

> Remove proxy.config.dns.url_expansions
> --
>
> Key: TS-4803
> URL: https://issues.apache.org/jira/browse/TS-4803
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Configuration, DNS
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> This is similar to TS-4725, so I think we should nuke this too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4803) Remove proxy.config.dns.url_expansions

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4803?focusedWorklogId=28043&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28043
 ]

ASF GitHub Bot logged work on TS-4803:
--

Author: ASF GitHub Bot
Created on: 03/Sep/16 02:03
Start Date: 03/Sep/16 02:03
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/950


Issue Time Tracking
---

Worklog Id: (was: 28043)
Time Spent: 1h 50m  (was: 1h 40m)

> Remove proxy.config.dns.url_expansions
> --
>
> Key: TS-4803
> URL: https://issues.apache.org/jira/browse/TS-4803
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Configuration, DNS
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> This is similar to TS-4725, so I think we should nuke this too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #950: TS-4803 Removes the config/support for prox...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/950


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4803) Remove proxy.config.dns.url_expansions

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4803?focusedWorklogId=28031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28031
 ]

ASF GitHub Bot logged work on TS-4803:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 23:16
Start Date: 02/Sep/16 23:16
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/950
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/689/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28031)
Time Spent: 1h 40m  (was: 1.5h)

> Remove proxy.config.dns.url_expansions
> --
>
> Key: TS-4803
> URL: https://issues.apache.org/jira/browse/TS-4803
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Configuration, DNS
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> This is similar to TS-4725, so I think we should nuke this too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #950: TS-4803 Removes the config/support for proxy.confi...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/950
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/689/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4803) Remove proxy.config.dns.url_expansions

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4803?focusedWorklogId=28027&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28027
 ]

ASF GitHub Bot logged work on TS-4803:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 23:14
Start Date: 02/Sep/16 23:14
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/950
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/585/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28027)
Time Spent: 1.5h  (was: 1h 20m)

> Remove proxy.config.dns.url_expansions
> --
>
> Key: TS-4803
> URL: https://issues.apache.org/jira/browse/TS-4803
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Configuration, DNS
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This is similar to TS-4725, so I think we should nuke this too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #950: TS-4803 Removes the config/support for proxy.confi...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/950
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/585/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : clang-analyzer #2594

[jenkins]

See 

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28026
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 23:04
Start Date: 02/Sep/16 23:04
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/584/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28026)
Time Spent: 50m  (was: 40m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/584/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28025
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 23:01
Start Date: 02/Sep/16 23:01
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/688/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28025)
Time Spent: 40m  (was: 0.5h)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/688/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4449) header_rewrite: Improve TSDebug() statements

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4449?focusedWorklogId=28024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28024
 ]

ASF GitHub Bot logged work on TS-4449:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 22:55
Start Date: 02/Sep/16 22:55
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/958
  
This is a cherry-pick to to get some of the better fixes, as a back port to 
6.2.x. The hook lookups were changed later (I think) on master.


Issue Time Tracking
---

Worklog Id: (was: 28024)
Time Spent: 1h  (was: 50m)

> header_rewrite: Improve TSDebug() statements
> 
>
> Key: TS-4449
> URL: https://issues.apache.org/jira/browse/TS-4449
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Right now, it can be difficult at times to understand why header_rewrite 
> isn't behaving as you'd expect. There are a number of places where we can 
> improve TSDebug().
> Also, I'm going to do a code cleanup here, to make the code more inline with 
> our current best practices (e.g. use if () { } consistently).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #958: TS-4449 Better errors and debug output

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/958
  
This is a cherry-pick to to get some of the better fixes, as a back port to 
6.2.x. The hook lookups were changed later (I think) on master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28023&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28023
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 22:50
Start Date: 02/Sep/16 22:50
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Should we change this to an ink_relase_assert() or an ink_abort() ?


Issue Time Tracking
---

Worklog Id: (was: 28023)
Time Spent: 0.5h  (was: 20m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
Should we change this to an ink_relase_assert() or an ink_abort() ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4815:
--
Fix Version/s: 7.0.0

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28022
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 22:48
Start Date: 02/Sep/16 22:48
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 28022)
Time Spent: 20m  (was: 10m)

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/963
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #963: TS-4815 - CID 1267839 dead code in /mgmt/ap...

[ngara]

GitHub user ngara opened a pull request:

https://github.com/apache/trafficserver/pull/963

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: re…

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return 
TS_ERR_PARAMS;

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ngara/trafficserver TS-4815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/963.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #963


commit 0825b52f2ccfda68c77de36fba7cef3a564d3e96
Author: Nathan Garabedian 
Date:   2016-09-02T21:13:38Z

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return 
TS_ERR_PARAMS;




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?focusedWorklogId=28012&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28012
 ]

ASF GitHub Bot logged work on TS-4815:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 22:10
Start Date: 02/Sep/16 22:10
Worklog Time Spent: 10m 
  Work Description: GitHub user ngara opened a pull request:

https://github.com/apache/trafficserver/pull/963

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: re…

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return 
TS_ERR_PARAMS;

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ngara/trafficserver TS-4815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/963.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #963


commit 0825b52f2ccfda68c77de36fba7cef3a564d3e96
Author: Nathan Garabedian 
Date:   2016-09-02T21:13:38Z

TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return 
TS_ERR_PARAMS;




Issue Time Tracking
---

Worklog Id: (was: 28012)
Time Spent: 10m
Remaining Estimate: 0h

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #961: TS-4810: Use the correct LuaJIT LDFLAGS

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/961


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4810) We no longer build LuaJIT on OmniOS properly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?focusedWorklogId=28006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28006
 ]

ASF GitHub Bot logged work on TS-4810:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 22:06
Start Date: 02/Sep/16 22:06
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/961


Issue Time Tracking
---

Worklog Id: (was: 28006)
Time Spent: 1h 50m  (was: 1h 40m)

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4810) We no longer build LuaJIT on OmniOS properly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?focusedWorklogId=28004&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28004
 ]

ASF GitHub Bot logged work on TS-4810:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 22:01
Start Date: 02/Sep/16 22:01
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
👍 


Issue Time Tracking
---

Worklog Id: (was: 28004)
Time Spent: 1h 40m  (was: 1.5h)

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #961: TS-4810: Use the correct LuaJIT LDFLAGS

[jpeach]

Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Comment Edited] (TS-4814) Crash in SSLNetVConnection::do_io_close

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459696#comment-15459696
 ] 

Leif Hedstrom edited comment on TS-4814 at 9/2/16 9:57 PM:
---

*this in frame 7:

{code}
$17 = { = { = { = 
{ = { = {
_vptr.force_VFPT_to_top = 0xc21658 },
  handler = (int (Continuation::*)(Continuation * const, int,
void *)) 0xa3c49a ,
  handler_name = 0xc2ffe0 
"(NetVConnHandler)&UnixNetVConnection::mainEvent", mutex = {m_ptr = 
0x60c000407d40},
  link = {> = {next = 0x0}, prev = 0x6185fc80}, 
control_flags = {raw_flags = 0}}, lerrno = 0},
  options = {ip_proto = NetVCOptions::USE_TCP, ip_family = 2, local_ip = 
{_family = 0, _addr = {_ip4 = 0, _ip6 = {__in6_u = {
__u6_addr8 = '\000' , __u6_addr16 = {0, 0, 0, 
0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}},
_byte = '\000' , _u32 = {0, 0, 0, 0}, _u64 = {0, 
0}}}, local_port = 0,
addr_binding = NetVCOptions::ANY_ADDR, f_blocking = false, 
f_blocking_connect = false, socks_support = 0 '\000',
socks_version = 0 '\000', socket_recv_bufsize = 0, socket_send_bufsize 
= 0, sockopt_flags = 0, packet_mark = 0,
packet_tos = 0, etype = 0, sni_servername = 
{ >> = {
_r = 0x0}, }}, socks_addr = {type = 0 '\000', addr 
= {ipv4 = "\000\000\000", buf = 0x0}},
  attributes = 4, thread = 0x2ae82b12d800, local_addr = {sa = {sa_family = 
2,
  sa_data = "\001\273h\357\217\020\000\000\000\000\000\000\000"}, sin = 
{sin_family = 2, sin_port = 47873, sin_addr = {
s_addr = 277868392}, sin_zero = "\000\000\000\000\000\000\000"}, 
sin6 = {sin6_family = 2, sin6_port = 47873,
  sin6_flowinfo = 277868392, sin6_addr = {__in6_u = {__u6_addr8 = 
'\000' , __u6_addr16 = {0, 0, 0, 0,
0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, 
remote_addr = {sa = {sa_family = 2,
  sa_data = "\366J˅\252\237\000\000\000\000\000\000\000"}, sin = 
{sin_family = 2, sin_port = 19190, sin_addr = {
s_addr = 2678752715}, sin_zero = "\000\000\000\000\000\000\000"}, 
sin6 = {sin6_family = 2, sin6_port = 19190,
  sin6_flowinfo = 2678752715, sin6_addr = {__in6_u = {__u6_addr8 = 
'\000' , __u6_addr16 = {0, 0, 0, 0,
0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, 
got_local_addr = true, got_remote_addr = true,
  is_internal_request = false, is_transparent = false, 
write_buffer_empty_event = 0}, action_ = {
  _vptr.Action = 0xa97040 , continuation = 0x0, mutex 
= {m_ptr = 0x0}, cancelled = 0}, closed = 0,
read = {enabled = 0, vio = {_cont = 0x619de880, nbytes = 
9223372036854775807, ndone = 0, op = 1, buffer = {name = 0x0,
  mbuf = 0x611000a94100, entry = 0x0}, vc_server = 0x61857080, 
mutex = {m_ptr = 0x60c000407d40}},
  ready_link = {> = {next = 0x0}, prev = 0x0}, 
enable_link = {next = 0x0}, in_enabled_list = 0,
  triggered = 0}, write = {enabled = 0, vio = {_cont = 0x0, nbytes = 0, 
ndone = 0, op = 2, buffer = {name = 0x0,
  mbuf = 0x611000a2ea80, entry = 0x611000a2eac0}, vc_server = 
0x61857080, mutex = {m_ptr = 0x60c000407d40}},
  ready_link = {> = {next = 0x0}, prev = 0x0}, 
enable_link = {next = 0x0}, in_enabled_list = 0,
  triggered = 1}, cop_link = {> = {next = 0x0}, 
prev = 0x0},
keep_alive_queue_link = {> = {next = 0x0}, prev = 
0x6185fc80},
active_queue_link = {> = {next = 0x0}, prev = 
0x0}, inactivity_timeout_in = 3000,
active_timeout_in = 0, next_inactivity_timeout_at = 1472850939322871213, 
next_activity_timeout_at = 0, ep = {fd = 56,
  event_loop = 0x2ae82bdbc800, type = 2, data = {c = 0x61857080, vc = 
0x61857080, dnscon = 0x61857080, na =
0x61857080, uc = 0x61857080}}, nh = 0x2ae82b131490, id = 603, 
server_addr = {sa = {sa_family = 2,
sa_data = "\366J˅\252\237\000\000\000\000\000\000\000"}, sin = 
{sin_family = 2, sin_port = 19190, sin_addr = {
  s_addr = 2678752715}, sin_zero = "\000\000\000\000\000\000\000"}, 
sin6 = {sin6_family = 2, sin6_port = 19190,
sin6_flowinfo = 2678752715, sin6_addr = {__in6_u = {__u6_addr8 = '\000' 
, __u6_addr16 = {0, 0, 0, 0,
  0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, 
{flags = 0, f = {got_local_addr = 0,
shutdown = 0}}, con = {_vptr.Connection = 0xc15330 , fd = 56, addr = {sa = {sa_family = 2,
  sa_data = "\366J˅\252\237\000\000\000\000\000\000\000"}, sin = 
{sin_family = 2, sin_port = 19190, sin_addr = {
s_addr = 2678752715}, sin_zero = "\000\000\000\000\000\000\000"}, 
sin6 = {sin6_family = 2, sin6_port = 19190,
  sin6_flowinfo = 2678752715, sin6_addr = {__in6_u = {__u6_addr8 = 
'\000' , __u6_addr16 = {0, 0, 0, 0,
0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, 
is_bound = false

[jira] [Commented] (TS-4814) Crash in SSLNetVConnection::do_io_close

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459696#comment-15459696
 ] 

Leif Hedstrom commented on TS-4814:
---

*this in frame 7:

{code}
$17 = { = { = { = 
{ = { = {
_vptr.force_VFPT_to_top = 0xc21658 },
  handler = (int (Continuation::*)(Continuation * const, int,
void *)) 0xa3c49a ,
  handler_name = 0xc2ffe0 
"(NetVConnHandler)&UnixNetVConnection::mainEvent", mutex = {m_ptr = 
0x60c000407d40},
  link = {> = {next = 0x0}, prev = 0x6185fc80}, 
control_flags = {raw_flags = 0}}, lerrno = 0},
  options = {ip_proto = NetVCOptions::USE_TCP, ip_family = 2, local_ip = 
{_family = 0, _addr = {_ip4 = 0, _ip6 = {__in6_u = {
__u6_addr8 = '\000' , __u6_addr16 = {0, 0, 0, 
0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}},
_byte = '\000' , _u32 = {0, 0, 0, 0}, _u64 = {0, 
0}}}, local_port = 0,
addr_binding = NetVCOptions::ANY_ADDR, f_blocking = false, 
f_blocking_connect = false, socks_support = 0 '\000',
socks_version = 0 '\000', socket_recv_bufsize = 0, socket_send_bufsize 
= 0, sockopt_flags = 0, packet_mark = 0,
packet_tos = 0, etype = 0, sni_servername = 
{ >> = {
_r = 0x0}, }}, socks_addr = {type = 0 '\000', addr 
= {ipv4 = "\000\000\000", buf = 0x0}},
  attributes = 4, thread = 0x2ae82b12d800, local_addr = {sa = {sa_family = 
2,
  sa_data = "\001\273h\357\217\020\000\000\000\000\000\000\000"}, sin = 
{sin_family = 2, sin_port = 47873, sin_addr = {
s_addr = 277868392}, sin_zero = "\000\000\000\000\000\000\000"}, 
sin6 = {sin6_family = 2, sin6_port = 47873,
  sin6_flowinfo = 277868392, sin6_addr = {__in6_u = {__u6_addr8 = 
'\000' , __u6_addr16 = {0, 0, 0, 0,
0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, 
remote_addr = {sa = {sa_family = 2,
  sa_data = "\366J˅\252\237\000\000\000\000\000\000\000"}, sin = 
{sin_family = 2, sin_port = 19190, sin_addr = {
s_addr = 2678752715}, sin_zero = "\000\000\000\000\000\000\000"}, 
sin6 = {sin6_family = 2, sin6_port = 19190,
  sin6_flowinfo = 2678752715, sin6_addr = {__in6_u = {__u6_addr8 = 
'\000' , __u6_addr16 = {0, 0, 0, 0,
0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, 
got_local_addr = true, got_remote_addr = true,
  is_internal_request = false, is_transparent = false, 
write_buffer_empty_event = 0}, action_ = {
  _vptr.Action = 0xa97040 , continuation = 0x0, mutex 
= {m_ptr = 0x0}, cancelled = 0}, closed = 0,
read = {enabled = 0, vio = {_cont = 0x619de880, nbytes = 
9223372036854775807, ndone = 0, op = 1, buffer = {name = 0x0,
  mbuf = 0x611000a94100, entry = 0x0}, vc_server = 0x61857080, 
mutex = {m_ptr = 0x60c000407d40}},
  ready_link = {> = {next = 0x0}, prev = 0x0}, 
enable_link = {next = 0x0}, in_enabled_list = 0,
  triggered = 0}, write = {enabled = 0, vio = {_cont = 0x0, nbytes = 0, 
ndone = 0, op = 2, buffer = {name = 0x0,
  mbuf = 0x611000a2ea80, entry = 0x611000a2eac0}, vc_server = 
0x61857080, mutex = {m_ptr = 0x60c000407d40}},
  ready_link = {> = {next = 0x0}, prev = 0x0}, 
enable_link = {next = 0x0}, in_enabled_list = 0,
  triggered = 1}, cop_link = {> = {next = 0x0}, 
prev = 0x0},
keep_alive_queue_link = {> = {next = 0x0}, prev = 
0x6185fc80},
active_queue_link = {> = {next = 0x0}, prev = 
0x0}, inactivity_timeout_in = 3000,
active_timeout_in = 0, next_inactivity_timeout_at = 1472850939322871213, 
next_activity_timeout_at = 0, ep = {fd = 56,
  event_loop = 0x2ae82bdbc800, type = 2, data = {c = 0x61857080, vc = 
0x61857080, dnscon = 0x61857080, na =
0x61857080, uc = 0x61857080}}, nh = 0x2ae82b131490, id = 603, 
server_addr = {sa = {sa_family = 2,
sa_data = "\366J˅\252\237\000\000\000\000\000\000\000"}, sin = 
{sin_family = 2, sin_port = 19190, sin_addr = {
  s_addr = 2678752715}, sin_zero = "\000\000\000\000\000\000\000"}, 
sin6 = {sin6_family = 2, sin6_port = 19190,
sin6_flowinfo = 2678752715, sin6_addr = {__in6_u = {__u6_addr8 = '\000' 
, __u6_addr16 = {0, 0, 0, 0,
  0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, 
{flags = 0, f = {got_local_addr = 0,
shutdown = 0}}, con = {_vptr.Connection = 0xc15330 , fd = 56, addr = {sa = {sa_family = 2,
  sa_data = "\366J˅\252\237\000\000\000\000\000\000\000"}, sin = 
{sin_family = 2, sin_port = 19190, sin_addr = {
s_addr = 2678752715}, sin_zero = "\000\000\000\000\000\000\000"}, 
sin6 = {sin6_family = 2, sin6_port = 19190,
  sin6_flowinfo = 2678752715, sin6_addr = {__in6_u = {__u6_addr8 = 
'\000' , __u6_addr16 = {0, 0, 0, 0,
0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, 
is_bound = false, is_connected = false,
  sock_type = 0}, r

[jira] [Work logged] (TS-4803) Remove proxy.config.dns.url_expansions

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4803?focusedWorklogId=28000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28000
 ]

ASF GitHub Bot logged work on TS-4803:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 21:54
Start Date: 02/Sep/16 21:54
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/950
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/583/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 28000)
Time Spent: 1h 20m  (was: 1h 10m)

> Remove proxy.config.dns.url_expansions
> --
>
> Key: TS-4803
> URL: https://issues.apache.org/jira/browse/TS-4803
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Configuration, DNS
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This is similar to TS-4725, so I think we should nuke this too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #950: TS-4803 Removes the config/support for proxy.confi...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/950
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/583/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4803) Remove proxy.config.dns.url_expansions

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4803?focusedWorklogId=27998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27998
 ]

ASF GitHub Bot logged work on TS-4803:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 21:51
Start Date: 02/Sep/16 21:51
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/950
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/687/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27998)
Time Spent: 1h 10m  (was: 1h)

> Remove proxy.config.dns.url_expansions
> --
>
> Key: TS-4803
> URL: https://issues.apache.org/jira/browse/TS-4803
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Configuration, DNS
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> This is similar to TS-4725, so I think we should nuke this too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #950: TS-4803 Removes the config/support for proxy.confi...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/950
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/687/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4581) CID 1356973 dead code in proxy/hdrs/HTTP.cc

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4581?focusedWorklogId=27997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27997
 ]

ASF GitHub Bot logged work on TS-4581:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 21:50
Start Date: 02/Sep/16 21:50
Worklog Time Spent: 10m 
  Work Description: Github user ngara closed the pull request at:

https://github.com/apache/trafficserver/pull/962


Issue Time Tracking
---

Worklog Id: (was: 27997)
Time Spent: 2.5h  (was: 2h 20m)

> CID 1356973 dead code in proxy/hdrs/HTTP.cc
> ---
>
> Key: TS-4581
> URL: https://issues.apache.org/jira/browse/TS-4581
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> 1069
>   notnull: At condition url_start, the value of url_start cannot be NULL.
>   dead_error_condition: The condition !url_start cannot be true.
>   notnull: At condition url_end, the value of url_end cannot be NULL.
>   dead_error_condition: The condition !url_end cannot be true.
> 1070if (!url_start || !url_end)
>   
> CID 1356973 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return PARSE_ERROR;.
> 1071  return PARSE_ERROR;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #962: TS-4581 - CID 1267839 dead code in /mgmt/ap...

[ngara]

Github user ngara closed the pull request at:

https://github.com/apache/trafficserver/pull/962


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4581) CID 1356973 dead code in proxy/hdrs/HTTP.cc

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4581?focusedWorklogId=27995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27995
 ]

ASF GitHub Bot logged work on TS-4581:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 21:48
Start Date: 02/Sep/16 21:48
Worklog Time Spent: 10m 
  Work Description: GitHub user ngara opened a pull request:

https://github.com/apache/trafficserver/pull/962

TS-4581 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: re…

TS-4581 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return 
TS_ERR_PARAMS;



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ngara/trafficserver TS-4815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #962






Issue Time Tracking
---

Worklog Id: (was: 27995)
Time Spent: 2h 20m  (was: 2h 10m)

> CID 1356973 dead code in proxy/hdrs/HTTP.cc
> ---
>
> Key: TS-4581
> URL: https://issues.apache.org/jira/browse/TS-4581
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> 1069
>   notnull: At condition url_start, the value of url_start cannot be NULL.
>   dead_error_condition: The condition !url_start cannot be true.
>   notnull: At condition url_end, the value of url_end cannot be NULL.
>   dead_error_condition: The condition !url_end cannot be true.
> 1070if (!url_start || !url_end)
>   
> CID 1356973 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return PARSE_ERROR;.
> 1071  return PARSE_ERROR;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #962: TS-4581 - CID 1267839 dead code in /mgmt/ap...

[ngara]

GitHub user ngara opened a pull request:

https://github.com/apache/trafficserver/pull/962

TS-4581 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: re…

TS-4581 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return 
TS_ERR_PARAMS;



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ngara/trafficserver TS-4815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #962






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: clang-analyzer #2593

[jenkins]

See 

Changes:

[ngarabedian] TS-4581 CID 1356973 dead code in proxy/hdrs/HTTP.cc

[Gancho Tenev] TS-4809 header_rewrite "hook" conditions checks

--
[...truncated 5341 lines...]
reading sources... [ 71%] developer-guide/api/functions/TSfopen.en
reading sources... [ 72%] developer-guide/api/functions/TSfread.en
reading sources... [ 72%] developer-guide/api/functions/TSfwrite.en
reading sources... [ 72%] developer-guide/api/functions/TSmalloc.en
reading sources... [ 72%] developer-guide/api/functions/index.en
reading sources... [ 73%] developer-guide/api/index.en
reading sources... [ 73%] developer-guide/api/types/TSCacheDataType.en
reading sources... [ 73%] developer-guide/api/types/TSCacheError.en
reading sources... [ 73%] developer-guide/api/types/TSCacheLookupResult.en
reading sources... [ 73%] developer-guide/api/types/TSCacheScanResult.en
reading sources... [ 74%] developer-guide/api/types/TSEvent.en
reading sources... [ 74%] developer-guide/api/types/TSFetchWakeUpOptions.en
reading sources... [ 74%] developer-guide/api/types/TSHttpHookID.en
reading sources... [ 74%] developer-guide/api/types/TSHttpStatus.en
reading sources... [ 75%] developer-guide/api/types/TSHttpType.en
reading sources... [ 75%] developer-guide/api/types/TSIOBuffersSizeIndex.en
reading sources... [ 75%] developer-guide/api/types/TSLifecycleHookID.en
reading sources... [ 75%] developer-guide/api/types/TSLookingUpType.en
reading sources... [ 75%] developer-guide/api/types/TSMilestonesType.en
reading sources... [ 76%] developer-guide/api/types/TSOverridableConfigKey.en
reading sources... [ 76%] developer-guide/api/types/TSParseResult.en
reading sources... [ 76%] developer-guide/api/types/TSRecordAccessType.en
reading sources... [ 76%] developer-guide/api/types/TSRecordCheckType.en
reading sources... [ 76%] developer-guide/api/types/TSRecordDataType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordModeType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordPersistType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordUpdateType.en
reading sources... [ 78%] developer-guide/api/types/TSReturnCode.en
reading sources... [ 78%] developer-guide/api/types/TSSDKVersion.en
reading sources... [ 78%] 
developer-guide/api/types/TSServerSessionSharingMatchType.en
reading sources... [ 78%] 
developer-guide/api/types/TSServerSessionSharingPoolType.en
reading sources... [ 78%] developer-guide/api/types/TSServerState.en
reading sources... [ 79%] developer-guide/api/types/TSSslVConnOp.en
reading sources... [ 79%] developer-guide/api/types/TSThreadPool.en
reading sources... [ 79%] developer-guide/api/types/TSUuid.en
reading sources... [ 79%] developer-guide/api/types/TSVConnCloseFlags.en
reading sources... [ 80%] developer-guide/api/types/index.en
reading sources... [ 80%] developer-guide/architecture/api-functions.en
reading sources... [ 80%] developer-guide/architecture/architecture.en
reading sources... [ 80%] developer-guide/architecture/consistency.en
reading sources... [ 80%] developer-guide/architecture/data-structures.en
reading sources... [ 81%] developer-guide/architecture/index.en
reading sources... [ 81%] developer-guide/architecture/ram-cache.en
reading sources... [ 81%] developer-guide/architecture/tiered-storage.en
reading sources... [ 81%] developer-guide/config-vars.en
reading sources... [ 82%] developer-guide/continuous-integration/index.en
reading sources... [ 82%] developer-guide/contributing/index.en
reading sources... [ 82%] developer-guide/debugging/core-dump-analysis.en
reading sources... [ 82%] developer-guide/debugging/debug-builds.en
reading sources... [ 82%] developer-guide/debugging/debug-tags.en
reading sources... [ 83%] developer-guide/debugging/index.en
reading sources... [ 83%] developer-guide/debugging/memory-leaks.en
reading sources... [ 83%] developer-guide/debugging/profiling.en
reading sources... [ 83%] developer-guide/debugging/using-tsassert.en
reading sources... [ 84%] developer-guide/documentation/adding-domains.en
reading sources... [ 84%] developer-guide/documentation/building.en
reading sources... [ 84%] developer-guide/documentation/conventions.en
reading sources... [ 84%] developer-guide/documentation/index.en
reading sources... [ 84%] developer-guide/documentation/plugins.en
reading sources... [ 85%] developer-guide/documentation/rst-and-sphinx.en
reading sources... [ 85%] developer-guide/documentation/structure.en
reading sources... [ 85%] developer-guide/documentation/ts-markup.en
reading sources... [ 85%] developer-guide/host-resolution-proposal.en
reading sources... [ 86%] developer-guide/index.en
reading sources... [ 86%] developer-guide/introduction/index.en
reading sources... [ 86%] developer-guide/plugins/actions/hosts-lookup-api.en
reading sources... [ 86%] developer-guide/plugins/actio

[jira] [Work logged] (TS-4806) Fix up event processor thread stacks

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4806?focusedWorklogId=27986&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27986
 ]

ASF GitHub Bot logged work on TS-4806:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 21:25
Start Date: 02/Sep/16 21:25
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/956
  
I'm ok with this, the sleep(1) in the main thread looks clunky as we 
discussed, but whatevs.


Issue Time Tracking
---

Worklog Id: (was: 27986)
Time Spent: 1.5h  (was: 1h 20m)

> Fix up event processor thread stacks
> 
>
> Key: TS-4806
> URL: https://issues.apache.org/jira/browse/TS-4806
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 7.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Fix event processor to create stacks on the appropriate numa node and with 
> the appropriate page size. Also, stop using the main thread as ET_NET 0 since 
> we can't control any of these aspects of it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #956: TS-4806: Fix up event processor thread stacks

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/956
  
I'm ok with this, the sleep(1) in the main thread looks clunky as we 
discussed, but whatevs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #961: TS-4810: Use the correct LuaJIT LDFLAGS

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
I made that suggested change, going to land this unless there are 
objections.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4810) We no longer build LuaJIT on OmniOS properly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?focusedWorklogId=27985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27985
 ]

ASF GitHub Bot logged work on TS-4810:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 21:24
Start Date: 02/Sep/16 21:24
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
I made that suggested change, going to land this unless there are 
objections.


Issue Time Tracking
---

Worklog Id: (was: 27985)
Time Spent: 1.5h  (was: 1h 20m)

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[Nathan Garabedian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nathan Garabedian reassigned TS-4815:
-

Assignee: Nathan Garabedian

> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>
>   cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
> is not NULL.
> 165  ink_assert(ctx);
>   notnull: At condition ctx, the value of ctx cannot be NULL.
>   dead_error_condition: The condition !ctx cannot be true.
> 166  if (!ctx) {
>   
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4814) Crash in SSLNetVConnection::do_io_close

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459607#comment-15459607
 ] 

Leif Hedstrom commented on TS-4814:
---

[~shinrich] any thoughts?

> Crash in SSLNetVConnection::do_io_close
> ---
>
> Key: TS-4814
> URL: https://issues.apache.org/jira/browse/TS-4814
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Network, SSL
>Reporter: Leif Hedstrom
>Priority: Critical
> Fix For: 7.0.0
>
>
> Seeing this on latest master, running on docs:
> {code}
> #0  0x2b411eeff1cd in write () at ../sysdeps/unix/syscall-template.S:81
> #1  0x2b411be4860c in __interceptor_write (fd=66, ptr=0x629a0203, 
> count=)
> at 
> ../../../../libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:453
> #2  0x2b411deaa826 in fd_write () from /opt/openssl/lib/libcrypto.so.1.0.0
> #3  0x2b411dea91ab in BIO_write () from 
> /opt/openssl/lib/libcrypto.so.1.0.0
> #4  0x2b411db50142 in ssl3_write_pending () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #5  0x2b411db52a70 in ssl3_dispatch_alert () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #6  0x2b411db4df92 in ssl3_shutdown () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #7  0x00a003a2 in SSLNetVConnection::do_io_close 
> (this=0x6183b880, lerrno=-1) at SSLNetVConnection.cc:837
> #8  0x0066bb4a in Http1ClientSession::do_io_close 
> (this=0x61929980, alerrno=-1) at Http1ClientSession.cc:303
> #9  0x0066c7d3 in Http1ClientSession::state_keep_alive 
> (this=0x61929980, event=104, data=0x6183b9a0)
> at Http1ClientSession.cc:415
> #10 0x0053a621 in Continuation::handleEvent (this=0x61929980, 
> event=104, data=0x6183b9a0)
> at ../iocore/eventsystem/I_Continuation.h:153
> #11 0x00a34eab in read_signal_and_update (event=104, 
> vc=0x6183b880) at UnixNetVConnection.cc:153
> #12 0x00a35594 in read_signal_done (event=104, nh=0x2b4123c27490, 
> vc=0x6183b880) at UnixNetVConnection.cc:214
> #13 0x00a3b72e in UnixNetVConnection::readSignalDone 
> (this=0x6183b880, event=104, nh=0x2b4123c27490)
> at UnixNetVConnection.cc:1030
> #14 0x009fe003 in SSLNetVConnection::net_read_io 
> (this=0x6183b880, nh=0x2b4123c27490, lthread=0x2b4123c23800)
> at SSLNetVConnection.cc:620
> #15 0x00a227e9 in NetHandler::mainNetEvent (this=0x2b4123c27490, 
> event=5, e=0x6090d040) at UnixNet.cc:527
> #16 0x0053a621 in Continuation::handleEvent (this=0x2b4123c27490, 
> event=5, data=0x6090d040)
> at ../iocore/eventsystem/I_Continuation.h:153
> #17 0x00a809fb in EThread::process_event (this=0x2b4123c23800, 
> e=0x6090d040, calling_code=5) at UnixEThread.cc:146
> #18 0x00a8183b in EThread::execute (this=0x2b4123c23800) at 
> UnixEThread.cc:273
> #19 0x00a7f407 in spawn_thread_internal (a=0x60418890) at 
> Thread.cc:84
> #20 0x2b411eef8dc5 in start_thread (arg=0x2b4124431700) at 
> pthread_create.c:308
> #21 0x2b411f920ced in clone () at 
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:113
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;

[Nathan Garabedian (JIRA)]

Nathan Garabedian created TS-4815:
-

 Summary: CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: 
return TS_ERR_PARAMS;
 Key: TS-4815
 URL: https://issues.apache.org/jira/browse/TS-4815
 Project: Traffic Server
  Issue Type: Bug
  Components: Management API
Reporter: Nathan Garabedian



cond_notnull: Condition ctx, taking true branch. Now the value of ctx 
is not NULL.
165  ink_assert(ctx);
notnull: At condition ctx, the value of ctx cannot be NULL.
dead_error_condition: The condition !ctx cannot be true.
166  if (!ctx) {

CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
167return TS_ERR_PARAMS;
168  }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-4581) CID 1356973 dead code in proxy/hdrs/HTTP.cc

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom resolved TS-4581.
---
Resolution: Fixed

> CID 1356973 dead code in proxy/hdrs/HTTP.cc
> ---
>
> Key: TS-4581
> URL: https://issues.apache.org/jira/browse/TS-4581
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> 1069
>   notnull: At condition url_start, the value of url_start cannot be NULL.
>   dead_error_condition: The condition !url_start cannot be true.
>   notnull: At condition url_end, the value of url_end cannot be NULL.
>   dead_error_condition: The condition !url_end cannot be true.
> 1070if (!url_start || !url_end)
>   
> CID 1356973 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return PARSE_ERROR;.
> 1071  return PARSE_ERROR;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4581) CID 1356973 dead code in proxy/hdrs/HTTP.cc

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4581?focusedWorklogId=27982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27982
 ]

ASF GitHub Bot logged work on TS-4581:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 21:06
Start Date: 02/Sep/16 21:06
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/893


Issue Time Tracking
---

Worklog Id: (was: 27982)
Time Spent: 2h 10m  (was: 2h)

> CID 1356973 dead code in proxy/hdrs/HTTP.cc
> ---
>
> Key: TS-4581
> URL: https://issues.apache.org/jira/browse/TS-4581
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Fix For: 7.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> 1069
>   notnull: At condition url_start, the value of url_start cannot be NULL.
>   dead_error_condition: The condition !url_start cannot be true.
>   notnull: At condition url_end, the value of url_end cannot be NULL.
>   dead_error_condition: The condition !url_end cannot be true.
> 1070if (!url_start || !url_end)
>   
> CID 1356973 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return PARSE_ERROR;.
> 1071  return PARSE_ERROR;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #893: TS-4581 CID 1356973 dead code in proxy/hdrs...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/893


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4810) We no longer build LuaJIT on OmniOS properly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?focusedWorklogId=27980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27980
 ]

ASF GitHub Bot logged work on TS-4810:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 20:59
Start Date: 02/Sep/16 20:59
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/582/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27980)
Time Spent: 1h 20m  (was: 1h 10m)

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #961: TS-4810: Use the correct LuaJIT LDFLAGS

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/582/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4810) We no longer build LuaJIT on OmniOS properly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?focusedWorklogId=27979&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27979
 ]

ASF GitHub Bot logged work on TS-4810:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 20:58
Start Date: 02/Sep/16 20:58
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/686/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27979)
Time Spent: 1h 10m  (was: 1h)

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4449) header_rewrite: Improve TSDebug() statements

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4449?focusedWorklogId=27978&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27978
 ]

ASF GitHub Bot logged work on TS-4449:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 20:57
Start Date: 02/Sep/16 20:57
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/958#discussion_r77410889
  
--- Diff: plugins/header_rewrite/ruleset.cc ---
@@ -73,7 +74,8 @@ RuleSet::add_operator(Parser &p)
 TSDebug(PLUGIN_NAME, "   Adding operator: %s(%s)\n", 
p.get_op().c_str(), p.get_arg().c_str());
 o->initialize(p);
 if (!o->set_hook(_hook)) {
-  TSError("[%s] can't use this operator in this hook", PLUGIN_NAME);
+  TSError("[%s] in %s: can't use this operator in hook=%d:  %s(%s)", 
PLUGIN_NAME, filename, _hook, p.get_op().c_str(),
--- End diff --

``TSHttpHookNameLookup`` again.


Issue Time Tracking
---

Worklog Id: (was: 27978)
Time Spent: 50m  (was: 40m)

> header_rewrite: Improve TSDebug() statements
> 
>
> Key: TS-4449
> URL: https://issues.apache.org/jira/browse/TS-4449
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Right now, it can be difficult at times to understand why header_rewrite 
> isn't behaving as you'd expect. There are a number of places where we can 
> improve TSDebug().
> Also, I'm going to do a code cleanup here, to make the code more inline with 
> our current best practices (e.g. use if () { } consistently).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #961: TS-4810: Use the correct LuaJIT LDFLAGS

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/686/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4449) header_rewrite: Improve TSDebug() statements

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4449?focusedWorklogId=27977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27977
 ]

ASF GitHub Bot logged work on TS-4449:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 20:57
Start Date: 02/Sep/16 20:57
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/958#discussion_r77410848
  
--- Diff: plugins/header_rewrite/ruleset.cc ---
@@ -40,15 +40,16 @@ RuleSet::append(RuleSet *rule)
 }
 
 void
-RuleSet::add_condition(Parser &p)
+RuleSet::add_condition(Parser &p, const char *filename)
 {
   Condition *c = condition_factory(p.get_op());
 
   if (NULL != c) {
 TSDebug(PLUGIN_NAME, "   Adding condition: %%{%s} with arg: %s\n", 
p.get_op().c_str(), p.get_arg().c_str());
 c->initialize(p);
 if (!c->set_hook(_hook)) {
-  TSError("[%s] can't use this condition in this hook", PLUGIN_NAME);
+  TSError("[%s] in %s: can't use this condition in hook=%d: %%{%s} 
with arg: %s", PLUGIN_NAME, filename, _hook,
+  p.get_op().c_str(), p.get_arg().c_str());
--- End diff --

Use ``TSHttpHookNameLookup`` to log the hook by name.


Issue Time Tracking
---

Worklog Id: (was: 27977)
Time Spent: 40m  (was: 0.5h)

> header_rewrite: Improve TSDebug() statements
> 
>
> Key: TS-4449
> URL: https://issues.apache.org/jira/browse/TS-4449
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Right now, it can be difficult at times to understand why header_rewrite 
> isn't behaving as you'd expect. There are a number of places where we can 
> improve TSDebug().
> Also, I'm going to do a code cleanup here, to make the code more inline with 
> our current best practices (e.g. use if () { } consistently).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #958: TS-4449 Better errors and debug output

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/958#discussion_r77410889
  
--- Diff: plugins/header_rewrite/ruleset.cc ---
@@ -73,7 +74,8 @@ RuleSet::add_operator(Parser &p)
 TSDebug(PLUGIN_NAME, "   Adding operator: %s(%s)\n", 
p.get_op().c_str(), p.get_arg().c_str());
 o->initialize(p);
 if (!o->set_hook(_hook)) {
-  TSError("[%s] can't use this operator in this hook", PLUGIN_NAME);
+  TSError("[%s] in %s: can't use this operator in hook=%d:  %s(%s)", 
PLUGIN_NAME, filename, _hook, p.get_op().c_str(),
--- End diff --

``TSHttpHookNameLookup`` again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #958: TS-4449 Better errors and debug output

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/958#discussion_r77410848
  
--- Diff: plugins/header_rewrite/ruleset.cc ---
@@ -40,15 +40,16 @@ RuleSet::append(RuleSet *rule)
 }
 
 void
-RuleSet::add_condition(Parser &p)
+RuleSet::add_condition(Parser &p, const char *filename)
 {
   Condition *c = condition_factory(p.get_op());
 
   if (NULL != c) {
 TSDebug(PLUGIN_NAME, "   Adding condition: %%{%s} with arg: %s\n", 
p.get_op().c_str(), p.get_arg().c_str());
 c->initialize(p);
 if (!c->set_hook(_hook)) {
-  TSError("[%s] can't use this condition in this hook", PLUGIN_NAME);
+  TSError("[%s] in %s: can't use this condition in hook=%d: %%{%s} 
with arg: %s", PLUGIN_NAME, filename, _hook,
+  p.get_op().c_str(), p.get_arg().c_str());
--- End diff --

Use ``TSHttpHookNameLookup`` to log the hook by name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4794) fix the memory leaks

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4794?focusedWorklogId=27975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27975
 ]

ASF GitHub Bot logged work on TS-4794:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 20:51
Start Date: 02/Sep/16 20:51
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/855#discussion_r77410114
  
--- Diff: iocore/net/test_P_Net.cc ---
@@ -68,6 +68,7 @@ struct NetTesterSM : public Continuation {
 default:
   ink_release_assert(!"unknown event");
 }
+delete[] str;
--- End diff --

``str`` needs to be initialized to NULL.


Issue Time Tracking
---

Worklog Id: (was: 27975)
Time Spent: 20m  (was: 10m)

> fix the memory leaks
> 
>
> Key: TS-4794
> URL: https://issues.apache.org/jira/browse/TS-4794
> Project: Traffic Server
>  Issue Type: Bug
>  Components: DNS, Network
>Reporter: Bryon Gloden, CISSP®
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> With reference to (WRT) https://github.com/apache/trafficserver/pull/855, on 
> line no. 74 of 'test_P_DNS.cc' there is a memory leak and on line no. 72 of 
> 'test_P_Net.cc' there is memory leak -- both memory leaks are errors.
> Ping [~zwoop]
> Found by https://github.com/bryongloden/cppcheck



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4794) fix the memory leaks

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4794?focusedWorklogId=27976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27976
 ]

ASF GitHub Bot logged work on TS-4794:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 20:52
Start Date: 02/Sep/16 20:52
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/855#discussion_r77410158
  
--- Diff: iocore/dns/test_P_DNS.cc ---
@@ -70,6 +70,7 @@ struct NetTesterSM : public Continuation {
 default:
   ink_release_assert(!"unknown event");
 }
+delete[] str;
--- End diff --

``str`` needs to be initialized to NULL.


Issue Time Tracking
---

Worklog Id: (was: 27976)
Time Spent: 0.5h  (was: 20m)

> fix the memory leaks
> 
>
> Key: TS-4794
> URL: https://issues.apache.org/jira/browse/TS-4794
> Project: Traffic Server
>  Issue Type: Bug
>  Components: DNS, Network
>Reporter: Bryon Gloden, CISSP®
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> With reference to (WRT) https://github.com/apache/trafficserver/pull/855, on 
> line no. 74 of 'test_P_DNS.cc' there is a memory leak and on line no. 72 of 
> 'test_P_Net.cc' there is memory leak -- both memory leaks are errors.
> Ping [~zwoop]
> Found by https://github.com/bryongloden/cppcheck



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #855: TS-4794 fix the memory leaks

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/855#discussion_r77410158
  
--- Diff: iocore/dns/test_P_DNS.cc ---
@@ -70,6 +70,7 @@ struct NetTesterSM : public Continuation {
 default:
   ink_release_assert(!"unknown event");
 }
+delete[] str;
--- End diff --

``str`` needs to be initialized to NULL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #855: TS-4794 fix the memory leaks

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/855#discussion_r77410114
  
--- Diff: iocore/net/test_P_Net.cc ---
@@ -68,6 +68,7 @@ struct NetTesterSM : public Continuation {
 default:
   ink_release_assert(!"unknown event");
 }
+delete[] str;
--- End diff --

``str`` needs to be initialized to NULL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TS-4814) Crash in SSLNetVConnection::do_io_close

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4814:
--
Fix Version/s: 7.0.0

> Crash in SSLNetVConnection::do_io_close
> ---
>
> Key: TS-4814
> URL: https://issues.apache.org/jira/browse/TS-4814
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Network, SSL
>Reporter: Leif Hedstrom
> Fix For: 7.0.0
>
>
> Seeing this on latest master, running on docs:
> {code}
> #0  0x2b411eeff1cd in write () at ../sysdeps/unix/syscall-template.S:81
> #1  0x2b411be4860c in __interceptor_write (fd=66, ptr=0x629a0203, 
> count=)
> at 
> ../../../../libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:453
> #2  0x2b411deaa826 in fd_write () from /opt/openssl/lib/libcrypto.so.1.0.0
> #3  0x2b411dea91ab in BIO_write () from 
> /opt/openssl/lib/libcrypto.so.1.0.0
> #4  0x2b411db50142 in ssl3_write_pending () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #5  0x2b411db52a70 in ssl3_dispatch_alert () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #6  0x2b411db4df92 in ssl3_shutdown () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #7  0x00a003a2 in SSLNetVConnection::do_io_close 
> (this=0x6183b880, lerrno=-1) at SSLNetVConnection.cc:837
> #8  0x0066bb4a in Http1ClientSession::do_io_close 
> (this=0x61929980, alerrno=-1) at Http1ClientSession.cc:303
> #9  0x0066c7d3 in Http1ClientSession::state_keep_alive 
> (this=0x61929980, event=104, data=0x6183b9a0)
> at Http1ClientSession.cc:415
> #10 0x0053a621 in Continuation::handleEvent (this=0x61929980, 
> event=104, data=0x6183b9a0)
> at ../iocore/eventsystem/I_Continuation.h:153
> #11 0x00a34eab in read_signal_and_update (event=104, 
> vc=0x6183b880) at UnixNetVConnection.cc:153
> #12 0x00a35594 in read_signal_done (event=104, nh=0x2b4123c27490, 
> vc=0x6183b880) at UnixNetVConnection.cc:214
> #13 0x00a3b72e in UnixNetVConnection::readSignalDone 
> (this=0x6183b880, event=104, nh=0x2b4123c27490)
> at UnixNetVConnection.cc:1030
> #14 0x009fe003 in SSLNetVConnection::net_read_io 
> (this=0x6183b880, nh=0x2b4123c27490, lthread=0x2b4123c23800)
> at SSLNetVConnection.cc:620
> #15 0x00a227e9 in NetHandler::mainNetEvent (this=0x2b4123c27490, 
> event=5, e=0x6090d040) at UnixNet.cc:527
> #16 0x0053a621 in Continuation::handleEvent (this=0x2b4123c27490, 
> event=5, data=0x6090d040)
> at ../iocore/eventsystem/I_Continuation.h:153
> #17 0x00a809fb in EThread::process_event (this=0x2b4123c23800, 
> e=0x6090d040, calling_code=5) at UnixEThread.cc:146
> #18 0x00a8183b in EThread::execute (this=0x2b4123c23800) at 
> UnixEThread.cc:273
> #19 0x00a7f407 in spawn_thread_internal (a=0x60418890) at 
> Thread.cc:84
> #20 0x2b411eef8dc5 in start_thread (arg=0x2b4124431700) at 
> pthread_create.c:308
> #21 0x2b411f920ced in clone () at 
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:113
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4814) Crash in SSLNetVConnection::do_io_close

[Leif Hedstrom (JIRA)]

Leif Hedstrom created TS-4814:
-

 Summary: Crash in SSLNetVConnection::do_io_close
 Key: TS-4814
 URL: https://issues.apache.org/jira/browse/TS-4814
 Project: Traffic Server
  Issue Type: Bug
  Components: Network, SSL
Reporter: Leif Hedstrom


Seeing this on latest master, running on docs:

{code}
#0  0x2b411eeff1cd in write () at ../sysdeps/unix/syscall-template.S:81
#1  0x2b411be4860c in __interceptor_write (fd=66, ptr=0x629a0203, 
count=)
at 
../../../../libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:453
#2  0x2b411deaa826 in fd_write () from /opt/openssl/lib/libcrypto.so.1.0.0
#3  0x2b411dea91ab in BIO_write () from /opt/openssl/lib/libcrypto.so.1.0.0
#4  0x2b411db50142 in ssl3_write_pending () from 
/opt/openssl/lib/libssl.so.1.0.0
#5  0x2b411db52a70 in ssl3_dispatch_alert () from 
/opt/openssl/lib/libssl.so.1.0.0
#6  0x2b411db4df92 in ssl3_shutdown () from /opt/openssl/lib/libssl.so.1.0.0
#7  0x00a003a2 in SSLNetVConnection::do_io_close (this=0x6183b880, 
lerrno=-1) at SSLNetVConnection.cc:837
#8  0x0066bb4a in Http1ClientSession::do_io_close (this=0x61929980, 
alerrno=-1) at Http1ClientSession.cc:303
#9  0x0066c7d3 in Http1ClientSession::state_keep_alive 
(this=0x61929980, event=104, data=0x6183b9a0)
at Http1ClientSession.cc:415
#10 0x0053a621 in Continuation::handleEvent (this=0x61929980, 
event=104, data=0x6183b9a0)
at ../iocore/eventsystem/I_Continuation.h:153
#11 0x00a34eab in read_signal_and_update (event=104, vc=0x6183b880) 
at UnixNetVConnection.cc:153
#12 0x00a35594 in read_signal_done (event=104, nh=0x2b4123c27490, 
vc=0x6183b880) at UnixNetVConnection.cc:214
#13 0x00a3b72e in UnixNetVConnection::readSignalDone 
(this=0x6183b880, event=104, nh=0x2b4123c27490)
at UnixNetVConnection.cc:1030
#14 0x009fe003 in SSLNetVConnection::net_read_io (this=0x6183b880, 
nh=0x2b4123c27490, lthread=0x2b4123c23800)
at SSLNetVConnection.cc:620
#15 0x00a227e9 in NetHandler::mainNetEvent (this=0x2b4123c27490, 
event=5, e=0x6090d040) at UnixNet.cc:527
#16 0x0053a621 in Continuation::handleEvent (this=0x2b4123c27490, 
event=5, data=0x6090d040)
at ../iocore/eventsystem/I_Continuation.h:153
#17 0x00a809fb in EThread::process_event (this=0x2b4123c23800, 
e=0x6090d040, calling_code=5) at UnixEThread.cc:146
#18 0x00a8183b in EThread::execute (this=0x2b4123c23800) at 
UnixEThread.cc:273
#19 0x00a7f407 in spawn_thread_internal (a=0x60418890) at 
Thread.cc:84
#20 0x2b411eef8dc5 in start_thread (arg=0x2b4124431700) at 
pthread_create.c:308
#21 0x2b411f920ced in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:113
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4814) Crash in SSLNetVConnection::do_io_close

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4814:
--
Priority: Critical  (was: Major)

> Crash in SSLNetVConnection::do_io_close
> ---
>
> Key: TS-4814
> URL: https://issues.apache.org/jira/browse/TS-4814
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Network, SSL
>Reporter: Leif Hedstrom
>Priority: Critical
> Fix For: 7.0.0
>
>
> Seeing this on latest master, running on docs:
> {code}
> #0  0x2b411eeff1cd in write () at ../sysdeps/unix/syscall-template.S:81
> #1  0x2b411be4860c in __interceptor_write (fd=66, ptr=0x629a0203, 
> count=)
> at 
> ../../../../libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:453
> #2  0x2b411deaa826 in fd_write () from /opt/openssl/lib/libcrypto.so.1.0.0
> #3  0x2b411dea91ab in BIO_write () from 
> /opt/openssl/lib/libcrypto.so.1.0.0
> #4  0x2b411db50142 in ssl3_write_pending () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #5  0x2b411db52a70 in ssl3_dispatch_alert () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #6  0x2b411db4df92 in ssl3_shutdown () from 
> /opt/openssl/lib/libssl.so.1.0.0
> #7  0x00a003a2 in SSLNetVConnection::do_io_close 
> (this=0x6183b880, lerrno=-1) at SSLNetVConnection.cc:837
> #8  0x0066bb4a in Http1ClientSession::do_io_close 
> (this=0x61929980, alerrno=-1) at Http1ClientSession.cc:303
> #9  0x0066c7d3 in Http1ClientSession::state_keep_alive 
> (this=0x61929980, event=104, data=0x6183b9a0)
> at Http1ClientSession.cc:415
> #10 0x0053a621 in Continuation::handleEvent (this=0x61929980, 
> event=104, data=0x6183b9a0)
> at ../iocore/eventsystem/I_Continuation.h:153
> #11 0x00a34eab in read_signal_and_update (event=104, 
> vc=0x6183b880) at UnixNetVConnection.cc:153
> #12 0x00a35594 in read_signal_done (event=104, nh=0x2b4123c27490, 
> vc=0x6183b880) at UnixNetVConnection.cc:214
> #13 0x00a3b72e in UnixNetVConnection::readSignalDone 
> (this=0x6183b880, event=104, nh=0x2b4123c27490)
> at UnixNetVConnection.cc:1030
> #14 0x009fe003 in SSLNetVConnection::net_read_io 
> (this=0x6183b880, nh=0x2b4123c27490, lthread=0x2b4123c23800)
> at SSLNetVConnection.cc:620
> #15 0x00a227e9 in NetHandler::mainNetEvent (this=0x2b4123c27490, 
> event=5, e=0x6090d040) at UnixNet.cc:527
> #16 0x0053a621 in Continuation::handleEvent (this=0x2b4123c27490, 
> event=5, data=0x6090d040)
> at ../iocore/eventsystem/I_Continuation.h:153
> #17 0x00a809fb in EThread::process_event (this=0x2b4123c23800, 
> e=0x6090d040, calling_code=5) at UnixEThread.cc:146
> #18 0x00a8183b in EThread::execute (this=0x2b4123c23800) at 
> UnixEThread.cc:273
> #19 0x00a7f407 in spawn_thread_internal (a=0x60418890) at 
> Thread.cc:84
> #20 0x2b411eef8dc5 in start_thread (arg=0x2b4124431700) at 
> pthread_create.c:308
> #21 0x2b411f920ced in clone () at 
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:113
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4813) HttpTunnel.cc:1215: failed assertion `p->alive == true || event == HTTP_TUNNEL_EVENT_PRECOMPLETE ...

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459465#comment-15459465
 ] 

Leif Hedstrom commented on TS-4813:
---

[~maskit] [~masaori] Any ideas? I did not get a core file, likely because I 
also run this with ASAN, but I can try to disable that and see if we can get 
some more info).

> HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
> HTTP_TUNNEL_EVENT_PRECOMPLETE ...
> 
>
> Key: TS-4813
> URL: https://issues.apache.org/jira/browse/TS-4813
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Network
>Reporter: Leif Hedstrom
>Priority: Critical
> Fix For: 7.0.0
>
>
> Seeing this with current (as of right now) master, on docs.trafficserver:
> {code}
> FATAL: HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
> HTTP_TUNNEL_EVENT_PRECOMPLETE || event == VC_EVENT_EOS || 
> sm->enable_redirection || (p->self_consumer && p->self_consumer->alive == 
> true)`
> traffic_server: using root directory '/opt/ats'
> traffic_server: Aborted (Signal sent by tkill() 13188 99)
> traffic_server - STACK TRACE:
> /opt/ats/lib/libtsutil.so.7(signal_crash_handler(int, siginfo_t*, 
> void*)+0x18)[0x2b6d1031729e]
> /opt/ats/bin/traffic_server(crash_logger_invoke(int, siginfo_t*, 
> void*)+0x155)[0x534104]
> /lib64/libpthread.so.0(+0xf100)[0x2b6d1240f100]
> /lib64/libc.so.6(gsignal+0x37)[0x2b6d12d6e5f7]
> /lib64/libc.so.6(abort+0x148)[0x2b6d12d6fce8]
> /opt/ats/lib/libtsutil.so.7(ink_warning(char const*, ...)+0x0)[0x2b6d102f6f4d]
> /opt/ats/lib/libtsutil.so.7(+0x733a7)[0x2b6d102f13a7]
> /opt/ats/bin/traffic_server(HttpTunnel::producer_handler(int, 
> HttpTunnelProducer*)+0xd14)[0x768a12]
> /opt/ats/bin/traffic_server(HttpTunnel::main_handler(int, 
> void*)+0x13b)[0x76b6e1]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(HttpSM::state_watch_for_client_abort(int, 
> void*)+0x9fe)[0x68c5e6]
> /opt/ats/bin/traffic_server(HttpSM::main_handler(int, void*)+0x58e)[0x69b7ec]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(Http2Stream::main_event_handler(int, 
> void*)+0x59f)[0x79c1df]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(EThread::process_event(Event*, 
> int)+0x2cf)[0xa809fb]
> /opt/ats/bin/traffic_server(EThread::execute()+0x671)[0xa8140f]
> /opt/ats/bin/traffic_server[0xa7f407]
> /lib64/libpthread.so.0(+0x7dc5)[0x2b6d12407dc5]
> /lib64/libc.so.6(clone+0x6d)[0x2b6d12e2fced]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4813) HttpTunnel.cc:1215: failed assertion `p->alive == true || event == HTTP_TUNNEL_EVENT_PRECOMPLETE ...

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4813:
--
Priority: Critical  (was: Major)

> HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
> HTTP_TUNNEL_EVENT_PRECOMPLETE ...
> 
>
> Key: TS-4813
> URL: https://issues.apache.org/jira/browse/TS-4813
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Network
>Reporter: Leif Hedstrom
>Priority: Critical
> Fix For: 7.0.0
>
>
> Seeing this with current (as of right now) master, on docs.trafficserver:
> {code}
> FATAL: HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
> HTTP_TUNNEL_EVENT_PRECOMPLETE || event == VC_EVENT_EOS || 
> sm->enable_redirection || (p->self_consumer && p->self_consumer->alive == 
> true)`
> traffic_server: using root directory '/opt/ats'
> traffic_server: Aborted (Signal sent by tkill() 13188 99)
> traffic_server - STACK TRACE:
> /opt/ats/lib/libtsutil.so.7(signal_crash_handler(int, siginfo_t*, 
> void*)+0x18)[0x2b6d1031729e]
> /opt/ats/bin/traffic_server(crash_logger_invoke(int, siginfo_t*, 
> void*)+0x155)[0x534104]
> /lib64/libpthread.so.0(+0xf100)[0x2b6d1240f100]
> /lib64/libc.so.6(gsignal+0x37)[0x2b6d12d6e5f7]
> /lib64/libc.so.6(abort+0x148)[0x2b6d12d6fce8]
> /opt/ats/lib/libtsutil.so.7(ink_warning(char const*, ...)+0x0)[0x2b6d102f6f4d]
> /opt/ats/lib/libtsutil.so.7(+0x733a7)[0x2b6d102f13a7]
> /opt/ats/bin/traffic_server(HttpTunnel::producer_handler(int, 
> HttpTunnelProducer*)+0xd14)[0x768a12]
> /opt/ats/bin/traffic_server(HttpTunnel::main_handler(int, 
> void*)+0x13b)[0x76b6e1]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(HttpSM::state_watch_for_client_abort(int, 
> void*)+0x9fe)[0x68c5e6]
> /opt/ats/bin/traffic_server(HttpSM::main_handler(int, void*)+0x58e)[0x69b7ec]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(Http2Stream::main_event_handler(int, 
> void*)+0x59f)[0x79c1df]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(EThread::process_event(Event*, 
> int)+0x2cf)[0xa809fb]
> /opt/ats/bin/traffic_server(EThread::execute()+0x671)[0xa8140f]
> /opt/ats/bin/traffic_server[0xa7f407]
> /lib64/libpthread.so.0(+0x7dc5)[0x2b6d12407dc5]
> /lib64/libc.so.6(clone+0x6d)[0x2b6d12e2fced]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4813) HttpTunnel.cc:1215: failed assertion `p->alive == true || event == HTTP_TUNNEL_EVENT_PRECOMPLETE ...

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4813:
--
Fix Version/s: 7.0.0

> HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
> HTTP_TUNNEL_EVENT_PRECOMPLETE ...
> 
>
> Key: TS-4813
> URL: https://issues.apache.org/jira/browse/TS-4813
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Network
>Reporter: Leif Hedstrom
> Fix For: 7.0.0
>
>
> Seeing this with current (as of right now) master, on docs.trafficserver:
> {code}
> FATAL: HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
> HTTP_TUNNEL_EVENT_PRECOMPLETE || event == VC_EVENT_EOS || 
> sm->enable_redirection || (p->self_consumer && p->self_consumer->alive == 
> true)`
> traffic_server: using root directory '/opt/ats'
> traffic_server: Aborted (Signal sent by tkill() 13188 99)
> traffic_server - STACK TRACE:
> /opt/ats/lib/libtsutil.so.7(signal_crash_handler(int, siginfo_t*, 
> void*)+0x18)[0x2b6d1031729e]
> /opt/ats/bin/traffic_server(crash_logger_invoke(int, siginfo_t*, 
> void*)+0x155)[0x534104]
> /lib64/libpthread.so.0(+0xf100)[0x2b6d1240f100]
> /lib64/libc.so.6(gsignal+0x37)[0x2b6d12d6e5f7]
> /lib64/libc.so.6(abort+0x148)[0x2b6d12d6fce8]
> /opt/ats/lib/libtsutil.so.7(ink_warning(char const*, ...)+0x0)[0x2b6d102f6f4d]
> /opt/ats/lib/libtsutil.so.7(+0x733a7)[0x2b6d102f13a7]
> /opt/ats/bin/traffic_server(HttpTunnel::producer_handler(int, 
> HttpTunnelProducer*)+0xd14)[0x768a12]
> /opt/ats/bin/traffic_server(HttpTunnel::main_handler(int, 
> void*)+0x13b)[0x76b6e1]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(HttpSM::state_watch_for_client_abort(int, 
> void*)+0x9fe)[0x68c5e6]
> /opt/ats/bin/traffic_server(HttpSM::main_handler(int, void*)+0x58e)[0x69b7ec]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(Http2Stream::main_event_handler(int, 
> void*)+0x59f)[0x79c1df]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(EThread::process_event(Event*, 
> int)+0x2cf)[0xa809fb]
> /opt/ats/bin/traffic_server(EThread::execute()+0x671)[0xa8140f]
> /opt/ats/bin/traffic_server[0xa7f407]
> /lib64/libpthread.so.0(+0x7dc5)[0x2b6d12407dc5]
> /lib64/libc.so.6(clone+0x6d)[0x2b6d12e2fced]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4813) HttpTunnel.cc:1215: failed assertion `p->alive == true || event == HTTP_TUNNEL_EVENT_PRECOMPLETE ...

[Leif Hedstrom (JIRA)]

Leif Hedstrom created TS-4813:
-

 Summary: HttpTunnel.cc:1215: failed assertion `p->alive == true || 
event == HTTP_TUNNEL_EVENT_PRECOMPLETE ...
 Key: TS-4813
 URL: https://issues.apache.org/jira/browse/TS-4813
 Project: Traffic Server
  Issue Type: Bug
  Components: Network
Reporter: Leif Hedstrom


Seeing this with current (as of right now) master, on docs.trafficserver:

{code}
FATAL: HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
HTTP_TUNNEL_EVENT_PRECOMPLETE || event == VC_EVENT_EOS || 
sm->enable_redirection || (p->self_consumer && p->self_consumer->alive == true)`
traffic_server: using root directory '/opt/ats'
traffic_server: Aborted (Signal sent by tkill() 13188 99)
traffic_server - STACK TRACE:
/opt/ats/lib/libtsutil.so.7(signal_crash_handler(int, siginfo_t*, 
void*)+0x18)[0x2b6d1031729e]
/opt/ats/bin/traffic_server(crash_logger_invoke(int, siginfo_t*, 
void*)+0x155)[0x534104]
/lib64/libpthread.so.0(+0xf100)[0x2b6d1240f100]
/lib64/libc.so.6(gsignal+0x37)[0x2b6d12d6e5f7]
/lib64/libc.so.6(abort+0x148)[0x2b6d12d6fce8]
/opt/ats/lib/libtsutil.so.7(ink_warning(char const*, ...)+0x0)[0x2b6d102f6f4d]
/opt/ats/lib/libtsutil.so.7(+0x733a7)[0x2b6d102f13a7]
/opt/ats/bin/traffic_server(HttpTunnel::producer_handler(int, 
HttpTunnelProducer*)+0xd14)[0x768a12]
/opt/ats/bin/traffic_server(HttpTunnel::main_handler(int, 
void*)+0x13b)[0x76b6e1]
/opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
void*)+0x149)[0x53a621]
/opt/ats/bin/traffic_server(HttpSM::state_watch_for_client_abort(int, 
void*)+0x9fe)[0x68c5e6]
/opt/ats/bin/traffic_server(HttpSM::main_handler(int, void*)+0x58e)[0x69b7ec]
/opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
void*)+0x149)[0x53a621]
/opt/ats/bin/traffic_server(Http2Stream::main_event_handler(int, 
void*)+0x59f)[0x79c1df]
/opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
void*)+0x149)[0x53a621]
/opt/ats/bin/traffic_server(EThread::process_event(Event*, int)+0x2cf)[0xa809fb]
/opt/ats/bin/traffic_server(EThread::execute()+0x671)[0xa8140f]
/opt/ats/bin/traffic_server[0xa7f407]
/lib64/libpthread.so.0(+0x7dc5)[0x2b6d12407dc5]
/lib64/libc.so.6(clone+0x6d)[0x2b6d12e2fced]
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4810) We no longer build LuaJIT on OmniOS properly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?focusedWorklogId=27973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27973
 ]

ASF GitHub Bot logged work on TS-4810:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 20:00
Start Date: 02/Sep/16 20:00
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/961#discussion_r77404086
  
--- Diff: configure.ac ---
@@ -1808,15 +1806,15 @@ iocore_include_dirs="\
 # of the generic flags, plus any Lua-specific flags so that we
 # can strip the coverage flags from Lua while keeping them by
 # default everywhere else.
-TS_ADDTO(LUA_CFLAGS, [$CFLAGS $lua_cflags])
-AC_SUBST([LUA_CFLAGS])
+TS_ADDTO(LUAJIT_CFLAGS, [$CFLAGS $lua_cflags])
--- End diff --

You should probably rename ``lua_cflags`` to ``luajit_cflags`` as well.


Issue Time Tracking
---

Worklog Id: (was: 27973)
Time Spent: 1h  (was: 50m)

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #961: TS-4810: Use the correct LuaJIT LDFLAGS

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/961#discussion_r77404086
  
--- Diff: configure.ac ---
@@ -1808,15 +1806,15 @@ iocore_include_dirs="\
 # of the generic flags, plus any Lua-specific flags so that we
 # can strip the coverage flags from Lua while keeping them by
 # default everywhere else.
-TS_ADDTO(LUA_CFLAGS, [$CFLAGS $lua_cflags])
-AC_SUBST([LUA_CFLAGS])
+TS_ADDTO(LUAJIT_CFLAGS, [$CFLAGS $lua_cflags])
--- End diff --

You should probably rename ``lua_cflags`` to ``luajit_cflags`` as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (TS-4810) We no longer build LuaJIT on OmniOS properly

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom reassigned TS-4810:
-

Assignee: Leif Hedstrom

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4810) We no longer build LuaJIT on OmniOS properly

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4810:
--
Fix Version/s: 7.0.0

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27971
 ]

ASF GitHub Bot logged work on TS-4809:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 19:46
Start Date: 02/Sep/16 19:46
Worklog Time Spent: 10m 
  Work Description: Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/960


Issue Time Tracking
---

Worklog Id: (was: 27971)
Time Spent: 1.5h  (was: 1h 20m)

> [header_rewrite] check to make sure "hook" conditions are first in the rule 
> set 
> 
>
> Key: TS-4809
> URL: https://issues.apache.org/jira/browse/TS-4809
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.0.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1: \
> @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem 
> is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print 
> another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come 
> first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #960: TS-4809 header_rewrite "hook" conditions ch...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/960


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27968
 ]

ASF GitHub Bot logged work on TS-4809:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 19:43
Start Date: 02/Sep/16 19:43
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
:+1:


Issue Time Tracking
---

Worklog Id: (was: 27968)
Time Spent: 1h 20m  (was: 1h 10m)

> [header_rewrite] check to make sure "hook" conditions are first in the rule 
> set 
> 
>
> Key: TS-4809
> URL: https://issues.apache.org/jira/browse/TS-4809
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1: \
> @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem 
> is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print 
> another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come 
> first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #960: TS-4809 header_rewrite "hook" conditions checks

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
:+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27967
 ]

ASF GitHub Bot logged work on TS-4809:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 19:39
Start Date: 02/Sep/16 19:39
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/581/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27967)
Time Spent: 1h 10m  (was: 1h)

> [header_rewrite] check to make sure "hook" conditions are first in the rule 
> set 
> 
>
> Key: TS-4809
> URL: https://issues.apache.org/jira/browse/TS-4809
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1: \
> @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem 
> is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print 
> another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come 
> first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #960: TS-4809 header_rewrite "hook" conditions checks

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/581/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27966
 ]

ASF GitHub Bot logged work on TS-4809:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 19:33
Start Date: 02/Sep/16 19:33
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/685/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27966)
Time Spent: 1h  (was: 50m)

> [header_rewrite] check to make sure "hook" conditions are first in the rule 
> set 
> 
>
> Key: TS-4809
> URL: https://issues.apache.org/jira/browse/TS-4809
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1: \
> @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem 
> is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print 
> another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come 
> first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #960: TS-4809 header_rewrite "hook" conditions checks

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/685/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27965&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27965
 ]

ASF GitHub Bot logged work on TS-4809:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 19:25
Start Date: 02/Sep/16 19:25
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
Build again, VMs rebooted [approve ci] 


Issue Time Tracking
---

Worklog Id: (was: 27965)
Time Spent: 50m  (was: 40m)

> [header_rewrite] check to make sure "hook" conditions are first in the rule 
> set 
> 
>
> Key: TS-4809
> URL: https://issues.apache.org/jira/browse/TS-4809
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1: \
> @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem 
> is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print 
> another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come 
> first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #960: TS-4809 header_rewrite "hook" conditions checks

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
Build again, VMs rebooted [approve ci] 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4810) We no longer build LuaJIT on OmniOS properly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?focusedWorklogId=27964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27964
 ]

ASF GitHub Bot logged work on TS-4810:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 19:04
Start Date: 02/Sep/16 19:04
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/579/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27964)
Time Spent: 50m  (was: 40m)

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27963
 ]

ASF GitHub Bot logged work on TS-4809:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 19:04
Start Date: 02/Sep/16 19:04
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/580/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27963)
Time Spent: 40m  (was: 0.5h)

> [header_rewrite] check to make sure "hook" conditions are first in the rule 
> set 
> 
>
> Key: TS-4809
> URL: https://issues.apache.org/jira/browse/TS-4809
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1: \
> @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem 
> is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print 
> another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come 
> first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #961: TS-4810: Use the correct LuaJIT LDFLAGS

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/579/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #960: TS-4809 header_rewrite "hook" conditions checks

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/580/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27962
 ]

ASF GitHub Bot logged work on TS-4809:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 18:59
Start Date: 02/Sep/16 18:59
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/684/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27962)
Time Spent: 0.5h  (was: 20m)

> [header_rewrite] check to make sure "hook" conditions are first in the rule 
> set 
> 
>
> Key: TS-4809
> URL: https://issues.apache.org/jira/browse/TS-4809
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1: \
> @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem 
> is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print 
> another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come 
> first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #960: TS-4809 header_rewrite "hook" conditions checks

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/684/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #961: TS-4810: Use the correct LuaJIT LDFLAGS

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/683/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4810) We no longer build LuaJIT on OmniOS properly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4810?focusedWorklogId=27961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27961
 ]

ASF GitHub Bot logged work on TS-4810:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 18:59
Start Date: 02/Sep/16 18:59
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/961
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/683/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 27961)
Time Spent: 40m  (was: 0.5h)

> We no longer build LuaJIT on OmniOS properly
> 
>
> Key: TS-4810
> URL: https://issues.apache.org/jira/browse/TS-4810
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Build
>Reporter: Leif Hedstrom
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Looks like we missed a change in the configure and substitutions. It's an 
> easy fix, I'll have a patch after gym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4809) [header_rewrite] check to make sure "hook" conditions are first in the rule set

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4809?focusedWorklogId=27960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27960
 ]

ASF GitHub Bot logged work on TS-4809:
--

Author: ASF GitHub Bot
Created on: 02/Sep/16 18:50
Start Date: 02/Sep/16 18:50
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/960
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 27960)
Time Spent: 20m  (was: 10m)

> [header_rewrite] check to make sure "hook" conditions are first in the rule 
> set 
> 
>
> Key: TS-4809
> URL: https://issues.apache.org/jira/browse/TS-4809
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Gancho Tenev
>Assignee: Gancho Tenev
> Fix For: 7.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The following configuration
> {code}
> $ cat etc/trafficserver/remap.config
> map http://example.com http://127.0.0.1: \
> @plugin=header_rewrite.so @pparam=hdrs.config
> $ cat etc/trafficserver/hdrs.config
> cond %{TRUE}
> cond %{REMAP_PSEUDO_HOOK}
>set-header Some-Header "some value"
> {code}
> Triggers the following error which does not show what and where the problem 
> is:
> {code}
> 20160901.23h17m13s [header_rewrite] Unknown condition: REMAP_PSEUDO_HOOK
> {code}
> I would like to add a check which will prevent the above error and print 
> another error clarifying where and what the problem is, for instance:
> {code}
> 20160901.23h17m13s [header_rewrite] cond %{REMAP_PSEUDO_HOOK} should come 
> first in the rule set at hdrs.config:2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)