[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
[
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34967
]
ASF GitHub Bot logged work on TS-5105:
--
Author: ASF GitHub Bot
Created on: 08/Jan/17 06:32
Start Date: 08/Jan/17 06:32
Worklog Time Spent: 10m
Work Description: Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1276
Sorry, it is my fault, the commit 724f7cb5cc2c689d618ad306b5ca5795aec88b11
did not merge into 6.2.x. I should rewrite the patch working with
vc->server_addr.
Issue Time Tracking
---
Worklog Id: (was: 34967)
Time Spent: 2h 10m (was: 2h)
> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
> Issue Type: Bug
> Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at
> /usr/local/bin/traffic_server
> 0x80275ab37 at /lib/libthr.so.3
> 0x80275a22c at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled =
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Config File:
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG: (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(&target_addr)), function init, file Socks.cc,
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at
> /usr/local/bin/traffic_server
> 0x80275ab37 at /lib/libthr.so.3
> 0x80275a22c at /lib/libthr.so.3
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1276 Sorry, it is my fault, the commit 724f7cb5cc2c689d618ad306b5ca5795aec88b11 did not merge into 6.2.x. I should rewrite the patch working with vc->server_addr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1175: socks.config - dest_ip rule issue
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/issues/1175
The libssl error is not related to this issue. Do you running the ats in
another server that different to build server?
In the last message you post here, the log line missing:
```
[Dec 21 17:27:35.052] Server {0x804008000} DEBUG: (Socks) Using Socks ip: 216.58.192.142:80
```
Can you try to rebuild the ATS ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
[
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34966
]
ASF GitHub Bot logged work on TS-5105:
--
Author: ASF GitHub Bot
Created on: 08/Jan/17 05:32
Start Date: 08/Jan/17 05:32
Worklog Time Spent: 10m
Work Description: Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1276
It is crash in ats_base64_encode during regression test.
```
traffic_server: Aborted (Signal sent by tkill() 2585 989)
traffic_server - STACK TRACE:
/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(crash_logger_invoke(int,
siginfo_t*, void*)+0xc3)[0x5096f4]
/lib64/libpthread.so.0(+0xf370)[0x7f601e88f370]
/lib64/libc.so.6(gsignal+0x37)[0x7f601d7651d7]
/lib64/libc.so.6(abort+0x148)[0x7f601d7668c8]
/var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_fatal_va(char
const*, __va_list_tag*)+0x0)[0x7f60203891fd]
/var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_fatal(char
const*, ...)+0x0)[0x7f60203892b6]
/var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_pfatal(char
const*, ...)+0x0)[0x7f6020389355]
/var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ats_base64_encode(unsigned
char const*, unsigned long, char*, unsigned long, unsigned
long*)+0x0)[0x7f6020386d96]
/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server[0x56ce19]
/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(INKContInternal::handle_event(int,
void*)+0xe5)[0x520b83]
/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(Continuation::handleEvent(int,
void*)+0x72)[0x50c662]
/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(EThread::process_event(Event*,
int)+0x136)[0x79e4dc]
/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(EThread::execute()+0x288)[0x79e8e8]
/var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server[0x79dabd]
/lib64/libpthread.so.0(+0x7dc5)[0x7f601e887dc5]
/lib64/libc.so.6(clone+0x6d)[0x7f601d82773d]
```
Issue Time Tracking
---
Worklog Id: (was: 34966)
Time Spent: 2h (was: 1h 50m)
> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
> Issue Type: Bug
> Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at
> /usr/local/bin/traffic_server
> 0x80275ab37 at /lib/libthr.so.3
> 0x80275a22c at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled =
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Config File:
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG: (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(&target_addr)), function init, file Socks.cc,
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at
> /usr/local/bin/traffic_server
> 0x80275ab37 at /lib/libthr.so.3
> 0x80275a22c at /lib/libthr.so.3
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1276 It is crash in ats_base64_encode during regression test. ``` traffic_server: Aborted (Signal sent by tkill() 2585 989) traffic_server - STACK TRACE: /var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(crash_logger_invoke(int, siginfo_t*, void*)+0xc3)[0x5096f4] /lib64/libpthread.so.0(+0xf370)[0x7f601e88f370] /lib64/libc.so.6(gsignal+0x37)[0x7f601d7651d7] /lib64/libc.so.6(abort+0x148)[0x7f601d7668c8] /var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_fatal_va(char const*, __va_list_tag*)+0x0)[0x7f60203891fd] /var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_fatal(char const*, ...)+0x0)[0x7f60203892b6] /var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ink_pfatal(char const*, ...)+0x0)[0x7f6020389355] /var/jenkins/workspace/Github-Linux/1204/install/lib/libtsutil.so.6(ats_base64_encode(unsigned char const*, unsigned long, char*, unsigned long, unsigned long*)+0x0)[0x7f6020386d96] /var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server[0x56ce19] /var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(INKContInternal::handle_event(int, void*)+0xe5)[0x520b83] /var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(Continuation::handleEvent(int, void*)+0x72)[0x50c662] /var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(EThread::process_event(Event*, int)+0x136)[0x79e4dc] /var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server(EThread::execute()+0x288)[0x79e8e8] /var/jenkins/workspace/Github-Linux/1204/install/bin/traffic_server[0x79dabd] /lib64/libpthread.so.0(+0x7dc5)[0x7f601e887dc5] /lib64/libc.so.6(clone+0x6d)[0x7f601d82773d] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
[
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34965&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34965
]
ASF GitHub Bot logged work on TS-5105:
--
Author: ASF GitHub Bot
Created on: 08/Jan/17 03:22
Start Date: 08/Jan/17 03:22
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1276
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/1204/ for details.
Issue Time Tracking
---
Worklog Id: (was: 34965)
Time Spent: 1h 50m (was: 1h 40m)
> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
> Issue Type: Bug
> Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at
> /usr/local/bin/traffic_server
> 0x80275ab37 at /lib/libthr.so.3
> 0x80275a22c at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled =
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Config File:
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG: (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(&target_addr)), function init, file Socks.cc,
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at
> /usr/local/bin/traffic_server
> 0x80275ab37 at /lib/libthr.so.3
> 0x80275a22c at /lib/libthr.so.3
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1276 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1204/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1301: Can trafficserver proxy to another proxy?
Github user lucaswxp commented on the issue: https://github.com/apache/trafficserver/issues/1301 @zwoop That's already helpful. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1276 Trying a new build [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Work logged] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
[
https://issues.apache.org/jira/browse/TS-5105?focusedWorklogId=34964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34964
]
ASF GitHub Bot logged work on TS-5105:
--
Author: ASF GitHub Bot
Created on: 08/Jan/17 03:07
Start Date: 08/Jan/17 03:07
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1276
Trying a new build [approve ci]
Issue Time Tracking
---
Worklog Id: (was: 34964)
Time Spent: 1h 40m (was: 1.5h)
> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
> Issue Type: Bug
> Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at
> /usr/local/bin/traffic_server
> 0x80275ab37 at /lib/libthr.so.3
> 0x80275a22c at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled =
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Config File:
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG: (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG: (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(&target_addr)), function init, file Socks.cc,
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at
> /usr/local/bin/traffic_server
> 0x80275ab37 at /lib/libthr.so.3
> 0x80275a22c at /lib/libthr.so.3
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-5022) Multiple Client Certificate to Origin
[ https://issues.apache.org/jira/browse/TS-5022?focusedWorklogId=34963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34963 ] ASF GitHub Bot logged work on TS-5022: -- Author: ASF GitHub Bot Created on: 08/Jan/17 03:06 Start Date: 08/Jan/17 03:06 Worklog Time Spent: 10m Work Description: Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1305 Issue Time Tracking --- Worklog Id: (was: 34963) Time Spent: 5h 40m (was: 5.5h) > Multiple Client Certificate to Origin > - > > Key: TS-5022 > URL: https://issues.apache.org/jira/browse/TS-5022 > Project: Traffic Server > Issue Type: Improvement > Components: Security, SSL, TLS >Reporter: Scott Beardsley >Assignee: Syeda Persia Aziz > Labels: yahoo > Fix For: 7.1.0 > > Time Spent: 5h 40m > Remaining Estimate: 0h > > Yahoo has a use case where the origin is doing mutual TLS authentication > which requires ATS to send a client certificate. This works fine (for now) > because ATS supports configuring *one* client cert but this feature should > really allow multiple client certificates to be configured which would depend > upon the origin being contacted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] trafficserver issue #1305: CID 1368316 Resource leak
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1305 Closing this as a dupe of #1308, since it has more details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1305: CID 1368316 Resource leak
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Work logged] (TS-5092) ATS handling of too many concurrent streams too agressive and maybe out of spec
[
https://issues.apache.org/jira/browse/TS-5092?focusedWorklogId=34962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34962
]
ASF GitHub Bot logged work on TS-5092:
--
Author: ASF GitHub Bot
Created on: 08/Jan/17 02:56
Start Date: 08/Jan/17 02:56
Worklog Time Spent: 10m
Work Description: GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1308
CID 1368316 & 1368315: Leaks and NULL references
I think this landed recently (TS-5092?), and we have to fix this for 7.1.x.
clang-analyzer also detects the NULL pointer reference.
```C
** CID 1368316: Resource leaks (RESOURCE_LEAK)
/proxy/http/HttpSM.cc: 5049 in HttpSM::do_http_server_open(bool)()
*** CID 1368316: Resource leaks (RESOURCE_LEAK)
/proxy/http/HttpSM.cc: 5049 in HttpSM::do_http_server_open(bool)()
5043 int len = 0;
5044 const char *host =
t_state.hdr_info.server_request.host_get(&len);
5045 if (host && len > 0) {
5046 opt.set_sni_servername(host, len);
5047 }
5048
CID 1368316: Resource leaks (RESOURCE_LEAK)
Failing to save or free storage allocated by
"Layout::relative_to(this->t_state.txn_conf->client_cert_filepath,
this->t_state.txn_conf->client_cert_filename)" leaks it.
5049 ats_scoped_str clientCert(
5050
ats_strdup((Layout::relative_to(t_state.txn_conf->client_cert_filepath,
t_state.txn_conf->client_cert_filename;
5051 opt.set_client_certname(clientCert);
5052 connect_action_handle = sslNetProcessor.connect_re(this,
// state machine
5053
&t_state.current.server->dst_addr.sa, // addr + port
5054&opt);
** CID 1368315: Null pointer dereferences (FORWARD_NULL)
/proxy/http2/Http2ConnectionState.cc: 217 in
rcv_headers_frame(Http2ConnectionState &, const Http2Frame &)()
*** CID 1368315: Null pointer dereferences (FORWARD_NULL)
/proxy/http2/Http2ConnectionState.cc: 217 in
rcv_headers_frame(Http2ConnectionState &, const Http2Frame &)()
211 if (!stream) {
212 return error;
213 }
214 }
215
216 // keep track of how many bytes we get in the frame
CID 1368315: Null pointer dereferences (FORWARD_NULL)
Dereferencing null pointer "stream".
217 stream->request_header_length += payload_length;
218 if (stream->request_header_length >
Http2::max_request_header_size) {
219 return Http2Error(HTTP2_ERROR_CLASS_STREAM,
HTTP2_ERROR_PROTOCOL_ERROR,
220 "recv headers payload for headers greater
than header length");
221 }
222
```
Issue Time Tracking
---
Worklog Id: (was: 34962)
Time Spent: 1.5h (was: 1h 20m)
> ATS handling of too many concurrent streams too agressive and maybe out of
> spec
> ---
>
> Key: TS-5092
> URL: https://issues.apache.org/jira/browse/TS-5092
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.1.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This issue was identified while debugging new errors seen by an internal team
> after they enabled HTTP/2 in their client. On the backend, they saw an
> increase in the cases were ATS sends the origin the POST header but no POST
> body and then closes the connection.
> With the addition of Error() messages we were able to see a case where the
> client is trying to open the 101'st stream on a session. This is beyond the
> 100 max concurrent stream limit, so ATS shuts down the session which kills
> the previous 100 streams.
> A closer reading of section 5.1.2 of the spec
> (https://tools.ietf.org/html/rfc7540#section-5.1.2) indicates that this
> should be a stream error and not a connection error. Bryan Call, Masaori, and
> Maskit confirmed this interpretation. Maskit also noted that the other error
> case in the current createStream method must be treated as a connection error.
> Presumably the client library is expecting the refused stream case so it can
> try again later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] trafficserver issue #1308: CID 1368316 & 1368315: Leaks and NULL references
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1308
CID 1368316 & 1368315: Leaks and NULL references
I think this landed recently (TS-5092?), and we have to fix this for 7.1.x.
clang-analyzer also detects the NULL pointer reference.
```C
** CID 1368316: Resource leaks (RESOURCE_LEAK)
/proxy/http/HttpSM.cc: 5049 in HttpSM::do_http_server_open(bool)()
*** CID 1368316: Resource leaks (RESOURCE_LEAK)
/proxy/http/HttpSM.cc: 5049 in HttpSM::do_http_server_open(bool)()
5043 int len = 0;
5044 const char *host =
t_state.hdr_info.server_request.host_get(&len);
5045 if (host && len > 0) {
5046 opt.set_sni_servername(host, len);
5047 }
5048
CID 1368316: Resource leaks (RESOURCE_LEAK)
Failing to save or free storage allocated by
"Layout::relative_to(this->t_state.txn_conf->client_cert_filepath,
this->t_state.txn_conf->client_cert_filename)" leaks it.
5049 ats_scoped_str clientCert(
5050
ats_strdup((Layout::relative_to(t_state.txn_conf->client_cert_filepath,
t_state.txn_conf->client_cert_filename;
5051 opt.set_client_certname(clientCert);
5052 connect_action_handle = sslNetProcessor.connect_re(this,
// state machine
5053
&t_state.current.server->dst_addr.sa, // addr + port
5054&opt);
** CID 1368315: Null pointer dereferences (FORWARD_NULL)
/proxy/http2/Http2ConnectionState.cc: 217 in
rcv_headers_frame(Http2ConnectionState &, const Http2Frame &)()
*** CID 1368315: Null pointer dereferences (FORWARD_NULL)
/proxy/http2/Http2ConnectionState.cc: 217 in
rcv_headers_frame(Http2ConnectionState &, const Http2Frame &)()
211 if (!stream) {
212 return error;
213 }
214 }
215
216 // keep track of how many bytes we get in the frame
CID 1368315: Null pointer dereferences (FORWARD_NULL)
Dereferencing null pointer "stream".
217 stream->request_header_length += payload_length;
218 if (stream->request_header_length >
Http2::max_request_header_size) {
219 return Http2Error(HTTP2_ERROR_CLASS_STREAM,
HTTP2_ERROR_PROTOCOL_ERROR,
220 "recv headers payload for headers greater
than header length");
221 }
222
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Work logged] (TS-5107) ATS 7.0.0 doesn't build against python docutils 0.13.1
[
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34961
]
ASF GitHub Bot logged work on TS-5107:
--
Author: ASF GitHub Bot
Created on: 08/Jan/17 02:52
Start Date: 08/Jan/17 02:52
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1303
We need into 7.1.x as well, right?
Issue Time Tracking
---
Worklog Id: (was: 34961)
Time Spent: 2h 10m (was: 2h)
> ATS 7.0.0 doesn't build against python docutils 0.13.1
> --
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
> Issue Type: Bug
> Components: Documentation
>Reporter: Jean Baptiste Favre
>Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c . -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [ 0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
> File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> . Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
> which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1303 We need into 7.1.x as well, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1306: [openbsd] pthread_np.h needs to be included
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1306 Yeh, I agree with peach, it seems very odd that it's not picking it up properly. It'd be better to fix that, instead of ifdef on openbsd IMO. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1306: [openbsd] pthread_np.h needs to be included
Github user jirib commented on the issue: https://github.com/apache/trafficserver/issues/1306 putting this - ac_cv_header_pthread_np_h=yes - as configure env doesn't need to change ink_thread_.h --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1306: [openbsd] pthread_np.h needs to be included
Github user jirib commented on the issue: https://github.com/apache/trafficserver/issues/1306 config.log https://gist.github.com/jirib/70174b76156791036eca9a80f5ff0120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1307: [openbsd] build fails while building SSLUtils.cc
GitHub user jirib opened an issue:
https://github.com/apache/trafficserver/issues/1307
[openbsd] build fails while building SSLUtils.cc
Build fails on OpenBSD.
```
kern.version=OpenBSD 6.0-current (GENERIC.MP) #0: Wed Nov 23 20:54:10 MST
2016
bu...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
```
```
c++ -DHAVE_CONFIG_H -I. -I../../lib -I../../iocore/eventsystem
-I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb
-I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils
-I../../iocore/dns -I../../lib -I../../lib/records -I../../proxy
-I../../proxy/hdrs -I../../proxy/shared -I../../proxy/logging -I../../mgmt
-I../../mgmt/utils -I../../proxy/api/ts -I../../proxy/http -I/usr/include
-I/usr/local/include-Dopenbsd -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1
-D_GNU_SOURCE -D_REENTRANT -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1
-D_FORTIFY_SOURCE=2 -I/usr/include -DOPENSSL_NO_SSL_INTERN
-I/usr/local/include/tcl8.5 -O2 -pipe -O0 -g -std=c++11 -Wall -Wextra
-Wno-ignored-qualifiers -Wno-unused-parameter -feliminate-unused-debug-symbols
-fno-strict-aliasing -Wno-invalid-offsetof -fPIE -fstack-protector -mcx16 -MT
SSLUtils.o -MD -MP -MF $depbase.Tpo -c -o SSLUtils.o SSLUtils.cc &&\
mv -f $depbase.Tpo $depbase.Po
SSLUtils.cc: In function 'void SSLInitializeLibrary()':
SSLUtils.cc:917:83: error: invalid conversion from 'void* (*)(size_t, const
char*, int) {aka void* (*)(long unsigned int, const char*, int)}' to 'void*
(*)(size_t) {aka void* (*)(long unsigned int)}' [-fpermissive]
CRYPTO_set_mem_functions(ssl_track_malloc, ssl_track_realloc,
ssl_track_free);
^
In file included from /usr/include/openssl/bio.h:69:0,
from /usr/include/openssl/evp.h:67,
from /usr/include/openssl/hmac.h:67,
from /usr/include/openssl/ssl.h:149,
from P_SSLNetVConnection.h:41,
from P_Net.h:104,
from SSLUtils.cc:26:
/usr/include/openssl/crypto.h:412:5: note: initializing argument 1 of 'int
CRYPTO_set_mem_functions(void* (*)(size_t), void* (*)(void*, size_t), void
(*)(void*))'
int CRYPTO_set_mem_functions(void *(*m)(size_t), void *(*r)(void *,
size_t), void (*f)(void *));
^
SSLUtils.cc:917:83: error: invalid conversion from 'void* (*)(void*,
size_t, const char*, int) {aka void* (*)(void*, long unsigned int, const char*,
int)}' to 'void* (*)(void*, size_t) {aka void* (*)(void*, longunsigned int)}'
[-fpermissive]
CRYPTO_set_mem_functions(ssl_track_malloc, ssl_track_realloc,
ssl_track_free);
^
In file included from /usr/include/openssl/bio.h:69:0,
from /usr/include/openssl/evp.h:67,
from /usr/include/openssl/hmac.h:67,
from /usr/include/openssl/ssl.h:149,
from P_SSLNetVConnection.h:41,
from P_Net.h:104,
from SSLUtils.cc:26:
/usr/include/openssl/crypto.h:412:5: note: initializing argument 2 of 'int
CRYPTO_set_mem_functions(void* (*)(size_t), void* (*)(void*, size_t), void
(*)(void*))'
int CRYPTO_set_mem_functions(void *(*m)(size_t), void *(*r)(void *,
size_t), void (*f)(void *));
^
SSLUtils.cc:917:83: error: invalid conversion from 'void (*)(void*, const
char*, int)' to 'void (*)(void*)' [-fpermissive]
CRYPTO_set_mem_functions(ssl_track_malloc, ssl_track_realloc,
ssl_track_free);
^
In file included from /usr/include/openssl/bio.h:69:0,
from /usr/include/openssl/evp.h:67,
from /usr/include/openssl/hmac.h:67,
from /usr/include/openssl/ssl.h:149,
from P_SSLNetVConnection.h:41,
from P_Net.h:104,
from SSLUtils.cc:26:
/usr/include/openssl/crypto.h:412:5: note: initializing argument 3 of 'int
CRYPTO_set_mem_functions(void* (*)(size_t), void* (*)(void*, size_t), void
(*)(void*))'
int CRYPTO_set_mem_functions(void *(*m)(size_t), void *(*r)(void *,
size_t), void (*f)(void *));
^
SSLUtils.cc:919:65: error: invalid conversion from 'void* (*)(size_t, const
char*, int) {aka void* (*)(long unsigned int, const char*, int)}' to 'void*
(*)(size_t) {aka void* (*)(long unsigned int)}' [-fpermissive]
CRYPTO_set_mem_functions(ssl_malloc, ssl_realloc, ssl_free);
^
In file included from /usr/include/openssl/bio.h:69:0,
from /usr/include/openssl/evp.h:67,
from /usr/include/op
[GitHub] trafficserver issue #1306: [openbsd] pthread_np.h needs to be included
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/issues/1306 The doesn't the existing configure check pick this header up? > On Jan 7, 2017, at 12:19 PM, jirib wrote: > > This passes at least some first steps in trying to build trafficserver on OpenBSD. Please consider this or better variation, thank you. > > kern.version=OpenBSD 6.0-current (GENERIC.MP) #0: Wed Nov 23 20:54:10 MST 2016 > bu...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP > --- lib/ts/ink_thread.h.origThu Oct 20 21:08:55 2016 > +++ lib/ts/ink_thread.h Sat Jan 7 21:16:56 2017 > @@ -44,6 +44,10 @@ > #include > #include > > +#if defined(openbsd) > +#include > +#endif > + > #if HAVE_PTHREAD_NP_H > #include > #endif > â > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or mute the thread. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1306: [openbsd] pthread_np.h needs to be included
GitHub user jirib opened an issue: https://github.com/apache/trafficserver/issues/1306 [openbsd] pthread_np.h needs to be included This passes at least some first steps in trying to build trafficserver on OpenBSD. Please consider this or better variation, thank you. ``` kern.version=OpenBSD 6.0-current (GENERIC.MP) #0: Wed Nov 23 20:54:10 MST 2016 bu...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP ``` ``` --- lib/ts/ink_thread.h.origThu Oct 20 21:08:55 2016 +++ lib/ts/ink_thread.h Sat Jan 7 21:16:56 2017 @@ -44,6 +44,10 @@ #include #include +#if defined(openbsd) +#include +#endif + #if HAVE_PTHREAD_NP_H #include #endif ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1305: CID 1368316 Resource leak
GitHub user persiaAziz opened an issue: https://github.com/apache/trafficserver/issues/1305 CID 1368316 Resource leak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
