[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()

[bgaff]

Github user bgaff commented on the issue:

https://github.com/apache/trafficserver/pull/1328
  
Shall I merge it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1350: TS-5080: log when remap.config is successf...

[randall]

GitHub user randall opened a pull request:

https://github.com/apache/trafficserver/pull/1350

TS-5080: log when remap.config is successfully reloaded



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/randall/trafficserver TS-5080

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1350


commit 32de6b8b45bcb9cba82768bbe997925f90bbad2f
Author: Randall Meyer 
Date:   2016-12-05T23:18:39Z

TS-5080: log when remap.config is successfully reloaded




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1349: TS-5079: logging enhancements around OCSP

[randall]

GitHub user randall opened a pull request:

https://github.com/apache/trafficserver/pull/1349

TS-5079: logging enhancements around OCSP



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/randall/trafficserver TS-5079

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1349


commit 5faa6542abc343b24cb8a187d9c688ea0726cca4
Author: Randall Meyer 
Date:   2016-12-05T23:30:53Z

TS-5079: logging enhancements around OCSP




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1348: log all config file reloads in a consistent manne...

[randall]

GitHub user randall opened an issue:

https://github.com/apache/trafficserver/issues/1348

log all config file reloads in a consistent manner

Expanding on James's requesting in 
[TS-5080](https://issues.apache.org/jira/browse/TS-5080), we should log all the 
individual config file reloads in consistent manner with a `Note`






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1347: TS-5022: nullptr check

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1347#discussion_r96964550
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -4062,13 +4062,17 @@ HttpSM::do_remap_request(bool run_inline)
   }
 
   // check if the overridden client cert filename is already attached to 
an existing ssl context
-  ats_scoped_str 
clientCert(Layout::relative_to(t_state.txn_conf->client_cert_filepath, 
t_state.txn_conf->client_cert_filename));
-  auto tCTX = params->getCTX(clientCert);
-
-  if (tCTX == nullptr) {
-// make new client ctx and add it to the ctx list
-auto tctx = params->getNewCTX(clientCert);
-params->InsertCTX(clientCert, tctx);
+  if (t_state.txn_conf->client_cert_filepath && 
t_state.txn_conf->client_cert_filename) {
--- End diff --

Are these set if the cert name is `NULL`? We shouldn't be doing the 
`ats_scoped_str` if this is guaranteed to fail. In fact, the string allocation 
should certainly be moved under the check on `clientCert` otherwise a useless 
string allocation is done every remap.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1327: get_creation_time() takes *time_t, not *long

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1327
  
Merged this to the 7.1.x branch as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1347: TS-5022: nullptr check

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1347
  
Merged this to the 7.1.x branch as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1343: Change connect_attempts_rr_retries test to match ...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1343
  
Merged this to the 7.1.x branch as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1334
  
Merged this to the 7.1.x branch as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : osx-master » clang,osx,debug #1341

[jenkins]

https://ci.trafficserver.apache.org/job/osx-master/compiler=clang,label=osx,type=debug/1341/

Jenkins build is back to normal : osx-master » clang,osx,release #1341

[jenkins]

https://ci.trafficserver.apache.org/job/osx-master/compiler=clang,label=osx,type=release/1341/

[GitHub] trafficserver pull request #1347: TS-5022: nullptr check

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1347


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1347: TS-5022: nullptr check

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1347
  
Looks good to me.  Explicitly checking that both the path and file name are 
NULL should avoid bogus load attempts.  Still odd that relative layout logic 
uses getcwd if the path is NULL.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1347: TS-5022: nullptr check

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1347
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1247/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1347: TS-5022: nullptr check

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1347
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1355/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1341: openssl errors for every request

[persiaAziz]

Github user persiaAziz commented on the issue:

https://github.com/apache/trafficserver/issues/1341
  
PR: https://github.com/apache/trafficserver/pull/1347/files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1347: TS-5022: nullptr check

[persiaAziz]

GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1347

TS-5022: nullptr check



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver TS-5022

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1347


commit 3cece67e3411d66c2e46a6a03bb5f687851aa5e4
Author: Syeda Persia Aziz 
Date:   2017-01-19T05:36:35Z

TS-5022: nullptr check




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1346: relative_to(char* path, char* filename) should re...

[persiaAziz]

GitHub user persiaAziz opened an issue:

https://github.com/apache/trafficserver/issues/1346

relative_to(char* path, char* filename) should return null if path is null

Digging down the code, ink_filepath_merge(char *path, int pathsz, const 
char *rootpath, const char *addpath, int flags) concatenates the current 
working directory with the filename is the rootpath is null. If this is 
expected to do this, then at least, we should not let relative_to function call 
ink_filepath_merge if either filepath of filename is null






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: osx-master » clang,osx,debug #1340

[jenkins]

https://ci.trafficserver.apache.org/job/osx-master/compiler=clang,label=osx,type=debug/1340/Changes:

[Leif Hedstrom] Change connect_attempts_rr_retries test to match warning text

--
[...truncated 1.10 MB...]
 real request (length=607)

GET http://people.netscape.com/jwz/hacks-1.gif HTTP/1.0
If-Modified-Since: Wednesday, 26-Feb-97 06:58:17 GMT; length=842
Referer: http://people.netscape.com/jwz/index.html
Proxy-Connection: Keep-Alive
User-Agent:  Mozilla/3.01 (X11; I; Linux 2.0.28 i586)
Pragma: no-cache
Host: people.netscape.com
Accept: image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, */*
X-1: blah
X-2: blah
X-3: blah
X-4: blah
X-5: blah
X-6: blah
X-7: blah
X-8: blah
X-9: blah
Pragma: no-cache
X-X-1: blah
X-X-2: blah
X-X-3: blah
X-X-4: blah
X-X-5: blah
X-X-6: blah
X-X-7: blah
X-X-8: blah
X-X-9: blah



[GET http://people.netscape.com/jwz/hacks-1.gif HTTP/1.0
If-Modified-Since: Wednesday, 26-Feb-97 06:58:17 GMT; length=842
Referer: http://people.netscape.com/jwz/index.html
Proxy-Connection: Keep-Alive
User-Agent:  Mozilla/3.01 (X11; I; Linux 2.0.28 i586)
Pragma: no-cache
Host: people.netscape.com
Accept: image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, */*
X-1: blah
X-2: blah
X-3: blah
X-4: blah
X-5: blah
X-6: blah
X-7: blah
X-8: blah
X-9: blah
Pragma: no-cache
X-X-1: blah
X-X-2: blah
X-X-3: blah
X-X-4: blah
X-X-5: blah
X-X-6: blah
X-X-7: blah
X-X-8: blah
X-X-9: blah

]


 real response (length=163)

HTTP/1.0 200 OK
MIME-Version: 1.0
Server: WebSTAR/2.1 ID/30013
Content-Type: text/html
Content-Length: 939
Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT



[HTTP/1.0 200 OK
MIME-Version: 1.0
Server: WebSTAR/2.1 ID/30013
Content-Type: text/html
Content-Length: 939
Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT

]

{HTTP/1.0 200 OK\15\12MIME-Version: 1.0\15\12Server: WebSTAR/2.1 
ID/30013\15\12Content-Type: text/html\15\12Content-Length: 
939\15\12Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT\15\12\15\12}   <<< 
MUST BE HAND-VERIFIED FOR FULL BENEFIT >>>

 parsing

 real request (length=123)

GET http://www.padding.com:80/ HTTP/1.0
X-1: blah1
X-3:   blah3
X-5: blah5
X-7:   blah7
X-9: blah9



[GET http://www.padding.com:80/ HTTP/1.0
X-1: blah1
X-3:   blah3
X-5: blah5
X-7: blah7
X-9: blah9

]


 real response (length=163)

HTTP/1.0 200 OK
MIME-Version: 1.0
Server: WebSTAR/2.1 ID/30013
Content-Type: text/html
Content-Length: 939
Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT



[HTTP/1.0 200 OK
MIME-Version: 1.0
Server: WebSTAR/2.1 ID/30013
Content-Type: text/html
Content-Length: 939
Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT

]

{HTTP/1.0 200 OK\15\12MIME-Version: 1.0\15\12Server: WebSTAR/2.1 
ID/30013\15\12Content-Type: text/html\15\12Content-Length: 
939\15\12Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT\15\12\15\12}   <<< 
MUST BE HAND-VERIFIED FOR FULL BENEFIT >>>

 parsing

   <<< MUST BE HAND-VERIFIED FOR FULL BENEFIT >>>

 parsing

   <<< MUST BE HAND-VERIFIED FOR FULL BENEFIT >>>

 parsing

 real request (length=56)

GET http://www.news.com/ HTTP/1.1
Connection: close



[GET http://www.news.com/ HTTP/1.1
Connection: close

]


 real response (length=163)

HTTP/1.0 200 OK
MIME-Version: 1.0
Server: WebSTAR/2.1 ID/30013
Content-Type: text/html
Content-Length: 939
Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT



[HTTP/1.0 200 OK
MIME-Version: 1.0
Server: WebSTAR/2.1 ID/30013
Content-Type: text/html
Content-Length: 939
Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT

]

{HTTP/1.0 200 OK\15\12MIME-Version: 1.0\15\12Server: WebSTAR/2.1 
ID/30013\15\12Content-Type: text/html\15\12Content-Length: 
939\15\12Last-Modified: Thursday, 01-Jan-04 05:00:00 GMT\15\12\15\12}   <<< 
MUST BE HAND-VERIFIED FOR FULL BENEFIT >>>

 parsing

   <<< MUST BE HAND-VERIFIED FOR FULL BENEFIT >>>

 parsing

   <<< MUST BE HAND-VERIFIED FOR FULL BENEFIT >>>

 parsing

   <<< MUST BE HAND-VERIFIED FOR FULL BENEFIT >>>

 parsing

Regression test(HostDBTests) still in progress
Regression test(SDK_API_TSTextLog) still in progress
Regression test(SDK_API_TSThread) still in progress
Regression test(cache) still in progress
Regression test(HostDBTests) still in progress
Regression test(SDK_API_TSTextLog) still in progress
Regression test(SDK_API_TSThread) still in progress
Regression test(cache) still in progress
Regression test(HostDBTests) still in progress
Regression test(SDK_API_TSTextLog) still in progress
Regression test(SDK_API_TSThread) still in progress
Regression test(ProxyConfig_Release) still in progress
Regression test(HostDBTests) still in progress
Regression test(SDK_API_TSThread) still in progress
Regression test(ProxyConfig_Release) still in progress
Regression test(HostDBTests) still in progress
Regression test(SDK_API_TSThread) still in progress
Regression test(ProxyConfig_Set) still in progress
Regression test(SDK_API_TSThread) still 

Build failed in Jenkins: osx-master » clang,osx,release #1340

[jenkins]

https://ci.trafficserver.apache.org/job/osx-master/compiler=clang,label=osx,type=release/1340/Changes:

[Leif Hedstrom] Change connect_attempts_rr_retries test to match warning text

--
[...truncated 1.11 MB...]
*** TEST 62 *** STARTING ***
*** TEST 62 *** PASSED ***
*** TEST 63 *** STARTING ***
*** TEST 63 *** PASSED ***
*** TEST 64 *** STARTING ***
*** TEST 64 *** PASSED ***
*** TEST 65 *** STARTING ***
*** TEST 65 *** PASSED ***
*** TEST 66 *** STARTING ***
*** TEST 66 *** PASSED ***
*** TEST 67 *** STARTING ***
*** TEST 67 *** PASSED ***
*** TEST 68 *** STARTING ***
*** TEST 68 *** PASSED ***
*** TEST 69 *** STARTING ***
*** TEST 69 *** PASSED ***
*** TEST 70 *** STARTING ***
*** TEST 70 *** PASSED ***
*** TEST 71 *** STARTING ***
*** TEST 71 *** PASSED ***
*** TEST 72 *** STARTING ***
*** TEST 72 *** PASSED ***
*** TEST 73 *** STARTING ***
*** TEST 73 *** PASSED ***
*** TEST 74 *** STARTING ***
*** TEST 74 *** PASSED ***
*** TEST 75 *** STARTING ***
*** TEST 75 *** PASSED ***
*** TEST 76 *** STARTING ***
*** TEST 76 *** PASSED ***
*** TEST 77 *** STARTING ***
*** TEST 77 *** PASSED ***
*** TEST 78 *** STARTING ***
*** TEST 78 *** PASSED ***
*** TEST 79 *** STARTING ***
*** TEST 79 *** PASSED ***
*** TEST 80 *** STARTING ***
*** TEST 80 *** PASSED ***
*** TEST 81 *** STARTING ***
*** TEST 81 *** PASSED ***
*** TEST 82 *** STARTING ***
*** TEST 82 *** PASSED ***
*** TEST 83 *** STARTING ***
*** TEST 83 *** PASSED ***
*** TEST 84 *** STARTING ***
*** TEST 84 *** PASSED ***
*** TEST 85 *** STARTING ***
*** TEST 85 *** PASSED ***
*** TEST 86 *** STARTING ***
*** TEST 86 *** PASSED ***
*** TEST 87 *** STARTING ***
*** TEST 87 *** PASSED ***
*** TEST 88 *** STARTING ***
*** TEST 88 *** PASSED ***
*** TEST 89 *** STARTING ***
*** TEST 89 *** PASSED ***
*** TEST 90 *** STARTING ***
*** TEST 90 *** PASSED ***
*** TEST 91 *** STARTING ***
*** TEST 91 *** PASSED ***
*** TEST 92 *** STARTING ***
*** TEST 92 *** PASSED ***
*** TEST 93 *** STARTING ***
*** TEST 93 *** PASSED ***
*** TEST 94 *** STARTING ***
*** TEST 94 *** PASSED ***
*** TEST 95 *** STARTING ***
*** TEST 95 *** PASSED ***
*** TEST 96 *** STARTING ***
*** TEST 96 *** PASSED ***
*** TEST 97 *** STARTING ***
*** TEST 97 *** PASSED ***
*** TEST 98 *** STARTING ***
*** TEST 98 *** PASSED ***
*** TEST 99 *** STARTING ***
*** TEST 99 *** PASSED ***
*** TEST 100 *** STARTING ***
*** TEST 100 *** PASSED ***
*** TEST 101 *** STARTING ***
*** TEST 101 *** PASSED ***
*** TEST 102 *** STARTING ***
*** TEST 102 *** PASSED ***
*** TEST 103 *** STARTING ***
*** TEST 103 *** PASSED ***
*** TEST 104 *** STARTING ***
*** TEST 104 *** PASSED ***
*** TEST 105 *** STARTING ***
*** TEST 105 *** PASSED ***
*** TEST 106 *** STARTING ***
*** TEST 106 *** PASSED ***
*** TEST 107 *** STARTING ***
*** TEST 107 *** PASSED ***
*** TEST 108 *** STARTING ***
*** TEST 108 *** PASSED ***
*** TEST 109 *** STARTING ***
*** TEST 109 *** PASSED ***
*** TEST 110 *** STARTING ***
*** TEST 110 *** PASSED ***
*** TEST 111 *** STARTING ***
*** TEST 111 *** PASSED ***
*** TEST 112 *** STARTING ***
*** TEST 112 *** PASSED ***
*** TEST 113 *** STARTING ***
*** TEST 113 *** PASSED ***
*** TEST 114 *** STARTING ***
*** TEST 114 *** PASSED ***
*** TEST 115 *** STARTING ***
*** TEST 115 *** PASSED ***
*** TEST 116 *** STARTING ***
*** TEST 116 *** PASSED ***
*** TEST 117 *** STARTING ***
*** TEST 117 *** PASSED ***
*** TEST 118 *** STARTING ***
*REGRESSION_RESULT PARENTSELECTION:  FAILED
REGRESSION_TEST DONE: FAILED
** TEST 118 *** PASSED ***
*** TEST 119 *** STARTING ***
*** TEST 119 *** PASSED ***
*** TEST 120 *** STARTING ***
*** TEST 120 *** PASSED ***
*** TEST 121 *** STARTING ***
*** TEST 121 *** PASSED ***
*** TEST 122 *** STARTING ***
*** TEST 122 *** PASSED ***
*** TEST 123 *** STARTING ***
*** TEST 123 *** PASSED ***
*** TEST 124 *** STARTING ***
*** TEST 124 *** PASSED ***
*** TEST 125 *** STARTING ***
*** TEST 125 *** PASSED ***
*** TEST 126 *** STARTING ***
*** TEST 126 *** PASSED ***
*** TEST 127 *** STARTING ***
*** TEST 127 *** PASSED ***
*** TEST 128 *** STARTING ***
*** TEST 128 *** PASSED ***
*** TEST 129 *** STARTING ***
*** TEST 129 *** PASSED ***
*** TEST 130 *** STARTING ***
*** TEST 130 *** PASSED ***
*** TEST 131 *** STARTING ***
*** TEST 131 *** PASSED ***
*** TEST 132 *** STARTING ***
*** TEST 132 *** PASSED ***
*** TEST 133 *** STARTING ***
*** TEST 133 *** PASSED ***
*** TEST 134 *** STARTING ***
*** TEST 134 *** PASSED ***
*** TEST 135 *** STARTING ***
*** TEST 135 *** PASSED ***
*** TEST 136 *** STARTING ***
*** TEST 136 *** PASSED ***
*** TEST 137 *** STARTING ***
*** TEST 137 *** PASSED ***
*** TEST 138 *** STARTING ***
*** TEST 138 *** PASSED ***
*** TEST 139 *** STARTING ***
*** TEST 139 *** PASSED ***
*** TEST 140 *** STARTING ***
*** TEST 140 *** PASSED ***
*** TEST 141 *** STARTING ***
*** TEST 141 *** PASSED ***
*** TEST 142 *** STARTING ***
*** TEST 142 *** PASSED ***
*** TEST 143 *** 

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
As we discussed, this ought to go into the "cmd" directory, and renamed 
traffic_cachetool or some such.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1340: new warning running 7.1

[zwoop]

Github user zwoop closed the issue at:

https://github.com/apache/trafficserver/issues/1340


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1343: Change connect_attempts_rr_retries test to...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1343


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1345: Crash on retry to open server connection with POS...

[oknet]

GitHub user oknet opened an issue:

https://github.com/apache/trafficserver/issues/1345

Crash on retry to open server connection with POST transformed content.

We have a plugin, it is working on POST transform.

ATS crash if a client sent the request:

```
telnet hunter.duapp.com 80

POST 
/command/?command=nlog-post=miller=iphone=iPhone%205s=8.2.5.10=88=1=10.1.1=640%2A1136=46003
 HTTP/1.1
Host: hunter.duapp.com
Content-Type: gzip
md5: 2094631255
Accept: */* 
Cookie: BAEID=EE0DE797B09D4DF50BBD38DFDE77FD59
Connection: keep-alive
length: 152 
Accept-Language: zh-cn
Content-Length: 130 
Accept-Encoding: gzip, deflate
User-Agent: %E6%89%8B%E6%9C%BA%E7%99%BE%E5%BA%A6/8.2.5.10 CFNetwork/808.1.4 
Darwin/16.1.0


0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
```

The hunter.duapp.com returned :
```
HTTP/1.1 505 
Server: openresty
Date: Thu, 19 Jan 2017 11:18:42 GMT
Content-Type: text/html
Transfer-Encoding: chunked
Connection: keep-alive

294

http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;>
http://www.w3.org/1999/xhtml; xml:lang="en" lang="en">

505 - HTTP Version Not Supported

var _hmt = _hmt || [];
(function() {
var hm = document.createElement("script");
hm.src = "//hm.baidu.com/hm.js?7c9ab3742865045299b00ad8031a17e3";
var s = document.getElementsByTagName("script")[0];
s.parentNode.insertBefore(hm, s);
})();



505 - HTTP Version Not Supported




0
```

ATS will downgrade the http version and retry the request if HTTP status 
code is 505.
```
HttpTransact::handle_cache_operation_on_forward_server_response(State *s)
{
...
  case HTTP_STATUS_HTTPVER_NOT_SUPPORTED: // 505
  {
bool keep_alive = (s->current.server->keep_alive == HTTP_KEEPALIVE);

s->next_action = how_to_open_connection(s);
...
```

The next_action will be set to SM_ACTION_ORIGIN_SERVER_OPEN.
And call do_http_server_open() again, then call state_http_server_open(), 
handle_http_server_open()
then run into do_post_transform_open() again.
We have POST transform done already, therefore it is assert on 
post_transform_info.vc == NULL.

ATS will crash randomly if ignore the assert.

I think we should change the assert to :
```
HttpSM::do_post_transform_open()
{
  // ink_assert(post_transform_info.vc == NULL);
  if (post_transform_info.vc != NULL) {
return NULL;
  }
...
```






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1344: Origin SNI

[brkishore]

Github user brkishore commented on the issue:

https://github.com/apache/trafficserver/issues/1344
  
I will work on the solution for this issue. Can someone assign it to me?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1354/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1246/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1344: Origin SNI

[jp557198]

GitHub user jp557198 opened an issue:

https://github.com/apache/trafficserver/issues/1344

Origin SNI

I currently have ATS configured to support a pristine host header.

   proxy.config.url_remap.pristine_host_hdr 1

I also have ATS configured to verify the origin server certificate.

   proxy.config.ssl.client.verify.server 1

My remap looks like this.

   map https://edge.tld/ https://origin.tld/


Because pristine is enabled, when ATS sends a request back to the origin, 
it uses a SNI value of:

 edge.tld

However, the origin returns a certificate that does not match the SNI. 
Specifically a CN of 'origin.tld'

Because the requested SNI and the returned CN/SAN do not match, coupled 
with verify.server enabled, ATS throws a TLS alert and sends a 502 back to the 
client.

After some testing it appears that when the origin request is built, the 
SNI is derived from the original client HOST header.  In situations where the 
origin certificate will not match the requested SNI value, the ATS 
administrator needs the ability to change the SNI accordingly.

A current work around is to use a lua script to modify the original client 
HOST header as the origin request is being built.


function cache_lookup()
   ts.client_request.header['Host'] = 'origin.tld'
return 0
end
function do_remap()
  ts.hook(TS_LUA_HOOK_CACHE_LOOKUP_COMPLETE, cache_lookup)
 return 0
end
 

Ideally there should be an over-ride option that sets the SNI which has 
priority over the client HOST header. One thought is to pass origin TLS options 
on the remap line.

Something like..

map https://edge.tld/ https://origin.tld/ 
tlsopt:sni=origin.tld;tlsopt2=foo;tlsopt3=bar

(maybe as a start only support a SNI tlsopt. add support for more tlsopts 
as ATS evolves)







---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---