[GitHub] trafficserver pull request #1453: MemView: Fix methods return type definitio...
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1422: YTS-614: Avoid crash due to error during P...
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1422: YTS-614: Avoid crash due to error during POST req...
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1422 We've been running this in production for months and it fixed a series of crashes in ATS for us. I think it should probably be backported to 7.1, Y! will be putting it in our 7.1 fork. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101526314 --- Diff: iocore/eventsystem/P_IOBuffer.h --- @@ -694,6 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i) } ink_release_assert(!"out of range"); + return default_ret[0]; --- End diff -- The real problem is ICC doesn't realize the assert never returns. Although, I don't understand why `static char zwoop = '0';` `return zwoop;` wouldn't work, rather than messing about with an array. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101527244
--- Diff: lib/ts/signals.cc ---
@@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler)
sigact = (void *)oact.sa_sigaction;
}
- if (sigact != handler) {
+ if (sigact != (void *)handler) {
--- End diff --
No C-style casts! `static_cast(handler)` although we should really
rethink using `void*` in this context.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1439: Add BIO_sock_non_fatal_error() attribution
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1437: Build fail with BoringSSL
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1456: Add TCP accept metric which tracks the tot...
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/1456 Add TCP accept metric which tracks the total number of TCP connections accepted. `proxy.process.net.tcp.accept` This is useful to track the rate of inbound connections accepted. This can be compared to transactions, open connections, or other OS network metrics to better identify performance issues. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SolidWallOfCode/trafficserver yts-502 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1456.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1456 commit b96478920bdcc9268d8c43550de4be88ff9d116c Author: Alan M. Carroll Date: 2017-02-16T15:43:59Z Add TCP accept metric which tracks the total number of TCP connections accepted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1563/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1457/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101558075 --- Diff: iocore/eventsystem/P_IOBuffer.h --- @@ -694,6 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i) } ink_release_assert(!"out of range"); + return default_ret[0]; --- End diff -- Sure, I can try that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101558553
--- Diff: lib/ts/signals.cc ---
@@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler)
sigact = (void *)oact.sa_sigaction;
}
- if (sigact != handler) {
+ if (sigact != (void *)handler) {
--- End diff --
I did look / try not using void *, but it turns out the sigaction is not
the same type as the handler. So some casting would be needed.
And yeh, I'll change to amc style cast, only because you are the best, and
currently sitting in the #1 spot on the ranking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/128/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1456 Why are there tsconfig changes with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1454: Updates to the help output for tsxs
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101584542
--- Diff: lib/ts/signals.cc ---
@@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler)
sigact = (void *)oact.sa_sigaction;
}
- if (sigact != handler) {
+ if (sigact != (void *)handler) {
--- End diff --
Actually, I'm not gonna change this, because everything else (in a million
places) uses the C-style cast already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver
GitHub user zizhong opened a pull request: https://github.com/apache/trafficserver/pull/1457 fix TS-4195: crash when stop trafficserver Because of `psiginfo`, `psignal` and `exit`, which call `malloc` and `free` inside `proxy_signal_handler`. ATS will crash from time to time when stop. > A signal handler can be called at any time, including during times when another call to malloc is in progress. If this happens, one of two things will occur: > > Your process will deadlock inside the signal handler, because malloc will be unable to acquire the heap lock. > Your process will corrupt its heap, because malloc does acquire the lock (or doesn't think it needs it), then proceeds to render the heap inconsistent, leading to a later crash. From [here](http://stackoverflow.com/questions/3366307/why-is-malloc-not-async-signal-safe) Tested with a script repeating starting and stopping ATS on RHEL 6.6, the current master crashes after about 2~10 times. This patch doesn't crash after 6k+ tries. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zizhong/trafficserver TS-4195 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1457.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1457 commit 8a9365aebd0eaa3a9fd451703996060c869fa7f5 Author: Zizhong Zhang Date: 2017-02-16T18:03:15Z fix TS-4195: double free when stop trafficserver --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1451 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1458/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1451 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1564/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1457 Is it still possible to use leak checkers that reconcile at exit after this fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1458: Removed spaces at the end of the line on a...
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1458 Removed spaces at the end of the line on all files Removed spaces at the end of the line on all files doing: `find . -type f | grep -v '\.git' | xargs -n1 perl -pi -e 's/\s+\n$/\n/'` and then doing `git co --` on the binary files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver no_space_eol Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1458.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1458 commit 63a7265478972bcba60b1c9d9fd2100220419184 Author: Bryan Call Date: 2017-02-16T18:24:12Z Removed spaces at the end of the line on all files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1444: issue #1401: Potential fix to the write_to_io_net...
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1444 Yes, as I said not an entirely satisfying solution. I do thing the issue is triggered by the changes from TS-4796 where @jacksontj added logic to bubble up these errors. I'm guessing in some error cases the VC is already partially freed up by this point. I just checked and the fixes for TS-4796 entered between 7.0 (not there) and 7.1 (is there). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1451 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/129/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1565/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1459/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1566/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1460/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/130/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/131/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 @jpeach , I haven't tested it yet. I would like to try it. Then I configured it with `--enable-asan`, but got ``` checking whether compiling and linking against OpenSSL works...no configure: error: failed to find OpenSSL. ``` But without `--enable-asan`, my configuration works and clearly, I have openssl installed. Any ideas? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 I checked the config.log and found the problem. I didn't have `asan` installed. However, the error message here was quite misleading. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1461/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/132/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1567/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 Tested with `--enable-asan` and didn't find any issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 Sorry for the build failed. It's because missed a piece when merging the code. Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 Testing new ICC builds [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/1/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1568/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1462/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1459: Mysterious uptick in user_agent SSL errors moving...
GitHub user shinrich opened an issue: https://github.com/apache/trafficserver/issues/1459 Mysterious uptick in user_agent SSL errors moving to 7.1 Comparing a machine running 7.1.x against its peer running our version of 5.3.x. A number of the proxy.process.ssl.user_agent_* metrics started increasing in the 7.1 build. Namely proxy.process.ssl.user_agent_unknown_cert and proxy.process.ssl.user_agent_bad_cert. I did packet captures for a few seconds on both machines to verify that this wasn't just a change in logging behavior. On the 7.1.x box with 5000 TLS handshakes captured we saw 81 Certificate Unknown alerts and 5 Bad Cert alerts. On the 5.3.x box with 23000 handshakes captured, 1 Bad Cert alert (from an internal IP) and 4 Certificate Unknown alerts (3 from the same IP address). After running for a few minutes, the rate of alerts in the 7.1 build does not go down. It isn't huge, but the difference is alarming me enough that I am not expanding my testing until I have a good story for this. Will go back and run 7.1.x with ASAN. Perhaps the cert buffers are getting corrupted in some cases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/2/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 Testing new ICC builds [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1569/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/3/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/133/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1463/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1570/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1464/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/134/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/4/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/135/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1450: Update to latest RAT version
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1571/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1465/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/136/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1572/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/5/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1466/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1458: Removed spaces at the end of the line on a...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1458 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1458 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/137/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1456 Bad merge, I'll fix the TSConfig stuff. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/6/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1573/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1460 Removes some unnecessary dependencies on the public ts/ts.h This also removes the proxy/api/ts directory from all default search paths, to make it more difficult to introduce more bad includes. There are still a few places that must have the public APIs, and a few that does but shouldn't. This is a step right direction at least. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver NoPubAPIInCoreDammit Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1460.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1467/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1460: Removes some unnecessary dependencies on the publ...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1460 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1574/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1460: Removes some unnecessary dependencies on the publ...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1460 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/7/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1460: Removes some unnecessary dependencies on the publ...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1460 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1468/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/138/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zizhong No need to apologize, this is exactly why we have a CI / build system. :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1456 Hmmm, how is this different from proxy.process.http.total_incoming_connections ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/9/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1461: Changes debug builds with Intel to just -g
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1461 Changes debug builds with Intel to just -g This gets rid of debug build warnings with Intel compilers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver Removeggdb3Intel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1461.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1461 commit 62b397538f7909ffad5fbd5ac3625aad524c2339 Author: Leif Hedstrom Date: 2017-02-17T00:01:31Z Changes debug builds with Intel to just -g --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1461 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1575/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1461 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1469/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1576/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1470/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1460: Removes some unnecessary dependencies on the publ...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1460 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/139/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1461 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/8/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zwoop , in https://ci.trafficserver.apache.org/job/icc-github/9/ ``` checking whether the C compiler works... no configure: error: in `/var/jenkins/workspace/icc-github/src': configure: error: C compiler cannot create executables ``` It seem sto be failed in configuration phase. Can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1461 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/140/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/141/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 Yeh, this failed because the Intel installation was not correct on one of the VMs. [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/10/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1461: Changes debug builds with Intel to just -g
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1461 Failed at ``` In file included from P_EventSystem.h(40), from EventSystem.cc(31): P_IOBuffer.h(697): error #1011: missing return statement at end of non-void function "IOBufferReader::operator[]" } ^ ``` I can open another pull request to fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1471/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1577/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 Failed at ``` P_IOBuffer.h(697): error #1011: missing return statement at end of non-void function "IOBufferReader::operator[]" } ^ ``` I can try to fix it with another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/142/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 Ah, that fails because you don't have the fixes I made on master. All you have to do is rebase your branch with current master, and push again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zwoop , thanks! Rebased and pushed again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/11/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1472/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1457 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1578/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
