[GitHub] trafficserver issue #1158: TS-5015: Convert storage configuration file to Lu...

[shukitchan]

Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1158
  
it looks like .luaconf is the winner. 
I will be updating this accordingly. Also will create new issue to make 
sure metrics.config and logging.config are changed accordingly as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[shukitchan]

Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
the patch compiles fine. And it seems to run through clang-format as well 
already. thanks. pls check out the comments above. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1446
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1551/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1446
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1655/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1445
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/218/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1445
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1550/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1516#discussion_r103610662
  
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
   ~InterceptData();
 };
 
+/*
+ * This class is responsible for keeping track of and processing the 
various
+ * Cache-Control values between all the requested documents
+ */
+struct CacheControlHeader {
+  // Update the object with a document's Cache-Control header
+  void update(TSMBuffer bufp, TSMLoc hdr_loc);
+
+  // Return the Cache-Control for the combined document
+  string generate() const;
+
+  // Cache-Control values we're keeping track of
+  int _max_age= 31536; // max value (10 years)
+  bool _public= true;
+  bool _private   = false;
--- End diff --

Hmmm, perhaps a tri-value enum? `private`, `public`, `default`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1445
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1654/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1445: Issue #1443 - Fix early or duplicate 404 e...

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1445
  
Intel CC build *failed*! See 
https://ci.trafficserver.apache.org/job/icc-github/86/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1445
  
I looked at this as well and it definitely looks like it's an artifact of a 
remap plugin setting the transaction to be an error. You can see that this 
happens in a switch statement where `t_state.next_action` was 
`SM_ACTION_REMAP_REQUEST` on entry yet is `SM_ACTION_SEND_ERROR_CACHE_NOOP`. 
This could only have been updated via `do_remap_request()` and presumably via a 
remap plugin as `RemapProcessor` doesn't update that member. It also seems 
reasonable to check if a plugin has error'd out the transaction and give up on 
further transaction processing at that point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1472
  
"TS-3100: Extend tr-pass to allow malformed HTTP GET requests to be blind 
tunneled." is added by @shinrich .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1472: condition that cause always passthrough bypass

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1472
  
It is fixed by “TS-5103: replace ua_raw_buffer_reader with 
ua_buffer_reader”
please check the code in master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1503: client cert should be added to netvcoptions only ...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1503
  
Not sure I follow here, does this land on master? Or was the intent here to 
make a backport PR against 7.1.x branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

[shukitchan]

Github user shukitchan commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1516#discussion_r103590528
  
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
   }
 }
 
+void
+CacheControlHeader::update(TSMBuffer bufp, TSMLoc hdr_loc)
+{
+  vector values;
+  bool found_immutable = false;
+  bool found_private   = false;
+
+  // Load each value from the Cache-Control header into the vector values
+  TSMLoc field_loc = TSMimeHdrFieldFind(bufp, hdr_loc, 
TS_MIME_FIELD_CACHE_CONTROL, TS_MIME_LEN_CACHE_CONTROL);
+  if (field_loc != TS_NULL_MLOC) {
+int n_values = TSMimeHdrFieldValuesCount(bufp, hdr_loc, field_loc);
+if ((n_values != TS_ERROR) && (n_values > 0)) {
+  for (int i = 0; i < n_values; i++) {
+// Grab this current header value
+int _val_len = 0;
+const char *_val = TSMimeHdrFieldValueStringGet(bufp, hdr_loc, 
field_loc, i, &_val_len);
+string val(_val, _val_len);
+
+// We want the header value to be lowercase since CC headers are 
case insensitive
+transform(val.begin(), val.end(), val.begin(), ::tolower);
+values.push_back(val);
+  }
+} else {
+  TSHandleMLocRelease(bufp, hdr_loc, field_loc);
+  return;
+}
+TSHandleMLocRelease(bufp, hdr_loc, field_loc);
+  } else {
+return;
+  }
+
+  for (auto const  : values) {
+// Update max-age if necessary
+if (val.find(TS_HTTP_VALUE_MAX_AGE) != string::npos) {
+  int max_age = -1;
+  char *ptr   = const_cast(val.c_str());
+  ptr += TS_HTTP_LEN_MAX_AGE;
+  while ((*ptr == ' ') || (*ptr == '\t'))
+ptr++;
+  if (*ptr == '=') {
+ptr++;
+max_age = atoi(ptr);
+  }
+  if (max_age > 0 && max_age < _max_age) {
+_max_age = max_age;
+  }
+  // If we find even a single occurrence of private, the whole 
response must be private
+} else if (val.find(TS_HTTP_VALUE_PRIVATE) != string::npos) {
+  found_private = true;
+  // Every requested document must have immutable for the final 
response to be immutable
+} else if (val.find(HTTP_IMMUTABLE) != string::npos) {
+  found_immutable = true;
+}
+  }
+
+  if (!found_immutable) {
+LOG_DEBUG("Did not see an immutable cache control. The response will 
be not be immutable");
+_immutable = false;
+  }
+
+  if (found_private) {
+LOG_DEBUG("Saw a private cache control. The response will be private");
+_public  = false;
+_private = true;
+  }
+}
+
+string
+CacheControlHeader::generate() const
+{
+  char line_buf[256];
+  const char *publicity;
+  const char *immutable;
+
+  if (_public) {
+publicity = TS_HTTP_VALUE_PUBLIC;
+  } else if (_private) {
+publicity = TS_HTTP_VALUE_PRIVATE;
+  } else {
+// Default is public
+publicity = TS_HTTP_VALUE_PUBLIC;
+  }
+  immutable = (_immutable ? ", " HTTP_IMMUTABLE : "");
+
+  sprintf(line_buf, "Cache-Control: max-age=%d, %s%s\r\n", _max_age, 
publicity, immutable);
--- End diff --

if we happen to support and have a case of having a really large (!) number 
for max age, we might have buffer overflow. 
Then we might need to consider snprintf or something safer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[shukitchan]

Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
will try to compile it tonight and see if i have more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[shukitchan]

Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
The max-age related code is also a bit different from before. Previously we 
can have max-age larger than 31536. Now with this change, I think we can no 
longer have max-age larger than that. right? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[shukitchan]

Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
I am not in favor with the "private" related changes because i think it can 
catch some existing users by surprise. And we did not mention anything in the 
document as well - 
https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/combo_handler.en.html

Speaking of the document, it would be great if we can update that, too. 
Thanks.

 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

[shukitchan]

Github user shukitchan commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1516#discussion_r103587579
  
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
   ~InterceptData();
 };
 
+/*
+ * This class is responsible for keeping track of and processing the 
various
+ * Cache-Control values between all the requested documents
+ */
+struct CacheControlHeader {
+  // Update the object with a document's Cache-Control header
+  void update(TSMBuffer bufp, TSMLoc hdr_loc);
+
+  // Return the Cache-Control for the combined document
+  string generate() const;
+
+  // Cache-Control values we're keeping track of
+  int _max_age= 31536; // max value (10 years)
+  bool _public= true;
+  bool _private   = false;
--- End diff --

I find it rather confusing to maintain two booleans here - _public and 
_private. 
Is there any other kind of value? 
If not, perhaps we can simply this to be just one boolean?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

[shukitchan]

Github user shukitchan commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1516#discussion_r103586416
  
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
   ~InterceptData();
 };
 
+/*
+ * This class is responsible for keeping track of and processing the 
various
+ * Cache-Control values between all the requested documents
+ */
+struct CacheControlHeader {
+  // Update the object with a document's Cache-Control header
+  void update(TSMBuffer bufp, TSMLoc hdr_loc);
+
+  // Return the Cache-Control for the combined document
+  string generate() const;
+
+  // Cache-Control values we're keeping track of
+  int _max_age= 31536; // max value (10 years)
--- End diff --

probably should be unsigned?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1511: heap-use-after-free: Access ua_session after Http...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1511
  
Also, can you put into the description what the problem is (like, when / 
how does it trigger), and what problem it causes? That really helps deciding 
severity, for backports etc., as well as for release notes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1511: heap-use-after-free: Access ua_session after Http...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1511
  
Is this a 7.1.x candidate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1518
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/217/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1518: Ensure 'service trafficserver stop’ is s...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1518


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1299
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/216/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver

[zizhong]

Github user zizhong commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1457#discussion_r103575599
  
--- Diff: proxy/Main.cc ---
@@ -460,7 +460,7 @@ proxy_signal_handler(int signo, siginfo_t *info, void 
*ctx)
   shutdown_event_system = true;
   sleep(1);
 
-  ::exit(signo);
--- End diff --

I couldn't understand why this change can cause an issue with leak 
detection.I read your original ticket about this line changing from `_exit` to 
`exit`. The reason you made that change was to fix some crashes on fedora 
instead of fixing leak detection issues. However,
it's never okay to call `exit` in a signal handler.  `exit()` is not an 
Async-signal-safe function, which can refer to [this man 
page](http://man7.org/linux/man-pages/man7/signal.7.html). Hence, we got lots 
of crashes when stopping or restarting ATS.
Besides, @zwoop tested this patch didn't make any behavior change of leak 
detection tools. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1518
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1549/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1518
  
Note that this is all @timbunce 's work, I just merged his two previous 
commits into one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1518: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1518
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1653/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1299
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/215/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1459: Mysterious uptick in user_agent SSL errors moving...

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/issues/1459
  
Yes, this is still an issue.  I need to do some more testing on PR #1446.  
Some variant of that will need to be added to 7.1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1511: heap-use-after-free: Access ua_session after Http...

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1511
  
Looks reasonable to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1518: Ensure 'service trafficserver stop’ is s...

[zwoop]

GitHub user zwoop opened a pull request:

https://github.com/apache/trafficserver/pull/1518

Ensure 'service trafficserver stop’ is synchronous under load on redhat

Currently the service trafficserver stop command on redhat might return 
before ATS has exited.
This is not good as it’s often followed by a start, which then fails.

/etc/init.d/trafficserver does:

action "Stopping ${TC_NAME}:" killproc -p $TC_PIDFILE $TC_DAEMON
action "Stopping ${TM_NAME}:" killproc -p $TM_PIDFILE $TM_DAEMON
action "Stopping ${TS_NAME}:" killproc -p $TS_PIDFILE $TS_DAEMON

and killproc, as defined in /etc/rc.d/init.d/functions, with those 
arguments essentially does this:

send SIGTERM
wait up to 3 seconds for it to exit
send SIGKILL
wait 0.1 seconds then return an exit status indicating if the process 
still exists

A SIGKILL signal always causes the death of a process but it’s not 
instantaneous. A process can take a long time to exit on a busy system for 
assorted reasons, including flushing dirty buffers to disk.

So if the stop is immediately followed by a start, as it often is, the 
start may fail with an error like ‘port 80 in use’. This seems to be a 
common cause of restart failures on busy systems and frustrating manual 
hand-holding.

Contrast this with the behaviour that /etc/init.d/trafficserver uses when 
run on Ubuntu… there it’ll wait up to 35 seconds.
(It'll also use SIGQUIT instead of SIGTERM which seems odd).

This PR makes /etc/init.d/trafficserver more reliable, and consistent, on 
redhat by adding `-d 35` to the killproc arguments so it'll wait for the 
daemons to stop on redhat for about as long as it does in ubuntu. Not perfect, 
but much better.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zwoop/trafficserver TimsPatchSquashed

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1518


commit 432151695cbd2dcedfffcb1baed620d335154f15
Author: Tim Bunce 
Date:   2017-02-28T18:14:15Z

Ensure 'service trafficserver stop’ is synchronous under load on redhat

Currently the service trafficserver stop command on redhat might return 
before ATS has exited.
This is not good as it’s often followed by a start, which then fails.

/etc/init.d/trafficserver does:

action "Stopping ${TC_NAME}:" killproc -p $TC_PIDFILE $TC_DAEMON
action "Stopping ${TM_NAME}:" killproc -p $TM_PIDFILE $TM_DAEMON
action "Stopping ${TS_NAME}:" killproc -p $TS_PIDFILE $TS_DAEMON

and killproc, as defined in /etc/rc.d/init.d/functions, with those 
arguments essentially does this:

send SIGTERM
wait up to 3 seconds for it to exit
send SIGKILL
wait 0.1 seconds then return an exit status indicating if the process 
still exists

A SIGKILL signal always causes the death of a process but it’s not 
instantaneous. A process can take a long time to exit on a busy system for 
assorted reasons, including flushing dirty buffers to disk.

So if the stop is immediately followed by a start, as it often is, the 
start may fail with an error like ‘port 80 in use’. This seems to be a 
common cause of restart failures on busy systems and frustrating manual 
hand-holding.

Contrast this with the behaviour that /etc/init.d/trafficserver uses when 
run on Ubuntu… there it’ll wait up to 35 seconds.
(It'll also use SIGQUIT instead of SIGTERM which seems odd).

This PR makes /etc/init.d/trafficserver more reliable, and consistent, on 
redhat by adding `-d 35` to the killproc arguments so it'll wait for the 
daemons to stop on redhat for about as long as it does in ubuntu. Not perfect, 
but much better.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1517
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/214/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1299
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1548/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1299
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1652/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/213/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1299
  
Intel CC build *failed*! See 
https://ci.trafficserver.apache.org/job/icc-github/84/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1299
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/83/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/212/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1299
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1651/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

[persiaAziz]

Github user persiaAziz commented on the issue:

https://github.com/apache/trafficserver/pull/1299
  
@SolidWallOfCode please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/211/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1546/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1517
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/82/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Not sure if it'll let you push again on this PR, but if not, just make a 
new one. The point is, we don't want broken / non-functional commits in the 
history, so I reverted this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1512
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/210/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1517
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1650/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1517
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1545/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Dang it my bad... I'm gonna revert these for now. @timbunce can you please 
squash the commits into one commit, and push again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1512: Don't push stack variables in lightuserdat...

[postwait]

Github user postwait closed the pull request at:

https://github.com/apache/trafficserver/pull/1512


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1514: Ensure 'service trafficserver stop’ is s...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/81/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1544/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1649/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/80/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[shukitchan]

Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
I would like to do the review on this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1543/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1648/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/79/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1517: Remove BisonHeaderToC++.sed

[jablko]

GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1517

Remove BisonHeaderToC++.sed

We can do without it, and less is more?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver bison

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1517


commit 3e0147748a2397bfe08cc1793180feb7f5ae4787
Author: Jack Bates 
Date:   2017-02-28T21:03:56Z

Remove BisonHeaderToC++.sed

We can do without it, and less is more?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1512
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/209/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1647/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1512
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1542/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1512
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/78/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1512
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1646/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/208/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[danobi]

Github user danobi commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
I'm on the fence about including the `Cache-Control: private` changes in 
this patch. On one hand, it makes sense for that to be in this refactor. On the 
other, it has nothing to do with `immutable`. Maybe change the commit name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1512
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/77/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1541/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

[danobi]

GitHub user danobi opened a pull request:

https://github.com/apache/trafficserver/pull/1516

Implement Cache-Control: immutable handling

This patch makes `combo_handler` correctly handle the presence of one or 
more immutable flags. 

In short, the combo response will be immutable if and only if all requested 
documents have immutable in their response headers.

In addition, the same logic applies for `Cache-Control: private`. This was 
not present before.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danobi/trafficserver combocache_immutable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1516


commit 3dfd7ef0da3915e257caafd2fea92d4812dbeb21
Author: Daniel Xu 
Date:   2017-02-24T15:36:50Z

Implement Cache-Control: immutable for combohandler

Before, combohandler would not insert the immutable cache control even
if all the requested documents had the header. Now, combohandler will
respect the presence of the header.

commit 9f9d6340dc3772ca13fb2d0ad2e8ed420c256019
Author: Daniel Xu 
Date:   2017-02-28T21:18:02Z

Handle private header & code cleanup

Now we handle Cache-Control: private directives. If any of the responses
has a private directive, then the combo response should also be private.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1512
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1645/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1512: Don't push stack variables in lightuserdata

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1512
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1540/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
Intel CC build *failed*! See 
https://ci.trafficserver.apache.org/job/icc-github/76/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1644/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1539/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1643/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/207/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
The FreeBSD failure is because of the VM being unstable (bloody FreeBSD 
needs a reboot once a week or so).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1538/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/75/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1642/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1379: Make sure to schedule connect event on correct th...

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1379
  
@zwoop Yes, this needs to get backported.  I ran into this issue testing 
the 7.1.x branch in production.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1457
  
I've reverted this, as per @bryancall recommendation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[timbunce]

Github user timbunce commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Gah! killproc is written to need the -d option to follow the -p option. 
Sorry!
```
killproc -p $TS_PIDFILE -d 35 $TS_DAEMON
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1457
  
@bcall Should we back this out? Fwiw, I don't see a difference in leak 
detection with or without this, they both fail badly on master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1515: Logging cache code map size fix

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1515


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1515: Logging cache code map size fix

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1515
  
We should file an Issue on that improvement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
Set a milestone please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Having some issues with this on my F25 box, e.g.

```
Stopping traffic_cop: pidof: invalid option -- 'p'

Usage:
 pidof [options] [program [...]]

Options:
 -s, --single-shot return one PID only
 -c, --check-root  omit processes with different root
 -xalso find shells running the named scripts
 -o, --omit-pid   omit processes with PID

 -h, --help display this help and exit
 -V, --version  output version information and exit

For more details see pidof(1).
pidof: invalid option -- 'p'
```

I have not investigated why yet, I'm assuming something odd with how they 
parse arguments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1515: Logging cache code map size fix

[jpeach]

Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1515
  
Can you look into fixing the APIs so this can't happen again?

> On Feb 28, 2017, at 10:32 AM, Gancho Tenev  
wrote:
> 
> The size of the cache code map does not correspond to the number of cache 
result code values.
> Discrepancy introduced with commit eadc9cf
> 
> You can view, comment on, or merge this pull request online at:
> 
>   https://github.com/apache/trafficserver/pull/1515
> 
> Commit Summary
> 
> Logging cache code map size fix
> File Changes
> 
> M proxy/logging/Log.cc (2)
> Patch Links:
> 
> https://github.com/apache/trafficserver/pull/1515.patch
> https://github.com/apache/trafficserver/pull/1515.diff
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/206/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1537/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1641/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/74/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1515: Logging cache code map size fix

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1515
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/205/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1514: Ensure 'service trafficserver stop’ is synchron...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1514
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1515: Logging cache code map size fix

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1515
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/73/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---