[GitHub] trafficserver pull request #1520: Report protocol in request via header
GitHub user shukitchan opened a pull request: https://github.com/apache/trafficserver/pull/1520 Report protocol in request via header See #1506 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shukitchan/trafficserver issue-1506 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1520.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1520 commit dbfb804e78608a29c21270b9f447ee690b8ea096 Author: Kit Chan Date: 2017-03-01T07:27:37Z report protocol in request via header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1520: Report protocol in request via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1520 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1656/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1520: Report protocol in request via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1520 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1552/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1520: Report protocol in request via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1520 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/88/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1520: Report protocol in request via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1520 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/220/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1276 clang-analyzer failed due to: TS-4729: Fix dead assignment. (29bc28a713463eb815524a91e03be95fe3aeedb1) Remove dead store. (67efb389b890919237248ed437c7af1d01559bf1) TS-4367: Failed clang-analyzer, memory leak in mgmt/api (1cff52240584e5e6dccee63a02ab70ce61a961a2) TS-4479: Clang-analyzer failure, Potential memory leak (87d1fc5d17d82ebb8f06f4138ca82b6e3b57179c) TS-4366 Uninitialized stack value used in mp4 plugin (77bd40ba19f29b11873c1709485b64840d137dde) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103611267
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
}
}
+void
+CacheControlHeader::update(TSMBuffer bufp, TSMLoc hdr_loc)
+{
+ vector values;
--- End diff --
Perhaps convolute the search logic. In that case there would be a
`std::array` initialized to the 3 values of interest. Each item
in the loop at 221 would have an inner loop like that starting at 241. Then
there's no need to allocate a vector as a temporary, and the comparisons can be
done using `strcasecmp` to avoid the copy as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103610928
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
~InterceptData();
};
+/*
+ * This class is responsible for keeping track of and processing the
various
+ * Cache-Control values between all the requested documents
+ */
+struct CacheControlHeader {
+ // Update the object with a document's Cache-Control header
+ void update(TSMBuffer bufp, TSMLoc hdr_loc);
+
+ // Return the Cache-Control for the combined document
+ string generate() const;
+
+ // Cache-Control values we're keeping track of
+ int _max_age= 31536; // max value (10 years)
--- End diff --
Or `ssize_t`. Is the 10 year value from the HTTP spec?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103611348
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
}
}
+void
+CacheControlHeader::update(TSMBuffer bufp, TSMLoc hdr_loc)
+{
+ vector values;
--- End diff --
This would also simplify the logic Kit was concerned about at 232-236.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1516 I agree with the private/public refactor. The code would be significantly uglier if processing for the cache control field was split. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1519: Update metrics.config and logging.config to new n...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1519 For the duration of 7.x, we have to support both the old and the new naming convention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1446 Looks good to me.. I tested with a plugin that requires this hook --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1521: Changes default RAM cache to the LRU + see...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1521 Changes default RAM cache to the LRU + seen-filter It turns out, the CLFUS is either having a bug/issue, or doesn't work well with some content. But several of our users have reported noticeable (2-3x) better cache hit ratio with the LRU vs the CLFUS. The issues with the CLFUS cache happens over time in at least my tests, where it can take up to 24h for it to deteriorate noticeably. This is likely why it has gone unnoticed for so long. This should also be backported into 7.1.x. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver LRU Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1521.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1521 commit 496b68881d4a39a832fbc48bb29fca7519420ad5 Author: Leif Hedstrom Date: 2017-03-01T15:14:23Z Changes default RAM cache to the LRU + seen-filter It turns out, the CLFUS is either having a bug/issue, or doesn't work well with some content. But several of our users have reported noticeable (2-3x) better cache hit ratio with the LRU vs the CLFUS. The issues with the CLFUS cache happens over time in at least my tests, where it can take up to 24h for it to deteriorate noticeably. This is likely why it has gone unnoticed for so long. This should also be backported into 7.1.x. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1553/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/89/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1657/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/221/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1517 I'm not sure we can do without this. I know I had problems which lead me to do this which may be related to older versions of Bison. Note that it works for 3.0.4 compared to 2.7. My experience is that Bison versions on old operating systems we support tend to be very old. I will need to check this on older OS versions we use here at Y!. Additionally the plan going forward for this is to remove all the parsing from TSConfig and have it depend on Lua. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1503: client cert should be added to netvcoptions only ...
Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1503 It should be merged with master, as well as backported to 7.1.x. Client cert is being checked every time a remap is performed rather it should be checked before making an actual ssl connection with the origin server --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1658/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/90/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/222/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1554/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1555/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1659/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1446: Need dedicated TS_SSL_SERVERNAME_HOOK
Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/1446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1299#discussion_r103734216 --- Diff: proxy/http/HttpTransact.cc --- @@ -8299,10 +8291,9 @@ HttpTransact::build_redirect_response(State *s) // s->free_internal_msg_buffer(); s->internal_msg_buffer_fast_allocator_size = -1; - s->internal_msg_buffer = body_factory->fabricate_with_old_api_build_va( -"redirect#moved_temporarily", s, 8192, &s->internal_msg_buffer_size, body_language, sizeof(body_language), body_type, -sizeof(body_type), "%s %s. %s.", "The document you requested is now", new_url, new_url, -"Please update your documents and bookmarks accordingly", NULL); + s->internal_msg_buffer = body_factory->getFormat(8192, &s->internal_msg_buffer_size, "%s %s. %s.", --- End diff -- Add a comment here that this is necessary because the template format doesn't have access to this computed URL and there is no current way to provide that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed
Github user jablko commented on the issue:
https://github.com/apache/trafficserver/pull/1517
> I'm not sure we can do without this. I know I had problems which lead me
to do this which may be related to older versions of Bison. Note that it works
for 3.0.4 compared to 2.7. My experience is that Bison versions on old
operating systems we support tend to be very old. I will need to check this on
older OS versions we use here at Y!.
Thanks for taking a look! It should work with Bison 2.7, just based on the
GitHub CI jobs (e.g. the FreeBSD job uses 2.7 [1]). The CentOS 6 machine uses
2.4 [2] -- but we don't run that for pull requests, I think.
I think the important difference between TsConfigGrammar.h and
TsConfigGrammar.hpp is that TsConfigGrammar.h contains yyscan_t (the first
tsconfigparse() parameter) and TsConfigGrammar.hpp doesn't -- but replacing
`%parse-param { yyscan_t lexer }` with `%parse-param { void *lexer }` has the
same effect?
[1] https://ci.trafficserver.apache.org/files/BuildMachines/FreeBSD10
[2] https://ci.trafficserver.apache.org/files/BuildMachines/CentOS6
> Additionally the plan going forward for this is to remove all the parsing
from TSConfig and have it depend on Lua.
Nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/91/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1299#discussion_r103733855
--- Diff: proxy/http/HttpTransact.cc ---
@@ -3571,11 +3571,7 @@ HttpTransact::handle_response_from_parent(State *s)
ink_assert(s->hdr_info.server_request.valid());
s->current.server->connect_result = ENOTCONN;
- // only mark the parent down in hostdb if the configuration allows
it,
- // see proxy.config.http.parent_proxy.mark_down_hostdb in
records.config.
- if (s->txn_conf->parent_failures_update_hostdb) {
-s->state_machine->do_hostdb_update_if_necessary();
- }
+ s->state_machine->do_hostdb_update_if_necessary();
--- End diff --
This looks like a bad merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1522: Ingore read and write errors if vio has be...
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1522 Ingore read and write errors if vio has been cleared You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver ignore_error Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1522.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1522 commit 5aac06f8a155c99443a53dd71c5d39e848d1b929 Author: Bryan Call Date: 2017-03-01T17:01:25Z Ingore read and write errors if vio has been cleared --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1299#discussion_r103735621
--- Diff: proxy/http/HttpTransact.cc ---
@@ -3571,11 +3571,7 @@ HttpTransact::handle_response_from_parent(State *s)
ink_assert(s->hdr_info.server_request.valid());
s->current.server->connect_result = ENOTCONN;
- // only mark the parent down in hostdb if the configuration allows
it,
- // see proxy.config.http.parent_proxy.mark_down_hostdb in
records.config.
- if (s->txn_conf->parent_failures_update_hostdb) {
-s->state_machine->do_hostdb_update_if_necessary();
- }
+ s->state_machine->do_hostdb_update_if_necessary();
--- End diff --
yeah it is, see https://github.com/apache/trafficserver/pull/1464 merged
about a week ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1522 Here is a workaround for issue #1401. I ran into issues with the read also coring. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...
Github user persiaAziz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1299#discussion_r103736131
--- Diff: proxy/http/HttpTransact.cc ---
@@ -3571,11 +3571,7 @@ HttpTransact::handle_response_from_parent(State *s)
ink_assert(s->hdr_info.server_request.valid());
s->current.server->connect_result = ENOTCONN;
- // only mark the parent down in hostdb if the configuration allows
it,
- // see proxy.config.http.parent_proxy.mark_down_hostdb in
records.config.
- if (s->txn_conf->parent_failures_update_hostdb) {
-s->state_machine->do_hostdb_update_if_necessary();
- }
+ s->state_machine->do_hostdb_update_if_necessary();
--- End diff --
I will fix that. Thanks for noticing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/223/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1660/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1556/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/92/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1523: ASAN segv when ramping up traffic to a production...
GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1523 ASAN segv when ramping up traffic to a production host ``` ASAN:SIGSEGV = ==38732==ERROR: AddressSanitizer: SEGV on unknown address 0x (pc 0x bp 0x2abf141497c0 sp 0x2abf141496a8 T23) ==38732==Hint: pc points to the zero page. AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV ??:0 ?? Thread T23 ([ET_NET 21]) created by T0 ([TS_MAIN]) here: #0 0x528ed4 in __interceptor_pthread_create (/home/y/bin64/traffic_server+0x528ed4) #1 0xb3e984 in ink_thread_create /home/bcall/dev/yahoo/build/_build/asan_build/../../trafficserver/lib/ts/ink_thread.h:152 #2 0xb3ef5a in Thread::start(char const*, unsigned long, void* (*)(void*), void*, void*) ../../../../trafficserver/iocore/eventsystem/Thread.cc:102 #3 0xb447d9 in EventProcessor::start(int, unsigned long) ../../../../trafficserver/iocore/eventsystem/UnixEventProcessor.cc:240 #4 0x654afe in main ../../../trafficserver/proxy/Main.cc:1771 #5 0x2abf0cdadd1c in __libc_start_main (/lib64/libc.so.6+0x1ed1c) ==38732==ABORTING ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/224/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics
GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1524 Seeing a lot of CPU being used on atomics ``` - 22.49%22.20% traffic_server [.] ink_atomic_increment - ink_atomic_increment - 65.31% RefCountObj::refcount_inc - 88.88% Ptr::Ptr - MutexTryLock::MutexTryLock + 56.95% CacheVC::openReadStartHead + 41.89% EThread::process_event - 11.12% Ptr::operator= Ptr::operator= EThread::schedule_local + EThread::schedule_in_local ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1525: Should allow control on whether default cert path...
GitHub user shinrich opened an issue: https://github.com/apache/trafficserver/issues/1525 Should allow control on whether default cert paths/files are included for verification When creating the SSL_CTX for ATS initiating connections to origin, we always call SSL_CTX_set_default_verify_path which adds the default trusted root packages on the system. You can also set your own via settings, but the default case is also added. For a reverse proxy, the default trusted root set is probably not desirable. You probably just want to verify that your origins are signed with your small set of trusted roots. Adding more trusted roots just allows for the possibility that you accept a cert signed by someone else entirely. There are a couple options to fix this 1. Add a new setting to ignore default trusted root 2. Don't call SSL_CTX_set_default_verify_path if a CA file or CA directory is explicitly defined. 3. The reverse proxy folks should just move the default trusted root files out of the way if they case (which is accidentally what we did). No option is technically difficult, but probably worth a bit of discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics
Github user bryancall closed the issue at: https://github.com/apache/trafficserver/issues/1524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1524 I believe this is not really an issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1522 Looks reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1526: When SSL connect fails, we return 502 succ...
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/1526 When SSL connect fails, we return 502 success While debugging a failure in origin cert verification, we saw that the response header included ``` HTTP/1.1 502 Success Date: Mon, 27 Feb 2017 15:18:29 GMT Connection: keep-alive ``` 502 Success seemed peculiar. Tracked it down to the fact that errno was not set in the SSL_connect failure case. Added a check to stuff in ENET_CONNECT_FAILED if errno is 0 so we get a reason that is in the ballpark. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shinrich/trafficserver success_on_502_pr Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1526.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1526 commit 085a5983b706a875229a2ac03d76174b9c79a2f5 Author: Susan Hinrichs Date: 2017-03-01T21:33:23Z When SSL connect fails, we return 502 success --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1444: issue #1401: Potential fix to the write_to...
Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/1444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1444: issue #1401: Potential fix to the write_to_io_net...
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1444 Closing in deference to the more complete solution in PR #1522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1526 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/93/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1465: Add new testing system to the test subdire...
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1465#discussion_r103799188 --- Diff: tests/getting_started.md --- @@ -0,0 +1,197 @@ + +# Getting Started + +This directory contains different tests for Apache Trafficserver. It is recommended that all test move to this common area under the correct location based on the type of test being added. + +## Layout +The current layout is: + +**gold_tests/** - contains all the TSQA v4 based tests that run on the Reusable Gold Testing System (AuTest) +**tools/** - contain programs used to help with testing. + +In the future a directory called **"unit/"** will be added for adding unit tests based on some standardized testing system. + + +## Scripts + +To help with easy running of the tests, there is a autest.sh and bootstrap.py file. + +### autest.sh +This file is a simple wrapper that will call the AuTest program in a python virtualenv. If the virtualenv is not setup it will try to install system. That will set up the Reusable Gold Testing System on most systems in a Python virtual environment. The wrapper add some basic options to the command to point to the location of the tests. Add --help for more details on options for running autest test system. + +### bootstrap.py +This script should try to install python35 or better on the system, and needed python packages for running the tests. + +# Advance setup + +AuTest can be install manually instead of using the wrapper script. The advange of this is that it is often easier to debug issues with the testing system, or the tests. There are two ways this can be done. +1. run the bootstrap script then source the path with a "source /env-test/bin/activate" command. At this point autest command should run without the wrapper script --- End diff -- This really installs stuff in `/env-test`? That seems unfriendly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1526 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1557/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1526 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1661/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1526 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/225/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1427: Crash in ATSConsistentHash::lookup_by_hashval
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1427 Are there any changes being made to parent.config with traffic_ctl when the crash happens? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1662/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1558/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/94/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1522 Testing this on docs, it's similar to #1444 which did not solve the problems for us there (completely at least), hopefully the additions to the read case helps. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1520: Report protocol in request via header
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1520#discussion_r103819181
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -741,26 +741,14 @@
HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd
}
char *incoming_via = s->via_string;
- int scheme = s->orig_scheme;
- ink_assert(scheme >= 0);
-
- int scheme_len = hdrtoken_index_to_length(scheme);
- int32_t hversion = header->version_get().m_version;
-
- memcpy(via_string, hdrtoken_index_to_wks(scheme), scheme_len);
- via_string += scheme_len;
-
- // Common case (I hope?)
- if ((HTTP_MAJOR(hversion) == 1) && HTTP_MINOR(hversion) == 1) {
-memcpy(via_string, "/1.1 ", 5);
-via_string += 5;
- } else {
-*via_string++ = '/';
-*via_string++ = '0' + HTTP_MAJOR(hversion);
-*via_string++ = '.';
-*via_string++ = '0' + HTTP_MINOR(hversion);
+ char const *proto_buf[10]; // 10 seems like a reasonable number of
protos to print
+ int retval = s->state_machine->populate_client_protocol(proto_buf,
countof(proto_buf));
+ for (int i = 0; i < retval; i++) {
+memcpy(via_string, proto_buf[i], strlen(proto_buf[i]));
--- End diff --
Aaah this is super unfortunate IMO, so now we have to do strlen() on all
these strings, even though they are static? :-/. I remember having this
conversation about the public APIs, but can we make something internal that
doesn't have this shortcoming?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/226/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x
Github user scw00 commented on the issue:
https://github.com/apache/trafficserver/issues/1401
epoll_wait triggered EVENTIO_ERROR after accept(do_blocking_accept) will
cause coredump, because we do not call any do_io_xx. In 6.x.x we do not handle
EVENTIO_ERROR eventï¼it may cause vc leaking, but avoid coredump.
` while ((vc = write_ready_list.dequeue())) {
set_cont_flags(vc->control_flags);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
write_to_net(this, vc, trigger_event->ethread);
else if (!vc->write.enabled) {
write_ready_list.remove(vc);
#if defined(solaris)
if (vc->write.triggered && vc->read.enabled) {
vc->ep.modify(-EVENTIO_WRITE);
vc->ep.refresh(EVENTIO_READ);
vc->readReschedule(this);
}
#endif
}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x
Github user scw00 commented on the issue: https://github.com/apache/trafficserver/issues/1401 epoll_wait trigger EVENTIO_ERROR(in read or write) would case segfault, because we do not set any state in vc(by calling do_io_xxx). we just recevie sockets and register in epoll_wait. In 6.x.x, we do not handle EVENTIO_ERROR. It may cause vc leaking, but avoid coredump. Calling do_io_xx before register or closed directly(it do not enter the trasaction) may fix it, but still on test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1510: Crash at HttpSM::state_request_wait_for_transform...
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1510 @bryancall @zwoop Could you please assign someone to review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
