[jira] [Commented] (TS-4016) Add the ability to skip the remap phase of the SM

2015-11-12 Thread Boaz Reicher (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002000#comment-15002000
 ] 

Boaz Reicher commented on TS-4016:
--

Hi [~briang],
That comment is in the patch for TS-4015, not it this one.

> Add the ability to skip the remap phase of the SM
> -
>
> Key: TS-4016
> URL: https://issues.apache.org/jira/browse/TS-4016
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: CPP API
>Reporter: Boaz Reicher
>Assignee: Sudheer Vinukonda
>  Labels: review
> Fix For: 6.1.0
>
> Attachments: ts-4016.diff
>
>
> Adding a method to the Transaction class to skip the remap phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4010) Add cached request/response to the CPP API transaction object

2015-11-11 Thread Boaz Reicher (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000239#comment-15000239
 ] 

Boaz Reicher commented on TS-4010:
--

Hi [~briang],
There's already a hook point for TS_HTTP_READ_CACHE_HDR_HOOK: 
https://github.com/apache/trafficserver/blob/master/lib/atscppapi/src/utils_internal.cc#L130
If it's missing someplace else, can you please point me to it and I'll add it?

Thanks,

> Add cached request/response to the CPP API transaction object
> -
>
> Key: TS-4010
> URL: https://issues.apache.org/jira/browse/TS-4010
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: CPP API
>Reporter: Boaz Reicher
>Assignee: Brian Geffon
> Fix For: 6.1.0
>
> Attachments: ts-4010.diff
>
>
> The transaction object should contain handles to the cached request and 
> response.
> The cached request/response objects should be initialized after 
> TS_EVENT_HTTP_READ_CACHE_HDR



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4015) Add a transaction method to set the HTTP return status

2015-11-11 Thread Boaz Reicher (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000479#comment-15000479
 ] 

Boaz Reicher commented on TS-4015:
--

[~briang], [~sudheerv] : Can you please review and merge?

Note:  I'm aware that this functionality already exists in 
Response::setStatusCode(), but this is required in cases where the Response 
objects haven't been initialized yet.  For example, a plugin that needs to 
block requests after reading the request headers and set a 401 return status 
would use this method (and Transaction::error(const std::string )).

Thanks,

> Add a transaction method to set the HTTP return status
> --
>
> Key: TS-4015
> URL: https://issues.apache.org/jira/browse/TS-4015
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: CPP API
>Reporter: Boaz Reicher
>Assignee: Brian Geffon
> Attachments: patch-4015.diff
>
>
> The Transaction class should have a method that allows setting the HTTP 
> return status without requiring a Response object.  Primarily needed for 
> setting error responses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (TS-4016) Add the ability to skip the remap phase of the SM

2015-11-11 Thread Boaz Reicher (JIRA)
Boaz Reicher created TS-4016:


 Summary: Add the ability to skip the remap phase of the SM
 Key: TS-4016
 URL: https://issues.apache.org/jira/browse/TS-4016
 Project: Traffic Server
  Issue Type: Improvement
  Components: CPP API
Reporter: Boaz Reicher
Assignee: Brian Geffon


Adding a method to the Transaction class to skip the remap phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4016) Add the ability to skip the remap phase of the SM

2015-11-11 Thread Boaz Reicher (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000538#comment-15000538
 ] 

Boaz Reicher commented on TS-4016:
--

[~briang], [~sudheerv] : Can you please review this patch?

Thanks,

> Add the ability to skip the remap phase of the SM
> -
>
> Key: TS-4016
> URL: https://issues.apache.org/jira/browse/TS-4016
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: CPP API
>Reporter: Boaz Reicher
>Assignee: Brian Geffon
> Attachments: ts-4016.diff
>
>
> Adding a method to the Transaction class to skip the remap phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TS-4016) Add the ability to skip the remap phase of the SM

2015-11-11 Thread Boaz Reicher (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boaz Reicher updated TS-4016:
-
Attachment: ts-4016.diff

> Add the ability to skip the remap phase of the SM
> -
>
> Key: TS-4016
> URL: https://issues.apache.org/jira/browse/TS-4016
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: CPP API
>Reporter: Boaz Reicher
>Assignee: Brian Geffon
> Attachments: ts-4016.diff
>
>
> Adding a method to the Transaction class to skip the remap phase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (TS-4015) Add a transaction method to set the HTTP return status

2015-11-11 Thread Boaz Reicher (JIRA)
Boaz Reicher created TS-4015:


 Summary: Add a transaction method to set the HTTP return status
 Key: TS-4015
 URL: https://issues.apache.org/jira/browse/TS-4015
 Project: Traffic Server
  Issue Type: Improvement
  Components: CPP API
Reporter: Boaz Reicher
Assignee: Brian Geffon


The Transaction class should have a method that allows setting the HTTP return 
status without requiring a Response object.  Primarily needed for setting error 
responses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TS-4015) Add a transaction method to set the HTTP return status

2015-11-11 Thread Boaz Reicher (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boaz Reicher updated TS-4015:
-
Attachment: patch-4015.diff

> Add a transaction method to set the HTTP return status
> --
>
> Key: TS-4015
> URL: https://issues.apache.org/jira/browse/TS-4015
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: CPP API
>Reporter: Boaz Reicher
>Assignee: Brian Geffon
> Attachments: patch-4015.diff
>
>
> The Transaction class should have a method that allows setting the HTTP 
> return status without requiring a Response object.  Primarily needed for 
> setting error responses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TS-4010) Add cached request/response to the CPP API transaction object

2015-11-11 Thread Boaz Reicher (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000364#comment-15000364
 ] 

Boaz Reicher commented on TS-4010:
--

You can list me as the author.

Thanks,

> Add cached request/response to the CPP API transaction object
> -
>
> Key: TS-4010
> URL: https://issues.apache.org/jira/browse/TS-4010
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: CPP API
>Reporter: Boaz Reicher
>Assignee: Brian Geffon
> Fix For: 6.1.0
>
> Attachments: ts-4010.diff
>
>
> The transaction object should contain handles to the cached request and 
> response.
> The cached request/response objects should be initialized after 
> TS_EVENT_HTTP_READ_CACHE_HDR



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (TS-4010) Add cached request/response to the CPP API transaction object

2015-11-10 Thread Boaz Reicher (JIRA)
Boaz Reicher created TS-4010:


 Summary: Add cached request/response to the CPP API transaction 
object
 Key: TS-4010
 URL: https://issues.apache.org/jira/browse/TS-4010
 Project: Traffic Server
  Issue Type: Improvement
  Components: CPP API
Reporter: Boaz Reicher
Assignee: Brian Geffon


The transaction object should contain handles to the cached request and 
response.
The cached request/response objects should be initialized after 
TS_EVENT_HTTP_READ_CACHE_HDR



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)