[jira] [Commented] (TS-3059) Logging API is missing a TSTextLogObjectRollingSizeMbSet()
[ https://issues.apache.org/jira/browse/TS-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123647#comment-14123647 ] Brian Rectanus commented on TS-3059: Yes, I kept it int as the existing TextLogObject function takes an int: TextLogObject::set_rolling_size_mb(int rolling_size_mb) Logging API is missing a TSTextLogObjectRollingSizeMbSet() -- Key: TS-3059 URL: https://issues.apache.org/jira/browse/TS-3059 Project: Traffic Server Issue Type: New Feature Components: Logging, TS API Reporter: Brian Rectanus Fix For: sometime These all exist, but seems to be missing the API to set rolling size: * Enabled: TSTextLogObjectRollingEnabledSet() * Interval: TSTextLogObjectRollingIntervalSecSet() * Hour: TSTextLogObjectRollingOffsetHrSet() It seems the rolling size can only be set globally in records.config (proxy.config.log.rolling_size_mb) and in the logs_xml.config (RollingSizeMb = size_in_MB/). Please add the missing TSTextLogObjectRollingSizeMbSet() API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TS-3059) Logging API is missing a TSTextLogObjectRollingSizeMbSet()
Brian Rectanus created TS-3059: -- Summary: Logging API is missing a TSTextLogObjectRollingSizeMbSet() Key: TS-3059 URL: https://issues.apache.org/jira/browse/TS-3059 Project: Traffic Server Issue Type: Bug Components: Logging Reporter: Brian Rectanus These all exist, but seems to be missing the API to set rolling size: * Enabled: TSTextLogObjectRollingEnabledSet() * Interval: TSTextLogObjectRollingIntervalSecSet() * Hour: TSTextLogObjectRollingOffsetHrSet() It seems the rolling size can only be set globally in records.config (proxy.config.log.rolling_size_mb) and in the logs_xml.config (RollingSizeMb = size_in_MB/). Please add the missing TSTextLogObjectRollingSizeMbSet() API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2279) proxy.config.exec_thread.affinity's values
[
https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103207#comment-14103207
]
Brian Rectanus commented on TS-2279:
Used to be that 1 was sockets, but now that changed to 2 and 1 is now NUMA.
This seems to mean I will need to change my config (or something will migrate
it). I would have expected NUMA to be added as a new value (4) as to not
require changes to old configs. Why did all the values shift between 4.2 and
master?
proxy.config.exec_thread.affinity's values
--
Key: TS-2279
URL: https://issues.apache.org/jira/browse/TS-2279
Project: Traffic Server
Issue Type: Bug
Components: Configuration
Reporter: Igor Galić
Assignee: Phil Sorber
Fix For: 5.1.0
The setting of {{proxy.config.exec_thread.affinity}} only has an affect when
traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at
all, not even a warning about its being ineffectual when setting that value
while trafficserver is *not* configured with {{--enable-hwloc}}.
Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
{code}
{RECT_CONFIG, proxy.config.exec_thread.affinity, RECD_INT, 0,
RECU_RESTART_TS, RR_NULL, RECC_INT, [0-1], RECA_READ_ONLY}
{code}
but the code uses a range of [0-3]:
{code}
#if TS_USE_HWLOC
if (affinity != 0) {
int logical_ratio;
switch(affinity) {
case 3: // assign threads to logical cores
logical_ratio = 1;
break;
case 2: // assign threads to real cores
logical_ratio = pu / cu;
break;
case 1: // assign threads to sockets
default:
logical_ratio = pu / socket;
}
{code}
And finally, 1 is the default value, rather than issuing a warning about an
incorrect value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
