[jira] [Updated] (TS-2859) fix DBG macros to not generate warnings from GCC 4.9
[ https://issues.apache.org/jira/browse/TS-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcin Juszkiewicz updated TS-2859: --- Attachment: trafficserver-fix-dbg.patch > fix DBG macros to not generate warnings from GCC 4.9 > > > Key: TS-2859 > URL: https://issues.apache.org/jira/browse/TS-2859 > Project: Traffic Server > Issue Type: Improvement > Components: Build >Reporter: Marcin Juszkiewicz > Attachments: trafficserver-fix-dbg.patch > > > Fedora 'rawhide' is using gcc 4.9 as default compiler. During build of > trafficserver 4.2.1 I had lot of extra output from gcc due to DBG macros: > --- > In file included from ../../lib/ts/ink_time.h:38:0, > from ../../lib/ts/ink_align.h:28, > from ../../lib/ts/libts.h:46, > from P_EventSystem.h:34, > from IOBuffer.cc:28: > ../../lib/ts/ink_defs.h:147:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define FDBGif (debug_level==1) printf("debug "__FILE__":%d > %s : entered\n" ,__LINE__,__FUNCTION__) > ^ > ../../lib/ts/ink_defs.h:148:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG(s) if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__) > ^ > ../../lib/ts/ink_defs.h:149:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG1(s,a) if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__, a) > ^ > ../../lib/ts/ink_defs.h:150:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG2(s,a1,a2) if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__, a1,a2) > ^ > ../../lib/ts/ink_defs.h:151:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG3(s,a1,a2,a3)if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3) > ^ > ../../lib/ts/ink_defs.h:152:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG4(s,a1,a2,a3,a4) if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3,a4) > --- > I have a fix for that. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (TS-2859) fix DBG macros to not generate warnings from GCC 4.9
Marcin Juszkiewicz created TS-2859: -- Summary: fix DBG macros to not generate warnings from GCC 4.9 Key: TS-2859 URL: https://issues.apache.org/jira/browse/TS-2859 Project: Traffic Server Issue Type: Improvement Components: Build Reporter: Marcin Juszkiewicz Attachments: trafficserver-fix-dbg.patch Fedora 'rawhide' is using gcc 4.9 as default compiler. During build of trafficserver 4.2.1 I had lot of extra output from gcc due to DBG macros: --- In file included from ../../lib/ts/ink_time.h:38:0, from ../../lib/ts/ink_align.h:28, from ../../lib/ts/libts.h:46, from P_EventSystem.h:34, from IOBuffer.cc:28: ../../lib/ts/ink_defs.h:147:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] #define FDBGif (debug_level==1) printf("debug "__FILE__":%d %s : entered\n" ,__LINE__,__FUNCTION__) ^ ../../lib/ts/ink_defs.h:148:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] #define DBG(s) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__) ^ ../../lib/ts/ink_defs.h:149:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] #define DBG1(s,a) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__, a) ^ ../../lib/ts/ink_defs.h:150:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] #define DBG2(s,a1,a2) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__, a1,a2) ^ ../../lib/ts/ink_defs.h:151:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] #define DBG3(s,a1,a2,a3)if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3) ^ ../../lib/ts/ink_defs.h:152:56: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] #define DBG4(s,a1,a2,a3,a4) if (debug_level==1) printf("debug "__FILE__":%d %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3,a4) --- I have a fix for that. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (TS-2860) AArch64 support
Marcin Juszkiewicz created TS-2860: -- Summary: AArch64 support Key: TS-2860 URL: https://issues.apache.org/jira/browse/TS-2860 Project: Traffic Server Issue Type: New Feature Components: Build, Portability Reporter: Marcin Juszkiewicz Attachments: trafficserver-aarch64.patch Out of the box traffic server does not build on AArch64 (64-bit ARM) architecture. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TS-2860) AArch64 support
[ https://issues.apache.org/jira/browse/TS-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcin Juszkiewicz updated TS-2860: --- Attachment: trafficserver-aarch64.patch This patch adds all required definitions to get traffic server 4.2.1 built on AArch64 system. All tests passed. > AArch64 support > --- > > Key: TS-2860 > URL: https://issues.apache.org/jira/browse/TS-2860 > Project: Traffic Server > Issue Type: New Feature > Components: Build, Portability >Reporter: Marcin Juszkiewicz > Attachments: trafficserver-aarch64.patch > > > Out of the box traffic server does not build on AArch64 (64-bit ARM) > architecture. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TS-2859) fix DBG macros to not generate warnings from GCC 4.9
[ https://issues.apache.org/jira/browse/TS-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcin Juszkiewicz updated TS-2859: --- Attachment: trafficserver-remove-dbg-macros.patch This patch removes DBG macros as they are not used. > fix DBG macros to not generate warnings from GCC 4.9 > > > Key: TS-2859 > URL: https://issues.apache.org/jira/browse/TS-2859 > Project: Traffic Server > Issue Type: Improvement > Components: Build >Reporter: Marcin Juszkiewicz > Attachments: trafficserver-fix-dbg.patch, > trafficserver-remove-dbg-macros.patch > > > Fedora 'rawhide' is using gcc 4.9 as default compiler. During build of > trafficserver 4.2.1 I had lot of extra output from gcc due to DBG macros: > --- > In file included from ../../lib/ts/ink_time.h:38:0, > from ../../lib/ts/ink_align.h:28, > from ../../lib/ts/libts.h:46, > from P_EventSystem.h:34, > from IOBuffer.cc:28: > ../../lib/ts/ink_defs.h:147:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define FDBGif (debug_level==1) printf("debug "__FILE__":%d > %s : entered\n" ,__LINE__,__FUNCTION__) > ^ > ../../lib/ts/ink_defs.h:148:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG(s) if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__) > ^ > ../../lib/ts/ink_defs.h:149:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG1(s,a) if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__, a) > ^ > ../../lib/ts/ink_defs.h:150:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG2(s,a1,a2) if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__, a1,a2) > ^ > ../../lib/ts/ink_defs.h:151:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG3(s,a1,a2,a3)if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3) > ^ > ../../lib/ts/ink_defs.h:152:56: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] > #define DBG4(s,a1,a2,a3,a4) if (debug_level==1) printf("debug "__FILE__":%d > %s :" s ,__LINE__,__FUNCTION__, a1,a2,a3,a4) > --- > I have a fix for that. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2860) AArch64 support
[ https://issues.apache.org/jira/browse/TS-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079036#comment-14079036 ] Marcin Juszkiewicz commented on TS-2860: I will take a look but I am not sure will I be able to port it. Can not provide access to ARM64 hardware yet. > AArch64 support > --- > > Key: TS-2860 > URL: https://issues.apache.org/jira/browse/TS-2860 > Project: Traffic Server > Issue Type: New Feature > Components: Build, Portability >Reporter: Marcin Juszkiewicz >Assignee: Leif Hedstrom > Fix For: 5.1.0 > > Attachments: trafficserver-aarch64.patch > > > Out of the box traffic server does not build on AArch64 (64-bit ARM) > architecture. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2860) AArch64 support
[ https://issues.apache.org/jira/browse/TS-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079190#comment-14079190 ] Marcin Juszkiewicz commented on TS-2860: Good news: looks that CK has support for gcc atomics. I added some small required changes and doing checks now. > AArch64 support > --- > > Key: TS-2860 > URL: https://issues.apache.org/jira/browse/TS-2860 > Project: Traffic Server > Issue Type: New Feature > Components: Build, Portability >Reporter: Marcin Juszkiewicz >Assignee: Leif Hedstrom > Fix For: 5.1.0 > > Attachments: trafficserver-aarch64.patch > > > Out of the box traffic server does not build on AArch64 (64-bit ARM) > architecture. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-2860) AArch64 support
[ https://issues.apache.org/jira/browse/TS-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084911#comment-14084911 ] Marcin Juszkiewicz commented on TS-2860: Good point. Will fix that patch tomorrow and upload proper one. > AArch64 support > --- > > Key: TS-2860 > URL: https://issues.apache.org/jira/browse/TS-2860 > Project: Traffic Server > Issue Type: New Feature > Components: Build, Portability >Reporter: Marcin Juszkiewicz >Assignee: Phil Sorber > Fix For: 5.1.0 > > Attachments: trafficserver-aarch64.patch > > > Out of the box traffic server does not build on AArch64 (64-bit ARM) > architecture. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TS-2860) AArch64 support
[ https://issues.apache.org/jira/browse/TS-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcin Juszkiewicz updated TS-2860: --- Attachment: trafficserver-5.0.1-aarch64.patch AArch64 support for 5.0.1 version > AArch64 support > --- > > Key: TS-2860 > URL: https://issues.apache.org/jira/browse/TS-2860 > Project: Traffic Server > Issue Type: New Feature > Components: Build, Portability >Reporter: Marcin Juszkiewicz >Assignee: Phil Sorber > Fix For: 5.1.0 > > Attachments: trafficserver-5.0.1-aarch64.patch, > trafficserver-aarch64.patch > > > Out of the box traffic server does not build on AArch64 (64-bit ARM) > architecture. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (TS-2860) AArch64 support
[ https://issues.apache.org/jira/browse/TS-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084911#comment-14084911 ] Marcin Juszkiewicz edited comment on TS-2860 at 8/4/14 5:29 PM: Checked once again 4.2.1 version. Patch is proper - there are two checks for __arm__ in code. was (Author: hrw-redhat): Good point. Will fix that patch tomorrow and upload proper one. > AArch64 support > --- > > Key: TS-2860 > URL: https://issues.apache.org/jira/browse/TS-2860 > Project: Traffic Server > Issue Type: New Feature > Components: Build, Portability >Reporter: Marcin Juszkiewicz >Assignee: Phil Sorber > Fix For: 5.1.0 > > Attachments: trafficserver-5.0.1-aarch64.patch, > trafficserver-aarch64.patch > > > Out of the box traffic server does not build on AArch64 (64-bit ARM) > architecture. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TS-3514) Atomic check for gcc >4.1 breaks with gcc 5.0
[ https://issues.apache.org/jira/browse/TS-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcin Juszkiewicz updated TS-3514: --- Attachment: 0001-GCC-compiler-4.1-should-accept-5.x-as-well.patch > Atomic check for gcc >4.1 breaks with gcc 5.0 > - > > Key: TS-3514 > URL: https://issues.apache.org/jira/browse/TS-3514 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: Marcin Juszkiewicz > Attachments: 0001-GCC-compiler-4.1-should-accept-5.x-as-well.patch > > > lib/ts/ink_atomic.h has a check for gcc >= 4.1 but done in a way which blocks > gcc 5.0 from being used. > Fedora 22 has prerelease of gcc 5.0 as default compiler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TS-3514) Atomic check for gcc >4.1 breaks with gcc 5.0
Marcin Juszkiewicz created TS-3514: -- Summary: Atomic check for gcc >4.1 breaks with gcc 5.0 Key: TS-3514 URL: https://issues.apache.org/jira/browse/TS-3514 Project: Traffic Server Issue Type: Bug Components: Build Reporter: Marcin Juszkiewicz lib/ts/ink_atomic.h has a check for gcc >= 4.1 but done in a way which blocks gcc 5.0 from being used. Fedora 22 has prerelease of gcc 5.0 as default compiler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3514) Atomic check for gcc >4.1 breaks with gcc 5.0
[ https://issues.apache.org/jira/browse/TS-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487062#comment-14487062 ] Marcin Juszkiewicz commented on TS-3514: Patch applies to 5.0.x 5.1.x and master branches. > Atomic check for gcc >4.1 breaks with gcc 5.0 > - > > Key: TS-3514 > URL: https://issues.apache.org/jira/browse/TS-3514 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: Marcin Juszkiewicz > Attachments: 0001-GCC-compiler-4.1-should-accept-5.x-as-well.patch > > > lib/ts/ink_atomic.h has a check for gcc >= 4.1 but done in a way which blocks > gcc 5.0 from being used. > Fedora 22 has prerelease of gcc 5.0 as default compiler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)