[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1152 Maybe this should be an ink_abort instead of ink_release_assert? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1152 I took a close look at this and I didn't make the change that caused clang-format to fail here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1152 OK, figured it out. removing a variable made the equals signs want to line up differently on a line i didnt modify. Fixed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1152 I put the plugin hook in and got it working. Thanks for the suggestion. Nathan > On Oct 26, 2016, at 9:01 PM, Leif Hedstrom <notificati...@github.com> wrote: > > @ngara <https://github.com/ngara> I think this is failing because of clang-format. I recommend you copy the pre-commit githook into your .git/hooks tree. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/trafficserver/pull/1152#issuecomment-256541086>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA51eE0tGOe6QyG0UPgODLOK41L_-Xutks5q4CILgaJpZM4KhylU>. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1155: TS-5012 CID 1267812 Logically Dead Code fi...
GitHub user ngara opened a pull request: https://github.com/apache/trafficserver/pull/1155 TS-5012 CID 1267812 Logically Dead Code fixed removed ink_asserts in favor of ink_abort with an error message You can merge this pull request into a Git repository by running: $ git pull https://github.com/ngara/trafficserver TS-5012 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1155 commit c89bd698064d9cb7a217f5d6707121665d76d309 Author: Nathan Garabedian <ng...@users.noreply.github.com> Date: 2016-10-26T23:54:32Z TS-5012 CID 1267812 Logically Dead Code fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1152: TS-5009 CID 1022011 Logically dead code re...
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1152
TS-5009 CID 1022011 Logically dead code removal
Please review - I changed this code to ink_release_assert instead of the
following code, which seems to either return '\0' or *b->start(); but will
ink_assert in debug mode.
ink_assert(!"out of range");
const: At condition !!b, the value of b must be equal to 0.
null: At condition !!b, the value of b must be NULL.
dead_error_condition: The condition !!b cannot be true.
700 if (unlikely(b)) {
CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return b->start();.
701return *b->start();
702 }
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngara/trafficserver TS-5009
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1152
commit 1d169f17565dfe9f2042bd7a73b92420ab602898
Author: Nathan Garabedian <ng...@users.noreply.github.com>
Date: 2016-10-26T23:14:59Z
TS-5009 CID 1022011 Logically dead code removal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1149: TS-5008 CID 1022007 Logically dead code
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1149
TS-5008 CID 1022007 Logically dead code
The first "if (in_ext_map)" and if (ret) return ret; causes the following
code if (in_ext_map) to never execute. Modified to clean it up.
if (in_ext_map) {
612ret = true;
613 }
614
615 if (ret) {
616return ret;
617 }
618
619 if (ink_hash_table_lookup(our_map, virt_ip, _value) != 0) {
const: At condition in_ext_map, the value of in_ext_map must be equal
to 0.
dead_error_condition: The condition in_ext_map cannot be true.
620if (in_ext_map) {
CID 1022007 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: ret = true;.
621 ret = true;
622} else {
623 ret = false;
624}
625 }
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngara/trafficserver TS-5008
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1149
commit b28f57089ec63eafa8170b24423538214ec27e67
Author: Nathan Garabedian <ng...@users.noreply.github.com>
Date: 2016-10-26T22:30:31Z
TS-5008 CID 1022007 Logically dead code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1145: TS-5004 CID 1021675 Structurally dead code...
GitHub user ngara opened a pull request: https://github.com/apache/trafficserver/pull/1145 TS-5004 CID 1021675 Structurally dead code removed Removed some lines of code that won't get executed You can merge this pull request into a Git repository by running: $ git pull https://github.com/ngara/trafficserver TS-5004 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1145.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1145 commit 52ad8539d3cff6793c32a87f0f5b0c8b0b266dc0 Author: Nathan Garabedian <ng...@users.noreply.github.com> Date: 2016-10-26T19:55:09Z TS-5004 CID 1021675 Structurally dead code removed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/963 Alright, I cleaned up my mess. Here's just the single commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1021: TS-4864 CID 1362769 - when pthread_create fails, ...
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1021 jpeach: I made the suggested modification. Tests good, also tested with ret=1 to see how the error would print and that works as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1021: TS-4864 CID 1362769 - when pthread_create ...
GitHub user ngara opened a pull request: https://github.com/apache/trafficserver/pull/1021 TS-4864 CID 1362769 - when pthread_create fails, ink_abort instead of⦠⦠returning 0, and remove dead code You can merge this pull request into a Git repository by running: $ git pull https://github.com/ngara/trafficserver TS-4864 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1021.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1021 commit 8d0bdadecda7427c3ebbc03e074f7ee22e025aa9 Author: Nathan Garabedian <ngar...@gmail.com> Date: 2016-09-14T20:59:23Z TS-4864 CID 1362769 - when pthread_create fails, ink_abort instead of returning 0, and remove dead code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/963 This pull request should not be merged in. Handling it with TS-4860 instead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #963: TS-4815 - CID 1267839 dead code in /mgmt/ap...
GitHub user ngara reopened a pull request: https://github.com/apache/trafficserver/pull/963 TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: re⦠TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS; You can merge this pull request into a Git repository by running: $ git pull https://github.com/ngara/trafficserver TS-4815 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/963.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #963 commit 8947c566f5564f1bb03fa63d5bcc2e18ab08ccde Author: Nathan Garabedian <ngarabed...@apple.com> Date: 2016-09-02T21:13:38Z TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS; --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #963: TS-4815 - CID 1267839 dead code in /mgmt/ap...
Github user ngara closed the pull request at: https://github.com/apache/trafficserver/pull/963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/963 Thanks for the feedback. Updated to use ink_release_assert which will always execute, and ready to review again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #893: TS-4581 CID 1356973 dead code in proxy/hdrs/HTTP.c...
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/893 ok, conflicts resolved again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #893: TS-4581 CID 1356973 dead code in proxy/hdrs/HTTP.c...
Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/893 Please take a look again, it should be fixed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #893: TS-4581 CID 1356973 dead code in proxy/hdrs...
GitHub user ngara opened a pull request: https://github.com/apache/trafficserver/pull/893 TS-4581 CID 1356973 dead code in proxy/hdrs/HTTP.cc You can merge this pull request into a Git repository by running: $ git pull https://github.com/ngara/trafficserver TS-4581 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/893.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #893 commit 6cc8fbd1b267324d86db17e1ff8e6a3ece7b2772 Author: Nathan Garabedian <ngarabed...@apple.com> Date: 2016-06-24T22:13:46Z TS-4581 CID 1356973 dead code in proxy/hdrs/HTTP.cc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
