[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-17 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
Looks good.  Persia addressed Leif and James' comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-17 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/926/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-17 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1034/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-17 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-17 Thread persiaAziz
Github user persiaAziz commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
Please review @shinrich 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-14 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1018/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-14 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/910/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-14 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-14 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1016/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-14 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/908/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-14 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-05 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/938/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-05 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/830/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-05 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-10-05 Thread persiaAziz
Github user persiaAziz commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
Please review @shinrich 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-09-15 Thread persiaAziz
Github user persiaAziz commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
pointer check removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-09-15 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/709/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-09-15 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/813/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-09-15 Thread zwoop
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1024
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---