[GitHub] trafficserver issue #1062: [TS-4908] Remove duplicated cancelling event

2016-10-11 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1062
  
Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1062: [TS-4908] Remove duplicated cancelling event

2016-10-10 Thread calavera
Github user calavera commented on the issue:

https://github.com/apache/trafficserver/pull/1062
  
@shinrich I made the change you suggested, making the even null and adding 
an assert replacing the double closing. I've also modified the 
title/description here and jira.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---