[GitHub] trafficserver issue #1080: TS-4934: Remove invalid assert
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1080 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/941/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1080: TS-4934: Remove invalid assert
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1080 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/833/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1080: TS-4934: Remove invalid assert
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1080
Looks good to me as well. In my working branch I had extended this assert
to
{code}
// Check to see if the stream is in the closed state
ink_assert(get_state() == HTTP2_STREAM_STATE_CLOSED || get_state() ==
HTTP2_STREAM_STATE_HALF_CLOSED_REMOTE);
{code}
But you are exactly right that with timeouts, checking the state is not
particularly useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1080: TS-4934: Remove invalid assert
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1080 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/936/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1080: TS-4934: Remove invalid assert
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1080 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/828/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1080: TS-4934: Remove invalid assert
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1080 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/934/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
