[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[jrushford]

Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
whew  wipes sweat from furrowed brow :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[jrushford]

Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
see the changes @jpeach.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1096/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1203/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[jrushford]

Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
@jpeach - tested and the fix consumes absolute paths, relative paths to 
install directory, and it now consumes config files relative to the config 
directory


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[jpeach]

Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
@jrushford Since you are fixing this, please make sure that the new 
behavior is consistent with other plugins that load files. IIRC absolute paths 
are consumes as is, relative paths are relative to the config directory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[jrushford]

Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
@zwoop I just put back the code used previous to TS-2682 in 
background_fetch.cc.  Didn't spend too much time on it, just wanted our configs 
to be read wen we deploy 6.2.  I can go back and clean it up.

@jpeach I haven't looked at every remap plugin  to see how they open and 
read they're config files.  Just put back the code from before the regression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[jpeach]

Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
Is this change consistent with other plugins are doing?

> On Nov 11, 2016, at 1:07 PM, Leif Hedstrom  
wrote:
> 
> @zwoop approved this pull request.
> 
> I'm ok with this, but it feels a little clunky that we duplicate the 
codes / error checking nested like this. Since it's C++, couldn't we iterate 
over a vector of candidate directories?
> 
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1201/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
Please add Milestones, Labels etc...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1218
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1094/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---