[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/36/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1365/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1472/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/35/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1364/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1471/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/34/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1363/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1470/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/33/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1404 Looks great. Two issues: 1) Run clang-format on it :). 2) On FreeBSD, it fails with ``` ../../plugins/experimental/ts_lua/ts_lua_http_config.c:244:53: error: '__ts_lua_http_config_vars_static_assert' declared as an array with a negative size extern char __ts_lua_http_config_vars_static_assert[NUM_HTTP_CONFIG_VARS == TS_CONFIG_LAST_ENTRY + 1 ? 0 : -1]; ^ ../../plugins/experimental/ts_lua/ts_lua_http_config.c:243:30: note: expanded from macro 'NUM_HTTP_CONFIG_VARS' #define NUM_HTTP_CONFIG_VARS (sizeof(ts_lua_http_config_vars) / sizeof(ts_lua_http_config_vars[0])) ^ 1 error generated. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1469/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1362/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1404 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/Github-Clang/31/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1467/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1359/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/Github-Clang/23/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1458/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1404 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1351/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1404 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user vmamidi commented on the issue: https://github.com/apache/trafficserver/pull/1404 incorporated the review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...
Github user vmamidi commented on the issue: https://github.com/apache/trafficserver/pull/1404 According to RFC ( https://tools.ietf.org/html/rfc7231#section-4.2.1 ) all the idempotent methods should be retryable but we can at least try to retry the safe requests. The methods GET, HEAD, OPTIONS, and TRACE are considered safe. ATS does not retry any requests based on the connection state with Origin Server and bytes sent to Origin Server. ATS should retry all the safe requests to give a chance to serve the request instead of responding with 502. Also, we can make this configurable so that ATS can handle special scenarios. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
