[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1522 or we can use: ``` if (vc->write.enabled && vc->write.triggered || vc->write.error && vc->write.vio._cont != nullptr) ``` keep old condition then add new condition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1522
to review #947 again, my suggestion is
```
diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
index 85d7527..5ef65cb 100644
--- a/iocore/net/UnixNet.cc
+++ b/iocore/net/UnixNet.cc
@@ -505,7 +505,7 @@ NetHandler::mainNetEvent(int event, Event *e)
set_cont_flags(vc->control_flags);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if ((vc->read.enabled || vc->read.error) && vc->read.triggered &&
vc->read.vio._cont != nullptr)
vc->net_read_io(this, trigger_event->ethread);
else if (!vc->read.enabled) {
read_ready_list.remove(vc);
@@ -522,7 +522,7 @@ NetHandler::mainNetEvent(int event, Event *e)
set_cont_flags(vc->control_flags);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if ((vc->write.enabled || vc->write.error) && vc->write.triggered
&& vc->write.vio._cont != nullptr)
write_to_net(this, vc, trigger_event->ethread);
else if (!vc->write.enabled) {
write_ready_list.remove(vc);
@@ -540,7 +540,7 @@ NetHandler::mainNetEvent(int event, Event *e)
diags->set_override(vc->control.debug_override);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if ((vc->read.enabled || vc->read.error) && vc->read.triggered &&
vc->read.vio._cont != nullptr)
vc->net_read_io(this, trigger_event->ethread);
else if (!vc->read.enabled)
vc->ep.modify(-EVENTIO_READ);
@@ -549,7 +549,7 @@ NetHandler::mainNetEvent(int event, Event *e)
diags->set_override(vc->control.debug_override);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if ((vc->write.enabled || vc->write.error) && vc->write.triggered
&& vc->write.vio._cont != nullptr)
write_to_net(this, vc, trigger_event->ethread);
else if (!vc->write.enabled)
vc->ep.modify(-EVENTIO_WRITE);
```
Before PR#947:
- IOCore Net Sub-System only callback to SM if vc->read.enabled is set to 1
and vc->read.triggered is set to 1.
- vc->read.enabled must not 0 if vc->read.vio._cont is not nullptr.
- there are 2 ways to set the read.enabled to 0:
- do_io_read(NULL, 0, NULL), both set vio._cont to nullptr
- do_io_read(this, 0, NULL), keep vio._cont not nullptr
- that means read.enabled==1 is indicate vio._cont is not nullptr.
- but read.enabled==0 is not means vio._cont is nullptr.
The target of PR#947 is making iocore to notify EPOLLERR to SM even
read.enabled is set to 0.
But the PR#947 forgot to finger out vio._cont is nullptr state.
the vc->net_read_io is designed to callback SM and Net sub-system must
assure the vio can be callback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1522 Still looking good on Docs, but would like to give it at least another 24 hours before we declare victory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1522 Testing this on docs, it's similar to #1444 which did not solve the problems for us there (completely at least), hopefully the additions to the read case helps. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1522 Looks reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/224/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/92/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1556/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1660/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1522 Here is a workaround for issue #1401. I ran into issues with the read also coring. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
