[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/804 [This](https://issues.apache.org/jira/browse/TS-2819) one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 Yeah, file a Jira probably. I could have sworn we've had issues before where loop detection kicked in when it shouldn't (e.g. you legitimately proxy to yourself). But I can find an issue on it, maybe you can take a look too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/804 > What do you think of a future feature (config) to disable this Via checking completely? If I know there's not chance of a loop, why bother checking the Via header? @zwoop, makes sense. Should I create new jira for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 Did a quick test of this, and it looks good: Via: http/1.1 fedora.ogre.com[f6f5162d-5a02-4d10-ac6e-35aede508fe5] (ApacheTrafficServer/7.0.0) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/337/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/443/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 @yatsukhnenko What do you think of a future feature (config) to disable this Via checking completely? If I know there's not chance of a loop, why bother checking the Via header? I guess one could just nuke the Via header on the incoming request, but there might be other reasons to keep it? This is completely unrelated to this PR though, just thinking out loud. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 I checked the core on this FreeBSD build, and it seems completely unrelated to pretty much anything :). ``` (gdb) bt #0 0x in ?? () #1 0x006ec34a in EThread::process_event (this=0x804107000, e=0x803f2c880, calling_code=) at I_Continuation.h:153 #2 0x006ec8ec in EThread::execute (this=0x804107000) at ../../../iocore/eventsystem/UnixEThread.cc:245 #3 0x006ebb82 in spawn_thread_internal (a=0x803ef5700) at ../../../iocore/eventsystem/Thread.cc:84 #4 0x0008027514f5 in pthread_create () from /lib/libthr.so.3 #5 0x in ?? () ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 I suspect this failed for other reasons, trying again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/335/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/441/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/804 Thanks for explaining about API usage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/333/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/439/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 It's an inefficiency for starters (you go through a C-> C++ wrapper layer, for no good reason (remember, the public APIs are all C, whereas in the core, you can use all the C++ objects and methods directly). In this case, it's marginal, but there are other places where it would be inefficient. And, it would add dependencies to the C-APIs in the C++ core which are undesirable in some cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/804 Don't quite understand why public API can't be used in internal code, but ok, changed code to `Machine::instance()->uuid.getString()` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 Almost, but not quite. :) All APIs that are prefixed TS are the public APIs, and we don't use those in the internal code. Look at the log tags in logging that uses the internal APIs for the UUID. E.g. const char *uuid = (char *)Machine::instance()->uuid.getString(); Makes sense? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
