[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/833 Because I thought it's the easiest way. I could parse query parameters and use a specific parameter as a trigger but it needs more codes. I wanted to keep the example plugin simple. I'd happy to rewrite the function if you have better ideas. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/833 By removing TSUrlHttpQueryGet() I meant, I was always returning true in the function. Why are you determining if it should push based on the length of the query string in the URL? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/683/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/787/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/833 @bryancall That's odd. I just rebased again but I don't see any problems. > After removing TSUrlHttpQueryGet() from the plugin I am seeing many server pushes for the URL in the logs. If you simply removed the line, this is understandable. I guess the variable is not initialized and have some value other than 0. It triggers many server pushes, because the sample plugin is using query string length stored in the variable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/833 I had problems getting it to work. I had problems with the plugin failing from TSUrlHttpQueryGet() in the plugin. After removing TSUrlHttpQueryGet() from the plugin I am seeing many server plus for the URL in the logs. However, I think it would be good to land and we can fix any problems before the 7.0.0 release is made. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/833 It works now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/659/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/763/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/833 It doesn't work correctly after the rebasing. I'm working on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/756/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/652/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/638/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/742/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/637/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/741/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/833 Rebased for now. We still needs discuss about `url` argument. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/833 @maskit Can you please update this pull request? I would like to get this in this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/416/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/519/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/833 Looks good. Please squash commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/397/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/500/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/833 Trying another build, for some reason builds are not stable now [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/392/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/495/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/494/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/391/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/390/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/493/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/833 @maskit Yeh, saw the email now :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/833 @jpeach Which parts of changes are those? I think all changes are related to the API or Server Push. @zwoop I sent a API proposal to dev@ about 11 hours ago. Please let me know if it lacks necessary information. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/833 Also, even with this being an experimental API, I think we should go through the normal API review process for this, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/833 There are quite a few changes that seem unrelated to the proposed API. Can you separate those out into an independent PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/833 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/492/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
