[GitHub] trafficserver pull request #1074: TS-4925: Manager pollMgmtProcessServer stu...

[jpeach]

Github user jpeach closed the pull request at:

https://github.com/apache/trafficserver/pull/1074


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1074: TS-4925: Manager pollMgmtProcessServer stu...

[jpeach]

GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/1074

TS-4925: Manager pollMgmtProcessServer stuck with EBADF.

If the select in pollMgmtProcessServer fails with an actual error
(EBADF, for example), it just returned back into the select loop
and was unable to recover. This might happen if the server file
descriptor is -1, or otherwise stale.

The fix is to not put -1 into the select set, and to break the loop
if select returns an error.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver fix/4925

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1074.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1074


commit a2ff45c956b9b69eb188b87ae1e4c02f74148aba
Author: James Peach 
Date:   2016-10-04T04:43:57Z

TS-4925: Manager pollMgmtProcessServer stuck with EBADF.

If the select in pollMgmtProcessServer fails with an actual error
(EBADF, for example), it just returned back into the select loop
and was unable to recover. This might happen if the server file
descriptor is -1, or otherwise stale.

The fix is to not put -1 into the select set, and to break the loop
if select returns an error.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---