[GitHub] trafficserver pull request #1254: TS-5085 `posix_fadvise` is incorrectly use...

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1254: TS-5085 `posix_fadvise` is incorrectly use...

[danobi]

Github user danobi commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1254#discussion_r91414850
  
--- Diff: proxy/logcat.cc ---
@@ -300,6 +307,9 @@ main(int /* argc ATS_UNUSED */, const char *argv[])
   }
 }
   }
+  // Now that we're done reading a potentially large log file, we can 
tell the kernel that it's OK to evict
+  // the associated log file pages from cache
+  posix_fadvise(in_fd, 0, 0, POSIX_FADV_DONTNEED);
--- End diff --

Oops, I forgot to wrap this call in `#if`'s. Will fix soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1254: TS-5085 `posix_fadvise` is incorrectly use...

[danobi]

GitHub user danobi opened a pull request:

https://github.com/apache/trafficserver/pull/1254

TS-5085 `posix_fadvise` is incorrectly used in traffic_logcat

`traffic_logcat` was not using `posix_fadvise` correctly. This
patch corrects the original poor usage as well as adds some more
`posix_fadvise` calls that should help with performance.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danobi/trafficserver TS-5085

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1254


commit 9e81f07421a10c3028fcbdefd6aaca79065b4446
Author: Daniel Xu 
Date:   2016-12-07T21:20:05Z

TS-5085 `posix_fadvise` is incorrectly used in traffic_logcat

`traffic_logcat` was not using `posix_fadvise` correctly. This
patch corrects the original poor usage as well as adds some more
`posix_fadvise` calls that should help with performance.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---