[GitHub] trafficserver pull request #856: TS-4749: generate warning message when orig...

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/856


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #856: TS-4749: generate warning message when orig...

[bryancall]

Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/856#discussion_r75507271
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -4865,12 +4865,13 @@ HttpSM::do_http_server_open(bool raw)
 md5_ctx.hash_immediate(hostname_hash, static_cast(t_state.current.server->name),
strlen(t_state.current.server->name));
 
-ip_port_text_buffer addrbuf;
 if (connections->getCount(t_state.current.server->dst_addr, 
hostname_hash,
   
(TSServerSessionSharingMatchType)t_state.txn_conf->server_session_sharing_match)
 >=
 t_state.txn_conf->origin_max_connections) {
-  DebugSM("http", "[%" PRId64 "] over the number of connection for 
this host: %s", sm_id,
-  ats_ip_nptop(_state.current.server->dst_addr.sa, addrbuf, 
sizeof(addrbuf)));
+  ip_port_text_buffer addrbuf;
+  ats_ip_ntop(_state.current.server->dst_addr.sa, addrbuf, 
sizeof(addrbuf));
--- End diff --

You would want to call `ats_ip_nptop`.  `ats_ip_ntop` will only copy the 
address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #856: TS-4749: generate warning message when orig...

[shinrich]

GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/856

TS-4749: generate warning message when origin_max_connections limits



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver ts-4749

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/856.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #856


commit 0bb94d12cda7077ec91901d01fa7d79f652063ce
Author: Susan Hinrichs 
Date:   2016-08-12T16:22:24Z

TS-4749: generate warning message when origin_max_connections limit is 
passed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---