[jira] [Comment Edited] (TS-3480) Large stream id cause PROTOCOL_ERROR
[
https://issues.apache.org/jira/browse/TS-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482967#comment-14482967
]
Ryo Okubo edited comment on TS-3480 at 4/7/15 10:42 AM:
Add counter of current streams and logic which compares it with
MAX_CONCURRENT_STREAM.
The counter checks only streams started by client but another counter for
server push streams. And a limiter which is the sum of these streams counter
may be required.
was (Author: rokubo):
Add counter of current streams and logic which compares it with
MAX_CONCURRENT_STREAM.
Large stream id cause PROTOCOL_ERROR
Key: TS-3480
URL: https://issues.apache.org/jira/browse/TS-3480
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Masakazu Kitajo
Assignee: Ryo Okubo
Fix For: 6.0.0
Attachments: ts-3480.diff
TS sends back a GOAWAY frame with PROTOCOL_ERROR if the stream id in a
request is over the value of SETTINGS_MAX_CONCURRENT_STREAMS.
This is because current implementation uses the value of the setting as the
maximum value for stream id, but not the maximum number of concurrent streams.
https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;a=blob;f=proxy/http2/Http2ConnectionState.cc;h=574c4ce5cf8303476ca3c7440ac6e0038477a933;hb=26f438d486eaa04267db953d8d5f1249a63af2c3#l712
How to reproduce:
{noformat}
nghttp -v -m 51 http://localhost/
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (TS-3480) Large stream id cause PROTOCOL_ERROR
[
https://issues.apache.org/jira/browse/TS-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481411#comment-14481411
]
Phil Sorber edited comment on TS-3480 at 4/6/15 4:51 PM:
-
Is any work being done on this? I'd like to roll an RC1 for 5.3.0 but I will
wait if this can make it in.
was (Author: psudaemon):
Is any work being done on this? I'd like to roll and RC1 for 5.3.0 but I will
wait if this can make it in.
Large stream id cause PROTOCOL_ERROR
Key: TS-3480
URL: https://issues.apache.org/jira/browse/TS-3480
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Masakazu Kitajo
Assignee: Ryo Okubo
Fix For: 6.0.0
TS sends back a GOAWAY frame with PROTOCOL_ERROR if the stream id in a
request is over the value of SETTINGS_MAX_CONCURRENT_STREAMS.
This is because current implementation uses the value of the setting as the
maximum value for stream id, but not the maximum number of concurrent streams.
https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;a=blob;f=proxy/http2/Http2ConnectionState.cc;h=574c4ce5cf8303476ca3c7440ac6e0038477a933;hb=26f438d486eaa04267db953d8d5f1249a63af2c3#l712
How to reproduce:
{noformat}
nghttp -v -m 51 http://localhost/
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
