[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518174#comment-14518174 ] Alan M. Carroll commented on TS-1015: - Yes. We had a long discussion about this on IRC earlier in the week and that was the concensus. I strongly support option 2. Each event would be marked with the enum value name, a descriptive string, and an internal flag. The internal flag would indicate the enum would go only in events.h and not apievents.h. Note the generator would have to account for this - it is *absolutely* required that enum values between the two definitions are identical. > TSEvent is widely declared as int > - > > Key: TS-1015 > URL: https://issues.apache.org/jira/browse/TS-1015 > Project: Traffic Server > Issue Type: Bug > Components: Cleanup >Reporter: Nick Kew >Assignee: Meera Mosale Nataraja >Priority: Minor > Labels: api-change, newbie > Fix For: 6.0.0 > > Attachments: TS-1015-2.diff, TS-1015.diff > > > TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is > declared as type int. This makes it harder to follow/debug using tools like > *trace or gdb. > This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515009#comment-14515009 ] Leif Hedstrom commented on TS-1015: --- I should say, if the choice is either between 1) Do nothing or 2) Have one formatted text file and a perl script that generates apievents.h and events.h (where the former is a subset of the latter) then I'm definitely in favor of #2. > TSEvent is widely declared as int > - > > Key: TS-1015 > URL: https://issues.apache.org/jira/browse/TS-1015 > Project: Traffic Server > Issue Type: Bug > Components: Cleanup >Reporter: Nick Kew >Assignee: Meera Mosale Nataraja >Priority: Minor > Labels: api-change, newbie > Fix For: 6.0.0 > > Attachments: TS-1015-2.diff, TS-1015.diff > > > TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is > declared as type int. This makes it harder to follow/debug using tools like > *trace or gdb. > This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514977#comment-14514977 ] Meera Mosale Nataraja commented on TS-1015: --- [~amc] Hello Alan, There are events in different places, some are enums and others are just #define. Please let me know how you would want to consolidate them. Meera. > TSEvent is widely declared as int > - > > Key: TS-1015 > URL: https://issues.apache.org/jira/browse/TS-1015 > Project: Traffic Server > Issue Type: Bug > Components: Cleanup >Reporter: Nick Kew >Assignee: Meera Mosale Nataraja >Priority: Minor > Labels: api-change, newbie > Fix For: 6.0.0 > > Attachments: TS-1015-2.diff, TS-1015.diff > > > TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is > declared as type int. This makes it harder to follow/debug using tools like > *trace or gdb. > This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514935#comment-14514935 ] Leif Hedstrom commented on TS-1015: --- [~jamespeach] Would you mind elaborate on this a bit? Is this really a big concern? It's not like the APIs can do anything nasty with the knowledge of internal events. Having everything unified into one enum type has some major advantages. [~amc] had some ideas around auto-generating two include files, one internal and one external, from a formatted text file. That would addressed your concerns, but I'm personally on the fence if it's worth this sort of complexity. > TSEvent is widely declared as int > - > > Key: TS-1015 > URL: https://issues.apache.org/jira/browse/TS-1015 > Project: Traffic Server > Issue Type: Bug > Components: Cleanup >Reporter: Nick Kew >Assignee: Meera Mosale Nataraja >Priority: Minor > Labels: api-change, newbie > Fix For: 6.0.0 > > Attachments: TS-1015-2.diff, TS-1015.diff > > > TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is > declared as type int. This makes it harder to follow/debug using tools like > *trace or gdb. > This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[
https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382377#comment-14382377
]
James Peach commented on TS-1015:
-
I don't think that putting all the event codes used by ATS into {{apidefs.h}}
is appropriate. This is a public API header and most of the event codes are
internal and should not be exposed to plugins.
> TSEvent is widely declared as int
> -
>
> Key: TS-1015
> URL: https://issues.apache.org/jira/browse/TS-1015
> Project: Traffic Server
> Issue Type: Bug
> Components: Cleanup
>Reporter: Nick Kew
>Assignee: Meera Mosale Nataraja
>Priority: Minor
> Labels: api-change, newbie
> Fix For: 6.0.0
>
> Attachments: TS-1015-2.diff, TS-1015.diff
>
>
> TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is
> declared as type int. This makes it harder to follow/debug using tools like
> *trace or gdb.
> This may usefully be fixed as and when people encounter instances of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382354#comment-14382354 ] Meera Mosale Nataraja commented on TS-1015: --- bwahn: Thanks for providing diffs. I am consolidating all events into lib/ts/apidefs.h. I will pass the diff in next few days. I just wanted to let you know what I am planning to do. There are at least 4 type of events and consolidating them to lib/ts/apidefs.h: Mgmt events under mgmt/api/include/mgmtapi.h and mgmt/BaseManager.h AIO events under iocore/eventsystem/I_Event.h Cache related events under iocore/cache/I_CacheDefs.h TSEvent for continuation is defined under lib/ts/apidefs.h VC events in iocore/eventsystem/I_VConnection.h > TSEvent is widely declared as int > - > > Key: TS-1015 > URL: https://issues.apache.org/jira/browse/TS-1015 > Project: Traffic Server > Issue Type: Bug > Components: Cleanup >Reporter: Nick Kew >Assignee: Meera Mosale Nataraja >Priority: Minor > Labels: api-change, newbie > Fix For: 6.0.0 > > Attachments: TS-1015-2.diff, TS-1015.diff > > > TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is > declared as type int. This makes it harder to follow/debug using tools like > *trace or gdb. > This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376146#comment-14376146 ] bwahn commented on TS-1015: --- Add TS-1015-2.diff. Please review diff file. > TSEvent is widely declared as int > - > > Key: TS-1015 > URL: https://issues.apache.org/jira/browse/TS-1015 > Project: Traffic Server > Issue Type: Bug > Components: Cleanup >Reporter: Nick Kew >Assignee: Meera Mosale Nataraja >Priority: Minor > Labels: api-change, newbie > Fix For: 6.0.0 > > Attachments: TS-1015-2.diff, TS-1015.diff > > > TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is > declared as type int. This makes it harder to follow/debug using tools like > *trace or gdb. > This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376013#comment-14376013 ] bwahn commented on TS-1015: --- TSEvent defined lib/ts/apidefs.h > TSEvent is widely declared as int > - > > Key: TS-1015 > URL: https://issues.apache.org/jira/browse/TS-1015 > Project: Traffic Server > Issue Type: Bug > Components: Cleanup >Reporter: Nick Kew >Assignee: Meera Mosale Nataraja >Priority: Minor > Labels: api-change, newbie > Fix For: 6.0.0 > > > TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is > declared as type int. This makes it harder to follow/debug using tools like > *trace or gdb. > This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196562#comment-14196562 ] Leif Hedstrom commented on TS-1015: --- Meera: we're assigning this to you, I think this is a fairly easy bug to work on, and I can help you through it. > TSEvent is widely declared as int > - > > Key: TS-1015 > URL: https://issues.apache.org/jira/browse/TS-1015 > Project: Traffic Server > Issue Type: Bug > Components: Cleanup >Reporter: Nick Kew >Priority: Minor > Labels: api-change, newbie > Fix For: 5.3.0 > > > TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is > declared as type int. This makes it harder to follow/debug using tools like > *trace or gdb. > This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
