[jira] [Commented] (TS-1086) Returning 304 response to unconditional request
[ https://issues.apache.org/jira/browse/TS-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761893#comment-13761893 ] Mohamad Khateeb commented on TS-1086: - I have attached a patch for this issue . the problem was , when ATS fails to get the cache write lock it changes to proxy mode , so when the object is stale and ATS has already made a conditional get to the server , ATS now must remove the conditional request headers that have been added by it . the ATS just removes If-Modified-Since header from the request , but a conditional get made by ATS can also have If-None-Match header , if etag header is found in the cached response. The patch that I have attached is just checking if the If-None-Match header is added by ATS . If so remove it , if it's not in the original client request. Returning 304 response to unconditional request --- Key: TS-1086 URL: https://issues.apache.org/jira/browse/TS-1086 Project: Traffic Server Issue Type: Bug Components: HTTP Affects Versions: 3.0.1 Environment: Observed on Amazon/ec2 build, which is 3.0.1 on redhat-like linux. Reporter: Nick Kew Fix For: 4.2.0 Attachments: TS-1086.diff ab is reporting HTTP 304 responses to a small number of unconditional requests in a test run: GET /testfile.html HTTP/1.0^M Host: localhost^M User-Agent: ApacheBench/2.3^M Accept: */*^M ^M HTTP/1.0 304 Not Modified^M Date: Mon, 21 Nov 2011 14:23:48 GMT^M Server: ATS/3.0.1^M ETag: 5e24-24cd-4b23b69f6e89c^M Cache-Control: max-age=60^M Age: 2^M ^M I presume what's happening is that trafficserver is sending a conditional request with If-Modified-Since to the origin server, and then returning the origin's 304 response to the client's unconditional request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1086) Returning 304 response to unconditional request
[ https://issues.apache.org/jira/browse/TS-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761928#comment-13761928 ] Nick Kew commented on TS-1086: -- Mohamad, I'm not sure if it's the same as my original issue, but your diagnosis and patch make sense to me, and pass make test. Committing to trunk - thanks! Returning 304 response to unconditional request --- Key: TS-1086 URL: https://issues.apache.org/jira/browse/TS-1086 Project: Traffic Server Issue Type: Bug Components: HTTP Affects Versions: 3.0.1 Environment: Observed on Amazon/ec2 build, which is 3.0.1 on redhat-like linux. Reporter: Nick Kew Fix For: 4.2.0 Attachments: TS-1086.diff ab is reporting HTTP 304 responses to a small number of unconditional requests in a test run: GET /testfile.html HTTP/1.0^M Host: localhost^M User-Agent: ApacheBench/2.3^M Accept: */*^M ^M HTTP/1.0 304 Not Modified^M Date: Mon, 21 Nov 2011 14:23:48 GMT^M Server: ATS/3.0.1^M ETag: 5e24-24cd-4b23b69f6e89c^M Cache-Control: max-age=60^M Age: 2^M ^M I presume what's happening is that trafficserver is sending a conditional request with If-Modified-Since to the origin server, and then returning the origin's 304 response to the client's unconditional request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1086) Returning 304 response to unconditional request
[ https://issues.apache.org/jira/browse/TS-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761939#comment-13761939 ] ASF subversion and git services commented on TS-1086: - Commit e8672a8934f468a4bf3fd34b3d573c783a5398cf in branch refs/heads/master from [~n...@webthing.com] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e8672a8 ] TS-1086: Avoid returning 304 to an unconditional request. Diagnosis and patch by Mohamad Khateeb. Returning 304 response to unconditional request --- Key: TS-1086 URL: https://issues.apache.org/jira/browse/TS-1086 Project: Traffic Server Issue Type: Bug Components: HTTP Affects Versions: 3.0.1 Environment: Observed on Amazon/ec2 build, which is 3.0.1 on redhat-like linux. Reporter: Nick Kew Assignee: Nick Kew Fix For: 4.1.0 Attachments: TS-1086.diff ab is reporting HTTP 304 responses to a small number of unconditional requests in a test run: GET /testfile.html HTTP/1.0^M Host: localhost^M User-Agent: ApacheBench/2.3^M Accept: */*^M ^M HTTP/1.0 304 Not Modified^M Date: Mon, 21 Nov 2011 14:23:48 GMT^M Server: ATS/3.0.1^M ETag: 5e24-24cd-4b23b69f6e89c^M Cache-Control: max-age=60^M Age: 2^M ^M I presume what's happening is that trafficserver is sending a conditional request with If-Modified-Since to the origin server, and then returning the origin's 304 response to the client's unconditional request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1086) Returning 304 response to unconditional request
[ https://issues.apache.org/jira/browse/TS-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762612#comment-13762612 ] seri,Kim commented on TS-1086: -- After applying this patch, the problem disappeared. Thanks!! Returning 304 response to unconditional request --- Key: TS-1086 URL: https://issues.apache.org/jira/browse/TS-1086 Project: Traffic Server Issue Type: Bug Components: HTTP Affects Versions: 3.0.1 Environment: Observed on Amazon/ec2 build, which is 3.0.1 on redhat-like linux. Reporter: Nick Kew Assignee: Nick Kew Fix For: 4.1.0 Attachments: TS-1086.diff ab is reporting HTTP 304 responses to a small number of unconditional requests in a test run: GET /testfile.html HTTP/1.0^M Host: localhost^M User-Agent: ApacheBench/2.3^M Accept: */*^M ^M HTTP/1.0 304 Not Modified^M Date: Mon, 21 Nov 2011 14:23:48 GMT^M Server: ATS/3.0.1^M ETag: 5e24-24cd-4b23b69f6e89c^M Cache-Control: max-age=60^M Age: 2^M ^M I presume what's happening is that trafficserver is sending a conditional request with If-Modified-Since to the origin server, and then returning the origin's 304 response to the client's unconditional request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1086) Returning 304 response to unconditional request
[ https://issues.apache.org/jira/browse/TS-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762682#comment-13762682 ] Leif Hedstrom commented on TS-1086: --- Sounds like this bug can be marked Resolved, right? Once resolved, and we publish v4.1.0, it'll get moved to closed. Returning 304 response to unconditional request --- Key: TS-1086 URL: https://issues.apache.org/jira/browse/TS-1086 Project: Traffic Server Issue Type: Bug Components: HTTP Affects Versions: 3.0.1 Environment: Observed on Amazon/ec2 build, which is 3.0.1 on redhat-like linux. Reporter: Nick Kew Assignee: Nick Kew Fix For: 4.1.0 Attachments: TS-1086.diff ab is reporting HTTP 304 responses to a small number of unconditional requests in a test run: GET /testfile.html HTTP/1.0^M Host: localhost^M User-Agent: ApacheBench/2.3^M Accept: */*^M ^M HTTP/1.0 304 Not Modified^M Date: Mon, 21 Nov 2011 14:23:48 GMT^M Server: ATS/3.0.1^M ETag: 5e24-24cd-4b23b69f6e89c^M Cache-Control: max-age=60^M Age: 2^M ^M I presume what's happening is that trafficserver is sending a conditional request with If-Modified-Since to the origin server, and then returning the origin's 304 response to the client's unconditional request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1086) Returning 304 response to unconditional request
[ https://issues.apache.org/jira/browse/TS-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507508#comment-13507508 ] Rob Lyon commented on TS-1086: -- I am seeing the same issue. I am seeing it on about 5% of the requests. The bad response (TCP_REFRESH_HIT/304) appears to be paired with a correct response (TCP_REFRESH_HIT/200) in the same second. The Via header is confirming a unconditional request (simple): ApacheTrafficServer/3.2.0 [uScSsNf pNeN:t cCSi p sS]. Returning 304 response to unconditional request --- Key: TS-1086 URL: https://issues.apache.org/jira/browse/TS-1086 Project: Traffic Server Issue Type: Bug Components: HTTP Affects Versions: 3.0.1 Environment: Observed on Amazon/ec2 build, which is 3.0.1 on redhat-like linux. Reporter: Nick Kew Fix For: 3.3.1 ab is reporting HTTP 304 responses to a small number of unconditional requests in a test run: GET /testfile.html HTTP/1.0^M Host: localhost^M User-Agent: ApacheBench/2.3^M Accept: */*^M ^M HTTP/1.0 304 Not Modified^M Date: Mon, 21 Nov 2011 14:23:48 GMT^M Server: ATS/3.0.1^M ETag: 5e24-24cd-4b23b69f6e89c^M Cache-Control: max-age=60^M Age: 2^M ^M I presume what's happening is that trafficserver is sending a conditional request with If-Modified-Since to the origin server, and then returning the origin's 304 response to the client's unconditional request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
