[jira] [Commented] (TS-1109) stack dump may crash too

[weijin (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217056#comment-13217056
 ] 

weijin commented on TS-1109:


By disassembly ink_restore_signal_handler_frame， I found it was not the base 
frame address but the function args stored in %rbp in release mode. The 
embedded assembly codes of getting base frame address is dangerous and have 
poor portability, so I remove them from the sources.

 stack dump may crash too
 

 Key: TS-1109
 URL: https://issues.apache.org/jira/browse/TS-1109
 Project: Traffic Server
  Issue Type: Bug
  Components: Core
Affects Versions: 3.1.2
Reporter: Zhao Yongming
Assignee: weijin
  Labels: crash
 Fix For: 3.1.4


 the codes doing stack dump may crash, in this case you will not able to get a 
 core file, that will hide most of the rare issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-1109) stack dump may crash too

[weijin (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217059#comment-13217059
 ] 

weijin commented on TS-1109:


Breakpoint 1, ink_stack_trace_get (stack=0x7fffb4d0, len=100, 
signalhandler_frame=2) at ink_stack_trace.cc:85
85  {
(gdb) n
87if ((btl = backtrace(stack, len))  0) {
(gdb) 
88  if (signalhandler_frame)
(gdb) 
89ink_restore_signal_handler_frame(stack, btl, signalhandler_frame 
+ 1);
(gdb) s
ink_restore_signal_handler_frame (stack=0x7fffb4d0, len=value optimized 
out, signalhandler_frame=2) at ink_stack_trace.cc:63
63asm volatile (mov %%rbp,%0:=r (fp));
(gdb) info reg rbp
rbp0x2  0x2
(gdb) n
67for (i = 0; i  signalhandler_frame; i++)
(gdb) 
68  fp = (void **) (*fp);
(gdb) 

Program received signal SIGSEGV, Segmentation fault.


 stack dump may crash too
 

 Key: TS-1109
 URL: https://issues.apache.org/jira/browse/TS-1109
 Project: Traffic Server
  Issue Type: Bug
  Components: Core
Affects Versions: 3.1.2
Reporter: Zhao Yongming
Assignee: weijin
  Labels: crash
 Fix For: 3.1.4


 the codes doing stack dump may crash, in this case you will not able to get a 
 core file, that will hide most of the rare issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira