[jira] [Commented] (TS-1257) Replace Tcl_Hash* with lib/ts/Map
[
https://issues.apache.org/jira/browse/TS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637853#comment-15637853
]
Leif Hedstrom commented on TS-1257:
---
My main concern is that goes against what we have said we want to do. That's
how we ended up in the mess that is IpAllow, where it's using STL containers
for absolutely no good reason whatsoever. It's easier to consistently say no to
STL on the critical path, than making exceptions.
> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have
> already discussed looking into removing the old Tcl cruft by replacing it
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be
> discussed/decided/evaluated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-1257) Replace Tcl_Hash* with lib/ts/Map
[
https://issues.apache.org/jira/browse/TS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636812#comment-15636812
]
Alan M. Carroll commented on TS-1257:
-
I looked at this some more. Unfortunately I haven't spent the time needed to
polish {{TSHashTable}}. Looking at the TCL hash table implementation I don't
see why {{std::unordered_map}} would be any worse and it would definitely have
a much better API and remove the TCL dependency. I understand the concerns with
common use of that but we already have common use of TCL hash with the same
negative effects.
> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>
> We have our own implementation of maps that we use in most new code. We have
> already discussed looking into removing the old Tcl cruft by replacing it
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be
> discussed/decided/evaluated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-1257) Replace Tcl_Hash* with lib/ts/Map
[
https://issues.apache.org/jira/browse/TS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626145#comment-15626145
]
Syeda Persia Aziz commented on TS-1257:
---
>From the description of this issue, we need to decide whether we want to
>replace the underlying implementation of InkHashTable or we want to replace it
>totally by Map. Is this still under discussion? [~amc] [~zwoop] [~i.galic]
> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>
> We have our own implementation of maps that we use in most new code. We have
> already discussed looking into removing the old Tcl cruft by replacing it
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be
> discussed/decided/evaluated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-1257) Replace Tcl_Hash* with lib/ts/Map
[
https://issues.apache.org/jira/browse/TS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196886#comment-14196886
]
Alan M. Carroll commented on TS-1257:
-
At this point I think we should use TSHashTable as the replacement.
> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Phil Sorber
> Fix For: sometime
>
>
> We have our own implementation of maps that we use in most new code. We have
> already discussed looking into removing the old Tcl cruft by replacing it
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be
> discussed/decided/evaluated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
