[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2014-05-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004121#comment-14004121
 ] 

ASF subversion and git services commented on TS-1411:
-

Commit a435e788234315f94016a3f490a09773e781d9fb in trafficserver's branch 
refs/heads/master from [~stc]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a435e78 ]

TS-1411: Seg fault when using %cquuc


 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Bryan Call
Priority: Critical
  Labels: Crash
 Fix For: 5.0.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt, cquuc 
 segfault patch.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(LogAccess::marshal_mem(char*, char const*, int, 
 int)+0x48)[0x58a118]
 /home/y/bin/traffic_server(LogAccessHttp::marshal_client_req_url_canon(char*)+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(LogFieldList::marshal(LogAccess*, 
 char*)+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(LogObject::log(LogAccess*, char*)+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(Log::access(LogAccess*)+0x146)[0x58f506]
 /home/y/bin/traffic_server(HttpSM::update_stats()+0x630)[0x526c50]
 /home/y/bin/traffic_server(HttpSM::kill_this()+0x928)[0x52b548]
 /home/y/bin/traffic_server(HttpSM::main_handler(int, void*)+0x198)[0x52b868]
 /home/y/bin/traffic_server(HttpTunnel::main_handler(int, 
 void*)+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(write_to_net_io(NetHandler*, UnixNetVConnection*, 
 EThread*)+0x847)[0x6756e7]
 /home/y/bin/traffic_server(NetHandler::mainNetEvent(int, 
 Event*)+0x286)[0x66e076]
 /home/y/bin/traffic_server(EThread::process_event(Event*, int)+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(EThread::execute()+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2014-05-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004122#comment-14004122
 ] 

ASF subversion and git services commented on TS-1411:
-

Commit a77a5e4a8b28dc0f4dcae6c7620f6f13a7d93763 in trafficserver's branch 
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a77a5e4 ]

Added TS-1411 to changes


 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Bryan Call
Priority: Critical
  Labels: Crash
 Fix For: 5.0.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt, cquuc 
 segfault patch.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(LogAccess::marshal_mem(char*, char const*, int, 
 int)+0x48)[0x58a118]
 /home/y/bin/traffic_server(LogAccessHttp::marshal_client_req_url_canon(char*)+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(LogFieldList::marshal(LogAccess*, 
 char*)+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(LogObject::log(LogAccess*, char*)+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(Log::access(LogAccess*)+0x146)[0x58f506]
 /home/y/bin/traffic_server(HttpSM::update_stats()+0x630)[0x526c50]
 /home/y/bin/traffic_server(HttpSM::kill_this()+0x928)[0x52b548]
 /home/y/bin/traffic_server(HttpSM::main_handler(int, void*)+0x198)[0x52b868]
 /home/y/bin/traffic_server(HttpTunnel::main_handler(int, 
 void*)+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(write_to_net_io(NetHandler*, UnixNetVConnection*, 
 EThread*)+0x847)[0x6756e7]
 /home/y/bin/traffic_server(NetHandler::mainNetEvent(int, 
 Event*)+0x286)[0x66e076]
 /home/y/bin/traffic_server(EThread::process_event(Event*, int)+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(EThread::execute()+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-12-05 Thread David Carlin (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840894#comment-13840894
 ] 

David Carlin commented on TS-1411:
--

The following patch written by Sean Cosgrave stabilizes the issue.  He made a 
point of saying its a band-aid and not a permanent fix however.

{noformat}
--- trafficserver-4.0.2/proxy/logging/LogAccessHttp.cc  2013-10-07 
22:02:04.0 +
+++ trafficserver-4.0.2_mod/proxy/logging/LogAccessHttp.cc  2013-11-04 
21:27:09.547218218 +
@@ -91,7 +91,9 @@

   if (hdr-client_request.valid()) {
 m_client_request = (hdr-client_request);
-m_client_req_url_str = 
m_client_request-url_string_get_ref(m_client_req_url_len);
+char *url_string_ref = 
m_client_request-url_string_get_ref(m_client_req_url_len);
+m_client_req_url_str = (char *) m_arena.str_alloc(m_client_req_url_len + 
1);
+ink_strlcpy(m_client_req_url_str, url_string_ref, (m_client_req_url_len + 
1));
 m_client_req_url_canon_str = LogUtils::escapify_url(m_arena, 
m_client_req_url_str, m_client_req_url_len,
 
m_client_req_url_canon_len);
 m_client_req_url_path_str = 
m_client_request-path_get(m_client_req_url_path_len);
{noformat}

 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Yunkai Zhang
Priority: Critical
 Fix For: 4.2.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(LogAccess::marshal_mem(char*, char const*, int, 
 int)+0x48)[0x58a118]
 /home/y/bin/traffic_server(LogAccessHttp::marshal_client_req_url_canon(char*)+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(LogFieldList::marshal(LogAccess*, 
 char*)+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(LogObject::log(LogAccess*, char*)+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(Log::access(LogAccess*)+0x146)[0x58f506]
 /home/y/bin/traffic_server(HttpSM::update_stats()+0x630)[0x526c50]
 /home/y/bin/traffic_server(HttpSM::kill_this()+0x928)[0x52b548]
 /home/y/bin/traffic_server(HttpSM::main_handler(int, void*)+0x198)[0x52b868]
 /home/y/bin/traffic_server(HttpTunnel::main_handler(int, 
 void*)+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(write_to_net_io(NetHandler*, UnixNetVConnection*, 
 EThread*)+0x847)[0x6756e7]
 /home/y/bin/traffic_server(NetHandler::mainNetEvent(int, 
 Event*)+0x286)[0x66e076]
 

[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-10-30 Thread Sean Cosgrave (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809715#comment-13809715
 ] 

Sean Cosgrave commented on TS-1411:
---

I think the fix from TS-1635 might resolve this issue.

 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Yunkai Zhang
Priority: Critical
 Fix For: 5.0.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(_ZN9LogAccess11marshal_memEPcPKcii+0x48)[0x58a118]
 /home/y/bin/traffic_server(_ZN13LogAccessHttp28marshal_client_req_url_canonEPc+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(_ZN12LogFieldList7marshalEP9LogAccessPc+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(_ZN9LogObject3logEP9LogAccessPc+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(_ZN3Log6accessEP9LogAccess+0x146)[0x58f506]
 /home/y/bin/traffic_server(_ZN6HttpSM12update_statsEv+0x630)[0x526c50]
 /home/y/bin/traffic_server(_ZN6HttpSM9kill_thisEv+0x928)[0x52b548]
 /home/y/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x198)[0x52b868]
 /home/y/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0x847)[0x6756e7]
 /home/y/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x286)[0x66e076]
 /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-10-30 Thread Leif Hedstrom (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809721#comment-13809721
 ] 

Leif Hedstrom commented on TS-1411:
---

[~stc]Sweet, should we close this as a dupe of TS-1635?

 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Yunkai Zhang
Priority: Critical
 Fix For: 4.1.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(_ZN9LogAccess11marshal_memEPcPKcii+0x48)[0x58a118]
 /home/y/bin/traffic_server(_ZN13LogAccessHttp28marshal_client_req_url_canonEPc+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(_ZN12LogFieldList7marshalEP9LogAccessPc+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(_ZN9LogObject3logEP9LogAccessPc+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(_ZN3Log6accessEP9LogAccess+0x146)[0x58f506]
 /home/y/bin/traffic_server(_ZN6HttpSM12update_statsEv+0x630)[0x526c50]
 /home/y/bin/traffic_server(_ZN6HttpSM9kill_thisEv+0x928)[0x52b548]
 /home/y/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x198)[0x52b868]
 /home/y/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0x847)[0x6756e7]
 /home/y/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x286)[0x66e076]
 /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-10-30 Thread Sean Cosgrave (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809727#comment-13809727
 ] 

Sean Cosgrave commented on TS-1411:
---

Waiting to see how it performs in production. We don't have a very reliable 
repro path.

 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Yunkai Zhang
Priority: Critical
 Fix For: 4.1.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(_ZN9LogAccess11marshal_memEPcPKcii+0x48)[0x58a118]
 /home/y/bin/traffic_server(_ZN13LogAccessHttp28marshal_client_req_url_canonEPc+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(_ZN12LogFieldList7marshalEP9LogAccessPc+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(_ZN9LogObject3logEP9LogAccessPc+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(_ZN3Log6accessEP9LogAccess+0x146)[0x58f506]
 /home/y/bin/traffic_server(_ZN6HttpSM12update_statsEv+0x630)[0x526c50]
 /home/y/bin/traffic_server(_ZN6HttpSM9kill_thisEv+0x928)[0x52b548]
 /home/y/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x198)[0x52b868]
 /home/y/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0x847)[0x6756e7]
 /home/y/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x286)[0x66e076]
 /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-10-30 Thread Sean Cosgrave (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809780#comment-13809780
 ] 

Sean Cosgrave commented on TS-1411:
---

Checked with David and he has been running ATS 4.0.2 for a couple days and is 
still seeing this crash. The fix to TS-1635 did not fix the issue we are having.

 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Yunkai Zhang
Priority: Critical
 Fix For: 4.1.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(_ZN9LogAccess11marshal_memEPcPKcii+0x48)[0x58a118]
 /home/y/bin/traffic_server(_ZN13LogAccessHttp28marshal_client_req_url_canonEPc+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(_ZN12LogFieldList7marshalEP9LogAccessPc+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(_ZN9LogObject3logEP9LogAccessPc+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(_ZN3Log6accessEP9LogAccess+0x146)[0x58f506]
 /home/y/bin/traffic_server(_ZN6HttpSM12update_statsEv+0x630)[0x526c50]
 /home/y/bin/traffic_server(_ZN6HttpSM9kill_thisEv+0x928)[0x52b548]
 /home/y/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x198)[0x52b868]
 /home/y/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0x847)[0x6756e7]
 /home/y/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x286)[0x66e076]
 /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-10-19 Thread Zhao Yongming (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799832#comment-13799832
 ] 

Zhao Yongming commented on TS-1411:
---

yeah, I mean TS-1988

 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Yunkai Zhang
Priority: Critical
 Fix For: 4.2.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(_ZN9LogAccess11marshal_memEPcPKcii+0x48)[0x58a118]
 /home/y/bin/traffic_server(_ZN13LogAccessHttp28marshal_client_req_url_canonEPc+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(_ZN12LogFieldList7marshalEP9LogAccessPc+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(_ZN9LogObject3logEP9LogAccessPc+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(_ZN3Log6accessEP9LogAccess+0x146)[0x58f506]
 /home/y/bin/traffic_server(_ZN6HttpSM12update_statsEv+0x630)[0x526c50]
 /home/y/bin/traffic_server(_ZN6HttpSM9kill_thisEv+0x928)[0x52b548]
 /home/y/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x198)[0x52b868]
 /home/y/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0x847)[0x6756e7]
 /home/y/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x286)[0x66e076]
 /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-10-18 Thread David Carlin (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799129#comment-13799129
 ] 

David Carlin commented on TS-1411:
--

The source of the crash has been narrowed down further; it only occurs when 
using custom logging with %cquuc field.  The addition of 
\%{User-Agent}cqh\ does not induce crashing.

 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Yunkai Zhang
Priority: Critical
 Fix For: 4.2.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(_ZN9LogAccess11marshal_memEPcPKcii+0x48)[0x58a118]
 /home/y/bin/traffic_server(_ZN13LogAccessHttp28marshal_client_req_url_canonEPc+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(_ZN12LogFieldList7marshalEP9LogAccessPc+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(_ZN9LogObject3logEP9LogAccessPc+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(_ZN3Log6accessEP9LogAccess+0x146)[0x58f506]
 /home/y/bin/traffic_server(_ZN6HttpSM12update_statsEv+0x630)[0x526c50]
 /home/y/bin/traffic_server(_ZN6HttpSM9kill_thisEv+0x928)[0x52b548]
 /home/y/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x198)[0x52b868]
 /home/y/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0x847)[0x6756e7]
 /home/y/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x286)[0x66e076]
 /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-10-18 Thread Zhao Yongming (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799137#comment-13799137
 ] 

Zhao Yongming commented on TS-1411:
---

is this issue still valid after Leif fixed TS-2216 on master?

 Seg fault when using %cquuc
 -

 Key: TS-1411
 URL: https://issues.apache.org/jira/browse/TS-1411
 Project: Traffic Server
  Issue Type: Bug
  Components: Logging
Affects Versions: 3.2.0
 Environment: RHEL 6.2 x86_64
Reporter: David Carlin
Assignee: Yunkai Zhang
Priority: Critical
 Fix For: 4.2.0

 Attachments: Log rotation segaults.txt, TS-1411 backtraces.txt


 I've been experiencing some segfaults during log rotation.  The sequence of 
 events is this.. log rotation occurs, then I get hundreds of dropping log 
 buffer error msgs, then the segfault.
 This started occurring when I lengthened the default log format to include 
 the unmapped URL and the user agent string:
 %cqtq %ttms %chi %crc/%pssc %psql %cqhm %cquc %caun 
 %phr/%pqsn %psct %xid %cquuc \%{User-Agent}cqh\
 In terms of frequency, we have a number of boxes and I probably see one of 
 these crashed per day since the above change.  Logs are rotated every 2 hours.
 I've had other log related segfaults, reported in TS-1330 - these new ones 
 seem to have a different cause.
 [Aug 14 21:07:20.002] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/error.log_l30.ycs.a4e.yahoo.com.20120814.17h59m50s-20120814.20h00m00s.old,
  was auto-deleted; 3148252 bytes were reclaimed.
 [Aug 14 21:07:42.859] Server {0x2ae3a8887700} STATUS: The rolled logfile, 
 /home/y/logs/trafficserver/squid.blog_l30.ycs.a4e.yahoo.com.20120814.18h00m00s-20120814.20h00m00s.old,
  was auto-deleted; 14735520048 bytes were reclaimed.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.865] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [...]
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 [Aug 14 21:07:42.876] Server {0x2ae3a8887700} WARNING: Dropping log buffer, 
 can't keep up.
 NOTE: Traffic Server received Sig 11: Segmentation fault
 /home/y/bin/traffic_server - STACK TRACE: 
 /lib64/libpthread.so.0[0x383f00f500]
 /home/y/bin/traffic_server(_ZN9LogAccess11marshal_memEPcPKcii+0x48)[0x58a118]
 /home/y/bin/traffic_server(_ZN13LogAccessHttp28marshal_client_req_url_canonEPc+0x20)[0x58c3f0]
 /home/y/bin/traffic_server(_ZN12LogFieldList7marshalEP9LogAccessPc+0x32)[0x59d5a2]
 /home/y/bin/traffic_server(_ZN9LogObject3logEP9LogAccessPc+0x399)[0x5a7ed9]
 /home/y/bin/traffic_server(_ZN3Log6accessEP9LogAccess+0x146)[0x58f506]
 /home/y/bin/traffic_server(_ZN6HttpSM12update_statsEv+0x630)[0x526c50]
 /home/y/bin/traffic_server(_ZN6HttpSM9kill_thisEv+0x928)[0x52b548]
 /home/y/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0x198)[0x52b868]
 /home/y/bin/traffic_server(_ZN10HttpTunnel12main_handlerEiPv+0xde)[0x56c3ee]
 /home/y/bin/traffic_server[0x673871]
 /home/y/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0x847)[0x6756e7]
 /home/y/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x286)[0x66e076]
 /home/y/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0xb4)[0x696ce4]
 /home/y/bin/traffic_server(_ZN7EThread7executeEv+0x4c3)[0x697673]
 /home/y/bin/traffic_server[0x695cb2]
 /lib64/libpthread.so.0[0x383f007851]



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (TS-1411) Seg fault when using %cquuc

2013-10-18 Thread Sean Cosgrave (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799249#comment-13799249
 ] 

Sean Cosgrave commented on TS-1411:
---

David, go ahead and try the changes from TS-1988, but I don't think they are 
going to resolve the underlying issue. 

In the crash stack trace we see that in the function 
marshal_client_req_url_canon() m_client_req_url_canon_str is pointing at a bad 
spot in memory. I have a idea on why m_client_req_url_canon_str might be bad, 
but I don't really know how it gets into this state. In the older version of TS 
that we used in the past we encountered a crash in 
LogAccessHttp::marshal_client_req_url() where m_client_req_url_str was pointing 
to bad memory. It was pointing to the wrong place in memory because it was 
equal to URL::m_ptr_printed_string, which was also was pointing to a bad spot 
in memory. The heap that URL::m_ptr_printed_string pointed to probably got 
coallesced, and the URL's pointer was not updated.

I think this bug is actually the same bug. I think 
LogAccessHttp::m_client_req_url_canon_str is pointing at a bad spot in memory 
because the heap where the string was stored was coallesced. In fact, I have 
seen (with some help from Bryan) that in this crash both 
LogAccessHttp::m_client_req_url_str (which points to the same memory as 
URL::m_ptr_printed_string) and LogAccessHttp::m_client_req_url_canon_str point 
to the same memory address:

{noformat}
(gdb) p (LogAccessHttp)*lad
$4 = {LogAccess = {_vptr.LogAccess = 0x6d2a10, initialized = false}, 
m_http_sm = 0x2ac8b337d2b0, m_arena = {m_blocks = 0x0}, m_client_request = 
0x2ac8b337d9a8,
  m_proxy_response = 0x2ac8b337d9e8, m_proxy_request = 0x0, m_server_response = 
0x0, m_cache_response = 0x2ac8b337dae8,
  m_client_req_url_str = 0x2ac7ac5af0bb Address 0x2ac7ac5af0bb out of bounds, 
m_client_req_url_len = 1968,
  m_client_req_url_canon_str = 0x2ac7ac5af0bb Address 0x2ac7ac5af0bb out of 
bounds, m_client_req_url_canon_len = 1968,
{noformat}

Here is how I think we get into this state:

1. m_client_req_url_str gets set to URL::m_ptr_printed_string, and 
m_client_req_url_canon_str gets set to m_client_req_url_str because 
LogUtils::escapify_url returns m_client_req_url_str when the URL does not have 
any characters that need to be escaped.

{noformat}
void
LogAccessHttp::init()
{
  HttpTransact::HeaderInfo * hdr = (m_http_sm-t_state.hdr_info);

  if (hdr-client_request.valid()) {
m_client_request = (hdr-client_request);
m_url = m_client_request-url_get();
if (m_url) {
  m_client_req_url_str = m_url-string_get_ref(m_client_req_url_len);
  m_client_req_url_canon_str = LogUtils::escapify_url(m_arena,
  m_client_req_url_str, 
  m_client_req_url_len, 
  
m_client_req_url_canon_len);
{noformat}

{noformat}
char *
LogUtils::escapify_url(Arena *arena, char *url, size_t len_in, int *len_out, 
char *dst, size_t dst_size, const unsigned char *map)
{
// skipping some lines.
  // Count specials in the url, assuming that there won't be any.
  //
  int count = 0;
  char *p = url;
  char *in_url_end = url + len_in;

  while (p  in_url_end) {
register unsigned char c = *p;
if (map[c / 8]  (1  (7 - c % 8))) {
  ++count;
}
++p;
  }

  if (!count) {
// The common case, no escapes, so just return the source string.
//
*len_out = len_in;
if (dst)
  ink_strlcpy(dst, url, dst_size);
return url;
  }
{noformat}

2. At some point after init() happens the HdrHeap::coalesce_str_heaps function 
gets called, and all the strings for the URL class get moved from the heap they 
were originally in into a new heap, and their pointers get updated, except for 
m_ptr_printed_string, and the pointers in the LogAccessHttp class.

{noformat}
void
URLImpl::move_strings(HdrStrHeap * new_heap)
{
  HDR_MOVE_STR(m_ptr_scheme, m_len_scheme);
  HDR_MOVE_STR(m_ptr_user, m_len_user);
  HDR_MOVE_STR(m_ptr_password, m_len_password);
  HDR_MOVE_STR(m_ptr_host, m_len_host);
  HDR_MOVE_STR(m_ptr_port, m_len_port);
  HDR_MOVE_STR(m_ptr_path, m_len_path);
  HDR_MOVE_STR(m_ptr_params, m_len_params);
  HDR_MOVE_STR(m_ptr_query, m_len_query);
  HDR_MOVE_STR(m_ptr_fragment, m_len_fragment);
//HDR_MOVE_STR(m_ptr_printed_string, m_len_printed_string);
}
{noformat}

3. We now have a crash when we try to access the 
LogAccessHttp::m_client_req_url_canon_str variable.

{noformat}
int
LogAccessHttp::marshal_client_req_url_canon(char *buf)
{
  int len = round_strlen(m_client_req_url_canon_len + 1);

  if (buf) {
// STC: m_client_req_url_canon_str is no good here :(
marshal_mem(buf, m_client_req_url_canon_str, m_client_req_url_canon_len, 
len);
  }
  return len;
}
{noformat}

I will continue to investigate how this happens and