[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922215#comment-13922215 ] Leif Hedstrom commented on TS-1453: --- Let me do another round of benchmarks, to make sure the latency issues are addressed. remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Labels: A, review Fix For: 5.2.0 Attachments: TS-1453.patch, TS-1453_v2.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703418#comment-13703418 ] Leif Hedstrom commented on TS-1453: --- Leaving this for v3.3.5 for now, with two caveats: 1) we get a response from Alibaba on John's comments from April 19 (possibly with a patch update) 2) some more benchmarks from other use cases. remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Labels: A Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672256#comment-13672256 ] Leif Hedstrom commented on TS-1453: --- Bin Chen: Any thoughts on John's comments? I'd like to land this for v3.3.3 if possible (and assuming it's safe from a performance perspective without the time wheel, which I think needs more work). remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.3 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636438#comment-13636438 ] Leif Hedstrom commented on TS-1453: --- If I understand you correctly, even without TS-1405, disabling InactivityCop is an improvement on performance / scalability? If so, great and +1. remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636444#comment-13636444 ] Leif Hedstrom commented on TS-1453: --- I'd probably also do what James suggested, eliminate the old code, and get rid of the INACTIVITY_TIMEOUT option. One thing I could *possible* see is to have a way to have both activated at any time, such that you run inactivity cop once every 60s or some such, to clean out potentially lost connection. I don't know if that can ever happen (but it did in the past). That's optional though, and can be a different bug / RFE. But if people think having such a feature is useful, then leave the old code, but change it to an #ifdef INACTIVITY_COP or some such (i.e. inverse the logic on the ifdef's). remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636624#comment-13636624 ] John Plevyak commented on TS-1453: -- Couple things: 1) the lock is always held over accesses to disabled so it doesn't need to be volatile 2) I would just change the callback_event to a new EVENT_DISABLED and handle it in NetVConnction::mainEvent. The reason is that this will isolate the changes to the net processor, and I think the interaction of the disabled flag with the timeouts is problematic: you are going to end up rescheduling the event as an immediate eventually which will cause a lot of busy processing. remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634992#comment-13634992 ] Bin Chen commented on TS-1453: -- John Leif, please help to review this patch(replace InActivCop), Thanks. remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635306#comment-13635306 ] James Peach commented on TS-1453: - volatile unsigned int disable should be bool, since it's only used with true and false values. Why is it required to be volatile? Is there any reason to keep the INACTIVITY_TIMEOUT definition? How does this behave with large numbers of client connections? remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635318#comment-13635318 ] Leif Hedstrom commented on TS-1453: --- I haven't reviewed this yet, but just two comments on this code base in general: 1) The reason why it is the way it is right now (two paths, one is disabled), is because it was thought that the event system could not handle the load. 2) Does this patch require the TS-1405 changes as well ? Meaning, without TS-1405, would we have a performance problem with the number of pending (future) events? remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635969#comment-13635969 ] Bin Chen commented on TS-1453: -- this patch can be not depending on TS-1405. In our env, ts should handle 200 thounds connections(InActiveCop should check every 1 second every conntions, It's so terrible). Now, we should improve cpu usage. The same box and same qps, our custom proxy use cpu about 60% of ts. remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.5 Attachments: TS-1453.patch when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1453) remove InactivityCop and enable define INACTIVITY_TIMEOUT
[ https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13612805#comment-13612805 ] Leif Hedstrom commented on TS-1453: --- Bin Chen: Are we aiming to get this in when you land the timewheel patch? If so, maybe we should schedule this for v3.3.0 ? remove InactivityCop and enable define INACTIVITY_TIMEOUT - Key: TS-1453 URL: https://issues.apache.org/jira/browse/TS-1453 Project: Traffic Server Issue Type: Sub-task Components: Core Affects Versions: 3.2.0 Reporter: Bin Chen Assignee: Bin Chen Fix For: 3.3.4 when we have O(1), then we can be enable define INACTIVITY_TIMEOUT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
