[jira] [Commented] (TS-1507) debug mode crash with bogus HTTP version
[ https://issues.apache.org/jira/browse/TS-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612821#comment-13612821 ] Leif Hedstrom commented on TS-1507: --- James: Are you going to work on it? Sounds like we ought to fix this sooner rather than later? > debug mode crash with bogus HTTP version > > > Key: TS-1507 > URL: https://issues.apache.org/jira/browse/TS-1507 > Project: Traffic Server > Issue Type: Bug > Components: HTTP >Reporter: James Peach >Priority: Minor > Labels: codenomicon, crash > Fix For: 3.3.4 > > > Codenomicon test case #424 > This test sends a HTTP request beginning with GET /424 HTTP/1.31122234\r\n. > If ATS is built in debug mode, it triggers the assertion in > http_hdr_version_to_string(). > FATAL: HTTP.cc:387: failed assert `HTTP_MINOR(version) < 10` > /opt/ats/bin/traffic_server - STACK TRACE: > 0 libtsutil.3.dylib 0x0001054f7af9 ink_fatal + 345 > 1 libtsutil.3.dylib 0x0001054f6a72 _ink_assert + 66 > 2 traffic_server 0x000104b6a21d > _ZL26http_hdr_version_to_stringiPc + 157 > 3 traffic_server 0x000104b6a4f4 > _Z14http_hdr_printP7HdrHeapP11HTTPHdrImplPciPiS4_ + 596 > 4 traffic_server 0x0001049f286d > _ZN7HTTPHdr5printEPciPiS1_ + 141 > 5 traffic_server 0x000104ad1c5f > _ZN12HttpTransact13HandleRequestEPNS_5StateE + 1679 > 6 traffic_server 0x000104aa9b30 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 144 > 7 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 8 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 9 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 10 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 11 traffic_server 0x000104ac2a47 > _ZN6HttpSM14set_next_stateEv + 455 > 12 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 13 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 14 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 15 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 16 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 17 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 18 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 19 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 20 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 21 traffic_server 0x000104aa98ee > _ZN6HttpSM32state_read_client_request_headerEiPv + 2638 > 22 traffic_server 0x000104aa7d11 > _ZN6HttpSM12main_handlerEiPv + 833 > This crash only happens in debug mode, but we should verify that the release > execution path is safe. The HTTP_MAJOR and HTTP_MINOR macros can result in > there being high ascii characters set in the char buffer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1507) debug mode crash with bogus HTTP version
[ https://issues.apache.org/jira/browse/TS-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618494#comment-13618494 ] Leif Hedstrom commented on TS-1507: --- Hmmm, I tried that exact string with current master, in debug mode, and it did not assert... > debug mode crash with bogus HTTP version > > > Key: TS-1507 > URL: https://issues.apache.org/jira/browse/TS-1507 > Project: Traffic Server > Issue Type: Bug > Components: HTTP >Reporter: James Peach >Priority: Minor > Labels: codenomicon, crash > Fix For: 3.3.2 > > > Codenomicon test case #424 > This test sends a HTTP request beginning with GET /424 HTTP/1.31122234\r\n. > If ATS is built in debug mode, it triggers the assertion in > http_hdr_version_to_string(). > FATAL: HTTP.cc:387: failed assert `HTTP_MINOR(version) < 10` > /opt/ats/bin/traffic_server - STACK TRACE: > 0 libtsutil.3.dylib 0x0001054f7af9 ink_fatal + 345 > 1 libtsutil.3.dylib 0x0001054f6a72 _ink_assert + 66 > 2 traffic_server 0x000104b6a21d > _ZL26http_hdr_version_to_stringiPc + 157 > 3 traffic_server 0x000104b6a4f4 > _Z14http_hdr_printP7HdrHeapP11HTTPHdrImplPciPiS4_ + 596 > 4 traffic_server 0x0001049f286d > _ZN7HTTPHdr5printEPciPiS1_ + 141 > 5 traffic_server 0x000104ad1c5f > _ZN12HttpTransact13HandleRequestEPNS_5StateE + 1679 > 6 traffic_server 0x000104aa9b30 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 144 > 7 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 8 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 9 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 10 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 11 traffic_server 0x000104ac2a47 > _ZN6HttpSM14set_next_stateEv + 455 > 12 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 13 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 14 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 15 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 16 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 17 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 18 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 19 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 20 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 21 traffic_server 0x000104aa98ee > _ZN6HttpSM32state_read_client_request_headerEiPv + 2638 > 22 traffic_server 0x000104aa7d11 > _ZN6HttpSM12main_handlerEiPv + 833 > This crash only happens in debug mode, but we should verify that the release > execution path is safe. The HTTP_MAJOR and HTTP_MINOR macros can result in > there being high ascii characters set in the char buffer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1507) debug mode crash with bogus HTTP version
[ https://issues.apache.org/jira/browse/TS-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648966#comment-13648966 ] Leif Hedstrom commented on TS-1507: --- I was unable to reproduce this, James? > debug mode crash with bogus HTTP version > > > Key: TS-1507 > URL: https://issues.apache.org/jira/browse/TS-1507 > Project: Traffic Server > Issue Type: Bug > Components: HTTP >Reporter: James Peach >Priority: Minor > Labels: A, codenomicon, crash > Fix For: 3.3.3 > > > Codenomicon test case #424 > This test sends a HTTP request beginning with GET /424 HTTP/1.31122234\r\n. > If ATS is built in debug mode, it triggers the assertion in > http_hdr_version_to_string(). > FATAL: HTTP.cc:387: failed assert `HTTP_MINOR(version) < 10` > /opt/ats/bin/traffic_server - STACK TRACE: > 0 libtsutil.3.dylib 0x0001054f7af9 ink_fatal + 345 > 1 libtsutil.3.dylib 0x0001054f6a72 _ink_assert + 66 > 2 traffic_server 0x000104b6a21d > _ZL26http_hdr_version_to_stringiPc + 157 > 3 traffic_server 0x000104b6a4f4 > _Z14http_hdr_printP7HdrHeapP11HTTPHdrImplPciPiS4_ + 596 > 4 traffic_server 0x0001049f286d > _ZN7HTTPHdr5printEPciPiS1_ + 141 > 5 traffic_server 0x000104ad1c5f > _ZN12HttpTransact13HandleRequestEPNS_5StateE + 1679 > 6 traffic_server 0x000104aa9b30 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 144 > 7 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 8 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 9 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 10 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 11 traffic_server 0x000104ac2a47 > _ZN6HttpSM14set_next_stateEv + 455 > 12 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 13 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 14 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 15 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 16 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 17 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 18 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 19 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 20 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 21 traffic_server 0x000104aa98ee > _ZN6HttpSM32state_read_client_request_headerEiPv + 2638 > 22 traffic_server 0x000104aa7d11 > _ZN6HttpSM12main_handlerEiPv + 833 > This crash only happens in debug mode, but we should verify that the release > execution path is safe. The HTTP_MAJOR and HTTP_MINOR macros can result in > there being high ascii characters set in the char buffer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1507) debug mode crash with bogus HTTP version
[ https://issues.apache.org/jira/browse/TS-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692018#comment-13692018 ] Leif Hedstrom commented on TS-1507: --- James: I still can't reproduce this, should we move this out to v3.5.0 ? > debug mode crash with bogus HTTP version > > > Key: TS-1507 > URL: https://issues.apache.org/jira/browse/TS-1507 > Project: Traffic Server > Issue Type: Bug > Components: HTTP >Reporter: James Peach >Priority: Minor > Labels: A, codenomicon, crash > Fix For: 3.3.5 > > > Codenomicon test case #424 > This test sends a HTTP request beginning with GET /424 HTTP/1.31122234\r\n. > If ATS is built in debug mode, it triggers the assertion in > http_hdr_version_to_string(). > FATAL: HTTP.cc:387: failed assert `HTTP_MINOR(version) < 10` > /opt/ats/bin/traffic_server - STACK TRACE: > 0 libtsutil.3.dylib 0x0001054f7af9 ink_fatal + 345 > 1 libtsutil.3.dylib 0x0001054f6a72 _ink_assert + 66 > 2 traffic_server 0x000104b6a21d > _ZL26http_hdr_version_to_stringiPc + 157 > 3 traffic_server 0x000104b6a4f4 > _Z14http_hdr_printP7HdrHeapP11HTTPHdrImplPciPiS4_ + 596 > 4 traffic_server 0x0001049f286d > _ZN7HTTPHdr5printEPciPiS1_ + 141 > 5 traffic_server 0x000104ad1c5f > _ZN12HttpTransact13HandleRequestEPNS_5StateE + 1679 > 6 traffic_server 0x000104aa9b30 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 144 > 7 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 8 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 9 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 10 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 11 traffic_server 0x000104ac2a47 > _ZN6HttpSM14set_next_stateEv + 455 > 12 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 13 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 14 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 15 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 16 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 17 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 18 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 19 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 20 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 21 traffic_server 0x000104aa98ee > _ZN6HttpSM32state_read_client_request_headerEiPv + 2638 > 22 traffic_server 0x000104aa7d11 > _ZN6HttpSM12main_handlerEiPv + 833 > This crash only happens in debug mode, but we should verify that the release > execution path is safe. The HTTP_MAJOR and HTTP_MINOR macros can result in > there being high ascii characters set in the char buffer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1507) debug mode crash with bogus HTTP version
[ https://issues.apache.org/jira/browse/TS-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693388#comment-13693388 ] James Peach commented on TS-1507: - yes > debug mode crash with bogus HTTP version > > > Key: TS-1507 > URL: https://issues.apache.org/jira/browse/TS-1507 > Project: Traffic Server > Issue Type: Bug > Components: HTTP >Reporter: James Peach >Priority: Minor > Labels: A, codenomicon, crash > Fix For: 3.3.5 > > > Codenomicon test case #424 > This test sends a HTTP request beginning with GET /424 HTTP/1.31122234\r\n. > If ATS is built in debug mode, it triggers the assertion in > http_hdr_version_to_string(). > FATAL: HTTP.cc:387: failed assert `HTTP_MINOR(version) < 10` > /opt/ats/bin/traffic_server - STACK TRACE: > 0 libtsutil.3.dylib 0x0001054f7af9 ink_fatal + 345 > 1 libtsutil.3.dylib 0x0001054f6a72 _ink_assert + 66 > 2 traffic_server 0x000104b6a21d > _ZL26http_hdr_version_to_stringiPc + 157 > 3 traffic_server 0x000104b6a4f4 > _Z14http_hdr_printP7HdrHeapP11HTTPHdrImplPciPiS4_ + 596 > 4 traffic_server 0x0001049f286d > _ZN7HTTPHdr5printEPciPiS1_ + 141 > 5 traffic_server 0x000104ad1c5f > _ZN12HttpTransact13HandleRequestEPNS_5StateE + 1679 > 6 traffic_server 0x000104aa9b30 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 144 > 7 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 8 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 9 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 10 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 11 traffic_server 0x000104ac2a47 > _ZN6HttpSM14set_next_stateEv + 455 > 12 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 13 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 14 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 15 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 16 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 17 traffic_server 0x000104aae186 > _ZN6HttpSM17handle_api_returnEv + 326 > 18 traffic_server 0x000104ac578f > _ZN6HttpSM14do_api_calloutEv + 63 > 19 traffic_server 0x000104ac28f0 > _ZN6HttpSM14set_next_stateEv + 112 > 20 traffic_server 0x000104aa9ca1 > _ZN6HttpSM32call_transact_and_set_next_stateEPFvPN12HttpTransact5StateEE + 513 > 21 traffic_server 0x000104aa98ee > _ZN6HttpSM32state_read_client_request_headerEiPv + 2638 > 22 traffic_server 0x000104aa7d11 > _ZN6HttpSM12main_handlerEiPv + 833 > This crash only happens in debug mode, but we should verify that the release > execution path is safe. The HTTP_MAJOR and HTTP_MINOR macros can result in > there being high ascii characters set in the char buffer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira