[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097298#comment-15097298 ] Kit Chan commented on TS-1611: -- this is done in 04/2015. forgot to close it. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: 6.0.0 > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347667#comment-14347667 ] Leif Hedstrom commented on TS-1611: --- Kit, is this something that you or anyone will work on? > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347822#comment-14347822 ] Kit Chan commented on TS-1611: -- [~portl4t] and I have talked about this and he said he is working on this feature. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348039#comment-14348039 ] portl4t commented on TS-1611: - Yeah, I'm doing this job these days, there will be some results come out this month. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375275#comment-14375275 ] Kit Chan commented on TS-1611: -- thanks for the patch. I will review it in these couple days. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384598#comment-14384598 ] Kit Chan commented on TS-1611: -- 1) Should we use TSError instead of ee() for reporting error? 2) Am I correct that there is no backward incompatibility? There are additional API such as fetch and fetch_multi. And then there are enhancements to existing api (transform/intercept). But those enhancements are backward compatible. Right? 3) Are all the fetch api blocking? Of course I have to wait for the response to come back before the next lua line is executed. But during the wait, do we no longer hold onto the thread so it can go and execute other stuff? 4) The fetch api (essesntialy using TSFetch* TS apis) does not seem to support streaming mode. Do you think it is necessary to support that or not? I have compiled and run your test example lua scripts. I also run my own application for a short while without problem. I think if we clarify the questions I have above, it should be good to be merged. Only stuff I need to do is just to run it through clang-format before committing. Thanks > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384623#comment-14384623 ] Kit Chan commented on TS-1611: -- [~portl4t] pls take a look at my comment. Thanks. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385008#comment-14385008 ] portl4t commented on TS-1611: - 1. Well, I think it is ok to use TSError instead of ee, although I prefer to record error message in traffic.out with ee. 2. There is no backward incompatibility, old scripts also work. 3. ts.fetch is definitely non-block, it will invoke lua_yield to release cpu after launching the FetchSM, and will excute the next lua line with lua_resume after FetchSM finished. ts.sleep uses the same mechanism. 4. Streaming mode is hard to display in the script, I am working on ts.cache_read these days, which has the same problem. I think we can implement streaming mode with an option if it is necessary. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388214#comment-14388214 ] ASF subversion and git services commented on TS-1611: - Commit 68b4d8536570167ae1bb8eb812b26aa55c620d08 in trafficserver's branch refs/heads/master from [~portl4t] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=68b4d85 ] TS-1611: Async request support in lua plugin > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388220#comment-14388220 ] Kit Chan commented on TS-1611: -- Things I just did 1) merge all patches from portl4t 2) run clang-format and fix other styling stuff Things I still have to do. (Will get to that after build is successful + some more tests) 1) Change to use TSError() instead of ee() > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388264#comment-14388264 ] portl4t commented on TS-1611: - Awesome > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389723#comment-14389723 ] Kit Chan commented on TS-1611: -- coverity reports some problem. I will be looking into it. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390191#comment-14390191 ] ASF subversion and git services commented on TS-1611: - Commit 0b3fac4a3f291a2b88dc2b7934a61d3e834c53eb in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0b3fac4 ] TS-1611: fix coverity scan defects and use TSError instead of fprintf to stderr > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493503#comment-14493503 ] Kit Chan commented on TS-1611: -- [~portl4t] Hi, we missed putting license info on these two files. would you please take a look? ts_lua_io.c ts_lua_io.h Thanks. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493526#comment-14493526 ] portl4t commented on TS-1611: - Yeah, your're right. I'm fixing it. By the way, I have finished ts.cache_xxx on github, should we create another issue to handle it ? > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493530#comment-14493530 ] Leif Hedstrom commented on TS-1611: --- I think it's fine to commit the fix against this Jira. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493561#comment-14493561 ] portl4t commented on TS-1611: - Agree with Leif. [~kichan], I think you can commit the fix directly as you have the rights. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493593#comment-14493593 ] ASF subversion and git services commented on TS-1611: - Commit c20098393fc91cc5c3557e2ab9aae7151053f411 in trafficserver's branch refs/heads/master from [~kichan] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c200983 ] TS-1611: Add missing license info > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493594#comment-14493594 ] Kit Chan commented on TS-1611: -- just added. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1611) async http request in lua remap plugin
[ https://issues.apache.org/jira/browse/TS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493861#comment-14493861 ] Luca Rea commented on TS-1611: -- Hello, I'm really glad to see progress on this side. Thank you all. > async http request in lua remap plugin > -- > > Key: TS-1611 > URL: https://issues.apache.org/jira/browse/TS-1611 > Project: Traffic Server > Issue Type: Improvement > Components: Lua, Plugins >Reporter: Luca Rea >Assignee: Kit Chan > Fix For: sometime > > Attachments: > 0001-TS-1611-async-http-request-in-lua-remap-plugin.patch, > 0002-TS-1611-add-ts_lua_constant.c.patch, > 0003-TS-1611-refine-doc-for-ts_lua.patch > > > Hi, > can you add support for async http requests in lua remap plugin please? > Thank you -- This message was sent by Atlassian JIRA (v6.3.4#6332)
