subject:"\[jira\] \[Commented\] \(TS\-1698\) thread\/pthread mis\-match on Solaris 10"

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

2014-01-21 Thread James Peach (JIRA)


[ 
https://issues.apache.org/jira/browse/TS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878013#comment-13878013
 ] 

James Peach commented on TS-1698:
-

I think that we should close this out as WONTFIX.

> thread/pthread mis-match on Solaris 10
> --
>
> Key: TS-1698
> URL: https://issues.apache.org/jira/browse/TS-1698
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Igor Galić
>Assignee: Igor Galić
> Fix For: 5.0.0
>
> Attachments: ink_pthead.patch
>
>
> {noformat}
>   CXX  UnixEventProcessor.o
> UnixEventProcessor.cc: In member function 'virtual int 
> EventProcessor::start(int)':
> UnixEventProcessor.cc:186:7: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> UnixEventProcessor.cc:188:9: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> cc1plus: all warnings being treated as errors
> gmake[2]: *** [UnixEventProcessor.o] Error 1
> gmake[2]: Leaving directory 
> `/export/home/buildbot/slave5/tserver-solaris-trunk-debug/build/iocore/eventsystem'
> gmake[1]: *** [all-recursive] Error 1
> {noformat}
> This seems to be caused by our naïve code to distinguish between different 
> platforms:
> {code}
> #include "P_EventSystem.h"  /* MAGIC_EDITING_TAG */
> #include 
> #if TS_USE_HWLOC
> #if HAVE_HWLOC_H
> #include 
> #endif
> #if HAVE_SCHED_H
> #include 
> #if !defined(solaris) && !defined(freebsd)
> typedef cpu_set_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #endif
> #if HAVE_SYS_PARAM_H
> #include 
> #endif
> #if HAVE_SYS_CPUSET_H
> #include 
> typedef cpuset_t ink_cpuset_t;
> #define PTR_FMT "p"
> #endif
> #if HAVE_PTHREAD_NP_H
> #include 
> #endif
> #if HAVE_SYS_PSET_H
> #include 
> typedef psetid_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #if HAVE_SYS_TYPES_H
> #include 
> #endif
> #endif
> #include "ink_defs.h"
> #if TS_USE_HWLOC
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

2014-01-21 Thread JIRA


[ 
https://issues.apache.org/jira/browse/TS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877870#comment-13877870
 ] 

Igor Galić commented on TS-1698:


I haven't had time to look at Solaris 10 in quite some time now :\

> thread/pthread mis-match on Solaris 10
> --
>
> Key: TS-1698
> URL: https://issues.apache.org/jira/browse/TS-1698
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Igor Galić
>Assignee: Igor Galić
> Fix For: 5.0.0
>
> Attachments: ink_pthead.patch
>
>
> {noformat}
>   CXX  UnixEventProcessor.o
> UnixEventProcessor.cc: In member function 'virtual int 
> EventProcessor::start(int)':
> UnixEventProcessor.cc:186:7: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> UnixEventProcessor.cc:188:9: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> cc1plus: all warnings being treated as errors
> gmake[2]: *** [UnixEventProcessor.o] Error 1
> gmake[2]: Leaving directory 
> `/export/home/buildbot/slave5/tserver-solaris-trunk-debug/build/iocore/eventsystem'
> gmake[1]: *** [all-recursive] Error 1
> {noformat}
> This seems to be caused by our naïve code to distinguish between different 
> platforms:
> {code}
> #include "P_EventSystem.h"  /* MAGIC_EDITING_TAG */
> #include 
> #if TS_USE_HWLOC
> #if HAVE_HWLOC_H
> #include 
> #endif
> #if HAVE_SCHED_H
> #include 
> #if !defined(solaris) && !defined(freebsd)
> typedef cpu_set_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #endif
> #if HAVE_SYS_PARAM_H
> #include 
> #endif
> #if HAVE_SYS_CPUSET_H
> #include 
> typedef cpuset_t ink_cpuset_t;
> #define PTR_FMT "p"
> #endif
> #if HAVE_PTHREAD_NP_H
> #include 
> #endif
> #if HAVE_SYS_PSET_H
> #include 
> typedef psetid_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #if HAVE_SYS_TYPES_H
> #include 
> #endif
> #endif
> #include "ink_defs.h"
> #if TS_USE_HWLOC
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

2013-02-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/TS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575143#comment-13575143
 ] 

ASF subversion and git services commented on TS-1698:
-

Commit 012df52981084d3cd82d1e8aa87074683dd22594 in branch refs/heads/master 
from [~i.galic]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=012df52 ]

Revert "cleanup ink_thread.h for TS-1698"

This reverts commit 26c408071d6a559bfb30da8a67854a4e888cfb71.

thanks for jpeach for pointing out that this is rather silly.
If we really want to handle these cases, we need to check them
with autoconf.


> thread/pthread mis-match on Solaris 10
> --
>
> Key: TS-1698
> URL: https://issues.apache.org/jira/browse/TS-1698
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Igor Galić
> Attachments: ink_pthead.patch
>
>
> {noformat}
>   CXX  UnixEventProcessor.o
> UnixEventProcessor.cc: In member function 'virtual int 
> EventProcessor::start(int)':
> UnixEventProcessor.cc:186:7: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> UnixEventProcessor.cc:188:9: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> cc1plus: all warnings being treated as errors
> gmake[2]: *** [UnixEventProcessor.o] Error 1
> gmake[2]: Leaving directory 
> `/export/home/buildbot/slave5/tserver-solaris-trunk-debug/build/iocore/eventsystem'
> gmake[1]: *** [all-recursive] Error 1
> {noformat}
> This seems to be caused by our naïve code to distinguish between different 
> platforms:
> {code}
> #include "P_EventSystem.h"  /* MAGIC_EDITING_TAG */
> #include 
> #if TS_USE_HWLOC
> #if HAVE_HWLOC_H
> #include 
> #endif
> #if HAVE_SCHED_H
> #include 
> #if !defined(solaris) && !defined(freebsd)
> typedef cpu_set_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #endif
> #if HAVE_SYS_PARAM_H
> #include 
> #endif
> #if HAVE_SYS_CPUSET_H
> #include 
> typedef cpuset_t ink_cpuset_t;
> #define PTR_FMT "p"
> #endif
> #if HAVE_PTHREAD_NP_H
> #include 
> #endif
> #if HAVE_SYS_PSET_H
> #include 
> typedef psetid_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #if HAVE_SYS_TYPES_H
> #include 
> #endif
> #endif
> #include "ink_defs.h"
> #if TS_USE_HWLOC
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

2013-02-06 Thread JIRA


[ 
https://issues.apache.org/jira/browse/TS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572297#comment-13572297
 ] 

Igor Galić commented on TS-1698:


These comments out of order seem.

> thread/pthread mis-match on Solaris 10
> --
>
> Key: TS-1698
> URL: https://issues.apache.org/jira/browse/TS-1698
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Igor Galić
> Attachments: ink_pthead.patch
>
>
> {noformat}
>   CXX  UnixEventProcessor.o
> UnixEventProcessor.cc: In member function 'virtual int 
> EventProcessor::start(int)':
> UnixEventProcessor.cc:186:7: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> UnixEventProcessor.cc:188:9: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> cc1plus: all warnings being treated as errors
> gmake[2]: *** [UnixEventProcessor.o] Error 1
> gmake[2]: Leaving directory 
> `/export/home/buildbot/slave5/tserver-solaris-trunk-debug/build/iocore/eventsystem'
> gmake[1]: *** [all-recursive] Error 1
> {noformat}
> This seems to be caused by our naïve code to distinguish between different 
> platforms:
> {code}
> #include "P_EventSystem.h"  /* MAGIC_EDITING_TAG */
> #include 
> #if TS_USE_HWLOC
> #if HAVE_HWLOC_H
> #include 
> #endif
> #if HAVE_SCHED_H
> #include 
> #if !defined(solaris) && !defined(freebsd)
> typedef cpu_set_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #endif
> #if HAVE_SYS_PARAM_H
> #include 
> #endif
> #if HAVE_SYS_CPUSET_H
> #include 
> typedef cpuset_t ink_cpuset_t;
> #define PTR_FMT "p"
> #endif
> #if HAVE_PTHREAD_NP_H
> #include 
> #endif
> #if HAVE_SYS_PSET_H
> #include 
> typedef psetid_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #if HAVE_SYS_TYPES_H
> #include 
> #endif
> #endif
> #include "ink_defs.h"
> #if TS_USE_HWLOC
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

2013-02-06 Thread JIRA


[ 
https://issues.apache.org/jira/browse/TS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572296#comment-13572296
 ] 

Igor Galić commented on TS-1698:


I think we should move {{PTR_FMT}} to the source: {{ink_thread.h}}.

> thread/pthread mis-match on Solaris 10
> --
>
> Key: TS-1698
> URL: https://issues.apache.org/jira/browse/TS-1698
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Igor Galić
> Attachments: ink_pthead.patch
>
>
> {noformat}
>   CXX  UnixEventProcessor.o
> UnixEventProcessor.cc: In member function 'virtual int 
> EventProcessor::start(int)':
> UnixEventProcessor.cc:186:7: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> UnixEventProcessor.cc:188:9: error: format '%lu' expects argument of type 
> 'long unsigned int', but argument 8 has type 'ink_thread {aka unsigned int}' 
> [-Werror=format]
> cc1plus: all warnings being treated as errors
> gmake[2]: *** [UnixEventProcessor.o] Error 1
> gmake[2]: Leaving directory 
> `/export/home/buildbot/slave5/tserver-solaris-trunk-debug/build/iocore/eventsystem'
> gmake[1]: *** [all-recursive] Error 1
> {noformat}
> This seems to be caused by our naïve code to distinguish between different 
> platforms:
> {code}
> #include "P_EventSystem.h"  /* MAGIC_EDITING_TAG */
> #include 
> #if TS_USE_HWLOC
> #if HAVE_HWLOC_H
> #include 
> #endif
> #if HAVE_SCHED_H
> #include 
> #if !defined(solaris) && !defined(freebsd)
> typedef cpu_set_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #endif
> #if HAVE_SYS_PARAM_H
> #include 
> #endif
> #if HAVE_SYS_CPUSET_H
> #include 
> typedef cpuset_t ink_cpuset_t;
> #define PTR_FMT "p"
> #endif
> #if HAVE_PTHREAD_NP_H
> #include 
> #endif
> #if HAVE_SYS_PSET_H
> #include 
> typedef psetid_t ink_cpuset_t;
> #define PTR_FMT PRIuPTR
> #endif
> #if HAVE_SYS_TYPES_H
> #include 
> #endif
> #endif
> #include "ink_defs.h"
> #if TS_USE_HWLOC
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

[jira] [Commented] (TS-1698) thread/pthread mis-match on Solaris 10

5 matches

Site Navigation

Mail list logo

Footer information