[ https://issues.apache.org/jira/browse/TS-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583566#comment-13583566 ]
Igor Galić commented on TS-1718: -------------------------------- Generally, yeah: But autoconf already knows that, our code doesn't. -- Sent from my phone. Please excuse my brevity. > iconv incorrectly recognized on Solaris > --------------------------------------- > > Key: TS-1718 > URL: https://issues.apache.org/jira/browse/TS-1718 > Project: Traffic Server > Issue Type: Bug > Components: Build > Reporter: Igor Galić > > A solaris system can have multiple installations of iconv (the most obvious > being that of its {{libc}}). > However, once {{configure}} has successfully identified an iconv, we don't > really do anything with that information. Instead we try to replicate it > (poorly) in our code. > Here's an example from {{ink_string.cc}}: > {code} > #if !defined(kfreebsd) && (defined(freebsd) || (!defined(__GNUC__) && > defined(solaris))) > if (iconv(ic, &in, &inbytesleft, &out, &outbytesleft) == (size_t) - 1) > #else > if (iconv(ic, (char **) &in, &inbytesleft, &out, &outbytesleft) == (size_t) > - 1) > #endif > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira