[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590185#comment-13590185 ] Yunkai Zhang commented on TS-1735: -- It seems that reclaimable_freelist_init() was broken by ink_assert(). There are two ink_assert() within it: {code} void reclaimable_freelist_init(InkFreeList **fl, const char *name, uint32_t type_size, uint32_t chunk_size, uint32_t alignment) { /* quick test for power of 2 */ ink_assert(!(alignment & (alignment - 1))); //#1 ... ink_assert(f->thread_cache_idx < MAX_NUM_FREELIST); //#2 } {code} I guess the #2 ink_assert() was triggered. Can you compile TS with --enable-debug options so that we can get more information from backtrace? Or you can enlarge MAX_NUM_FREELIST's value in lib/ts/ink_queue_ext.cc and try again. > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590889#comment-13590889 ] Bryan Call commented on TS-1735: Backtrace with debug enabled: (gdb) bt #0 0x7fff8fa17d46 in __kill () #1 0x7fff84824df0 in abort () #2 0x000100aff8d3 in ink_mutex_init () #3 0x000100aff64d in reclaimable_freelist_init () #4 0x000100afe9c1 in ink_freelist_init () #5 0x00010018b3c1 in Allocator::Allocator () #6 0x00010018aba1 in Allocator::Allocator () #7 0x000100af1947 in __cxx_global_var_init () #8 0x000100af1959 in global constructors keyed to a () The core is happening at ink_mutex.h:80 if (pthread_mutex_init(m, &_g_mattr.attr) != 0) { <--- _g_mattr hasn't been initialized abort(); <- here } > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591299#comment-13591299 ] Yunkai Zhang commented on TS-1735: -- [~bcall]: Oh, I got it. I'll try to fix it later. Thanks. > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591355#comment-13591355 ] Yunkai Zhang commented on TS-1735: -- HI [~bcall]: I have submitted a patch: https://issues.apache.org/jira/secure/attachment/12571735/0001-TS-1735-fix-initialization-of-_g_mattr.attr.patch . Could you test it and give me some feedback? Thanks. > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593678#comment-13593678 ] James Peach commented on TS-1735: - Global initializers should be in a .cc file. There's just too much compiler risk with putting this stuff in a header file. > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593683#comment-13593683 ] James Peach commented on TS-1735: - Why does the freelist code use PTHREAD_PROCESS_SHARED? > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593705#comment-13593705 ] Yunkai Zhang commented on TS-1735: -- Hi [~jamespeach]: In my patch, I just moved the initialization code from x_pthread_mutexattr_t() to ink_mutex_init(), they are both inline functions in the same head file. It should not break anything, shouldn't it? > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593714#comment-13593714 ] James Peach commented on TS-1735: - I would expect a static initializer would prevent inlining. So that means that the compiler will emit the function definition multiple times and the linker would be responsible for choosing one of the definitions. Since you don't actually want this inlined anymore, it's better to not attempt that. J > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593717#comment-13593717 ] Yunkai Zhang commented on TS-1735: -- I got it, thank you:) > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.1 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609331#comment-13609331 ] ASF subversion and git services commented on TS-1735: - Commit dbf7124a945f38204b0548b1d2fdc54f51ed84ce in branch refs/heads/master from [~john.v.kew...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=dbf7124 ] TS-1735: Remove dead code that invokes missing vmap_config tool Virtual IPs were once managed such that within a cluster they would automatically rebalance themselves between nodes by bringing subinterfaces up and down. After ATS was open sourced the original setuid tool, vip_config (or traffic_vip_config) was inadvertently removed; but the code which depended on this tool was not cleaned up. Since modern deployments either do not use this tool at all (because it was broken for a few years) and modern deployments also have some central system for managing cluster state reliably, we do not need VMap to implement some scheme for automatically rebalancing the ips. This patch keeps much of the code for detecting ip address conflicts and for receiving the multicast messages from the cluster; but we remove all instances where we either bring up/down an interface. Deployments should manage this through external state systems. Note: VIPs do not actually bind to the specific addresses in vaddrs; this is just an operations convience to ensure that a cluster has no ip conflicts or unmanaged vips. This feature becomes even less useful. LocalManager.cc would have to be modified in some way to set this up properly. > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call > Fix For: 3.3.2 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr-V2.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650170#comment-13650170 ] James Peach commented on TS-1735: - Also doesn't build on Darwin: /Users/jpeach/src/trafficserver.git/lib/ts/ink_queue_ext.cc:183:35: error: use of undeclared identifier 'MAP_ANONYMOUS' MAP_PRIVATE|MAP_ANONYMOUS, > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call >Assignee: Bryan Call > Fix For: 3.3.3 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr-V2.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650364#comment-13650364 ] Yunkai Zhang commented on TS-1735: -- According the mmap() manual on Darwin: https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man2/mmap.2.html It seems that we should use 'MAP_ANON' macro. > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call >Assignee: Bryan Call > Fix For: 3.3.3 > > Attachments: 0001-TS-1735-fix-initialization-of-_g_mattr.attr-V2.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1735) reclaimable freelist causes core in osx
[ https://issues.apache.org/jira/browse/TS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665383#comment-13665383 ] ASF subversion and git services commented on TS-1735: - Commit 70a797599605fddffc64985c7b9c4eac8aca2987 in branch refs/heads/master from James Peach [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=70a7975 ] TS-1735: use MAP_ANON to fix build error on Darwin > reclaimable freelist causes core in osx > --- > > Key: TS-1735 > URL: https://issues.apache.org/jira/browse/TS-1735 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Bryan Call >Assignee: Bryan Call > Fix For: 3.3.3 > > Attachments: > 0001-TS-1735-fix-initialization-of-_g_mattr.attr-V2.patch, > 0001-Use-MAP_ANON-macro-to-fix-build-error-on-Darwin.patch > > > Global variable dependency and ininitialtion order can cause reclaimable > freelist to core. Reclaimable freelist depends on a global mutex attribute. > (gdb) bt > #0 0x7fff8fa17d46 in __kill () > #1 0x7fff84824df0 in abort () > #2 0x0001009ce697 in reclaimable_freelist_init (fl= unavailable, due to optimizations>, name= to optimizations>, type_size= optimizations>, chunk_size= optimizations>, alignment= optimizations>) at ink_mutex.h:80 > #3 0x7fff5fc13378 in > __dyld__ZN16ImageLoaderMachO18doModInitFunctionsERKN11ImageLoader11LinkContextE > () > #4 0x7fff5fc13762 in > __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE > () > #5 0x7fff5fc1006e in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #6 0x7fff5fc0ffc4 in > __dyld__ZN11ImageLoader23recursiveInitializationERKNS_11LinkContextEjRNS_21InitializerTimingListE > () > #7 0x7fff5fc0feba in > __dyld__ZN11ImageLoader15runInitializersERKNS_11LinkContextERNS_21InitializerTimingListE > () > #8 0x7fff5fc01fc0 in __dyld__ZN4dyld24initializeMainExecutableEv () > #9 0x7fff5fc05b04 in > __dyld__ZN4dyld5_mainEPK12macho_headermiPPKcS5_S5_Pm () > #10 0x7fff5fc01397 in > __dyld__ZN13dyldbootstrap5startEPK12macho_headeriPPKclS2_Pm () > #11 0x7fff5fc0105e in __dyld__dyld_start () -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira