[jira] [Commented] (TS-1736) Fatal() terminate process without logging backtrace
[ https://issues.apache.org/jira/browse/TS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620133#comment-13620133 ] ASF subversion and git services commented on TS-1736: - Commit 82ce5ff1919a0c15e44b47dba36967db0acc427b in branch refs/heads/master from [~yunkai] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=82ce5ff ] TS-1736: Fatal() terminates process without a backtrace The root casue is that cleanup_func() was called before logging backtrace in Diags::error(), however cleanup_func() would terminate process by calling exit() directly. Fatal() terminate process without logging backtrace --- Key: TS-1736 URL: https://issues.apache.org/jira/browse/TS-1736 Project: Traffic Server Issue Type: Bug Components: Logging Reporter: Yunkai Zhang Assignee: James Peach Fix For: 3.3.2 Attachments: 0001-diags-Fatal-terminate-process-without-logging-backtr-V2.patch, 0001-diags-Fatal-terminate-process-without-logging-backtr-V3.patch The root casue is that cleanup_func() was called before logging backtrace in Diags::error(), however cleanup_func() would terminate process by calling exit() directly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1736) Fatal() terminate process without logging backtrace
[ https://issues.apache.org/jira/browse/TS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619285#comment-13619285 ] James Peach commented on TS-1736: - I don't much like this patch; there is a problem with LocalManager::mgmtShutdown() clobberring status with waitpid() and I think the notion of this function calling exit() is flawed. It seems to me that there is only 1 place that needs to call _exit() and that is the call from mgmt/Main.cc. Can we remove the _exit() form mgmtShutdown() and just call it in the one place it's needed? If you do that, you should also be able to remove the status argument from mgmtShutdown(). Fatal() terminate process without logging backtrace --- Key: TS-1736 URL: https://issues.apache.org/jira/browse/TS-1736 Project: Traffic Server Issue Type: Bug Components: Logging Reporter: Yunkai Zhang Assignee: James Peach Fix For: 3.3.2 Attachments: 0001-diags-Fatal-terminate-process-without-logging-backtr-V2.patch The root casue is that cleanup_func() was called before logging backtrace in Diags::error(), however cleanup_func() would terminate process by calling exit() directly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1736) Fatal() terminate process without logging backtrace
[ https://issues.apache.org/jira/browse/TS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619454#comment-13619454 ] Yunkai Zhang commented on TS-1736: -- Oh, I hadn't noticed the status mistake, thank you. Agree to you, Let's remove the status argument, and call _exit() after this function when necessary. I'll give V3. Fatal() terminate process without logging backtrace --- Key: TS-1736 URL: https://issues.apache.org/jira/browse/TS-1736 Project: Traffic Server Issue Type: Bug Components: Logging Reporter: Yunkai Zhang Assignee: James Peach Fix For: 3.3.2 Attachments: 0001-diags-Fatal-terminate-process-without-logging-backtr-V2.patch The root casue is that cleanup_func() was called before logging backtrace in Diags::error(), however cleanup_func() would terminate process by calling exit() directly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1736) Fatal() terminate process without logging backtrace
[ https://issues.apache.org/jira/browse/TS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13593595#comment-13593595 ] James Peach commented on TS-1736: - How confident are you that this doesn't break any other process management? ie. other callers of LocalManager::mgmtShutdown() that expect _exit() as a side-effect. Fatal() terminate process without logging backtrace --- Key: TS-1736 URL: https://issues.apache.org/jira/browse/TS-1736 Project: Traffic Server Issue Type: Bug Components: Logging Reporter: Yunkai Zhang Attachments: 0001-diags-Fatal-terminate-process-without-logging-backtr.patch The root casue is that cleanup_func() was called before logging backtrace in Diags::error(), however cleanup_func() would terminate process by calling exit() directly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1736) Fatal() terminate process without logging backtrace
[ https://issues.apache.org/jira/browse/TS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13593609#comment-13593609 ] Yunkai Zhang commented on TS-1736: -- [~jamespeach] I'm sorry, I only checked the mgmt_cleanup(). I'll give V2 later. Fatal() terminate process without logging backtrace --- Key: TS-1736 URL: https://issues.apache.org/jira/browse/TS-1736 Project: Traffic Server Issue Type: Bug Components: Logging Reporter: Yunkai Zhang Attachments: 0001-diags-Fatal-terminate-process-without-logging-backtr.patch The root casue is that cleanup_func() was called before logging backtrace in Diags::error(), however cleanup_func() would terminate process by calling exit() directly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
